This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 7a4cf3569d4c9c49aba43e3c524d8ac09474740a (commit)
via b3ed9a40426bec52c1da9334818c49a6cbcfb464 (commit)
via c97921bb68849a2c7dd5f2f5ad8f5b97789df5c1 (commit)
from 8994ded2c47d22fd46ea46f6e7855da52826b351 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7a4cf3569d4c9c49aba43e3c524d8ac09474740a
Author: Tomas Cohen Arazi <tomasco...@theke.io>
Date: Thu May 14 09:06:51 2020 -0300
Bug 25502: Adapt Advanced macros routes to current guidelines
The original development started before the changes we introduced in the
guidelines in late 2019, and the major code changes that took place in January
2020.
- Attribute mapping logic is now on the Koha::Object-level (the patches
implement that, but are not using it)
- Related to the above, some helper methods like to_api and to_model are
kept, the same for the mappings in the controller, they should all go away
- Related to the above, set_from_api and new_from_api should be used
instead of using helper to_api and to_model methods in the controller
- $c->objects->search doesn't use the to_model and to_api params
- Response status codes need to be changed, at least for DELETE operations
Those are fixed by this patch.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/advanced_editor_macros.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Victor Grousset/tuxayo <vic...@tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
commit b3ed9a40426bec52c1da9334818c49a6cbcfb464
Author: Tomas Cohen Arazi <tomasco...@theke.io>
Date: Wed May 13 17:17:21 2020 -0300
Bug 25493: Make ->unhandled_exception use Koha::Logger
To test:
1. Edit the Koha/REST/V1/Cities.pm 'list' method adding
die("Nada"); before the render step.
2. Restart plack and try the endpoint
=> SUCCESS: The message is generic, but you see something is
logged in /var/log/koha/kohadev/api-error.log
3. Change die("Nada"); for a real exception like:
use Koha::Exceptions;
Koha::Exceptions::DuplicateObject->throw("Nada");
4. Repeat 2.
=> SUCCESS: The message is generic, but a meaningful text is added to
the logs.
5. Point your browser to the /api/v1/hola route from your dev
environment
=> FAIL: Wow, such a weird error
6. Apply this patch
7. Restart plack and repeat 2, 3 and 4
=> SUCCESS: No behaviour change
8. Repeat 5
=> SUCCESS: The regular Mojolicious 404 weird page
9. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
Signed-off-by: Kyle M Hall <k...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
commit c97921bb68849a2c7dd5f2f5ad8f5b97789df5c1
Author: Julian Maurice <julian.maur...@biblibre.com>
Date: Tue May 19 10:05:41 2020 -0300
Bug 25501: Supress warnings on installing translation
To test:
1) Verify the error installing translations for any language
2) Apply the patch
3) Repeat 1), check warning is gone
Signed-off-by: Bernardo Gonzalez Kriegel <bgkrie...@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/REST/Plugin/Exceptions.pm | 3 +-
Koha/REST/V1.pm | 3 -
Koha/REST/V1/AdvancedEditorMacro.pm | 180 +++++++------------------
api/v1/swagger/paths/advancededitormacros.json | 4 +-
misc/translator/tmpl_process3.pl | 4 +-
t/db_dependent/api/v1/advanced_editor_macros.t | 12 +-
6 files changed, 57 insertions(+), 149 deletions(-)
hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
