This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.05.x has been updated
via 892e0bb3817788ed6eaa046fb314ace8cb2f2e55 (commit)
via 70349c437f48b0b4b75adc144c64c16f0e66a74d (commit)
via 574e7dc490bc2e0cc2a742d43cbca7c0e5eb331e (commit)
via cfacdd567378b8aa3c55b506ce483748409e6ff6 (commit)
via e11d3de73169e2fbe9e7434894310cfcec625729 (commit)
via 82c2ee215486004957f7ea353635895d0dcf606a (commit)
via e9455e8d55ca1233db40349999b422944bb7d7d8 (commit)
via 371389605fdd75169d78ea2a9637ecab85b07bc4 (commit)
via 79bafa2aa84bcb135ebbbc98bf485356be37c98b (commit)
via 4055497a8c5e2e983e85e3a1f34d1fa285ca9659 (commit)
via 14c9a6401d733747ec93ff6045950c31949c7f4b (commit)
via c96cfdcb801a4dff276dd6cab53a4f3f4c2736b2 (commit)
via 68424ae5adab4b8ab4b4f165b6c9ac72cf2590cc (commit)
via b6b773c39a52ee92c96e2d10ceed323f55e8b885 (commit)
via 502565a21cc71d13711d0194f809ac6062c9009b (commit)
via 639dda850db7832a0fb6d06db6d270f804228eac (commit)
via b4fcef681084d017cc5b782e0910290924a9b0de (commit)
via 0fec6e205dc02504d436c1cc76a407086f907ace (commit)
via 5451e33184f7e8ac84a60ec36d377dd75d222fa2 (commit)
from 4b0602e77044f280982c8dcb07b3ca33a0f29b4f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 892e0bb3817788ed6eaa046fb314ace8cb2f2e55
Author: Martin Renvoize <martin.renvo...@ptfs-europe.com>
Date: Mon Jun 24 14:48:27 2019 +0100
Bug 23034: (RM follow-up) Consistent coding style
We had a mix of q||, q{} and '' in this one script. This followup just
makes them all conform to our standard style of q{}.
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 4dc64b4b124abf4bd2437004879e083972e20492)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 70349c437f48b0b4b75adc144c64c16f0e66a74d
Author: Joonas Kylmälä <joonas.kylm...@helsinki.fi>
Date: Mon Jun 3 14:58:34 2019 +0000
Bug 23034: Remove uninitialized value warning in Mana KB settings
This gets rid of the warning "Use of uninitialized value $auto_share
in string ne at [...]" by initializing the variable with empty string.
Test plan:
1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto
subscription sharing". Click "Save".
2) Check plack-error.log and notice the warning "Use of uninitialized
value $auto_share [...]"
3) Apply the patch and repeat the previous steps but now this time the
warning is gone in plack-error.log.
4) Make sure the AutoShareWithMana syspref with and without the patch
is in unselected state after clicking "Save".
Sponsored-by: The National Library of Finland
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 0df3fc3dae575ceb16b85de6c201f5e82d01059c)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 574e7dc490bc2e0cc2a742d43cbca7c0e5eb331e
Author: Fridolin Somers <fridolin.som...@biblibre.com>
Date: Tue Jun 11 15:31:45 2019 +0200
Bug 22944: remove obsolete unit test
Test 'AnonymiseIssueHistory should not return any error if success' is
obsolete,
previous statement will explode if something went wrong.
Test plan :
Run t/db_dependent/Koha/Patrons.t
Signed-off-by: Arthur Bousquet <arthur.bousq...@inlibro.com>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit ed7b3760965ec5a52783efe64bcba13b45b3725a)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit cfacdd567378b8aa3c55b506ce483748409e6ff6
Author: Fridolin Somers <fridolin.som...@biblibre.com>
Date: Tue May 21 11:55:40 2019 +0200
Bug 22944: avoid AnonymousPatron in search_patrons_to_anonymise
In Koha::Patrons::search_patrons_to_anonymise() old issues already affected
to the anonymous patron should be avoided. It is useless and can impact
performance.
It is already working if AnymousPatron is not defined or 0 because of :
'old_issues.borrowernumber' => { 'not' => undef }
In theory the anymous patron should have privacy=0 but in case its not it
should be explicitly avoided.
Test plan :
Run t/db_dependent/Koha/Patrons.t
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 66975364b672ea5f362d49f6e5fca8c9a0e8326c)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit e11d3de73169e2fbe9e7434894310cfcec625729
Author: Fridolin Somers <fridolin.som...@biblibre.com>
Date: Tue May 21 11:17:11 2019 +0200
Bug 22944: change unit tests
Add a dedicated UT and correct a test return value
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 48e5713e6ff78d7aad7eff9e239ec8779d62655c)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 82c2ee215486004957f7ea353635895d0dcf606a
Author: Mark Tompsett <mtomp...@hotmail.com>
Date: Mon Jun 17 17:57:46 2019 +0000
Bug 22571: (follow up) fix Donald cut-&-paste error
Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit d08e776cf1e25ffa407bb3a5d668c1b140be6ec2)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit e9455e8d55ca1233db40349999b422944bb7d7d8
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date: Sun May 5 12:41:46 2019 -0500
Bug 22571: Handle control fields in MMT for conditionals
Control fields are not handled correctly by Koha::SimpleMARC when
comparaison (with or without regex) is done.
Which means we did not support something like:
Do something if control field 008 equals or matches "a string"
Test plan:
Create a new MARC modification template and a new action, like:
Add new field 100$a with value "foo bar" if 008 (or any other control
fields) matches (or equals) a regex
Then use the record mofication tool and confirm that the new field is
create if the regex matches 008 of the bib record
Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit c59586aebe1d8eab56d3cd32b5156fc1a61f11ec)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 371389605fdd75169d78ea2a9637ecab85b07bc4
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date: Sun May 5 12:41:43 2019 -0500
Bug 22571: Add tests
Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit f6009342a95575dc6b1157c953f5e6e8c249b6d0)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 79bafa2aa84bcb135ebbbc98bf485356be37c98b
Author: Fridolin Somers <fridolin.som...@biblibre.com>
Date: Fri Jun 14 10:43:15 2019 +0200
Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage
When logged into the staff client with an account with full circulate
permissions (and therefore including the manage_checkout_notes permission) an
error occurs when clicking on the Checkout notes pending link. The account is
logged out automatically with the message: "Error: you do not have permission
to view this page. Log in as a different user".
The same error occurs for both the link on the home page dashboard and from
the Circulation module button. Works as expected if Superlibrarian permission
is set.
This is just a typo in perl script : circulation instead of circulate
Test plan :
1) Set preference "AllowCheckoutNotes" to "Allow"
2) Create a user with only permissions "catalogue" and "circulate >
manage_checkout_notes"
3) Loggin with this user
4) Go to "Circulation" home page
5) Click on "Checkout notes"
6) You should be allowed to access
Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 206498dc5585fbd555181a1b241d5049632870df)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 4055497a8c5e2e983e85e3a1f34d1fa285ca9659
Author: Nick Clemens <n...@bywatersolutions.com>
Date: Fri Jun 21 11:02:43 2019 +0000
Bug 23179: Add 'edit subfields' button to framework management
To test:
1) Go to Administration > MARC bibliographic framework
2) On a line click Actions > MARC structure
3) Note the dropdowns for each tag are: Edit, Subfields, Delete
4) Apply patch
5) Reload and note dropdowns are: Edit tag, View subfields, Edit subfields,
Delete
6) Confirm options do what is selected
Signed-off-by: Bin Wen <bin....@inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 6b6dc7bc791853d4dafb7f9ab02d3767c926ff08)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 14c9a6401d733747ec93ff6045950c31949c7f4b
Author: Fridolin Somers <fridolin.som...@biblibre.com>
Date: Wed Jun 19 07:04:25 2019 +0200
Bug 23153: In framework management action subfields must not go directly to
edition
Since 18.11, when viewing a framework field clicking on Actions >
Subfields goes to subfields edition instead of subfields table view.
This is because link contains op=add_form.
This is is also missing /cgi-bin/koha/admin.
Test plan :
1) Go to Administration > MARC bibliographic framework
2) On a line click Actions > MARC structure
3) On a line click Actions > Subfields
4) You see subfields table
5) Click on Edit subfields
6) You see subfields edition tabs
Signed-off-by: Owen Leonard <oleon...@myacpl.org>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 49e0384f10f659e337fac1b08e6bdd2c163151ae)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit c96cfdcb801a4dff276dd6cab53a4f3f4c2736b2
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date: Mon Jun 17 20:07:29 2019 -0500
Bug 15814: Add missing filters
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 12a9dfb6593c4d5ccc6936b85c82479c12337309)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 68424ae5adab4b8ab4b4f165b6c9ac72cf2590cc
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date: Wed May 29 21:28:23 2019 -0500
Bug 15814: Handle correctly MMTA edit button
The MARC modification template action edit buton does not correctly
handle variable escaping.
Assigning a JS variable containing the JSON representation of the
hashref will make the processing much more easier.
Test plan:
Create a MARC Modification Template with several actions.
In the description you should use the following characters, to try to
break this patch: \ ' " \n \r
(not sure what we handled \n and \r)
Then edit the action, modify and save again.
Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 7a80483a1358a7bc3e516a8fbc92d34b6559dcac)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit b6b773c39a52ee92c96e2d10ceed323f55e8b885
Author: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Date: Thu Jun 20 12:37:27 2019 +0000
Bug 23150: (follow-up) Make gdpr_proc_consent mandatory for create
When updating (patron modification), the field should not be required.
Test plan:
Check patron modification on opac.
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 6dc8306b58bc1207f396d2df919a3daf4712e8e5)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 502565a21cc71d13711d0194f809ac6062c9009b
Author: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Date: Wed Jun 19 14:49:15 2019 -0500
Bug 23150: Do not consider gdpr_proc_consent a mandatory field
It introduced a regression in the patron's self modification feature.
Patron's details are no longer modificable, the screen displays
"You have not filled out all required fields. Please fill in all missing
fields and resubmit."
Test plan:
- Set GDPR_Policy to either Enforced or Permissive
- Set PatronSelfRegistrationBorrowerMandatoryField to empty
- Set OPACPatronDetails to Allow
- Log into the OPAC
- Accept the GDPR screen
- Go to opac-memberentry.pl, change something, submit modification
request
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Signed-off-by: Nick Clemens <n...@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 3b14f7d636fea4425b2f6eab922be9aa2a9eed1d)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 639dda850db7832a0fb6d06db6d270f804228eac
Author: Owen Leonard <oleon...@myacpl.org>
Date: Tue May 21 12:39:09 2019 +0000
Bug 22946: Markup error in OPAC search results around selection links
This patch makes minor corrections to the template for OPAC search
results. These corrections fix errors returned by the HTML validator.
To reproduce the problem, make sure holds and/or tags are enabled in the
OPAC. Perform a search in the OPAC which will return multiple results.
Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."
This patch addresses one specific error:
- "Element div not allowed as child of element span in this context."
To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the search results view.
Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 48259267f6830b2e388b2a91268117645bda80f3)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit b4fcef681084d017cc5b782e0910290924a9b0de
Author: Katrin Fischer <katrin.fischer...@web.de>
Date: Mon Jun 17 21:35:19 2019 +0000
Bug 23097: Fix regression on overdues report and link patrons to moremember
The link from the patron name in the circulation > overdues report
shouldn't point to the reserves tab, as this report is about checkouts.
The patch restores the behaviour as it was in 17.11.
To test:
- Make sure you have a patron account with overdue items
- If you don't have one, check out an item with specified due date in the
past
- Go to Circulation > Overdues
- Veriy the overdue shows
- Click on the patron name that is linked
- Verify you go to the checkouts tab in patron account with holds tab
selected
- Apply patch
- Reload Overdues report
- Verify the link now leads to the Details tab with the checkouts tab in
front
Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit d018953ca1947649c35df8670a385a942c80c134)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 0fec6e205dc02504d436c1cc76a407086f907ace
Author: Kyle M Hall <k...@bywatersolutions.com>
Date: Wed Jun 19 07:00:01 2019 -0400
Bug 23103: (QA follow-up) Return undef implicitly
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit 3bf26cfb934cb699839aabb136df09ea97c030bb)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
commit 5451e33184f7e8ac84a60ec36d377dd75d222fa2
Author: Kyle M Hall <k...@bywatersolutions.com>
Date: Wed Jun 12 15:08:08 2019 -0400
Bug 23103: Cannot checkin items lost by deleted patrons with fines attached
Test Plan:
1) Checkout an item to a patron
2) Ensure the item has a replacement cost (or itemtype has default)
3) Ensure patrons are charged when items lost
4) Mark the item lost
5) Confirm patron has a fine
6) Write off the fine
7) Delete the patron
8) Check in the item
9) Note the internal server error
10) Apply this patch
11) Repeat steps 1-8
12) Note there is no internal server error!
13) prove t/db_dependent/Circulation.t
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>
(cherry picked from commit d2a2e4a8d52c2098dd183e6714b03aed5b6a84bb)
Signed-off-by: Fridolin Somers <fridolin.som...@biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 7 ++-
Koha/Patrons.pm | 2 +
Koha/SimpleMARC.pm | 12 +++--
admin/share_content.pl | 6 +--
circ/checkout-notes.pl | 2 +-
.../prog/en/modules/admin/marctagstructure.tt | 5 +-
.../intranet-tmpl/prog/en/modules/circ/overdue.tt | 2 +-
.../modules/tools/marc_modification_templates.tt | 24 ++-------
.../prog/js/marc_modification_templates.js | 53 +++++++++++---------
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 8 +--
opac/opac-memberentry.pl | 2 +-
t/SimpleMARC.t | 49 +++++++++++++++++-
t/db_dependent/Circulation.t | 44 +++++++++++++++-
t/db_dependent/Koha/Patrons.t | 9 ++--
14 files changed, 158 insertions(+), 67 deletions(-)
hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
