[Koha-devel] Bug 5636

2011-12-12 Thread Marcel de Rooy
Hi all, Patch 5636 should be next in passing qa now, but these questions remained open: Style question to the community: should core pages in the staff client (like tools/cleanborrowers.pl) have both a templated page in the staff client AND a command-line presence, or should the commandline

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Zeno Tajoli
Hi all, Il 12/12/2011 14:06, Marcel de Rooy ha scritto: Patch 5636 should be next in passing qa now, but these questions remained open: Style question to the community: should core pages in the staff client (like tools/cleanborrowers.pl) have both a templated page in the staff client AND

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Tomas Cohen Arazi
2011/12/12 Marcel de Rooy m.de.r...@rijksmuseum.nl: Hi all, Patch 5636 should be next in passing qa now, but these questions remained open: Style question to the community:  should core pages in the staff client (like tools/cleanborrowers.pl) have both a templated page in the staff

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Paul Poulain
Le 12/12/2011 14:06, Marcel de Rooy a écrit : Hi all, Patch 5636 should be next in passing qa now, but these questions remained open: Style question to the community: should core pages in the staff client (like tools/cleanborrowers.pl) have both a templated page in the staff client AND a

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Ian Walls
My difficulty with this patch is that it sets precedent for implementing both commandline and staff client interfaces for a single script. Up until now, that's not be the case (as far as my research has shown; counter-examples welcome). I just think we need, for consistency sake, to either make

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Paul Poulain
Le 12/12/2011 17:24, Ian Walls a écrit : My difficulty with this patch is that it sets precedent for implementing both commandline and staff client interfaces for a single script. Up until now, that's not be the case (as far as my research has shown; counter-examples welcome). I just think

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Jared Camins-Esakov
Ian, My difficulty with this patch is that it sets precedent for implementing both commandline and staff client interfaces for a single script. Up until now, that's not be the case (as far as my research has shown; counter-examples welcome). I just think we need, for consistency sake, to

Re: [Koha-devel] Bug 5636

2011-12-12 Thread LAURENT Henri-Damien
Le 12/12/2011 17:24, Ian Walls a écrit : My difficulty with this patch is that it sets precedent for implementing both commandline and staff client interfaces for a single script. Up until now, that's not be the case (as far as my research has shown; counter-examples welcome). I just think

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Chris Cormack
On 13 December 2011 06:11, LAURENT Henri-Damien laurent...@alinto.com wrote: Hi, in my opinion, it is not dual-purpose script, command-line or web interface, it is the same process you want. duplicating code and editing to make the code commandline compliant would be far harder to maintain

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Chris Nighswonger
On Mon, Dec 12, 2011 at 12:07 PM, Galen Charlton g...@esilibrary.comwrote: Hi, Such an attack may be more theoretical than real, but my preference would be that if a script's logic should be accessible from the command line and the web interface, to put the logic in the API and have the CGI

Re: [Koha-devel] Bug 5636

2011-12-12 Thread MJ Ray
Tomas Cohen Arazi tomasco...@gmail.com I think functionality should be included in C4 or Koha, and exposed by both command-line tool and templated front-ends. Also, any command-line tool should honour system preferences by default, and the user be warned if using parameters others than