: Friday, 7 August 2020 9:56 AM
To: Koha Devel
Subject: Re: [Koha-devel] An idea for consolidating staff interface header
search forms
On Wed, Jul 15, 2020 at 10:41 PM wrote:
>
> Yeah, I'm not a fan of a single big file either.
...
> It looks like that 1 file is 764 lines long
For c
On Wed, Jul 15, 2020 at 10:41 PM wrote:
>
> Yeah, I'm not a fan of a single big file either.
...
> It looks like that 1 file is 764 lines long
For comparison, columns_settings.yml is currently 1434 lines long.
-- Owen
--
Web Developer
Athens County Public Libraries
(740) 737-6006
--
From: Koha-devel On Behalf Of
Julian Maurice
Sent: Wednesday, 15 July 2020 6:46 PM
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] An idea for consolidating staff interface header
search forms
I'm personally not a big fan of the "single big file" approach. I find it
I'm personally not a big fan of the "single big file" approach. I find
it difficult to navigate through, and can cause git conflicts more often.
Also, it means that all blocks need to be parsed by TT on every page.
Maybe it doesn't affect performance too much (or maybe it affects
performance in
> this looks good to me - why do you think it might not be worth pursuing?
No particular reason, I just wanted to get some opinions in case there
was a downside I wasn't seeing.
Also: Julian is right, the t() macro works perfectly, I was just
looking at the wrong po file!
Thanks,
Owen
--
Hi Owen,
this looks good to me - why do you think it might not be worth pursuing?
Katrin
On 13.07.20 16:36, Owen Leonard wrote:
I've posted a work in progress here:
https://gitlab.com/koha-dev/koha-dev/-/tree/wip-2020-07-08-combine-header-searches
Katrin I liked your idea about defining the
Le 13/07/2020 à 16:36, Owen Leonard a écrit :
Even with the t() macro the
labels are still not picked up for translation correctly.
What do you mean ? Translation works for me on your branch :
https://pic.infini.fr/nqc3mEkM/mvaUg6k2.png
--
Julian Maurice
BibLibre
I've posted a work in progress here:
https://gitlab.com/koha-dev/koha-dev/-/tree/wip-2020-07-08-combine-header-searches
Katrin I liked your idea about defining the labels, but I'm not sure I
did exactly what you were suggesting. Even with the t() macro the
labels are still not picked up for
Hi,
You don't need bug 20988, you can already use the t() macro to make
strings translatable
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% catalog_searches = [
{ formid => 'circ_search', label => t('Check out') },
{ formid => 'checkin_search', label => t('Check in') },
{ formid
Hi Owen,
I like the idea of centralizing this code a bit more.
I am not sure if bug 20988 will fix the translation issue, but maybe we
could work around it for the time being?
Maybe instead of using [% form.label | html %] we could use the
form.formid and translate that to labels. Then we'd
10 matches
Mail list logo
