Re: [Koha-devel] some thoughts on #28519 regarding lib

2021-06-15 Thread dcook
Ditto what Jonathan said. CGI::Session::Serializer::yamlxs is 100% a Koha module at this point. Doesn't exist on CPAN. In this case, I created #28519 to make it easier to use additional namespaces beyond C4 and Koha (and historically OpenILS) without having to update Makefile.PL. Of course, I

Re: [Koha-devel] some thoughts on #28519 regarding lib

2021-06-15 Thread dcook
Speaking of benefits, I have a different Perl project I support and develop, and it stores all its Perl modules in a "./lib" directory, and I'm able to easily run my app from a git checkout or a package deployment. The only difference is path configuration. Also, while I have provided

Re: [Koha-devel] Sharing installation method with Hea

2021-06-15 Thread dcook
I was wondering if Koha already had that data, but I'm not so sure. I am thinking that "make install" would perhaps create a file containing the index method, and the Debian package build could overwrite that. David Cook Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point

[Koha-devel] Perl syntax for strings

2021-06-15 Thread Fridolin SOMERS
Hi, I see in Perl code some cases where a string in written with a space between q or qq or qw and string. Like : qq /foo bar/ instead of qq/foo bar/ It works, but I dont find it in docs like https://perldoc.perl.org/perlop#Quote-Like-Operators Most of cases are in : use CGI qw ( -utf8

[Koha-devel] some thoughts on #28519 regarding lib

2021-06-15 Thread Thomas Klausner
Hi! without knowing a lot of Koha-internals (still..), I'd strongly prefer to have all the code in a lib dir (as is standard in Perl apps / modules for ages). There are also a lot of tools available to make using code stored `lib` (but not "installed" in the system, i.e. only available in the

Re: [Koha-devel] some thoughts on #28519 regarding lib

2021-06-15 Thread Jonathan Druart
Hi Thomas, I've sent the following notes to the QA team, but maybe it needed to be public. The history behind 28519 is not trivial :) """ To clarify and explain a bit more what we are doing here (to those outside of the loop): - We switched from YAML[::Syck] to YAML::XS (22824, 27673) - We had

Re: [Koha-devel] Perl syntax for strings

2021-06-15 Thread Thomas Klausner
Hi! On Tue, Jun 15, 2021 at 10:19:12AM +0200, Fridolin SOMERS wrote: > I see in Perl code some cases where a string in written with a space between > q or qq or qw and string. > Like : qq /foo bar/ instead of qq/foo bar/ While this works, it is strongly recommended to not use this "feature".