Re: [Koha-devel] Rebase after passing QA?

2014-09-17 Thread Chris Cormack
* Holger Meissner (holger.meiss...@hs-gesundheit.de) wrote: Dear Koha devs, a few weeks ago one of my patches passed QA. By now it doesn't auto-merge with master anymore. I suspect the conflicts can be resolved without too much trouble. Should I rebase, keeping the Passed QA status? Or

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Jonathan Druart
\o/ If I understood correctly, it's exactly what I had in mind, so I totally agree! 2014-09-16 13:16 GMT+02:00 Kyle Hall kyle.m.h...@gmail.com: Yes. I'm imagining something along the lines of Koha::Object, and Koha::Object::Set which would have all the boilerplate we need for general use (

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Chris Cormack
* Jonathan Druart (jonathan.dru...@biblibre.com) wrote: \o/ If I understood correctly, it's exactly what I had in mind, so I totally agree! 2014-09-16 13:16 GMT+02:00 Kyle Hall kyle.m.h...@gmail.com: Yes. I'm imagining something along the lines of Koha::Object, and Koha::Object::Set

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Jonathan Druart
Chris, I tent to agree with you, but a Koha::Object makes sense to me. For instance, bug 12891 [1] shows us that we need an object to refactor common stuffs. [1] http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31515 2014-09-17 9:50 GMT+02:00 Chris Cormack chr...@catalyst.net.nz: *

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Kyle Hall
Chris, I'm a bit lost here. The idea behind Koha::Object is that we have a common base class from which to derive Koha::Biblio, Koha::Serial and so forth. That is, this class would be used as the base for classes that have a simple 1 to 1 table mapping to encapsulate DBIC while maintaining a

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Colin Campbell
A Koha::Object sounds like extremely poor design. What kind of object is a Koha::Object, what are its properties, when we say a Koha::Biblio isa Koha::Object what does that mean? In practice what meaningful properties it has it inherits from Koha::Schema::Result::Biblio which is liable to be a

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Marcel de Rooy
I would say: Leave all storage related actions in Koha::Schema. KohaRow does not make sense to me. Furthermore, define the objects that actually have 'real' business logic and put that in some Koha::Object. Just to add to the confusion ;) When I wrote some Koha::Object here, I was not

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Mark Tompsett
Greetings, Just to add to the confusion ;) When I wrote some Koha::Object here, I was not literally suggesting Koha::Object, I was thinking of something like Koha::Biblio or Koha::Patron etc. That’s what I understood. So physically, we may have the tables we currently have accessed via DBIC,

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Colin Campbell
On Wed, Sep 17, 2014 at 08:50:37AM -0400, Mark Tompsett wrote: Greetings, Just to add to the confusion ;) When I wrote some Koha::Object here, I was not literally suggesting Koha::Object, I was thinking of something like Koha::Biblio or Koha::Patron etc. That’s what I understood. So

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Chris Cormack
On 18 September 2014 1:49:34 am NZST, Colin Campbell colin.campb...@ptfs-europe.com wrote: On Wed, Sep 17, 2014 at 08:50:37AM -0400, Mark Tompsett wrote: Greetings, Just to add to the confusion ;) When I wrote some Koha::Object here, I was not literally suggesting Koha::Object, I was

Re: [Koha-devel] Koha and DBIC

2014-09-17 Thread Kyle Hall
I agree. I'd rather use DBIC directly and extend what we already have. It's just an idea if the conclusion is we can't do that. Kyle http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated

Re: [Koha-devel] Dom indexing operational with a fresh install?

2014-09-17 Thread Francois Charbonnier
Thanks! You're right. I was checking the wrong file. The set up is ok. But I still have the same problem. I tried to update biblio-koha-indexdefs.xml following the instructions on this wiki page : http://wiki.koha-community.org/wiki/MRenvoize/zebra I can't make the language index based on the

Re: [Koha-devel] Dom indexing operational with a fresh install?

2014-09-17 Thread Zeno Tajoli
Hi Francois, I probably have the same problem. If, as me, you use DOM indexing, you need to fix only marc21/biblios/biblio-koha-indexdefs.xml Probaly the only change to do are the changes written in this comment of Paul Poulain:

Re: [Koha-devel] Rebase after passing QA?

2014-09-17 Thread Tomas Cohen Arazi
Tell me the bug number. On Wed, Sep 17, 2014 at 2:32 AM, Holger Meissner holger.meiss...@hs-gesundheit.de wrote: Dear Koha devs, a few weeks ago one of my patches passed QA. By now it doesn't auto-merge with master anymore. I suspect the conflicts can be resolved without too much trouble.

[Koha-devel] Call for news: September Newsletter

2014-09-17 Thread Koha News
Fellow Koha users ~ We're collecting news for the September newsletter. Send anything noteworthy to: k o h a news AT gmail dot com News criteria: --- * News items can be of any length. * Anything and everything Koha. * Submit by the 26th. If you are working on an

[Koha-devel] Call for development news - September Newsletter

2014-09-17 Thread Koha News
Koha Development community ~ If you have any bugs or projects you'd like us to highlight or promote in the September newsletter, please let us know. Maybe it'll attract some additional eyes, testers and sign-offs. k o h a news AT gmail dot com Thank you! -- Chad Roseburg Joanne Dillon

[Koha-devel] Conventions for CLI scripts

2014-09-17 Thread Robin Sheat
There's been talk of making a few conventions for the parameters to command-line scripts. The initial discussion was dealing with test mode where it runs through all the actions but doesn't actually do anything, i.e. you know if it'll complete successfully. 1. There are two directions for