Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost

2017-07-20 Thread Marcel de Rooy
Not sure if 18966 is the way to go, "halting the system" until we fixed the autoincrement. The solution of merging the tables, as David refers to, is the ideal one, but it seems too big to implement right now, as we need to fix stable branches right now. The renumbering fix depended on

Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost

2017-07-20 Thread Katrin
Merging the tables can only be a long term solution, but we need a solution for the stable branches now. If we agree to merge, not only reports will be affected for some of the tables, it will be a lot of work. Katrin On 21.07.2017 05:57, David Cook wrote: Jonathan, have you thought

Re: [Koha-devel] CI improvement

2017-07-20 Thread Katrin
That's good news! Thx for your work! On 20.07.2017 00:55, Jonathan Druart wrote: Hi devs, Yesterday Tomas and I spent some time to improve our continuous integration server (jenkins.koha-community.org ). What's new: - a new task 17.05 has been created -

Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost

2017-07-20 Thread David Cook
Jonathan, have you thought anymore about merging the deleted* tables back in with the active tables? This would have the benefit of fixing problems with things like “Checkout history” where issues containing deleted borrowers or deleted items have these details nullified and thus disappear from

Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost

2017-07-20 Thread David Cook
Not in my experience, but we are running in DEBUG mode, so you’ll typically have a max of 1 collision with a table pairing which is very easy to remedy. But that’s academic. As Jonathan has pointed out, if you don’t have DEBUG on, you’ll lose data, and that’s not good! Jonathan, I started

Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost

2017-07-20 Thread David Cook
Thanks for that excerpt, Jonathan. We run our systems with DEBUG on, which must be why we’re not losing data! David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From:

Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost

2017-07-20 Thread Jonathan Druart
And see bug 18966 for a third (last!?) round. I tried to resume in the description of the bug what has been done and what I propose to move forward. BE INVOLVED! On Wed, 12 Jul 2017 at 15:11 Jonathan Druart < jonathan.dru...@bugs.koha-community.org> wrote: > Hi devs, > > Please review and test >

Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost

2017-07-20 Thread Michael Hafen
On top of that by the time you get to that error you already have a primary key conflict, between biblios and deletedbiblios as an example, because the conflict is what causes the error. There would be a lot of table that would have to be touched to resolve the key conflict in order to maintain