Re: [Koha-devel] 0000-00-00 is expired?

2018-02-13 Thread Magnus Enger 
Hiya!

On 13 February 2018 at 20:06, Jonathan Druart
 wrote:
> It would be useful to know the return of
>   SELECT COUNT(*) FROM borrowers where dateexpiry="-00-00"
> on old installations.

I just checked my 5 oldest instances (upgraded regularly since
2009/2010) and none of them had any users meeting this criterium.

Best regards,
Magnus
Libriotech
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Re: [Koha-devel] 0000-00-00 is expired?

2018-02-13 Thread Bob Birchall 

Hi Jonathan,
We have a number of old installations. They are all running 17.05 today.

I checked about eight DBs and found only one record with dateexpiry = 
"-00-00". The record was created in 2012.


Bob

On 14/02/18 06:06, Jonathan Druart wrote:
"Enrollment period" is mandatory when creating/updating a patron 
category, dateexpiry will be calculated when a patron is created.
So, at least with new versions, this field should never be set to 
-00-00 (at least using the interface).
We will need to take a decision at some point, either update these 
values with -12-31 or recalculate them.


It would be useful to know the return of
  SELECT COUNT(*) FROM borrowers where dateexpiry="-00-00"
on old installations.

Cheers,
Jonathan

On Tue, 6 Feb 2018 at 18:37 Katrin Fischer > wrote:


Hm, I don't remember a special use case for -00-00.

My impression was that it is impossible to have a patron without a
valid dateexpiry date.

On 06.02.2018 17 :10, Jonathan Druart
wrote:

Hi devs,

I have just caught that:

Koha::Patron->is_expired returns  0 if $self->dateexpiry eq
'-00-00'
And there is a test I wrote for it on bug 17578 (commit
5a0a2ce584dec74808f471b0f92b2114c3d6029e , GetMemberDetails -
Remove is_expired)

But then we also have, in C4::Circulation::CanBookBeIssued:
 752 if ( !defined $patron->dateexpiry || $patron->dateexpiry
eq '-00-00') {
 753 $issuingimpossible{EXPIRED} = 1;
 754 } else {
With a test:
is( $issuingimpossible->{EXPIRED}, 1, 'The patron should be
considered as expired if dateexpiry is -00-00' );

So, my questions, do you have a very old Koha installations to
search if there is borrowers.is_expired == "-00-00" in it?
Do you remember if it meant expired or not at some point?

I am trying to adapt our code to sql strict modes, and this value
is no longer valid, we will need to update existing values.

Cheers,
Jonathan

(yes, the same code should be used)


___
Koha-devel mailing list
Koha-devel@lists.koha-community.org

http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website :http://www.koha-community.org/
git :http://git.koha-community.org/
bugs :http://bugs.koha-community.org/


___
Koha-devel mailing list
Koha-devel@lists.koha-community.org

http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/



___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Re: [Koha-devel] 0000-00-00 is expired?

2018-02-13 Thread Jonathan Druart 
"Enrollment period" is mandatory when creating/updating a patron category,
dateexpiry will be calculated when a patron is created.
So, at least with new versions, this field should never be set to
-00-00 (at least using the interface).
We will need to take a decision at some point, either update these values
with -12-31 or recalculate them.

It would be useful to know the return of
  SELECT COUNT(*) FROM borrowers where dateexpiry="-00-00"
on old installations.

Cheers,
Jonathan

On Tue, 6 Feb 2018 at 18:37 Katrin Fischer  wrote:

> Hm, I don't remember a special use case for -00-00.
>
> My impression was that it is impossible to have a patron without a valid
> dateexpiry date.
> On 06.02.2018 17 <06%2002%2020%2018%2017>:10, Jonathan Druart wrote:
>
> Hi devs,
>
> I have just caught that:
>
> Koha::Patron->is_expired returns  0 if $self->dateexpiry eq '-00-00'
> And there is a test I wrote for it on bug 17578 (commit
> 5a0a2ce584dec74808f471b0f92b2114c3d6029e , GetMemberDetails - Remove
> is_expired)
>
> But then we also have, in C4::Circulation::CanBookBeIssued:
>  752 if ( !defined $patron->dateexpiry || $patron->dateexpiry eq
> '-00-00') {
>  753 $issuingimpossible{EXPIRED} = 1;
>  754 } else {
> With a test:
> is( $issuingimpossible->{EXPIRED}, 1, 'The patron should be considered as
> expired if dateexpiry is -00-00' );
>
> So, my questions, do you have a very old Koha installations to search if
> there is borrowers.is_expired == "-00-00" in it?
> Do you remember if it meant expired or not at some point?
>
> I am trying to adapt our code to sql strict modes, and this value is no
> longer valid, we will need to update existing values.
>
> Cheers,
> Jonathan
>
> (yes, the same code should be used)
>
>
> ___
> Koha-devel mailing 
> listkoha-de...@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Re: [Koha-devel] Update your Koha master installations!

2018-02-13 Thread Victor Grousset 

Hi,

I had a little trouble finding where to put the new rules.
On a non plack, non-packaged, apache install. Here is what I had to do:

===
vim /etc/apache2/sites-enabled/koha.conf

# Before «REST API configuration» (at two different places) add the 
following.
 RewriteRule 
^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L] 

 RewriteRule 
^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L] 




This includes the fix for bug 20187
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187


Cheers,

--
Victor Grousset, dev support/maintenance
BibLibre, Services en logiciels libres pour les bibliothèques
BibLibre, Libre/Open Source software and services for libraries
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-devel] Hackfest in Marseille, last call ;)

2018-02-13 Thread Paul Poulain 

Hello everybody,

The hackfest in Marseille start in just one month from now. It's still 
time to decide to come !


Already 50 registered people, coming from USA (4), Germany (2), Greece 
(3), Norway (1), Spain (1), Senegal (1), and France (others ;) )


We miss someone from Italy, Portugal, UK, Argentina, New Zealand, 
Australia and [enter your country here] :D


the guys from reasonablegraph will be there, we have people motivated to 
work on Elastic Search. And of course a lot of other hacking & fun. And 
French cheese.


--
Paul Poulain, Associé-gérant / co-owner
BibLibre, Services en logiciels libres pour les bibliothèques
BibLibre, Open Source software and services for libraries

___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/