After writing some patches and doing some testing here’s the results:
1. Jonathan’s idea of using “#” instead of “/cgi-bin/koha/opac-user.pl”
works.
2. My idea of using “#loginModal” instead of “/cgi-bin/koha/opac-user.pl”
(and disabling our a.login-link.loginModal-trigger click
Thanks for replying so quickly, Jonathan.
Based on https://www.w3schools.com/Bootstrap/bootstrap_ref_js_modal.asp, I’d
say that it should actually be a CSS ID selector. In this case #loginModal.
This makes sense because when I was debugging the Jquery, it was failing to use
Thx Phil, great explanation!
On 04.03.20 00:32, Phil Ringnalda wrote:
For a single-branch system, they should be the same.
For a multi-branch system, Holds Queue first looks for an item already
at the pickup branch and puts the hold in that branch's queue
(possibly even jumping priority order
href is supposed to be an anchor, but it's an url
https://www.w3schools.com/Bootstrap/bootstrap_ref_js_modal.asp
Caused by
commit 8b1fb387acee35ba64f61d59fd332a79
Bug 14862: Upgrade jQuery from 1.7 to 3.4.1 in OPAC
We should replace the href="/cgi-bin/koha/opac-user.pl" with href="#". But
I
Hi all (and especially Owen),
I'm noticing some odd Javascript errors in the OPAC in 19.11 and master.
Steps to reproduce:
1. Go to the OPAC and open the F12 dev tools.
2. Click on "Log in to your account"
3. Note the following in your console logs