: maandag 29 maart 2021 18:25
Aan: koha-devel
Onderwerp: [Koha-devel] Second look needed on a few (2!) lines related to
plugins
Hi :)
It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
There are two lines in the patch that are out of my knowledge to QA:
https://eur03
-devel] Second look needed on a few (2!) lines related to
plugins
Hi,
In my opinion this syntax looks strange.
I'd prefer :
my $filter = { uploadcategorycode => $browsecategory };
$filter{public} = 1 if $plugin;
$uploads = Koha::UploadedFiles->search($filter)->
On 21-03-30 01:31, Mason James wrote:
hiya, here's some info...
https://docstore.mik.ua/orelly/perl3/prog/ch03_16.htm
Indeed there is a trinary, but it's about if it makes sense to do "those
things" related to plugins. Is that useful, is that valid, is that enough?
Cheers,
--
Victor
Hi,
In my opinion this syntax looks strange.
I'd prefer :
my $filter = { uploadcategorycode => $browsecategory };
$filter{public} = 1 if $plugin;
$uploads = Koha::UploadedFiles->search($filter)->unblessed;
Super cool enhancement BTW ;)
Best regards,
Le 29/03/2021 à
hiya, here's some info...
https://docstore.mik.ua/orelly/perl3/prog/ch03_16.htm
On 30/03/21 5:25 am, Victor Grousset/tuxayo wrote:
Hi :)
It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
There are two lines in the patch that are out of my knowledge to QA:
Hi :)
It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
There are two lines in the patch that are out of my knowledge to QA:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
[% PROCESS plugin_pars %]
[...]
$plugin? ( public => 1 ): ()
Does this look
