Re: [Koha-devel] What's the definitive way to use Perl tidy in koha-testing-docker?

2022-12-11 Thread Katrin Fischer
Hm, so we have a mismatch between documentation and real life use? Wiki: "The offical perltidy style for perl code in Koha is the perltidy 'default' or 'larry-wall' style. There was a customised perltidy style in Koha for a while, but it was never official or enforced and later removed." There

Re: [Koha-devel] What's the definitive way to use Perl tidy in koha-testing-docker?

2022-12-11 Thread Tomas Cohen Arazi
I normally point vscode's perltidy extension to the shipped perltidyrc: https://git.koha-community.org/Koha-community/Koha/src/branch/master/xt/perltidyrc and do Ctrl+k-f on the region I'm editing. El vie, 9 dic 2022 0:27, David Cook escribió: > Hi all, > > > > I’ve heard a few people saying

Re: [Koha-devel] What's the definitive way to use Perl tidy in koha-testing-docker?

2022-12-11 Thread Katrin Fischer
Hi David, when using perltidy in my editor with the standard configuration, the indentation appears to be correct. But I am not sure what you mean with :Tidy in ktd? It looks like our coding guidelines matches the defaults for PerlTidy: n=4 and space. Could it be that some local config file is

[Koha-devel] What's the definitive way to use Perl tidy in koha-testing-docker?

2022-12-08 Thread David Cook
Hi all, I've heard a few people saying lately that they wish people would use Perl tidy more. So I used the ":Tidy" command in koha-testing-docker on my visual selection and I got the following: +$this_item->{shelves} = +