I've added a section in
https://wiki.koha-community.org/wiki/Commit_messages to encourage people
adding more informations to commits.
Changing Signed-off-by seems to be a bad idea. So let's do nothing about
this.
What about the QA signoff ? Reviewed-by or not ?
Le 25/09/2018 à 08:04, Renvoize,
I agree to the idea in principle too, adding detail is great.
I don't have an issue with misusing the signoff line, I've been aware of
that distinction for a long time. The major advantage of using it for our
workflow is that it's often the least technical user doing the initial
signoff and as
I think we'd need to change a lot of things if we switched from
Signed-off-by to another - including a lot of documentation. It might
add more confusion than doing good imo. But I'd be OK with changing the
line for QA to make things more clear if that is what people would like
to see. Also
I like the idea of adding more uses. Mentored-by is interesting information
on the QA step, for example.
El mié., 19 sept. 2018 a las 12:39, Owen Leonard ()
escribió:
> > > Bit late in the project to make this change imo? But yes, our
> > > interpretation is quite different ;)
> > But it's never
> > Bit late in the project to make this change imo? But yes, our
> > interpretation is quite different ;)
> But it's never too late to make a positive change, right ? :)
I agree that it's not too late to make useful changes to our workflow.
There was a time when we didn't even sign off patches!
Le 19/09/2018 à 16:44, Marcel de Rooy a écrit :
>> Should we replace Signed-off-by by Tested-By (for testers) and Reviewed-By
>>(for QA) ?
>> Should we use Signed-off-by as suggested in the git-commit manpage ?
> Bit late in the project to make this change imo? But yes, our
> interpretation is
> Should we use Reported-By ?
Could be added optionally imo. No problem. Replace By with by btw.
> Should we replace Signed-off-by by Tested-By (for testers) and Reviewed-By
> (for QA) ?
> Should we use Signed-off-by as suggested in the git-commit manpage ?
Bit late in the project to make this
Hi all,
AFAIK in our commit messages we are using two different trailers:
- Signed-off-by tells who tested/reviewed the patch
- Sponsored-by tells who sponsored the patch
I recently stumbled upon the contribution guidelines for git [1] which
suggests to use Reported-by, Acked-by, Reviewed-by,
