Re: [Koha-devel] Avoid $sth->finish

2009-06-10 Thread John Beppu
2009/6/4 Joe Atzberger > Kohackers -- > > I want to mention this because I've seen a lot of recent patches still > using the old style of code calling $sth->finish() explicitly. I know a lot > of the codebase still does this internally, but for Koha such usage is > almost always wrong. > > One w

Re: [Koha-devel] Avoid $sth->finish

2009-06-05 Thread paul POULAIN
Jesse a écrit : > I've wondered about this myself, since Perl, being a dynamic language, > should have some sort of destructor support. > > Thanks for looking into this, I'll try to avoid it in the future. Hi Jesse, how is your MUA configured ? (and what MUA do you use?) it's a "nighmare" to rea

Re: [Koha-devel] Avoid $sth->finish

2009-06-05 Thread Jesse
2009/6/4 Joe Atzberger > Kohackers -- > > I want to mention this because I've seen a lot of recent patches still > using the old style of code calling $sth->finish() explicitly. I know a lot > of the codebase still does this internally, but for Koha such usage is > almost always wrong. > > If th

[Koha-devel] Avoid $sth->finish

2009-06-04 Thread Joe Atzberger
Kohackers -- I want to mention this because I've seen a lot of recent patches still using the old style of code calling $sth->finish() explicitly. I know a lot of the codebase still does this internally, but for Koha such usage is almost always wrong. If this were just my personal contention, I