Re: [Koha-patches] [PATCH] Bug 2920 DB Rev 028 AmazonReviews syspref

2009-04-27 Thread Galen Charlton
Hi Frédéric, I've pushed your latest 2920 patches. Please follow up with a patch to admin/systempreferences.pl to put the new AmazonReviews syspref in the enhanced content category. Regards, Galen 2009/4/27 Frédéric Demians f.demi...@tamil.fr: Add AmazonReviews syspref. DOCUMENTATION:  

[Koha-patches] [PATCH] bug 2559: fix search limit on Spanish language (DB rev 029)

2009-04-27 Thread Galen Charlton
Fixes bug where searching with the language limit set to Spanish would instead retrieve Russian records. --- installer/data/mysql/updatedatabase.pl | 11 +++ kohaversion.pl |2 +- 2 files changed, 12 insertions(+), 1 deletions(-) diff --git

[Koha-patches] [PATCH] (bug #2914) delete only items from the user homebranch

2009-04-27 Thread Nahuel ANGELINETTI
This patch is a fix for the previous one. This one, alert the user will delete only all items from his branch, and not from others. So if the holdingbranch equal the user branch, the item will be deleted. --- catalogue/detail.pl|5 + cataloguing/additem.pl

Re: [Koha-patches] [PATCH] Bug 2920 DB Rev 028 AmazonReviews syspref

2009-04-27 Thread Frédéric DEMIANS
I've pushed your latest 2920 patches. Please follow up with a patch to admin/systempreferences.pl to put the new AmazonReviews syspref in the enhanced content category. I missed that, sorry. You should have ask to modify! DOCUMENTATION: AmazonReviews is OPACAmazonReviews counterpart,

[Koha-patches] [PATCH] Bug 2920 Display AmazonReviews syspref in the enhanced content category

2009-04-27 Thread Frédéric Demians
--- admin/systempreferences.pl |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/admin/systempreferences.pl b/admin/systempreferences.pl index aa5cb5c..1c6ed74 100755 --- a/admin/systempreferences.pl +++ b/admin/systempreferences.pl @@ -226,6 +226,7 @@

Re: [Koha-patches] [PATCH] [followup](bug #2961) change the workflow of the new issue

2009-04-27 Thread Galen Charlton
Hi, On Tue, Mar 17, 2009 at 10:28 AM, Nahuel ANGELINETTI nahuel.angeline...@biblibre.com wrote: This patch change the operations, it add a new expected if no one expected exists, else it create new excepted, and set the others as late This patch has three unconditional warns - please remove

[Koha-patches] [PATCH] (bug #2961) change the workflow of the new issue

2009-04-27 Thread Nahuel ANGELINETTI
This patch change the operations, it add a new expected if no one expected exists, else it create new excepted, and set the others as late --- serials/serials-collection.pl | 50 1 files changed, 30 insertions(+), 20 deletions(-) diff --git

[Koha-patches] [PATCH] bug 2915 followup - small efficiency improvement

2009-04-27 Thread Galen Charlton
Following up on a suggestion by Joe Atzberger, save a database query by not counting the subscriptions to delete; instead, simply fetch a list of them. No user-visible change. --- C4/Biblio.pm |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/C4/Biblio.pm

Re: [Koha-patches] [PATCH] Revisions to auto-generated authorities patch

2009-04-27 Thread Brian Harrington
On Fri, 24 Apr 2009 15:54:44 -0400 Joe Atzberger joe.atzber...@liblime.com wrote: I think SetMarcUnicodeFlag should stay, in part because BiblioAddAuthorities() should move to a C4 .pm and be used by other scripts. In fact, SetMarcUnicodeFlag should be called earlier in the sub, before any

Re: [Koha-patches] [PATCH] Revisions to auto-generated authorities patch

2009-04-27 Thread Galen Charlton
Hi, On Mon, Apr 27, 2009 at 1:15 PM, Brian Harrington br...@jhu.edu wrote: I can certainly revise things and put the SetMarcUnicodeFlag call back in immediately after MARC::Record-new().  I guess my question would be whether setting the MARC::Record-encoding() there actually has any impact on

[Koha-patches] [PATCH] Bugs 2822, 2551, 3163 fixes to XSLT

2009-04-27 Thread Jane Wagner
Bug 2822 -- for leader6 types of i (nonmusical) or j (musical), the hitlist uses an icon and label of Sound while the record display page uses Music. Modified record display to use Sound. Bug 2551 -- for leader7 type of i says it's type Serial which is incorrect. The bug report suggested

[Koha-patches] [PATCH] bug 3156 Fix display of LTFL content when not displaying it in tabs.

2009-04-27 Thread Chris Catalfo
LTFL content needs to appear in div rather than span elements. This patch simply replaces the LTFL span elements with divs to fix Bug 3156: LTFL content not displaying if LibraryThingForLibrariesTabbedView sys pref is Off. --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |6 +++--- 1

Re: [Koha-patches] [PATCH] bug 3156 Fix display of LTFL content when not displaying it in tabs.

2009-04-27 Thread Galen Charlton
Hi Chris, On Mon, Apr 27, 2009 at 3:26 PM, Chris Catalfo ccata...@gmail.com wrote: +               span class=results_summarydiv id=ltfl_related class=ltfl/div/span +               span class=results_summarydiv id=ltfl_similars class=ltfl/div/span +               span

[Koha-patches] [PATCH] Revisions to auto-generated authorities patch

2009-04-27 Thread Brian Harrington
It turns out that the blank record created by MARC::Record-new() has a leader, so now I explicitly create one in addbiblio.pl. I also realized I can't count. :-) Modified per comments by Joe and Galen to keep SetMarcUnicodeFlag and move it and the leader set to earlier in the process. ---

Re: [Koha-patches] [PATCH] Revisions to auto-generated authorities patch

2009-04-27 Thread Galen Charlton
Hi Brian, There are a couple problems with this latest patch - it doesn't apply cleanly against HEAD for me. Also: On Mon, Apr 27, 2009 at 4:53 PM, Brian Harrington br...@jhu.edu wrote:          my $marcrecordauth=MARC::Record-new(); +               if (C4::Context-preference('marcflavour')