[Koha-patches] [PATCH 2/2] Make GetBooksellerFromId error return consistent

2010-02-18 Thread Colin Campbell
return undef or empty array in error cases hopefully if we're consistent someone may start checking it removed unnecessary ()s --- C4/Bookseller.pm |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm index 655d25e..63df90d 100644 ---

[Koha-patches] [PATCH 2/3] bug 1080: XHTML-ify audio tags

2010-02-18 Thread Galen Charlton
This doesn't actually do much, since the audio tag is still not defined in XHTML1, but it makes it consistent with the rest of the markup. Signed-off-by: Galen Charlton gmcha...@gmail.com --- .../prog/en/modules/circ/circulation.tmpl |4 ++-- .../prog/en/modules/circ/returns.tmpl

[Koha-patches] [PATCH] bug 4155 followup: fix indication of when checkbox syspref is modified

2010-02-18 Thread Galen Charlton
Signed-off-by: Galen Charlton gmcha...@gmail.com --- .../intranet-tmpl/prog/en/js/pages/preferences.js |4 ++-- .../prog/en/modules/admin/preferences.tmpl |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js

Re: [Koha-patches] [PATCH] (bug #4207) receive shipment problem

2010-02-18 Thread Galen Charlton
Hi, This patch does not apply against HEAD. Please fix this and resubmit, and please ensure that you test your merges first and ensure that the patches you send apply on HEAD at the time you submit them. Regards, Galen On Wed, Feb 17, 2010 at 9:24 AM, Nahuel ANGELINETTI

[Koha-patches] [PATCH] Bug 4215 OPAC Search for title in can fail with trailing slashes in title

2010-02-18 Thread Jane Wagner
While configuring Search for Title In links, I found that some target sites can't process an incoming title search if the title being sent has a trailing slash. If the same search is sent without the trailing slash, it works fine. I modified opac-detail.pl to strip off the trailing slash (and

[Koha-patches] [PATCH 1/2] bug 1080 follow-up: make sure 'sound' isn't listed as a language

2010-02-18 Thread Galen Charlton
Signed-off-by: Galen Charlton gmcha...@gmail.com --- C4/Languages.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Languages.pm b/C4/Languages.pm index ab57614..5879930 100644 --- a/C4/Languages.pm +++ b/C4/Languages.pm @@ -265,7 +265,7 @@ sub _get_language_dirs {

[Koha-patches] [PATCH 2/2] update RM notes for new translation wrapper script

2010-02-18 Thread Galen Charlton
Signed-off-by: Galen Charlton gmcha...@gmail.com --- misc/release_notes/README.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/misc/release_notes/README.txt b/misc/release_notes/README.txt index cb3424b..1a3f66f 100644 --- a/misc/release_notes/README.txt +++

[Koha-patches] [PATCH] Fix for Bug 4219, strange artifacts showing on lists in the staff client

2010-02-18 Thread Owen Leonard
Recent change to C4/VirtualShelves/Page.pm caused display of subtitles to break in the staff client display of lists --- .../prog/en/modules/virtualshelves/shelves.tmpl|2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Koha-patches] [PATCH] bug 4220 add additional search buttons to advanced search

2010-02-18 Thread Nicole Engard
This patches both the opac the staff client. It also fixes an issue where language appeared twice on the opac advanced search page if you chose to see 'more options' --- .../prog/en/modules/catalogue/advsearch.tmpl | 35 ++- .../opac-tmpl/prog/en/modules/opac-advsearch.tmpl

[Koha-patches] [PATCH] Bug 4102: import_borrowers.pl fails silently

2010-02-18 Thread Chris Nighswonger
This patch adds code to validate column names in the CSV header row against the current columns in the borrowers table as well as additional valid columns. It also adds error trapping to prevent import of files with fatal errors such as unparsable header rows and invalid column names. ---

[Koha-patches] [PATCH] Updating credits and history document

2010-02-18 Thread Chris Cormack
--- docs/history.txt |8 koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl | 10 -- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/docs/history.txt b/docs/history.txt index d7d152d..90844d7 100644 --- a/docs/history.txt

Re: [Koha-patches] [PATCH] Updating Ubuntu install docs

2010-02-18 Thread Galen Charlton
Hi, As we discussed, it turns out this doesn't apply on a fresh install of Karmic, so as you requested, I won't push this. Regards, Galne On Thu, Feb 18, 2010 at 3:28 PM, Chris Nighswonger cnighswon...@foundations.edu wrote: Adding a note about Ubuntu 9.10 Karmic building MySQL w/o InnoDB.

[Koha-patches] [PATCH] Adding some clarity to the acquistion called off line in the history

2010-02-18 Thread Chris Cormack
--- docs/history.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/history.txt b/docs/history.txt index 90844d7..96601e5 100644 --- a/docs/history.txt +++ b/docs/history.txt @@ -464,7 +464,7 @@ February 2 2010 Community Handover meeting

[Koha-patches] [PATCH] Bug 4227: Removes unused opac-logout.pl.

2010-02-18 Thread Garry Collum
Performed a recursive grep on the entire file structure to confirm. --- opac/opac-logout.pl | 84 --- 1 files changed, 0 insertions(+), 84 deletions(-) delete mode 100755 opac/opac-logout.pl diff --git a/opac/opac-logout.pl b/opac/opac-logout.pl

[Koha-patches] [PATCH 2/4] bug 1532: tweak new reserves columns and add to init SQL (DB rev 121)

2010-02-18 Thread Galen Charlton
Changed type of lowestpriority from BOOL to tinyint(1) - BOOL was likely OK, but made it tinyint(1) to match the rest of the flag columns. We should look into converting those to BOOL en masse in 3.4. Also made expirationdate nullable. Signed-off-by: Galen Charlton gmcha...@gmail.com ---

[Koha-patches] [PATCH 3/4] bug 1532: fix XHTML validation errors

2010-02-18 Thread Galen Charlton
Also changed some titles to use hold instead of reserve for display purposes. Signed-off-by: Galen Charlton gmcha...@gmail.com --- .../prog/en/modules/reserve/request.tmpl | 32 ++-- .../opac-tmpl/prog/en/modules/opac-reserve.tmpl|4 +- 2 files changed, 18

[Koha-patches] [PATCH 4/4] bug 1532: various code cleanup

2010-02-18 Thread Galen Charlton
* export C4::Reserves::CancelExpiredReserves * rename misc/cronjobs/cancel_expired_reserves.pl to misc/cronjobs/holds/cancel_expired_holds.pl * added cancel_expired_holds.pl to example crontab * fix staff crash if AllowHoldDateInFuture is on * expirationdate is now nullable instead of relying

[Koha-patches] [PATCH 1/4] (bug 1532) Reserves Updates Ported From Dev_Week

2010-02-18 Thread Galen Charlton
From: Kyle M Hall kyle.m.h...@gmail.com This is a much improved re-implementation of the reserves updates from dev_week. Less new code has been added, and more existing functions are used instead of adding new ones. The 'Lock Hold' function has been removed due to it not working as intended.

[Koha-patches] [PATCH] Enhancement [3.4] Add separate Perl module verification script

2010-02-18 Thread Chris Nighswonger
From: Chris Nighswonger chris.nighswon...@gmail.com This patch moves the dependency list to C4::Installer and adds a script to check Perl modules. --- C4/Installer.pm | 91 +++ Makefile.PL | 93