[Koha-patches] [PATCH] (bug #3174) fill borrower number, and show author and creation date in saved reports

2009-04-30 Thread Nahuel ANGELINETTI
This patch add 2 columns in Use Saved page whith creation date, and the creator id. It fix the creation of a report, to save the borrowernumber in reports table(to show it after). --- C4/Reports/Guided.pm | 12 +---

[Koha-patches] [PATCH] [HEAD] (bug #3170) check if mandatory fields are not empty

2009-04-30 Thread Nahuel ANGELINETTI
This patch make authority and biblio add/edit to check that at least one subfield of mandatory fields are filled-in. --- .../prog/en/modules/authorities/authorities.tmpl | 51 ++-- .../prog/en/modules/cataloguing/addbiblio.tmpl | 46 +- 2 files changed,

Re: [Koha-patches] [PATCH] (bug #3170) check if mandatory fields are not empty

2009-04-30 Thread Nahuel ANGELINETTI
Le Wed, 29 Apr 2009 08:53:47 -0400, Galen Charlton galen.charl...@liblime.com a écrit : Hi, On Tue, Apr 28, 2009 at 11:06 AM, Nahuel ANGELINETTI nahuel.angeline...@biblibre.com wrote: This patch make authority and biblio add/edit to check that at least one subfield of mandatory fields

[Koha-patches] [PATCH] Moved some variable definitions out of conditionals

2009-04-30 Thread Colin Campbell
--- C4/AuthoritiesMarc.pm | 63 1 files changed, 37 insertions(+), 26 deletions(-) diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm index 633ced8..882211d 100644 --- a/C4/AuthoritiesMarc.pm +++ b/C4/AuthoritiesMarc.pm @@ -526,8 +526,13

Re: [Koha-patches] [PATCH] Bug 3173 Place Hold link visible in OPAC even if syspref turned off

2009-04-30 Thread Wagner, Jane
I've reworked resent. There are some really odd nests in those templates Thanks. Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 jwag...@ptfs.com From: Joe

[Koha-patches] [PATCH] Bug 3177 - haspermission offers bogus option

2009-04-30 Thread Joe Atzberger
$intflags was never used or returned if hashref instead of userid was passed. Also cleaned up needless passing of $dbh. --- C4/Auth.pm | 41 - members/deletemem.pl |3 ++- members/memberentry.pl |2 +- 3 files changed, 19

[Koha-patches] [PATCH] Bugfix 3176 - Browser selected languages are not use by OPAC

2009-04-30 Thread Frédéric Demians
This patch uses HTTP_ACCEPT_LANGUAGE web browser variable to select OPAC available language. --- C4/Languages.pm | 10 +- C4/Output.pm| 11 --- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/C4/Languages.pm b/C4/Languages.pm index 5795202..a082b1f 100644

Re: [Koha-patches] [PATCH] Bug 3173 Place Hold link visible in OPAC even if syspref turned off

2009-04-30 Thread Wagner, Jane
Not sure I understand what you mean. If the syspref is set to disallow holds, right now the detail page is the only place that obeys it. The results, lists, and cart still give an option for placing holds. That's what the patch is designed to fix -- turn off the place holds option on those

[Koha-patches] [PATCH] More fixes for Bug 2704, 440 Display Issues

2009-04-30 Thread Owen Leonard
Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record. ---

[Koha-patches] [PATCH] Fix for Bug 2767, cart and lists buttons missing on opac-search.pl

2009-04-30 Thread Owen Leonard
This fix adds alternate markup to be included on the advanced search page in order to mimic the placement of the cart and lists buttons on other opac pages. --- koha-tmpl/opac-tmpl/prog/en/css/opac.css |5 + koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc |4 2 files

[Koha-patches] [PATCH] Verbiage clarification in intranet advsearch.tmpl

2009-04-30 Thread Liz Rea
From: root r...@liz-koha.nekls.org Changed verbiage from Limit type to: match any of the following to Limit to any of the following: --- .../prog/en/modules/catalogue/advsearch.tmpl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Koha-patches] [PATCH] Bug fix to OPAC shelf browsing query statement

2009-04-30 Thread David Birmingham
If the items.location field was NULL, then the current SQL query would produce no results. I have turned this into a conditional block that removes the location condition in the query if the location is not specified. In addition, there was a small change to opac-detail.tmpl that changed Library

[Koha-patches] [PATCH] Remove unused $toggle code

2009-04-30 Thread Joe Atzberger
Some trivial other cleanups also. --- cataloguing/z3950_search.pl | 61 -- 1 files changed, 18 insertions(+), 43 deletions(-) diff --git a/cataloguing/z3950_search.pl b/cataloguing/z3950_search.pl index 884333c..df2fab1 100755 ---

[Koha-patches] [PATCH] Syndetics: handle variations in reviews XML output

2009-04-30 Thread Galen Charlton
For some reason different Syndetics users get slightly different results when requesting an XML-formatted review, so it's necessary to handle both observed variations: Here's one variation: ... Notes Fld520 I1=BLANK I2=BLANK aThis is a review And another: ... Notes Fld520 I1=BLANK

[Koha-patches] [PATCH] fix to C4::Koha::_isbn_cleanup

2009-04-30 Thread Galen Charlton
Both valid ISBN-10s and -13s can use 'X' as a checkdigit value. --- C4/Koha.pm |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/C4/Koha.pm b/C4/Koha.pm index 418b815..b4ce84b 100644 --- a/C4/Koha.pm +++ b/C4/Koha.pm @@ -1206,10 +1206,11 @@ sub _normalize_match_point {

[Koha-patches] [PATCH] Syndetics: start switch to XML::LibXML to parse results

2009-04-30 Thread Galen Charlton
XML::Simple doesn't handle mixed content, which is a problem because reviews provided by Syndetics sometimes contain HTML tags. Furthermore, it's often easier to write XPath to extract bits of an XML document than trying to play with XML::Simple's options. --- C4/External/Syndetics.pm | 47

Re: [Koha-patches] [PATCH] Adding date format hints to date entry fields (Bug 3089).

2009-04-30 Thread Joe Atzberger
Looks like a good chance to use ELSIF. -- Joe Atzberger LibLime - Open Source Library Solutions On Thu, Apr 30, 2009 at 12:25 PM, Owen Leonard oleon...@myacpl.org wrote: --- .../prog/en/modules/members/memberentrygen.tmpl|6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)

[Koha-patches] [PATCH] Bug 3179: Typo in C4::Circulation function call causes fatal error

2009-04-30 Thread Ryan Higgins
--- C4/Circulation.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 210b8ff..f218a8e 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1561,7 +1561,7 @@ sub AddReturn {

[Koha-patches] [PATCH] Bug #2974 Adding category code to BorrowerMandatoryField produced a The following fields are mandatory: categorycode

2009-04-30 Thread Garry Collum
If you made a column that is implemented by a select box mandatory in BorrowerMandatoryField, Members.js would throw an error on the first element. The original intent of the function was probably to catch the first option for a drop-down list such as Salutation where the text is blank. Added

Re: [Koha-patches] [PATCH] Adding date format hints to date entry fields (Bug 3089).

2009-04-30 Thread Owen Leonard
Looks like a good chance to use ELSIF. I guess I'm confused about whether this is a continuing issue: http://lists.koha.org/pipermail/koha-patches/2008-July/001322.html -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org