Re: [Koha-patches] [PATCH] Adds TLS support to LDAP auth

2010-05-20 Thread Chris Nighswonger
On Thu, May 20, 2010 at 4:26 PM, Ian Walls ian.wa...@bywatersolutions.com wrote: diff --git a/install_misc/debian.packages b/install_misc/debian.packages index 11dfeb4..23a1af6 100644 --- a/install_misc/debian.packages +++ b/install_misc/debian.packages @@ -39,6 +39,7 @@

Re: [Koha-patches] [PATCH] Adds TLS support to LDAP auth

2010-05-20 Thread Chris Nighswonger
shortly. Thanks. Kind Regards, Chris On Thu, May 20, 2010 at 4:34 PM, Chris Nighswonger cnighswon...@foundations.edu wrote: On Thu, May 20, 2010 at 4:26 PM, Ian Walls ian.wa...@bywatersolutions.com wrote: diff --git a/install_misc/debian.packages b/install_misc/debian.packages index 11dfeb4

[Koha-patches] [PATCH] Updating INSTALL documents

2010-05-19 Thread Chris Nighswonger
copyright 2010 Chris Nighswonger Feedback/bug reports: Koha Developer's List: http://lists.koha.org/mailman/listinfo/koha-devel -This document last modified: 30 April 2008 +This document last modified: 19 May 2010 Installation Instructions = @@ -69,7 +68,7 @@ Run

[Koha-patches] [PATCH 2/2] Backing down the required version of Graphics::Magick

2010-05-17 Thread Chris Nighswonger
This brings the required version into line with the latest version available in the Debian and Ubuntu repos. --- C4/Installer/PerlDependencies.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm index

[Koha-patches] [PATCH 2/5] [2/5] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-15 Thread Chris Nighswonger
Porting Makefile.PL over to use C4::Installer::PerlModules --- Makefile.PL | 99 +-- 1 files changed, 8 insertions(+), 91 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index a31d6db..5966d0d 100644 --- a/Makefile.PL +++

[Koha-patches] [PATCH 1/5] [1/5] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-15 Thread Chris Nighswonger
pattern used in the other dependencies. + +=head1 AUTHOR + +Chris Nighswonger cnighswonger AT foundations DOT edu + +=head1 COPYRIGHT + +Copyright 2010 Foundations Bible College. + +=head1 LICENSE + +This file is part of Koha. + +Koha is free software; you can redistribute it and/or modify it under

[Koha-patches] [PATCH 3/5] [3/5] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-15 Thread Chris Nighswonger
Porting about.pl over to use C4::Installer::PerlModules --- about.pl | 148 +-- koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl | 33 - 2 files changed, 66 insertions(+), 115 deletions(-) diff --git a/about.pl b/about.pl index

[Koha-patches] [PATCH 4/5] [4/5] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-15 Thread Chris Nighswonger
Porting install.pl over to use C4::Installer::PerlModules --- installer/install.pl | 148 .../prog/en/modules/installer/step1.tmpl | 39 ++ 2 files changed, 42 insertions(+), 145 deletions(-) diff --git a/installer/install.pl

[Koha-patches] [PATCH 5/5] [5/5] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-15 Thread Chris Nighswonger
= module is installed and current + +=item B-h|--help|? + +prints this help text + +=back + +=head1 AUTHOR + +Chris Nighswonger cnighswonger AT foundations DOT edu + +=head1 COPYRIGHT + +Copyright 2010 Foundations Bible College. + +=head1 LICENSE + +This file is part of Koha. + +Koha is free software

[Koha-patches] [PATCH] [3.2] Bug 4141 Reconcile 3.0.x and HEAD database updates for 3.2.0

2010-05-12 Thread Chris Nighswonger
This is a partial fix addressing this error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 at /home/koha/koha.prod/installer/data/mysql/updatedatabase.pl line 2916., referer:

[Koha-patches] [PATCH 1/3] [1/3] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-12 Thread Chris Nighswonger
@module_list = $perl_modules-module_list; + +This is useful for commandline exercises such as: + +perl -MC4::Installer::PerlModules -e 'my $deps = C4::Installer::PerlModule-new; print (join(\n,$deps-module_list));' + +=head1 AUTHOR + +Chris Nighswonger cnighswonger AT foundations DOT edu

[Koha-patches] [PATCH 2/3] [2/3] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-12 Thread Chris Nighswonger
Porting Makefile.PL over to use C4::Installer::PerlModules --- Makefile.PL | 96 +++--- 1 files changed, 5 insertions(+), 91 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index a31d6db..6c0346e 100644 --- a/Makefile.PL +++ b/Makefile.PL

[Koha-patches] [PATCH 3/3] [3/3] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-12 Thread Chris Nighswonger
Porting about.pl over to use C4::Installer::PerlModules --- about.pl | 148 +-- koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl | 33 - 2 files changed, 66 insertions(+), 115 deletions(-) diff --git a/about.pl b/about.pl index

[Koha-patches] [PATCH 1/4] [1/4] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-12 Thread Chris Nighswonger
; print (join(\n,$deps-module_list));' + +=head1 AUTHOR + +Chris Nighswonger cnighswonger AT foundations DOT edu + +=head1 COPYRIGHT + +Copyright 2010 Foundations Bible College. + +=head1 LICENSE + +This file is part of Koha. + +Koha is free software; you can redistribute it and/or modify it under

[Koha-patches] [PATCH 2/4] [2/4] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-12 Thread Chris Nighswonger
Porting Makefile.PL over to use C4::Installer::PerlModules --- Makefile.PL | 98 -- 1 files changed, 7 insertions(+), 91 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index a31d6db..8378703 100644 --- a/Makefile.PL +++ b/Makefile.PL

[Koha-patches] [PATCH 4/4] [4/4] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-12 Thread Chris Nighswonger
Porting install.pl over to use C4::Installer::PerlModules --- installer/install.pl | 142 .../prog/en/modules/installer/step1.tmpl | 39 ++ 2 files changed, 40 insertions(+), 141 deletions(-) diff --git a/installer/install.pl

[Koha-patches] [PATCH 3/4] [3/4] Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

2010-05-12 Thread Chris Nighswonger
Porting about.pl over to use C4::Installer::PerlModules --- about.pl | 148 +-- koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl | 33 - 2 files changed, 66 insertions(+), 115 deletions(-) diff --git a/about.pl b/about.pl index

[Koha-patches] [PATCH] Bugfix 3.2.alpha2 Correcting URLs in docs to point to the current koha-community.org resources

2010-05-11 Thread Chris Nighswonger
by: Chris Nighswonger (cnighswonger AT foundations DOT edu) Feedback/bug reports: Koha Developer's List: -http://lists.koha.org/mailman/listinfo/koha-devel +http://lists.koha-community.org/mailman/listinfo/koha-devel This document last modified: 22 June 2009 @@ -30,7 +30,7 @@ Your locale

[Koha-patches] [PATCH] Bug 4450 Use more consistent error returns in C4/Creators/*

2010-05-06 Thread Chris Nighswonger
( -1 might in some cases be legit data). Signed-off-by: Chris Nighswonger cnighswon...@foundations.edu --- C4/Creators/Batch.pm| 10 ++ C4/Creators/Layout.pm | 18 -- C4/Creators/Lib.pm | 27 +++ C4/Creators/PDF.pm |8

Re: [Koha-patches] Use CSS3 box-shadow property for Cart tooltip (Bug 4387)

2010-04-13 Thread Chris Nighswonger
2010/4/13 Owen Leonard oleon...@myacpl.org: The OPAC Cart tooltip (Your cart is empty, 1 item(s) added to your Cart) currently uses a jQuery plugin to generate a drop shadow. This works cross-browser, but has a high failure rate with regard to hiding the shadow consistently, resulting in an

Re: [Koha-patches] [PATCH] (bug #4334) create needed sample datas

2010-03-23 Thread Chris Nighswonger
Hmm... sample notice data in English still appears in the main repo: http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=blob;f=installer/data/mysql/en/mandatory/sample_notices.sql;h=ca570adc62a12ca07878cbe7f4398aa050b29289;hb=HEAD Kind Regards, Chris On Tue, Mar 23, 2010 at 11:41 AM, Nahuel

[Koha-patches] [PATCH] Bug 4102: import_borrowers.pl fails silently

2010-02-18 Thread Chris Nighswonger
This patch adds code to validate column names in the CSV header row against the current columns in the borrowers table as well as additional valid columns. It also adds error trapping to prevent import of files with fatal errors such as unparsable header rows and invalid column names. ---

[Koha-patches] [PATCH] Enhancement [3.4] Add separate Perl module verification script

2010-02-18 Thread Chris Nighswonger
From: Chris Nighswonger chris.nighswon...@gmail.com This patch moves the dependency list to C4::Installer and adds a script to check Perl modules. --- C4/Installer.pm | 91 +++ Makefile.PL | 93

[Koha-patches] [PATCH] Bugfix: [2/3] overdue_notices.pl does not process all advertised fields

2010-02-16 Thread Chris Nighswonger
This patch adds a dependency requirement for Locale::Currency::Format NOTE: It does not adjust kohaversion.pl and sets the dev version to XXX. --- Makefile.PL|1 + about.pl |1 + installer/data/mysql/updatedatabase.pl | 14

[Koha-patches] [PATCH] Bugfix: [1/3] overdue_notices.pl does not process all advertised fields

2010-02-16 Thread Chris Nighswonger
Note: overdue_notices.pl really needs to be completely re-written. The script does not process all fields advertised in tools/letter.pl This patch adds code to process all fields advertised as well as any from the items table. It also adds two additional tags for use in the letter templates:

[Koha-patches] [PATCH] Bugfix: Correcting invalid markup

2010-02-13 Thread chris . nighswonger
From: Chris Nighswonger chris.nighswon...@gmail.com --- en/koha3-2manual.xml | 66 +++-- 1 files changed, 47 insertions(+), 19 deletions(-) diff --git a/en/koha3-2manual.xml b/en/koha3-2manual.xml index d447b99..d6a88c0 100644 --- a/en/koha3

Re: [Koha-patches] [PATCH] Bugfix: Correcting invalid markup

2010-02-13 Thread Chris Nighswonger
NOTE: This patch is intended for the 3.2 documentation repo rather than the code repo. On Sat, Feb 13, 2010 at 7:26 PM, chris.nighswon...@gmail.com wrote: From: Chris Nighswonger chris.nighswon...@gmail.com ---  en/koha3-2manual.xml |   66

[Koha-patches] [PATCH] Enhancement: [3.4] A Script For Bulk Updateing Patron Messageing Preferences

2010-02-12 Thread Chris Nighswonger
notification preferences. + +=head1 AUTHOR + +Chris Nighswonger cnighswonger AT foundations DOT edu + +=head1 COPYRIGHT + +Copyright 2010 Foundations Bible College. + +=head1 LICENSE + +This file is part of Koha. + +Koha is free software; you can redistribute it and/or modify it under

[Koha-patches] [PATCH] Enhancement: [3.4] Adding code to support using gmail as an SMTP server

2010-02-12 Thread Chris Nighswonger
+= + +Copyright (C) 2010 Foundations Bible College (http://www.foundations.edu) + +Author: Chris Nighswonger (cnighswonger AT foundations DOT edu + +Feedback/bug reports: Koha Developer's List: +http://lists.koha.org/mailman/listinfo/koha-devel + +This document last

[Koha-patches] [PATCH] Bug 4102: import_borrowers.pl fails silently

2010-02-10 Thread Chris Nighswonger
This patch adds code to validate column names in the CSV header row against the current columns in the borrowers table as well as additional valid columns. It also adds error trapping to prevent import of files with fatal errors such as unparsable header rows and invalid column names. ---

[Koha-patches] [PATCH] Bugfix: Removing useless lines from patroncards/manage.pl

2010-02-10 Thread Chris Nighswonger
--- patroncards/manage.pl |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/patroncards/manage.pl b/patroncards/manage.pl index b9eda3e..7e07139 100755 --- a/patroncards/manage.pl +++ b/patroncards/manage.pl @@ -28,11 +28,6 @@ use autouse 'Data::Dumper' = qw(Dumper);

[Koha-patches] [PATCH] Bugfix: Make smart-rules.tmpl display zero values in fields.

2010-02-10 Thread Chris Nighswonger
Since TMPL_IFs evaluate false if the template variable is 0, smart-rules.tmpl was not displaying zero values in fields where the db field value was indeed zero which leads to some small confusion. This patch removes the TMPL_IFs since those fields will always be populated with some value even if

[Koha-patches] [PATCH] Bugfix: Fixing issues with the patron card pdf rendering code

2010-02-08 Thread Chris Nighswonger
This patch fixes two bugs: 1. Correcting the text alignment alogrithms for center and right alignment 2. Changes a reference to layout to a copy of the layout to avoid performing operations on the layout. --- C4/Patroncards/Lib.pm|4 ++-- C4/Patroncards/Patroncard.pm |2 +-

[Koha-patches] [PATCH] Bugfix: Enabling guide box configuration parameter

2010-02-08 Thread Chris Nighswonger
This patch enables turning the guide boxes on/off in the patron cards layout editor. --- .../prog/en/modules/patroncards/edit-layout.tmpl | 11 ++- patroncards/create-pdf.pl |2 +- patroncards/edit-layout.pl |2 ++ 3 files

[Koha-patches] [PATCH] Bringing label, patroncard, and creator modules into conformity with the rest of C4 style.

2010-02-08 Thread Chris Nighswonger
--- C4/Creators.pm| 28 C4/Creators/Lib.pm| 32 C4/Labels.pm | 13 + C4/Labels/Lib.pm | 28 ++-- C4/Patroncards.pm | 24

[Koha-patches] [PATCH] Removing depricated file from the C4::Labels module.

2010-02-08 Thread Chris Nighswonger
}}; -} -} -$$table[$row_index] = {text_fields = $fields}; -$col_index = 0; -$row_index++; -$fields = []; -} -return $table; -} - -1; -__END__ - -=head1 AUTHOR - -Chris Nighswonger cnighswonger AT foundations DOT edu - -=cut -- 1.6.0.4

[Koha-patches] [PATCH] Bugfix: Enabling guide box configuration parameter

2010-02-08 Thread Chris Nighswonger
This patch enables turning the guide boxes on/off in the patron cards layout editor. --- .../prog/en/modules/patroncards/edit-layout.tmpl | 15 --- patroncards/create-pdf.pl |2 +- patroncards/edit-layout.pl |2 ++ 3 files

Re: [Koha-patches] [PATCH] Bugfix: Enabling guide box configuration parameter

2010-02-08 Thread Chris Nighswonger
Fixed and resubmitted. On Mon, Feb 8, 2010 at 1:11 PM, Owen Leonard oleon...@myacpl.org wrote: input type=radio name=page_side id=page_side value=F checked / This is invalid. It needs to be input type=radio name=page_side id=page_side value=F checked=checked /  -- Owen -- Web

[Koha-patches] [PATCH] Bugfix: Fixing a broken link in the patron card layout editor

2010-02-05 Thread Chris Nighswonger
--- .../prog/en/modules/patroncards/edit-template.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tmpl index 6429154..38fe2a2

[Koha-patches] [PATCH] Bugfix: borrowers.userid is not defined as a unique key

2010-02-05 Thread Chris Nighswonger
While this constraint is enforced by memberentry.pl, it is not enforced by import_borrowers.pl and in any case should be enforced by the database in case custome patron import/update scripts are being run. --- installer/data/mysql/kohastructure.sql |2 +-

Re: [Koha-patches] [PATCH] Bugfix: Fixing a broken link in the patron card layout editor

2010-02-05 Thread Chris Nighswonger
Disregard.. duplicate submission... On Fri, Feb 5, 2010 at 11:35 AM, Chris Nighswonger cnighswon...@foundations.edu wrote: ---  .../prog/en/modules/patroncards/edit-template.tmpl |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en

[Koha-patches] [PATCH] Bugfix: Correcting hash dereferencing for image data

2010-02-04 Thread Chris Nighswonger
This patch corrects hash dereferencing syntax. --- C4/Patroncards/Patroncard.pm |2 +- patroncards/create-pdf.pl| 29 +++-- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/C4/Patroncards/Patroncard.pm b/C4/Patroncards/Patroncard.pm index

[Koha-patches] [PATCH] Bugfix: Correcting name of help file in Label Creator Tool

2010-02-04 Thread Chris Nighswonger
The Label Profile Editor help file was mis-named. This patch corrects the name. --- .../en/modules/help/labels/label-edit-profile.tmpl | 49 .../en/modules/help/labels/label-profiles.tmpl | 49 2 files changed, 49 insertions(+), 49 deletions(-)

[Koha-patches] [PATCH] Bugfix: Implimentation of JpegBlob and AltJpeg methods

2010-02-04 Thread Chris Nighswonger
Implimentation of JpegBlob and AltJpeg methods in C4::Creators::PDF --- C4/Creators/PDF.pm | 92 +++- 1 files changed, 91 insertions(+), 1 deletions(-) diff --git a/C4/Creators/PDF.pm b/C4/Creators/PDF.pm index 1421a2b..7ffb303 100644 ---

[Koha-patches] [PATCH] Bugfix: Correcting hash dereferencing for barcode data

2010-02-04 Thread Chris Nighswonger
This patch corrects hash dereferencing syntax. --- C4/Patroncards/Patroncard.pm | 10 +- patroncards/create-pdf.pl|2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/C4/Patroncards/Patroncard.pm b/C4/Patroncards/Patroncard.pm index 7e3ed35..595dfd1 100644 ---

[Koha-patches] [PATCH] Bugfix: Fixing a broken link in the patron card layout editor

2010-02-04 Thread Chris Nighswonger
--- .../prog/en/modules/patroncards/edit-template.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tmpl index 6429154..38fe2a2

[Koha-patches] [PATCH] Bugfix:[3.2] Corrects bad behavior in opac-reserve.pl

2010-02-03 Thread Chris Nighswonger
When AllowOnShelfHolds is enabled, but maxreserves is NULL, attempting to reserve an item results in a basically blank page being returned with no error message. This patch adds a check to see if the check for maxreserves has returned a value and bypasses the application of it if it has not.

[Koha-patches] [PATCH] Bugfix: Upping the byte size limit of patron images

2010-02-03 Thread Chris Nighswonger
This brings it more in line with the size limit placed on other images uploaded for use on patron cards. --- tools/picture-upload.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/picture-upload.pl b/tools/picture-upload.pl index a28f259..c3f7b00 100755 ---

[Koha-patches] [PATCH] Bugfix: Corrects bad behavior in opac-reserve.pl

2010-02-01 Thread Chris Nighswonger
When AllowOnShelfHolds is enabled, but maxreserves is NULL, attempting to reserve an item results in a basically blank page being returned with no error message. This patch adds a check to see if the check for maxreserves has returned a value and bypasses the application of it if it has not.

[Koha-patches] [PATCH] 4074 Bugfix: The 'Subject(s)' link(s) are malformed resulting in no search results

2010-02-01 Thread Chris Nighswonger
This bug was introduced by commit d51332698b2cce43542a58e53fd916df99329158 which removed the inability to do a search on anything contianing a colon (:). This patch expands the regexp to only normalize true limit operators and leave all other colons (:) intact. --- C4/Search.pm | 18

[Koha-patches] [PATCH] 4074 Bugfix: The 'Subject(s)' link(s) are malformed resulting in no search results

2010-01-28 Thread Chris Nighswonger
These links are rendered with the wrong syntax. ie. 'q=su:foo' This results in a search for 'su:foo' rather than a search for 'foo' with an index of 'su.' This patch corrects the code so that the syntax conforms to current parsing methods. ie. 'idx=suq=foo' NOTE: The change to the underlying

[Koha-patches] [PATCH] 3.0.x Back-port: 4074 Bugfix: The 'Subject(s)' link(s) are malformed resulting in no search results

2010-01-28 Thread Chris Nighswonger
. ie. 'idx=suq=foo' NOTE: The change to the underlying C4::Biblio-GetMarcSubjects() does not need to be ported to any other calling code. Signed-off-by: Chris Nighswonger cnighswon...@foundations.edu --- C4/Biblio.pm | 275 ++-- .../opac-tmpl

[Koha-patches] [PATCH] Bugfix: Fixing hardcoded dir paths in C4::XSLT

2010-01-28 Thread Chris Nighswonger
--- C4/XSLT.pm | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 8a67e04..10bcd51 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@ -73,7 +73,7 @@ sub transformMARCXML4XSLT { $value = GetAuthorisedValueDesc( $tag,

[Koha-patches] [PATCH] Bugfix: Fixing hardcoded dir paths in C4::XSLT

2010-01-28 Thread Chris Nighswonger
This patch makes C4::XSLT.pm obey the 'themes/opacthemes' system preferences --- C4/XSLT.pm | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 8a67e04..db9717a 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@ -73,7 +73,7 @@ sub

Re: [Koha-patches] [PATCH] Bugfix: Fixing hardcoded dir paths in C4::XSLT

2010-01-28 Thread Chris Nighswonger
Disregard this patch. Resubmit to follow. On Thu, Jan 28, 2010 at 12:26 PM, Chris Nighswonger cnighswon...@foundations.edu wrote: ---  C4/XSLT.pm |   13 +++--  1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 8a67e04..10bcd51 100644

Re: [Koha-patches] [PATCH] Bugfix: Fixing hardcoded dir paths in C4::XSLT

2010-01-28 Thread Chris Nighswonger
This is the resubmit. On Thu, Jan 28, 2010 at 12:35 PM, Chris Nighswonger cnighswon...@foundations.edu wrote: This patch makes C4::XSLT.pm obey the 'themes/opacthemes' system preferences ---  C4/XSLT.pm |   16  1 files changed, 8 insertions(+), 8 deletions(-) diff --git

[Koha-patches] [PATCH] Bugfix: Stop C4::Koha from filling the log with pesky warns

2010-01-28 Thread Chris Nighswonger
--- C4/Koha.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Koha.pm b/C4/Koha.pm index 31bd678..ae89770 100644 --- a/C4/Koha.pm +++ b/C4/Koha.pm @@ -1086,7 +1086,7 @@ sub GetAuthorisedValues { my $sth = $dbh-prepare($query); $sth-execute; while

[Koha-patches] [PATCH] Bugfix: Stop opac/opac-detail.pl from filling the log with pesky warns

2010-01-28 Thread Chris Nighswonger
--- opac/opac-detail.pl |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index f0a7288..9af15a8 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -585,9 +585,9 @@ if (C4::Context-preference('TagsEnabled') and

Re: [Koha-patches] [PATCH] Bugfix: Fixing hardcoded dir paths in C4::XSLT

2010-01-28 Thread Chris Nighswonger
I'm withdrawing this patch in favor of work done by BibLibre on the XSLT features of Koha (soon to be submitted). On Thu, Jan 28, 2010 at 12:38 PM, Chris Nighswonger cnighswon...@foundations.edu wrote: This is the resubmit. On Thu, Jan 28, 2010 at 12:35 PM, Chris Nighswonger cnighswon

[Koha-patches] [PATCH] Enhancement: This patch adds a 'cardnumber' parameter and checks

2010-01-26 Thread Chris Nighswonger
From: Chris Nighswonger cnighswon...@foundations.edu to see if it is present when the script is called. If it is, the patron information is retrieved and borrowernumber set from that. Otherwise, the patron information is retrieved by borrowernumber. The changes in this patch do not require

[Koha-patches] [PATCH] Bugfix: Adding missing package to Makefile.PL

2010-01-15 Thread Chris Nighswonger
--- Makefile.PL |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index aa45911..6ef3b1d 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -571,6 +571,7 @@ WriteMakefile( 'LWP::Simple' = 1.41,

[Koha-patches] [PATCH] Bugfix: 4046 Misc SQL Syntax Errors

2010-01-14 Thread Chris Nighswonger
This patch fixes several SQL syntax errors with the ALTER TABLE pragma --- installer/data/mysql/updatedatabase.pl | 47 +++ 1 files changed, 23 insertions(+), 24 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl

[Koha-patches] Pull Request

2010-01-11 Thread Chris Nighswonger
Since github does not seem to be able to email a pull request... The patron card work is ready to be pulled from git:// github.com/cnighswonger/koha-wip.git Note: the four most recent patches are bugfixs not related, but which need to be pulled as well. Kind Regards, Chris

[Koha-patches] [PATCH] Correcting array element reference syntax which caused unnecessary warns

2010-01-07 Thread Chris Nighswonger
Also adding conditional to check ENV VAR definition to avoid unnecssary warns. --- opac/opac-main.pl | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/opac/opac-main.pl b/opac/opac-main.pl index f218a00..ba0409c 100755 --- a/opac/opac-main.pl +++

[Koha-patches] [PATCH] Correcting array element reference syntax which caused unnecessary warns

2010-01-07 Thread Chris Nighswonger
Also adding conditional to check ENV VAR definition to avoid unnecssary warns. --- opac/opac-main.pl | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/opac/opac-main.pl b/opac/opac-main.pl index f218a00..e0a65a9 100755 --- a/opac/opac-main.pl +++

Re: [Koha-patches] [PATCH] Correcting array element reference syntax which caused unnecessary warns

2010-01-07 Thread Chris Nighswonger
Disregard this patch. Corrected version to follow. On Thu, Jan 7, 2010 at 9:37 AM, Chris Nighswonger cnighswon...@foundations.edu wrote: Also adding conditional to check ENV VAR definition to avoid unnecssary warns. ---  opac/opac-main.pl |   18 ++  1 files changed, 10

[Koha-patches] [PATCH] Bugfix: Missing line terminator at the end of an INSERT

2009-12-12 Thread Chris Nighswonger
--- installer/data/mysql/en/mandatory/sysprefs.sql | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/installer/data/mysql/en/mandatory/sysprefs.sql b/installer/data/mysql/en/mandatory/sysprefs.sql index e9df35e..cfa16e2 100644 ---

[Koha-patches] [PATCH] Bugfix for various bugs in mandatory and sample data for webinstaller

2009-12-12 Thread Chris Nighswonger
NOTE: This patch removes the sample budgets data which was obsoleted by the new aquisitions module. The changes introduced with this new module will require a completely new set of sample data to be written. --- installer/data/mysql/en/mandatory/sysprefs.sql |2 --

[Koha-patches] [PATCH] Fix for MSWin32

2009-12-05 Thread Chris Nighswonger
A tweak to restore MSWin32 installation capability. NOTE: Native MSWin32 support in Koha is for Strawberry Perl 5.10.1.0 or later. There are some issues with GDBM_File.pm which prevent Koha from running without a bit of a workaround. This will be resolved in the January 2010 release of

[Koha-patches] [PATCH] Adding the capacity to retrieve patron reading records by cardnumber

2009-11-19 Thread chris . nighswonger
From: Chris Nighswonger chris.nighswon...@gmail.com This patch adds a 'cardnumber' parameter and checks to see if it is present when the script is called. If it is, the patron information is retrieved and borrowernumber set from that. Otherwise, the patron information is retrieved

[Koha-patches] [PATCH] Bug 3706 Part 2: Label templates/layouts do not save properly

2009-10-15 Thread Chris Nighswonger
This completes adding checks for profile id passed in by the layout edit template. --- labels/label-edit-template.pl | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/labels/label-edit-template.pl b/labels/label-edit-template.pl index cc539c5..ec80f3d

[Koha-patches] [PATCH] Bug 3706 Label templates/layouts do not save properly

2009-10-12 Thread Chris Nighswonger
Two issues here: 1. No radio box was selected by default in the format section of the layout editor. This actually needs some additional attention to allow the user to establish a default method of entering the format string. As noted in comments in the code, this would probably be best

[Koha-patches] [PATCH] Bugfix Corrects a bug in the labels printer profile module which caused the printer name and tray to be updated incorrectly when saving changes.

2009-09-18 Thread Chris Nighswonger
--- .../prog/en/modules/labels/label-edit-profile.tmpl |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-profile.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-profile.tmpl index

[Koha-patches] [PATCH] Bug 2500 Correcting incorrect splitting of cutter numbers

2009-09-15 Thread Chris Nighswonger
This patch does two things to improve the call number splitting algorithms: 1. It makes changes to ensure that cutter numbers are split correctly in ddcns 2. It moves custom/fiction/biography call number splitting to a separate algorithm. Before they were incorrectly placed

[Koha-patches] [PATCH] Moving css to correct location

2009-09-14 Thread Chris Nighswonger
See comments in commit b1197477d476ddaedec43392bdd92396b94b0852 --- .../prog/en/lib/greybox/gb_styles.css | 14 -- .../prog/en/modules/labels/label-print.tmpl|1 + 2 files changed, 1 insertions(+), 14 deletions(-) diff --git

[Koha-patches] [PATCH] Bug 2500 Correcting incorrect splitting of cutter numbers

2009-09-14 Thread Chris Nighswonger
This patch does two things to improve the call number splitting algorithms: 1. It makes changes to ensure that cutter numbers are split correctly in ddcns 2. It moves custom/fiction/biography call number splitting to a separate algorithm. Before they were incorrectly placed in ddcns. This

[Koha-patches] Request to pull

2009-09-02 Thread Chris Nighswonger
The following changes since commit de66ef5c4987039f97e291257682a4941d12d0df: Galen Charlton (1): bug 3564 follow: ensure NoZebra is passed to templates are available in the git repository at: git://git.foundations.edu/pub/git/koha.labels_recon labels.recon Chris Nighswonger (40

[Koha-patches] [PATCH] [labels_recon] Adding a missing module to labels search

2009-09-02 Thread Chris Nighswonger
This causes an error to be thrown if no items are retrieved and the code goes to call syslog --- labels/label-item-search.pl |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/labels/label-item-search.pl b/labels/label-item-search.pl index 8f950ec..9acd04e 100755 ---

[Koha-patches] [PATCH 2/2] Bug 3390 Enabling ZIP compression in pdf generation to reduce file size

2009-07-03 Thread Chris Nighswonger
Enabling compression gives a ~26% *reduction* over non-compressed Type 3 font embedding. ie. 4.5 K/pg (compressed graphic) vs. 17.5 K/pg (uncompressed Type 3 font) vs 111 K/pg (uncompressed graphic). It also appears that most other applications that export in pdf use compression by default.

[Koha-patches] [PATCH] Adding installation documentation for Ubuntu

2009-06-23 Thread Chris Nighswonger
://liblime.com) + +Original author: Joshua Ferraro (jmf AT liblime DOT com) +Modified for Ubuntu by: Chris Nighswonger (cnighswonger AT foundations DOT edu) + +Feedback/bug reports: Koha Developer's List: +http://lists.koha.org/mailman/listinfo/koha-devel + +This document last modified: 22 June 2009

[Koha-patches] [PATCH] Bug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers

2009-05-27 Thread Chris Nighswonger
Presently 252.051 T147 v.1-2 is split as 252.051 T147 v.1 -2 This patch corrects the algorithm so that it splits as 252.051 T147 v.1-2 It also updates Labels_split_ddcn.t to include this particular case. --- C4/Labels.pm |2 +- t/Labels_split_ddcn.t |3 ++- 2 files changed, 3

[Koha-patches] [PATCH] kohabug 2955 GetMarcFromKohaField now requires $framework

2009-02-11 Thread Chris Nighswonger
Failure to pass the $framework parameter by barcode.pl causes GetMarcFromKohaField to return 0,0 which breaks the value builder. The patch submitted corrects this. This patch is build against the current 3.1.x HEAD, however, this bug also affects the 3.0.x codebase and should be applied there as

[Koha-patches] [PATCH] kohabug 2955 (2/2) GetMarcFromKohaField now requires $framework

2009-02-11 Thread Chris Nighswonger
Failure to pass the $framework parameter by dateaccessioned.pl causes GetMarcFromKohaField to return 0,0 which breaks the value builder. The patch submitted corrects this. This patch is build against the current 3.1.x HEAD, however, this bug also affects the 3.0.x codebase and should be applied

[Koha-patches] [PATCH] kohabug 2934 - Wrong datatype causes artificial limit to label batch id's

2009-01-29 Thread Chris Nighswonger
labels.batch_id should be int as the value is always an integer. This corrects the problem. I'm submitting a patch for this built against the current 3.0.x branch. It should be ported forward to the current 3.1 branch as well. --- installer/data/mysql/kohastructure.sql |2 +-

[Koha-patches] [PATCH] DDCN Split Regexp Refinements

2008-09-23 Thread Chris Nighswonger
Adjusting to allow: 1. a space between the prefix and call number 2. 'n.d.' --- C4/Labels.pm | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/C4/Labels.pm b/C4/Labels.pm index 6531164..343287b 100644 --- a/C4/Labels.pm +++ b/C4/Labels.pm @@ -974,15

Re: [Koha-patches] [PATCH] DDCN Split Regexp Refinements

2008-09-23 Thread Chris Nighswonger
Sorry. Disregard this patch. On Tue, Sep 23, 2008 at 11:49 AM, Chris Nighswonger [EMAIL PROTECTED] wrote: Adjusting to allow: 1. a space between the prefix and call number 2. 'n.d.' --- C4/Labels.pm | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff

[Koha-patches] [PATCH] kohabug 2491 Improving error trapping and communication w/user

2008-08-23 Thread Chris Nighswonger
This patch adds code to indicate why a rule is not saved when the Delay field is left blank. Form validation in general is improved. It also corrects a condition which caused the form not to display current rules for the selected branch. It also adds the ability to delete a rule. This patch

[Koha-patches] [PATCH] kohabug 2491 Improving error trapping and communication w/user

2008-08-12 Thread Chris Nighswonger
This patch adds code to indicate why a rule is not saved when the Delay field is left blank. The patch also corrects a condition which caused the form not to display current rules for the selected branch. It also adds the ability to delete a rule. Documentation note: Docs will need to be

[Koha-patches] [PATCH] kohabug 2427 Correcting C4::Items:: _koha_new_item to populate items.copynumber

2008-08-07 Thread Chris Nighswonger
The INSERT was missing the copynumber parameter. moredetail.pl was also not setting the copyvol template variable. This patch corrects these issues so that the copynumber is both inserted when a new item is created (including during a bulkmarcimport.pl run) and displayed properly on

[Koha-patches] [PATCH] kohabug 2448 Correcting Alignment of Column Headers

2008-08-06 Thread Chris Nighswonger
This patch corrects the alignment of the column headers in the overdues list on the 'Overdue' tab on opac-user.pl It also corrects the template to display the item type rather than the Koha collection type. --- koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl | 16 +++- 1 files

Re: [Koha-patches] [PATCH] Replace TMPL_ELSIF with TMPL_ELSE and TMPL_IF in label-manager.tmpl;

2008-07-28 Thread Chris Nighswonger
that those installations have the correct version of H::T::P installed. Kind Regards, -- Chris Nighswonger LibLime www.liblime.com [EMAIL PROTECTED] ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] kohabug 2392 Changing array dereferencing syntax

2008-07-23 Thread Chris Nighswonger
It appears that Perl 5.10 does not like [EMAIL PROTECTED] but rather wants $foo-[0] The latter is also much more readable. This patch makes the change. --- C4/Auth.pm| 12 ++-- C4/VirtualShelves.pm |8 C4/VirtualShelves/Page.pm | 12 ++-- 3

[Koha-patches] [PATCH] Correcting bad session var that caused Lists link not to be displayed in anonymous sessions

2008-07-22 Thread Chris Nighswonger
--- C4/Auth.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Auth.pm b/C4/Auth.pm index 98c151e..3f39504 100755 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -741,7 +741,7 @@ sub checkauth { ($pubshelves, $totshelves) = GetRecentShelves(2,

[Koha-patches] [PATCH] Correcting C4::VirtualShelves::ShelfPossibleAction to handle the case where the staff user is the superlibrarian ($user == 0)

2008-07-22 Thread Chris Nighswonger
--- C4/VirtualShelves.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm index fbb100d..ec55a65 100644 --- a/C4/VirtualShelves.pm +++ b/C4/VirtualShelves.pm @@ -476,7 +476,7 @@ sub ShelfPossibleAction { return 1 if (

[Koha-patches] [PATCH] Correcting text wrapping on labels

2008-07-10 Thread Chris Nighswonger
--- C4/Labels.pm | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/C4/Labels.pm b/C4/Labels.pm index e78df94..3387a11 100644 --- a/C4/Labels.pm +++ b/C4/Labels.pm @@ -21,7 +21,7 @@ use strict; use vars qw($VERSION @ISA @EXPORT); use PDF::Reuse; -#use

[Koha-patches] [PATCH] kohabug 1875 Public lists/virtualshelves are displayed and viewable whether a patron is logged in or not.

2008-06-20 Thread Chris Nighswonger
NOTE: This patch introduces code which generates an anonymous session when a patron first browses to OPAC. This anonymous session contains a minimal amount of information including the results of a query to discover all public lists/shevles. When the user logs in, the anonymous session is

[Koha-patches] [PATCH] Tidying up the Lists button menu

2008-06-20 Thread Chris Nighswonger
--- koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc index 0fe8239..a0e67ea 100755 ---