Script was written as though it had an array rather than
a single supplier. Replaced the excess punctuation with a single
supplier variable
replaced the C-style currency loop with a simpler perl-style one
we only need 1 loop not multiples
Changed variable name $GST to $tax_rate it's not magical an
We've checked the return for definedness and
assigned an empty string to it ao we don't want
to make it undef again
This is a good argument that cascading if-elses expecially with
long unstructured elses are a bad idea
---
acqui/basket.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-
---
serials/reorder_members.pl |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/serials/reorder_members.pl b/serials/reorder_members.pl
index 66d4ab2..28175fb 100755
--- a/serials/reorder_members.pl
+++ b/serials/reorder_members.pl
@@ -21,12 +21,17 @@
use strict;
use
basket.pl calculates variables i, odd and count which are
no longer used in the template
removing them allows some simplification of the main loop
and cuts out on an extra db call
Loop through basketgroups also made more readable
Try to dimish the number of undef warnings filling the logs
---
acqu
Script was written as though it had an array rather than
a single supplier. Replaced the excess punctuation with a single
supplier variable
replaced the C-style currency loop with a simpler perl-style one
Changed variable name $GST to $tax it's not magical and not a constant
and we all know what t
Script was written as though it had an array rather than
a single supplier. Replaced the excess punctuation with a single
supplier variable
replaced the C-style currency loop with a simpler perl-style one
Changed variable name $GST to $tax it's not magical and not a constant
and we all know what t
The only serials routine without warnings enabled was a
script with the least code to generate them
removed the numerous Module use declarations that were not
required
aligned the parameters for a more aesthetically pleasing effect
---
serials/reorder_members.pl | 20 +++-
1 file
The empty vendor created by the select if any subscriptions
have no associated vendor generates a 'wrong-looking' display
and selecting it gives no options
---
C4/Serials.pm |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/C4/Serials.pm b/C4/Serials.pm
index bca9fc8..f8a9b
;do(< ALTER TABLE `aqbudgets` AUTO_INCREMENT=$$maxbudgetid[0]
> BUDGETAUTOINCREMENT
Quick thought - is it not safer to use NULL rather than 0 as the
behaviour of auto_increment passed 0 is dependent on the SQL mode that
MySQL is running under? (sorry scarred by an early experience of
re
Enable warnings - remove Bug 2505 FIXME messages
Correct FSF address in License statement
To aid code analysis tools:
Call new unambiguously with arrow syntax
use noninterpolating quotes on noninterpolating strings
---
errors/400.pl | 12 ++--
errors/401.pl | 13 ++---
errors/4
ed !!!
>
> Good catch, I missed spotting that when I cherry picked it over.
>
Patch to the cherry-picked patch posted
C.
--
Colin Campbell
Chief Software Engineer,
PTFS Europe Limited
Content Management and Library Solutions
+44 (0) 208 366 1295 (phone)
+44 (0) 7759 633626 (mobile)
co
Changed arriveddate format to follow syspref
Fixed a whitespace error
---
serials/serials-edit.pl |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl
index bd7d420..b407ca9 100755
--- a/serials/serials-edit.pl
+++ b/serials/
if $index is unnecessary as we have made this true 5 lines above
variables should not be declared in conditionals if used outside of them
set $struct_attr to a sensible default to avoid generating warnings
in this assigment and elsewhere
---
C4/Search.pm |6 +++---
1 files changed, 3 insertion
A lot of routines were defaulting to return -1 in error conditions
but calling code was expecting a ref or object
use return with explicit undef (or emptyness in array context)
for these cases. Extended this to cases where return was not tested
( -1 might in some cases be legit data).
---
C4/Creat
Used in Sip.pm
---
Makefile.PL |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile.PL b/Makefile.PL
index c88d5ea..a31d6db 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -550,6 +550,7 @@ WriteMakefile(
'DBD::mysql' =>
Script was incorrectly asking user to define an active currency
Now test for active currency in the standard way
Use the currency routines in Budgets where applicable
Move the code paths in the if else to subroutines to clarify flow
Enable warnings
---
admin/currency.pl | 258
Ooops posted the wrong version here's the correct patch
___
Koha-patches mailing list
Koha-patches@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-patches
Script was incorrectly asking user to define an active currency
Now test for active currency in the standard way
Use the currency routines in Budgets where applicable
Move the code paths in the if else to subroutines to clarify flow
Enable warnings
---
admin/currency.pl | 257
Script was incorrectly asking user to define an active currency
Now test for active currency in the standard way
Use the currency routines in Budgets where applicable
Move the code paths in the if else to subroutines to clarify flow
Enable warnings
---
admin/currency.pl | 258
on current 3.2 HEAD.
These are not major new functionality, but a series of fixes to
eradicate some randomness caused by undefined values. Includes a commit
to fix Licenses in the serials directory.
Credit due to the staff at fao for their testing, feedback and perseverance.
Colin
--
Colin
labeled_marc ioption was omitted (spelling police?)
options available now match those in code
---
.../en/modules/admin/preferences/cataloguing.pref |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
Identify Patron Expiry so that it is returned in Patron Info Response
---
C4/SIP/ILS/Patron.pm | 25 -
1 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm
index 386287b..2a73307 100644
--- a/C4/SIP/ILS/Patron.pm
+++
Change timestamp routine to do the right thing when passed an iso date
Otherwise was generating an epoch date of 0
---
C4/SIP/Sip.pm |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm
index 558a1d4..44d877e 100644
--- a/C4/SIP/Sip.pm
+++ b
Allow partial payment of outstanding fines
either against individual fine entries or as a lump payment.
Sponsered by East Brunswick Public Library, East Brunswick, NJ, USA
---
C4/Accounts.pm | 101 ++-
.../intranet-tmpl/prog/en/modules/members/pay.tmpl |
---
C4/Accounts.pm|3 +--
members/mancredit.pl |5 -
members/maninvoice.pl |5 -
3 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/C4/Accounts.pm b/C4/Accounts.pm
index bce9c19..c7e05bc 100644
--- a/C4/Accounts.pm
+++ b/C4/Accounts.pm
@@ -454,7 +454,6 @@ s
Also remove the reverse column if no contents to be displayed
( otherwise looks like a markup error )
Rationalize the main loop now toggle not required
---
.../prog/en/modules/members/boraccount.tmpl|6 ++-
members/boraccount.pl | 60 +++
Script was incorrectly asking user to define an active currency
Now test for active currency in the standard way
Use the currency routines in Budgets where applicable
Move the code paths in the if else to subroutines to clarify flow
Enable warnings
---
admin/currency.pl | 258
Remove unnecessary db calls and processing from acqui-home.pl
Do not duplicate processing of fields
Declare variables closer to use
Remove unnecessary holding vars
Replace some anonymous var names by something more meaningful
Do not generate a toggle variable use Template's LOOP vars
---
acqui/acq
Calculation of budget spent and encumbered is done by
queries on aqorders by budget_id
Index budget_id to speed these queries
---
installer/data/mysql/kohastructure.sql |2 ++
installer/data/mysql/updatedatabase.pl |7 +++
kohaversion.pl |2 +-
3 files chang
Fixes generation of empty index page when total_parcels is a multiple of
pagesize
Remove some calculations whose results were not used
Make variable names meaningful (results and count arnt)
Fix errors in pod syntax
Make what code does clearer to readers who are not computers
Use a subroutine
---
On 18/03/10 14:30, Colin Campbell wrote:
> for dafer code.
Oops that should be safer (though I've generated my fair share of dafter
code over the years)
C.
--
Colin Campbell
Chief Software Engineer,
PTFS Europe Limited
Content Management and Library Solutions
+44 (0) 208 366 1295 (ph
y with
one element ( i.e. [ undef, ] ). Better to just return; which returns
undef in a scalar context and an empty array in an array context. Makes
for dafer code.
Colin
--
Colin Campbell
Chief Software Engineer,
PTFS Europe Limited
Content Management and Library Solutions
+44 (0) 208 366 1
Garry Collum's patch correctly identified the core flaw in operation
looking closer revealed some other flaws (2 "blank" options, some vars
and documentation belonging to a superceded version, etc.
Changed GetCities to return a structure rather than the messy two returns
Let the template do the con
Remove any carriage returns in text data as they will be
interpreted as end of message by clients and cause communication failure
---
C4/SIP/Sip.pm |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm
index 558a1d4..f176516 100644
--- a/C4/SIP/Sip
return undef or empty array in error cases
hopefully if we're consistent someone may start checking it
removed unnecessary ()s
---
C4/Bookseller.pm |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm
index 655d25e..63df90d 100644
--- a/
---
admin/aqcontract.pl |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/admin/aqcontract.pl b/admin/aqcontract.pl
index 81cc640..5fe7be3 100755
--- a/admin/aqcontract.pl
+++ b/admin/aqcontract.pl
@@ -35,7 +35,7 @@ my $contractnumber = $input->param('contractnumber');
m
mysql comments require a space after the --
---
installer/data/mysql/en/optional/auth_val.sql |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/installer/data/mysql/en/optional/auth_val.sql
b/installer/data/mysql/en/optional/auth_val.sql
index 5a39534..12856d0 100644
--- a
dom is the recommended authorities indexing mode in external docs
making it default accepts what appears to be the de facto preference
see Indexdata's documentation for more details on the options
---
Makefile.PL |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.PL
---
acqui/neworderempty.pl | 30 ---
.../prog/en/modules/acqui/neworderempty.tmpl |8 -
2 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl
index 9fb1870..cedec85 100755
--- a/a
Before formatting and doing arithmetic with them we should
ensure undefined numeric elements are numbers
(This should be enforced in the db)
---
acqui/acqui-home.pl | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/acqui/acqui-home.pl b/acqui/acqui-home.pl
index 01
Script test.pl was added to the top level directory
Due to the name this gets run in a make test and end in error
I suspect it was comitted in error
moved and renamed so it dosent get in the way
---
misc/split_test.pl | 30 ++
test.pl| 30 ---
An earlier patch inadvertantly reverted a name change in the template
---
.../opac-tmpl/prog/en/modules/opac-basket.tmpl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tmpl
b/koha-tmpl/opac-tmpl/prog/en/modules/opac-ba
---
t/Dates.t |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/Dates.t b/t/Dates.t
index 0f0cbc2..da6f377 100644
--- a/t/Dates.t
+++ b/t/Dates.t
@@ -3,7 +3,7 @@
use strict;
use warnings;
-use Test::More tests => 192;
+use Test::More tests => 276;
BEGIN {
use
On 08/02/10 20:15, Chris Nighswonger wrote:
> +our @EXPORT = qw(get_all_templates
> -our @EXPORT_OK = qw(get_all_templates
I'm not sure replacing EXPORT_OK with EXPORT can be called progress. A
migration in the other direction might be considered 'A Good Thing&#x
changed link to point at labels script
---
.../en/modules/labels/label-edit-template.tmpl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-template.tmpl
b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-e
updatedatebase is now setting aqorders.quantityreceived to NOT NULL
kohastructure needs bringing into line
---
installer/data/mysql/kohastructure.sql |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/installer/data/mysql/kohastructure.sql
b/installer/data/mysql/kohastructu
The return from Mail::Sendmail should always be checked
Output the error message if it fails so we have some
indication of where to start looking if it fails
---
C4/Letters.pm | 21 +
1 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/C4/Letters.pm b/C4/Letters.p
quantityreceived drives other parts of acq noticeably budget balances
ensure that a number (usually 0) is set in NewOrder
give field a valid default and set as not null
reinterpret exsting nulls in table as zero
---
C4/Acquisition.pm |3 +++
installer/data/mysql/updatedata
---
C4/Acquisition.pm |2 +-
acqui/basket.pl |8 +++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
index 148d3a1..80dd667 100644
--- a/C4/Acquisition.pm
+++ b/C4/Acquisition.pm
@@ -1009,7 +1009,7 @@ sub NewOrder {
die "
order_by parameter should be an arrayref of hashrefs
Have made order surname, firstname asc (see bug 4067)
do not generate logged warnings by manipulating undef
---
serials/member-search.pl | 28 +++-
1 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/serials
Fixed two calls where new interface was not used
Arguably new syntax allows more options than we require but it was not catching
error cases (when 0 or undef is passed). It also can now be called in ways
which would validly return multiple hits but explicitly does not
(nor does calling code expect
New version of patch to apply against 3.2alpha
Also remove related FIXME message that was displaying to the user
---
acqui/neworderbiblio.pl| 14 +-
.../prog/en/modules/acqui/neworderbiblio.tmpl |2 +-
2 files changed, 6 insertions(+), 10 deletion
---
C4/Budgets.pm | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/C4/Budgets.pm b/C4/Budgets.pm
index 4a8b3b6..8d0a2f0 100644
--- a/C4/Budgets.pm
+++ b/C4/Budgets.pm
@@ -630,14 +630,14 @@ sub DelBudget {
return $rc;
}
-=back
-
=head2 FUNCTIONS ABOUT B
Subscription end date is required before receiving against
the subscription. If not set the subscription needs
renewal before use.
---
.../prog/en/modules/serials/subscription-add.tmpl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
a/koha-tmpl/intranet-tmpl/prog/en/modul
due date was not being formatted as a timestamp
but being passed as epoch seconds
---
C4/SIP/Sip/MsgType.pm |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
index 1b210ca..d0550e3 100644
--- a/C4/SIP/Sip/MsgType.pm
+++ b/C4
Add use warnings where not present
Remove unused variables
Avoid redeclarations of variables
trailing spaces trimmed
---
serials/acqui-search-result.pl |4 +-
serials/checkexpiration.pl |2 +-
serials/claims.pl |1 -
serials/lateissues-excel.pl|
Calls to the unexported subroutine result in system error
---
C4/Serials.pm |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/C4/Serials.pm b/C4/Serials.pm
index 0b70099..d72e98c 100644
--- a/C4/Serials.pm
+++ b/C4/Serials.pm
@@ -56,6 +56,7 @@ BEGIN {
&reorder_members
Some koha acq terminology is confusing to new users so lets at least
be consistent in our usages we are adding to the basket here not an order
---
.../prog/en/modules/acqui/basket.tmpl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/pr
Get SuppliersWithLateIssues should return a list of suppliers
If you have subscriptions with no supplier it also returned a
invalid supplier with a null id and null name.
This patch ignores the non-supplier supplier
---
C4/Serials.pm |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
di
Previous patch still used old variable name to get count causing
incorrect value to be returned
---
serials/claims.pl |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/serials/claims.pl b/serials/claims.pl
index d6a7ce7..8ff672f 100755
--- a/serials/claims.pl
+++ b/serials
Let templating system do what its designed for
pass an array ref with the suppliers
---
.../prog/en/modules/serials/claims.tmpl|7 -
serials/claims.pl | 30 ---
2 files changed, 19 insertions(+), 18 deletions(-)
diff --git a/k
Fix obvious warning generators
use of string comparison on numeric values
use of capture variables without testing comparison
reuse of variable names in same lexical scope
Tidy some layout issues
remove commented out code
remove unused variables
remove tabs from mixed space tab layouts
rewri
Serials receiving thinks undef is a valid value for indicators
Reset to space space if that received
---
C4/Biblio.pm | 26 ++
1 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index cf48c91..31333b0 100644
--- a/C4/Biblio.pm
+++
Required CPAN module was missing from deoendency list
---
Makefile.PL |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile.PL b/Makefile.PL
index aeeba7f..ae93b7f 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -537,6 +537,7 @@ WriteMakefile(
NO_META
Field is varchar(10) allow all characters to be used
---
.../prog/en/modules/admin/aqbookfund.tmpl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbookfund.tmpl
b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqboo
The return from Mail::Sendmail should always be checked
This is not a solution to problems with claims etc but at least
we should have some minimal debugging if it does nothing
---
C4/Letters.pm |8
C4/Suggestions.pm |3 ++-
2 files changed, 6 insertions(+), 5 deletions(-)
di
Script was supplying an extra empty record to the template
Changed loop to remove the extra variable that was tempting
us into the error.
Removed the element highlight as the template didn't use (or need) it
---
acqui/neworderbiblio.pl | 17 -
1 files changed, 8 insertions(+), 9
Dont display unpopulated field
---
.../prog/en/modules/acqui/neworderempty.tmpl |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl
b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl
index
The aqbasket invoice number is not the one populated on receipt
as the order line invoice number is the field used elsewhere
suppress the unpopulated field from the basket display
---
.../prog/en/modules/acqui/basket.tmpl |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
dif
Allows searching by purchase order number in acq screens
Add PO Number to histsearch results display for consistency
This feature sponsored by UN-FAO
---
C4/Acquisition.pm | 29 +++
acqui/posearch.pl | 56 ++
..
Removed some old code from basket display
Added use warnings to basket.pl
Suppress some warnings generated in basket.pl
---
C4/Acquisition.pm | 11 +---
acqui/basket.pl| 53 ++--
.../prog/en/modules/acqui/bask
Removed some useless counts from serials-edit / Serials interfaces
Removed old commented out code. Unrequired variables
Reformatted code so that improving logic can be done
more easily
---
C4/Serials.pm | 15 +--
serials/serials-edit.pl | 442 +++---
Moved generation of dropdown to template from script
Removed the unnecessary count variable returned by
C4::Serials::GetLateIssues
C4::Serials::GetLateMissingIssues
---
C4/Serials.pm | 37 +++-
.../prog/en/modules/serials/claims.tmpl
Remove dead code
Clarify the loop assigning dates
Remove the cause of undef warnings in the log
---
serials/routing.pl | 44
1 files changed, 16 insertions(+), 28 deletions(-)
diff --git a/serials/routing.pl b/serials/routing.pl
index d49d450..9e969a
y aid maintainability.
The can also be found in the fao-patches branch of
git://github.com/colinsc/koha.git
Colin Campbell (3):
Remove unused or unnecessary variables from claims processing
Cleanup date handling in routing.pl
Basic refactoring of serials-edit.pl
C4/Seria
If an invalid item barcode is passed to checkin
the sip2 connection dies. This is because although
no item object is created its mehods are called in Checkin
To maintain the connection properly catch the condition
and return the correct response to the unit
(should also fix Bug #3696 )
---
C4/SIP/
While the comment correctly notes that the order of variable length
fields is not fixed some units expect mandatory fields to
follow the sequence in the protocol definition and fail
parsing otherwise. Moved institution id to its expected
place in the patron information response.
Indented the first
When editing items the user library rather than the
existing value was being set as the default value in
branch fields of the item
---
cataloguing/additem.pl |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
index e25bb44..4
Although the due date of an on loan item was being retrieved
the appropriate field in the Item object was not set
causing the due date not to be returned in the item
information response
---
C4/SIP/ILS/Item.pm |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/C4/SIP/ILS/Item
As subsequent operations don't get what they expect
all manner of nastiness ensues
---
serials/serials-edit.pl |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl
index 9994e44..86e594e 100755
--- a/serials/serials-edit.pl
+
Also cleaned the interface to the claims related functions
in Serials so they do not return and extra count variable
moved generation of dropdown to template instead of inline code
---
C4/Serials.pm | 37 +++-
.../prog/en/modules/serials/claim
Fixed obvious warnings generators in scripts
with mismatched comparisons or undefined variables
removed temporary variable selected while ensuring the
comparison it represented was between two defined variables
---
C4/AuthoritiesMarc.pm|2 +-
authorities/auth_finder.pl
Fix a couple of comparisons generating warnings
---
admin/marctagstructure.pl |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/admin/marctagstructure.pl b/admin/marctagstructure.pl
index acd8cd7..a9ae892 100755
--- a/admin/marctagstructure.pl
+++ b/admin/marctagstructur
Fix code generating warnings with warnings enabled
---
admin/koha2marclinks.pl | 24 +++-
1 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/admin/koha2marclinks.pl b/admin/koha2marclinks.pl
index e65e1e5..8e0e105 100755
--- a/admin/koha2marclinks.pl
+++ b/admin
Removes the redundant link from the label accession date to orderreceive.pl
accessing the link invariably generates an error
it is also not clear what anyone following the link would expect
to access if it were working
---
.../prog/en/modules/catalogue/moredetail.tmpl |3 +--
1 files chan
Previously could not add or update subfields in MARC Authority
Subfield Structure if no Librarian Text supplied
Requirement removed
---
admin/auth_subfields_structure.pl |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/admin/auth_subfields_structure.pl
b/admin/auth_subfi
Item is a hash reference. We need to specify the field in
the hash to fill the data field not the hash itself.
Where no barcode field is present but we have an itemnumber
retrieve the item details to provide the barcode in
the hash to fill the data field not the hash itself.
---
C4/SIP/Sip/MsgType
---
koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl
b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl
index 3a64ef9..e1fb45c 100644
--- a/koha-tmpl/intranet-tmpl/prog/
the device checks-in and routes holds
and transits as if a normal checkin and one where it checks in the book
but needs a second manual checkin before placing the book on the
hold-shelf (much as if the pickup location was another branch).
Comments and suggestions welcome.
C.
--
Colin Campbel
Set $op to an empty string if no value passed
otherwise the error-log fills with warnings on comparison
---
serials/serials-collection.pl |3 +--
serials/serials-recieve.pl |2 +-
serials/statecollection.pl |2 +-
serials/subscription-bib-search.pl |2 +-
seria
Hold status was unchanged when on-hold items were returned
via the SIP2 interface.
---
C4/SIP/ILS/Transaction/Checkin.pm | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/C4/SIP/ILS/Transaction/Checkin.pm
b/C4/SIP/ILS/Transaction/Checkin.pm
index d3a4700..23d778
---
reserve/modrequest.pl | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/reserve/modrequest.pl b/reserve/modrequest.pl
index 8b7d8ee..f47e112 100755
--- a/reserve/modrequest.pl
+++ b/reserve/modrequest.pl
@@ -70,11 +70,12 @@ else {
}
}
my $from=$query->pa
Pull the code into its own subr so that the dangers of
inaccurate copy & paste are avoided in future
---
C4/Biblio.pm | 27 +++
1 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index cdb119f..b851bc0 100644
--- a/C4/Biblio.pm
+++
---
C4/Biblio.pm |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index cdb119f..96e86a7 100644
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -1709,8 +1709,8 @@ sub TransformHtmlToXml {
else {
my $i
remove unnecessary calls to finish
let DBI return an array instead of looping to create one
make some SQL oneliners more succinct
---
C4/Bookfund.pm | 43 ---
1 files changed, 8 insertions(+), 35 deletions(-)
diff --git a/C4/Bookfund.pm b/C4/Bookfund.pm
i
Remove some superfluous variables
Simplify some loops over lists
Fix generated warnings
Strip whitespace from line endings
---
serials/acqui-search-result.pl | 45 ++-
serials/acqui-search.pl| 28 +++---
serials/checkexpiration.pl
Behave consistently with other patron_ids as many sip clients
use this in a subsequent patron information or patron status request
---
C4/SIP/ILS/Item.pm| 13 +
C4/SIP/Sip/MsgType.pm |2 +-
2 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/C4/SIP/ILS/Item.pm b/C
---
tools/overduerules.pl | 35 ---
1 files changed, 16 insertions(+), 19 deletions(-)
diff --git a/tools/overduerules.pl b/tools/overduerules.pl
index ec50ff8..e14d1d8 100755
--- a/tools/overduerules.pl
+++ b/tools/overduerules.pl
@@ -18,12 +18,13 @@
# Suite 33
date_due'} } @$issues if
> ($issues);
>
Would it not be preferable to declare @issue_list outside of the
conditional?
C.
--
Colin Campbell
Software Engineer, PTFS Europe Limited
Content Management and Library Solutions
+44 (0) 208 366 1295 (phone)
+44 (0) 7759 633626 (mobile)
col
Numbers in perl with leading zeros are interpreted in octal
Ensure that comparisons are done using string operators
or where appropriate use the MARC::Field method
---
C4/Record.pm |2 +-
cataloguing/addbiblio.pl |2 +-
misc/batchCompareMARCvsFramewo
1 - 100 of 126 matches
Mail list logo
