Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise

2016-01-04 Thread R.Harish Navnit
> On Dec. 30, 2015, 5:25 p.m., Pali Rohár wrote: > > protocols/groupwise/ui/gwprivacydialog.cpp, line 160 > > > > > > I'm not sure this code is correct. You are iterating over indexes of > > allowList in for

Re: Review Request 124227: Remove Q3ListViews from autoreplace

2016-01-04 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/ --- (Updated Jan. 4, 2016, 5:08 p.m.) Review request for Kopete, Laurent

Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise

2016-01-04 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/ --- (Updated Jan. 4, 2016, 5:50 p.m.) Review request for Kopete and Laurent

Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise

2016-01-04 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/#review90582 --- protocols/groupwise/ui/gwprivacydialog.cpp (line 161)

Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise

2016-01-04 Thread Pali Rohár
> On jan. 4, 2016, 1:22 popoludní, R.Harish Navnit wrote: > > protocols/groupwise/ui/gwprivacydialog.cpp, line 278 > > > > > > There's an obvious typo here, which I've fixed locally, but for some > > reason

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2016-01-04 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124721/#review90585 --- CMakeLists.txt (line 136)