Re: Kopete - GSoC 2015

2015-06-19 Thread R.Harish Navnit
On Wed, Jun 17, 2015 at 4:20 AM, Pali Rohár pali.ro...@gmail.com wrote: if some commits are ready for merging, please make sure that commit message contains relevant REVIEW: num or BUG: num tags and put commits into your new branch in your repository (rebased on top of kopete master). I'm

Re: GSoC History plugin

2015-06-19 Thread Joshua Joseph
On Thu, Jun 18, 2015 at 10:07 PM, Pali Rohár pali.ro...@gmail.com wrote: I get it now. We will have to store the contactId() also. I will need to get good column names to avoid confusion with the foreign key columns. See my yesterday email where I proposed to store pluginId() as

Re: GSoC History plugin

2015-06-19 Thread Pali Rohár
On Friday 19 June 2015 09:59:17 Joshua Joseph wrote: On Thu, Jun 18, 2015 at 10:07 PM, Pali Rohár pali.ro...@gmail.com wrote: I get it now. We will have to store the contactId() also. I will need to get good column names to avoid confusion with the foreign key columns.

Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin

2015-06-19 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/ --- (Updated June 19, 2015, 6:32 p.m.) Review request for Kopete, Laurent

Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin

2015-06-19 Thread R.Harish Navnit
On June 15, 2015, 10:25 a.m., Laurent Montel wrote: plugins/texteffect/texteffectprefs.ui, line 85 https://git.reviewboard.kde.org/r/124094/diff/1/?file=379855#file379855line85 Why added indent ? meh, unintentional. My(editor's ?) bad :\ On June 15, 2015, 10:25 a.m., Laurent

Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin

2015-06-19 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/ --- (Updated June 19, 2015, 7:06 p.m.) Review request for Kopete, Laurent

Re: GSoC History plugin

2015-06-19 Thread Joshua Joseph
On Fri, Jun 19, 2015 at 10:33 AM, Pali Rohár pali.ro...@gmail.com wrote: On Friday 19 June 2015 09:59:17 Joshua Joseph wrote: On Thu, Jun 18, 2015 at 10:07 PM, Pali Rohár pali.ro...@gmail.com wrote: I get it now. We will have to store the contactId() also. I will need to get

Re: GSoC History plugin

2015-06-19 Thread Pali Rohár
On Friday 19 June 2015 16:54:57 Joshua Joseph wrote: On Fri, Jun 19, 2015 at 10:33 AM, Pali Rohár pali.ro...@gmail.com wrote: On Friday 19 June 2015 09:59:17 Joshua Joseph wrote: On Thu, Jun 18, 2015 at 10:07 PM, Pali Rohár pali.ro...@gmail.com wrote: I get it now.

Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin

2015-06-19 Thread R.Harish Navnit
On June 15, 2015, 10:25 a.m., Laurent Montel wrote: plugins/texteffect/texteffectpreferences.cpp, line 171 https://git.reviewboard.kde.org/r/124094/diff/1/?file=379854#file379854line171 this list is single selection or multiselection ? R.Harish Navnit wrote: I *think* it's

Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin

2015-06-19 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/ --- (Updated June 20, 2015, 12:43 a.m.) Review request for Kopete, Laurent