Re: Review Request 123489: Remove unnecessary k3listview includes
On jún 23, 2015, 9:41 dopoludnia, R.Harish Navnit wrote: This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? Laurent Montel wrote: As Pali Rohar told you in comment Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). you forgot to add REVIEW: If you have some commits ready for merging into kopete master, please create new branch in your clonned repository and add that commits into that branch. Then ping back and we can merge your branch into kopete master. Until now you did not send any information what you want to merge... - Pali --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- On máj 9, 2015, 8:58 dopoludnia, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated máj 9, 2015, 8:58 dopoludnia) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
On June 23, 2015, 1:11 p.m., R.Harish Navnit wrote: This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? Laurent Montel wrote: As Pali Rohar told you in comment Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). you forgot to add REVIEW: Pali Rohár wrote: If you have some commits ready for merging into kopete master, please create new branch in your clonned repository and add that commits into that branch. Then ping back and we can merge your branch into kopete master. Until now you did not send any information what you want to merge... I was thinking of creating a new branch and adding commits as soon as kde3 dependencies are completely removed. Just the kopete/protocols remain now in this respect, I thought it would be better to wait. No ? - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- On May 9, 2015, 12:28 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated May 9, 2015, 12:28 p.m.) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
On jún 23, 2015, 9:41 dopoludnia, R.Harish Navnit wrote: This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? Laurent Montel wrote: As Pali Rohar told you in comment Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). you forgot to add REVIEW: Pali Rohár wrote: If you have some commits ready for merging into kopete master, please create new branch in your clonned repository and add that commits into that branch. Then ping back and we can merge your branch into kopete master. Until now you did not send any information what you want to merge... R.Harish Navnit wrote: I was thinking of creating a new branch and adding commits as soon as kde3 dependencies are completely removed. Just the kopete/protocols remain now in this respect, I thought it would be better to wait. No ? If you do not tell me location of git repository and branch (which contains your commits) I cannot merge them into kopete -- because I do not know what to merge. This one review request is OK and can be merged into kopete master. - Pali --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- On máj 9, 2015, 8:58 dopoludnia, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated máj 9, 2015, 8:58 dopoludnia) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Kopete - GSoC 2015 - mid term evaluation
On Tue, Jun 23, 2015 at 1:11 PM, Pali Rohár pali.ro...@gmail.com wrote: It is basically to deliver what have you done and something which you can show to other people... With that I means to prepare code in your git branch to some state which can be compiled and maybe also easily reused/merged (if possible). Okay, I see. In your case it would be e.g. kopete branch which compiles fine and (some finished/ported plugins) run without qt3/kde3 dependences... In the end it would be full Kopete on KF5 desktop. Yes, with the current progress, Kopete should compile free of Qt3 dependencies. That's the target of course :) Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com/ ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Kopete - GSoC 2015 - mid term evaluation
On Tuesday 23 June 2015 09:31:16 R.Harish Navnit wrote: Hey Pali, On Mon, Jun 22, 2015 at 12:56 PM, Pali Rohár pali.ro...@gmail.com wrote: By June 26 please prepare or update your git repositories so your code can be evaluated. Try to prepare code to state which could be presented by you to audience (some demo)... I'm just curious to know who would the audience comprise of, just members of the KDE community I'm guessing ? It is basically to deliver what have you done and something which you can show to other people... With that I means to prepare code in your git branch to some state which can be compiled and maybe also easily reused/merged (if possible). Also, in my case, the porting project, the demo wouldn't really look much different from the current version of Kopete. Hope that is fine :) In your case it would be e.g. kopete branch which compiles fine and (some finished/ported plugins) run without qt3/kde3 dependences... In the end it would be full Kopete on KF5 desktop. Also do not forget to fill your own evaluation form in google melange system! It is required by google and better to do it ASAP and not to wait for deadline. Sure, noted. Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com/ -- Pali Rohár pali.ro...@gmail.com ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? - R.Harish Navnit On May 9, 2015, 12:28 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated May 9, 2015, 12:28 p.m.) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
On juin 23, 2015, 7:41 matin, R.Harish Navnit wrote: This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? As Pali Rohar told you in comment Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). you forgot to add REVIEW: - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- On mai 9, 2015, 6:58 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated mai 9, 2015, 6:58 matin) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
