Re: Review Request 123162: Replace outdated URL in add account settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/#review79618 --- I'm against this change. Rather remove that URL from text box. - Pali Rohár On mar. 28, 2015, 3:55 popoludní, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/ --- (Updated mar. 28, 2015, 3:55 popoludní) Review request for Kopete and Pali Rohár. Repository: kopete Description --- Skype API was shut down sometime before. Hence the currently provided URL goes to an unavailable webpage. This patch replaces it a URL that works. Diffs - protocols/skype/ui/skypeeditaccountbase.ui ff41acc764e08410f7c4ac08402dcbd2e11ea858 Diff: https://git.reviewboard.kde.org/r/123162/diff/ Testing --- Rebuilt from source, testing done. Works fine. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123162: Replace outdated URL in add account settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/#review79617 --- Ship it! If url works. Ship it :) - Laurent Montel On mars 28, 2015, 2:55 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/ --- (Updated mars 28, 2015, 2:55 après-midi) Review request for Kopete and Pali Rohár. Repository: kopete Description --- Skype API was shut down sometime before. Hence the currently provided URL goes to an unavailable webpage. This patch replaces it a URL that works. Diffs - protocols/skype/ui/skypeeditaccountbase.ui ff41acc764e08410f7c4ac08402dcbd2e11ea858 Diff: https://git.reviewboard.kde.org/r/123162/diff/ Testing --- Rebuilt from source, testing done. Works fine. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
