Review Request 124345: Use treeWidgets instead of listviews in libkopete accountSelector
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace K3ListViews/Q3ListViews with QTreeWidget classes. Diffs - libkopete/ui/accountselector.h ff42a881f9151fe3b4db175577807fa191351467 libkopete/ui/accountselector.cpp e6d5ee5f788cbc7606be25d8a9e3aff9b4866468 Diff: https://git.reviewboard.kde.org/r/124345/diff/ Testing --- Build Succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Review Request 124227: Remove Q3ListViews from autoreplace
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Summary (updated) - Remove Q3ListViews from autoreplace Repository: kopete Description (updated) --- Replace the Q3ListView classes with QTreeWidgets. Diffs (updated) - plugins/autoreplace/autoreplacepreferences.cpp dab6645f0552e6066ae8da09a35654d7dbaca8db plugins/autoreplace/autoreplaceprefs.ui 034013d41f90dd3d2e4c1e2dc94a0fbded8a7782 Diff: https://git.reviewboard.kde.org/r/124227/diff/ Testing (updated) --- Build Succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124349: Remove kde3 dependencies from gadu protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124349/#review82519 --- protocols/gadu/gadueditcontact.cpp (line 110) https://git.reviewboard.kde.org/r/124349/#comment56923 So item which is not selectable and disable ? protocols/gadu/gadueditcontact.cpp (line 136) https://git.reviewboard.kde.org/r/124349/#comment56924 As usual you didn't read doc protocols/gadu/gadupubdir.cpp (line 80) https://git.reviewboard.kde.org/r/124349/#comment56925 Read doc it's a QStackedWidget... protocols/gadu/gadupubdir.cpp (line 120) https://git.reviewboard.kde.org/r/124349/#comment56926 ? - Laurent Montel On juil. 14, 2015, 6:07 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124349/ --- (Updated juil. 14, 2015, 6:07 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Q3WidgetStack, Q3ButtonGroup, Q3ListViews and other classes removed. Diffs - protocols/gadu/CMakeLists.txt b6da7736c94a1174b507aac3055b88c76da6aec2 protocols/gadu/gaduaddcontactpage.cpp e55bd301b2bf4a6205c88b02c798b0094ceced5f protocols/gadu/gadueditaccount.cpp 20635e38b1bb4a99d220830747cc48731c7ccc63 protocols/gadu/gadueditcontact.h 6b93fa3d84f7e54ec7ca3269f423e3b29e117449 protocols/gadu/gadueditcontact.cpp 7475a4954173da0e9aac657cf90f4a3d2986bb4a protocols/gadu/gadupubdir.cpp c264519c44aa273039f0acb664e1a5df90b1640f protocols/gadu/gadusession.h 401a8eb16acf8e3263d20a36cd14b7eeb393783e protocols/gadu/ui/gaduadd.ui fdbe4a63fe1336095479b8f690a039e1652e7195 protocols/gadu/ui/gadusearch.ui 3011347434e10205a390adf872a6a80077afb6b2 Diff: https://git.reviewboard.kde.org/r/124349/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124345: Use treeWidgets instead of listviews in libkopete accountSelector
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/#review82518 --- libkopete/ui/accountselector.cpp (line 46) https://git.reviewboard.kde.org/r/124345/#comment56921 Why it's not ported ? libkopete/ui/accountselector.cpp (line 109) https://git.reviewboard.kde.org/r/124345/#comment56922 Please reread doc - Laurent Montel On juil. 14, 2015, 7:20 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/ --- (Updated juil. 14, 2015, 7:20 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace K3ListViews/Q3ListViews with QTreeWidget classes. Diffs - libkopete/ui/accountselector.h ff42a881f9151fe3b4db175577807fa191351467 libkopete/ui/accountselector.cpp e6d5ee5f788cbc7606be25d8a9e3aff9b4866468 Diff: https://git.reviewboard.kde.org/r/124345/diff/ Testing --- Build Succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82517 --- When I read doc I see: * @deprecated Use QLabel. (QLabel::setOpenExternalLinks(true) for labels with hyperlinks; * QLabel::setTextInteractionFlags(Qt::TextSelectableByMouse|Qt::TextSelectableByKeyboard) for labels whose text * should be selectable by user.) But you replace just by QLabel it's normal ? - Laurent Montel On juil. 14, 2015, 7:04 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated juil. 14, 2015, 7:04 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124227: Remove Q3ListViews from autoreplace
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/#review82520 --- plugins/autoreplace/autoreplacepreferences.cpp (line 49) https://git.reviewboard.kde.org/r/124227/#comment56927 Why ? Why not add directly setColumCount(2) ? plugins/autoreplace/autoreplacepreferences.cpp (line 214) https://git.reviewboard.kde.org/r/124227/#comment56928 indent - Laurent Montel On juil. 14, 2015, 6:28 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/ --- (Updated juil. 14, 2015, 6:28 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the Q3ListView classes with QTreeWidgets. Diffs - plugins/autoreplace/autoreplacepreferences.cpp dab6645f0552e6066ae8da09a35654d7dbaca8db plugins/autoreplace/autoreplaceprefs.ui 034013d41f90dd3d2e4c1e2dc94a0fbded8a7782 Diff: https://git.reviewboard.kde.org/r/124227/diff/ Testing --- Build Succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Review Request 124349: Remove kde3 dependencies from gadu protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124349/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Q3WidgetStack, Q3ButtonGroup, Q3ListViews and other classes removed. Diffs - protocols/gadu/CMakeLists.txt b6da7736c94a1174b507aac3055b88c76da6aec2 protocols/gadu/gaduaddcontactpage.cpp e55bd301b2bf4a6205c88b02c798b0094ceced5f protocols/gadu/gadueditaccount.cpp 20635e38b1bb4a99d220830747cc48731c7ccc63 protocols/gadu/gadueditcontact.h 6b93fa3d84f7e54ec7ca3269f423e3b29e117449 protocols/gadu/gadueditcontact.cpp 7475a4954173da0e9aac657cf90f4a3d2986bb4a protocols/gadu/gadupubdir.cpp c264519c44aa273039f0acb664e1a5df90b1640f protocols/gadu/gadusession.h 401a8eb16acf8e3263d20a36cd14b7eeb393783e protocols/gadu/ui/gaduadd.ui fdbe4a63fe1336095479b8f690a039e1652e7195 protocols/gadu/ui/gadusearch.ui 3011347434e10205a390adf872a6a80077afb6b2 Diff: https://git.reviewboard.kde.org/r/124349/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
