Review Request 124721: Adapt CMakeLists.txt to kf5

2015-08-12 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124721/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository:

Re: Review Request 124643: First review request for the history plugin

2015-08-12 Thread Roman Nazarenko
On Авг. 6, 2015, 4:37 п.п., Pali Rohár wrote: plugins/history/databaseconstants.cpp, line 139 https://git.reviewboard.kde.org/r/124643/diff/1/?file=390726#file390726line139 *All* I mean really *all* SQL statements mustn't contains any external data, like return value of function