Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130155/#review103334
---




tests/libkopete/kopetepropertycontainertest.cpp (line 61)


remove space before/after ->



tests/libkopete/kopetestatusgrouptest.cpp (line 37)


remove space before/after ...



tests/libkopete/kopetestatustest.cpp (line 46)


now you can test 2 signal etc.

Perhaps emit signal when same message etc.

you need to create more autotests which is more complex.

Regards


- Laurent Montel


On June 17, 2017, 8:21 p.m., Vijay Krishnavanshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130155/
> ---
> 
> (Updated June 17, 2017, 8:21 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> These autotests cover following classes - 
> - Kopete::PropertyTemplate
> - Kopete::StatusGroup
> - Kopete::Status::Status
> - Kopete::PropertyContainer
> - Kopete::Property
> 
> 
> Diffs
> -
> 
>   tests/libkopete/CMakeLists.txt 236284b 
>   tests/libkopete/kopetepropertycontainertest.cpp PRE-CREATION 
>   tests/libkopete/kopetepropertytemplatetest.cpp PRE-CREATION 
>   tests/libkopete/kopetepropertytest.cpp PRE-CREATION 
>   tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION 
>   tests/libkopete/kopetestatustest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/130155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vijay Krishnavanshi
> 
>

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

[Vijay Krishnavanshi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130155/
---

(Updated June 17, 2017, 8:21 p.m.)


Review request for Kopete, Laurent Montel and Pali Rohár.


Changes
---

Fixed issues


Repository: kopete


Description
---

These autotests cover following classes - 
- Kopete::PropertyTemplate
- Kopete::StatusGroup
- Kopete::Status::Status
- Kopete::PropertyContainer
- Kopete::Property


Diffs (updated)
-

  tests/libkopete/CMakeLists.txt 236284b 
  tests/libkopete/kopetepropertycontainertest.cpp PRE-CREATION 
  tests/libkopete/kopetepropertytemplatetest.cpp PRE-CREATION 
  tests/libkopete/kopetepropertytest.cpp PRE-CREATION 
  tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION 
  tests/libkopete/kopetestatustest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/130155/diff/


Testing
---


Thanks,

Vijay Krishnavanshi

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130155/#review103332
---




tests/libkopete/kopetepropertytemplatetest.cpp (line 84)


use different string it's better



tests/libkopete/kopetestatusgrouptest.cpp (line 36)


same string here. Cache value

Remove space before after ->

use QStringLiteral



tests/libkopete/kopetestatustest.cpp (line 43)


remove space before/after ->

use QStringLiteral etc.


- Laurent Montel


On June 17, 2017, 9:03 a.m., Vijay Krishnavanshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130155/
> ---
> 
> (Updated June 17, 2017, 9:03 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> These autotests cover following classes - 
> - Kopete::PropertyTemplate
> - Kopete::StatusGroup
> - Kopete::Status::Status
> - Kopete::PropertyContainer
> - Kopete::Property
> 
> 
> Diffs
> -
> 
>   tests/libkopete/CMakeLists.txt 236284b 
>   tests/libkopete/kopetepropertycontainertest.cpp PRE-CREATION 
>   tests/libkopete/kopetepropertytemplatetest.cpp PRE-CREATION 
>   tests/libkopete/kopetepropertytest.cpp PRE-CREATION 
>   tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION 
>   tests/libkopete/kopetestatustest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/130155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vijay Krishnavanshi
> 
>

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

[Vijay Krishnavanshi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130155/
---

(Updated June 17, 2017, 9:03 a.m.)


Review request for Kopete, Laurent Montel and Pali Rohár.


Changes
---

Updated with new commits


Summary (updated)
-

Added autotests for libkopete for classes - kopetestatus, 
kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and 
kopetestatusgroup


Repository: kopete


Description (updated)
---

These autotests cover following classes - 
- Kopete::PropertyTemplate
- Kopete::StatusGroup
- Kopete::Status::Status
- Kopete::PropertyContainer
- Kopete::Property


Diffs (updated)
-

  tests/libkopete/CMakeLists.txt 236284b 
  tests/libkopete/kopetepropertycontainertest.cpp PRE-CREATION 
  tests/libkopete/kopetepropertytemplatetest.cpp PRE-CREATION 
  tests/libkopete/kopetepropertytest.cpp PRE-CREATION 
  tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION 
  tests/libkopete/kopetestatustest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/130155/diff/


Testing
---


Thanks,

Vijay Krishnavanshi