[kopete-devel] KDE/kdenetwork/kopete/protocols/jabber/libiris
SVN commit 926385 by mlaurent:
Fix iterator and pedantic
CCMAIL: kopete-devel@kde.org
A 024_fix_semicolons_and_iterator.patch
M +1 -1 iris/irisnet/appledns/appledns.cpp
M +1 -1 iris/irisnet/corelib/jdnsshared.cpp
M +2 -2 iris/irisnet/corelib/netinterface_unix.cpp
M +2 -2 iris/xmpp/cutestuff/httppoll.cpp
M +1 -1 iris/xmpp/cutestuff/socks.cpp
M +2 -2 iris/xmpp/sasl/digestmd5proplist.cpp
M +3 -3 iris/xmpp/xmpp-core/parser.cpp
M +2 -2 iris/xmpp/xmpp-core/protocol.cpp
M +1 -1 iris/xmpp/xmpp-core/stream.cpp
M +2 -2 iris/xmpp/xmpp-core/xmpp.h
M +1 -1 iris/xmpp/xmpp-im/client.cpp
M +1 -1 iris/xmpp/xmpp-im/filetransfer.cpp
M +3 -3 iris/xmpp/xmpp-im/s5b.cpp
M +4 -4 iris/xmpp/xmpp-im/types.cpp
M +1 -1 iris/xmpp/xmpp-im/xmpp_address.h
M +4 -4 iris/xmpp/xmpp-im/xmpp_tasks.cpp
---
trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/irisnet/appledns/appledns.cpp
#926384:926385
@@ -237,7 +237,7 @@
class AppleProvider : public XMPP::IrisNetProvider
{
Q_OBJECT
- Q_INTERFACES(XMPP::IrisNetProvider);
+ Q_INTERFACES(XMPP::IrisNetProvider)
public:
QDnsSd dns;
QHashint,QDnsSdDelegate* delegateById;
---
trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/irisnet/corelib/jdnsshared.cpp
#926384:926385
@@ -416,7 +416,7 @@
None,// don't muck with anything
FillInAddress, // for A/
FillInPtrOwner6, // for PTR, IPv6
- FillInPtrOwner4, // for PTR, IPv4
+ FillInPtrOwner4 // for PTR, IPv4
};
JDnsShared *q;
---
trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/irisnet/corelib/netinterface_unix.cpp
#926384:926385
@@ -318,7 +318,7 @@
class UnixNet : public NetInterfaceProvider
{
Q_OBJECT
- Q_INTERFACES(XMPP::NetInterfaceProvider);
+ Q_INTERFACES(XMPP::NetInterfaceProvider)
public:
QListInfo info;
QTimer t;
@@ -406,7 +406,7 @@
class UnixNetProvider : public IrisNetProvider
{
Q_OBJECT
- Q_INTERFACES(XMPP::IrisNetProvider);
+ Q_INTERFACES(XMPP::IrisNetProvider)
public:
virtual NetInterfaceProvider *createNetInterfaceProvider()
{
---
trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/cutestuff/httppoll.cpp
#926384:926385
@@ -510,7 +510,7 @@
QString HttpProxyPost::getHeader(const QString var) const
{
- for(QStringList::ConstIterator it = d-headerLines.begin(); it !=
d-headerLines.end(); ++it) {
+ for(QStringList::ConstIterator it = d-headerLines.constBegin(); it !=
d-headerLines.constEnd(); ++it) {
const QString s = *it;
int n = s.indexOf(: );
if(n == -1)
@@ -752,7 +752,7 @@
QString HttpProxyGetStream::getHeader(const QString var) const
{
- for(QStringList::ConstIterator it = d-headerLines.begin(); it !=
d-headerLines.end(); ++it) {
+ for(QStringList::ConstIterator it = d-headerLines.constBegin(); it !=
d-headerLines.constEnd(); ++it) {
const QString s = *it;
int n = s.indexOf(: );
if(n == -1)
---
trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/cutestuff/socks.cpp
#926384:926385
@@ -284,7 +284,7 @@
int at = 0;
quint16 c;
bool ok;
- for(QStringList::ConstIterator it = s6.begin(); it != s6.end();
++it) {
+ for(QStringList::ConstIterator it = s6.constBegin(); it !=
s6.constEnd(); ++it) {
c = (*it).toInt(ok, 16);
a6[at++] = (c 8);
a6[at++] = c 0xff;
---
trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/sasl/digestmd5proplist.cpp
#926384:926385
@@ -34,7 +34,7 @@
QByteArray DIGESTMD5PropList::get(const QByteArray var)
{
- for(ConstIterator it = begin(); it != end(); ++it) {
+ for(ConstIterator it = constBegin(); it != constEnd(); ++it) {
if((*it).var == var)
return (*it).val;
}
@@ -123,7 +123,7 @@
int DIGESTMD5PropList::varCount(const QByteArray var)
{
int n = 0;
- for(ConstIterator it = begin(); it != end(); ++it) {
+ for(ConstIterator it = constBegin(); it != constEnd(); ++it) {
if((*it).var == var)
++n;
}
---
trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-core/parser.cpp
#926384:926385
@@ -603,9 +603,9 @@
QString Parser::Event::nsprefix(const QString s) const
{
- QStringList::ConstIterator it = d-nsnames.begin();
- QStringList::ConstIterator it2 = d-nsvalues.begin();
- for(; it != d-nsnames.end(); ++it) {
+ QStringList::ConstIterator it = d-nsnames.constBegin();
+ QStringList::ConstIterator it2 = d-nsvalues.constBegin();
+
Re: GSoC 2015 - Accepted Kopete projects
Le Friday 01 May 2015 16:41:05 R.Harish Navnit a écrit : Not sure if Laurent is subscribed to this list. Adding him to the discussions. Warm Regards. Thanking You, R.Harish Navnit I am on ML but thanks to add me to CC :) Regards. ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123162: Replace outdated URL in add account settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/#review79617 --- Ship it! If url works. Ship it :) - Laurent Montel On mars 28, 2015, 2:55 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/ --- (Updated mars 28, 2015, 2:55 après-midi) Review request for Kopete and Pali Rohár. Repository: kopete Description --- Skype API was shut down sometime before. Hence the currently provided URL goes to an unavailable webpage. This patch replaces it a URL that works. Diffs - protocols/skype/ui/skypeeditaccountbase.ui ff41acc764e08410f7c4ac08402dcbd2e11ea858 Diff: https://git.reviewboard.kde.org/r/123162/diff/ Testing --- Rebuilt from source, testing done. Works fine. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review81595 --- plugins/texteffect/texteffectpreferences.cpp (line 149) https://git.reviewboard.kde.org/r/124094/#comment55929 better to use ++f plugins/texteffect/texteffectpreferences.cpp (line 151) https://git.reviewboard.kde.org/r/124094/#comment55928 why don't add directly ret.appent(...-item(f)-text()) ? plugins/texteffect/texteffectpreferences.cpp (line 184) https://git.reviewboard.kde.org/r/124094/#comment55930 currentItem no ? single selection plugins/texteffect/texteffectpreferences.cpp (line 187) https://git.reviewboard.kde.org/r/124094/#comment55931 Remove loop currentItem plugins/texteffect/texteffectpreferences.cpp (line 204) https://git.reviewboard.kde.org/r/124094/#comment55932 currentItem ? plugins/texteffect/texteffectpreferences.cpp (line 232) https://git.reviewboard.kde.org/r/124094/#comment55933 fix indent - Laurent Montel On juin 19, 2015, 7:13 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/ --- (Updated juin 19, 2015, 7:13 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the K3ListBox classes with QListWidget. Diffs - plugins/texteffect/texteffectpreferences.cpp 35fac60d419cbac5644a8e143be1fc7c640385a9 plugins/texteffect/texteffectprefs.ui 1b82f3de4b449373a3dedb39b664c0f645f1d02a Diff: https://git.reviewboard.kde.org/r/124094/diff/ Testing --- Build succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124184: Remove Qt3 dependencies from meanwhile protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124184/#review81762 --- protocols/meanwhile/CMakeLists.txt (line 4) https://git.reviewboard.kde.org/r/124184/#comment56071 Why this definition ? - Laurent Montel On juin 26, 2015, 4:28 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124184/ --- (Updated juin 26, 2015, 4:28 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the Q3GroupBox widgets with QGroupBox instead. Diffs - protocols/meanwhile/CMakeLists.txt 5b3e7d468bda985add7a83c1b3f9a9939c8ef81f protocols/meanwhile/ui/meanwhileeditaccount.ui 5e61aed483fb2501a26aa2452247e0a61782ed8d Diff: https://git.reviewboard.kde.org/r/124184/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81764 --- protocols/gadu/ui/gadusearch.ui (line 441) https://git.reviewboard.kde.org/r/124173/#comment56075 Remove it protocols/groupwise/ui/gwchatsearch.ui (line 84) https://git.reviewboard.kde.org/r/124173/#comment56076 Please don't use find/replace, remove when not necessary protocols/groupwise/ui/gwchatsearch.ui (line 96) https://git.reviewboard.kde.org/r/124173/#comment56077 remove it protocols/groupwise/ui/gwcontactprops.ui (line 213) https://git.reviewboard.kde.org/r/124173/#comment56078 Remove it protocols/groupwise/ui/gwcustomstatus.ui (line 77) https://git.reviewboard.kde.org/r/124173/#comment56079 Remove it... - Laurent Montel On juin 25, 2015, 12:47 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated juin 25, 2015, 12:47 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removing the K3ListViews, Q3ListViews and Q3ListViewItem classes from the groupwise protocol. Diffs - protocols/gadu/ui/gadusearch.ui 8b1ecc1898f74f49f3efcf2346241545ff876de1 protocols/groupwise/ui/gwaddcontactpage.cpp be2ead4e8fd4b521cf11b70fe81afad8f27a9f01 protocols/groupwise/ui/gwchatpropsdialog.cpp 7361241c6f6380338774315332530daa6fb3705f protocols/groupwise/ui/gwchatsearch.ui f7e95071f8b9cd8b2c3815306b4fed4ac2afeec8 protocols/groupwise/ui/gwchatsearchdialog.cpp ae23311cafb8c318f2da671e0809bf0a57f4b373 protocols/groupwise/ui/gwcontactproperties.h b0a68812dffbe618205c4528586d7799d71e9131 protocols/groupwise/ui/gwcontactprops.ui 19425b934a018f614642d3d48599a1d532ee5def protocols/groupwise/ui/gwcustomstatus.ui bbd7e5052975810963bde1f84c3efdc9a7074769 protocols/groupwise/ui/gwprivacydialog.cpp 95328c738a3d21556a598408cfadd4a8bbeda227 Diff: https://git.reviewboard.kde.org/r/124173/diff/ Testing --- Build succeeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/#review81763 --- protocols/groupwise/ui/gwchatprops.ui (line 380) https://git.reviewboard.kde.org/r/124181/#comment56074 Are you sure that all signal are ok now in cpp file ? protocols/groupwise/ui/gwchatprops.ui (line 436) https://git.reviewboard.kde.org/r/124181/#comment56072 Remove it. protocols/groupwise/ui/gwchatprops.ui (line 460) https://git.reviewboard.kde.org/r/124181/#comment56073 it's not local include. Remove it. - Laurent Montel On juin 25, 2015, 6:12 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/ --- (Updated juin 25, 2015, 6:12 après-midi) Review request for Kopete and Laurent Montel. Repository: kopete Description --- Remove the K3ListBox and needless includes from groupwise. Diffs - protocols/groupwise/gwconnector.cpp d1330ad824dc7c731dc37a95b8735273c4890a46 protocols/groupwise/ui/gwchatprops.ui f93fb5db8269323d5b28bd60181bbe3a209f80e3 Diff: https://git.reviewboard.kde.org/r/124181/diff/ Testing --- Build succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
On juin 23, 2015, 7:41 matin, R.Harish Navnit wrote: This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? As Pali Rohar told you in comment Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). you forgot to add REVIEW: - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- On mai 9, 2015, 6:58 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated mai 9, 2015, 6:58 matin) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81782 --- protocols/groupwise/ui/gwcustomstatus.ui (line 77) https://git.reviewboard.kde.org/r/124173/#comment56091 Remove it too. QTreeView is a native widget protocols/groupwise/ui/gwcustomstatus.ui (line 83) https://git.reviewboard.kde.org/r/124173/#comment56092 Not necessary - Laurent Montel On juin 26, 2015, 1:59 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated juin 26, 2015, 1:59 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removing the K3ListViews, Q3ListViews and Q3ListViewItem classes from the groupwise protocol. Diffs - protocols/gadu/ui/gadusearch.ui 8b1ecc1898f74f49f3efcf2346241545ff876de1 protocols/groupwise/ui/gwaddcontactpage.cpp be2ead4e8fd4b521cf11b70fe81afad8f27a9f01 protocols/groupwise/ui/gwchatpropsdialog.cpp 7361241c6f6380338774315332530daa6fb3705f protocols/groupwise/ui/gwchatsearch.ui f7e95071f8b9cd8b2c3815306b4fed4ac2afeec8 protocols/groupwise/ui/gwchatsearchdialog.cpp ae23311cafb8c318f2da671e0809bf0a57f4b373 protocols/groupwise/ui/gwcontactproperties.h b0a68812dffbe618205c4528586d7799d71e9131 protocols/groupwise/ui/gwcontactprops.ui 19425b934a018f614642d3d48599a1d532ee5def protocols/groupwise/ui/gwcustomstatus.ui bbd7e5052975810963bde1f84c3efdc9a7074769 protocols/groupwise/ui/gwprivacydialog.cpp 95328c738a3d21556a598408cfadd4a8bbeda227 Diff: https://git.reviewboard.kde.org/r/124173/diff/ Testing --- Build succeeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review81473 --- plugins/texteffect/texteffectpreferences.cpp (line 101) https://git.reviewboard.kde.org/r/124094/#comment55827 addItems ? plugins/texteffect/texteffectpreferences.cpp (line 151) https://git.reviewboard.kde.org/r/124094/#comment55828 Wrong. CurrentItem ? it's always the same = you will store always the same item. plugins/texteffect/texteffectpreferences.cpp (line 171) https://git.reviewboard.kde.org/r/124094/#comment55829 this list is single selection or multiselection ? plugins/texteffect/texteffectpreferences.cpp (line 235) https://git.reviewboard.kde.org/r/124094/#comment55826 addItems ? plugins/texteffect/texteffectprefs.ui (line 85) https://git.reviewboard.kde.org/r/124094/#comment55825 Why added indent ? plugins/texteffect/texteffectprefs.ui (line 244) https://git.reviewboard.kde.org/r/124094/#comment55824 Please remove this part. It's not a customwidget now that it use a QListWidget - Laurent Montel On juin 14, 2015, 2:08 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/ --- (Updated juin 14, 2015, 2:08 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the K3ListBox classes with QListWidget. Diffs - plugins/texteffect/texteffectpreferences.cpp 35fac60d419cbac5644a8e143be1fc7c640385a9 plugins/texteffect/texteffectprefs.ui 1b82f3de4b449373a3dedb39b664c0f645f1d02a Diff: https://git.reviewboard.kde.org/r/124094/diff/ Testing --- Build succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81975 --- Ship it! Seems good now. Ship it - Laurent Montel On juin 29, 2015, 9:04 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated juin 29, 2015, 9:04 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removing the K3ListViews, Q3ListViews and Q3ListViewItem classes from the groupwise protocol. Diffs - protocols/groupwise/ui/gwprivacydialog.cpp 95328c738a3d21556a598408cfadd4a8bbeda227 protocols/groupwise/ui/gwcustomstatus.ui bbd7e5052975810963bde1f84c3efdc9a7074769 protocols/groupwise/ui/gwcontactprops.ui 19425b934a018f614642d3d48599a1d532ee5def protocols/groupwise/ui/gwaddcontactpage.cpp be2ead4e8fd4b521cf11b70fe81afad8f27a9f01 protocols/groupwise/ui/gwcontactproperties.h b0a68812dffbe618205c4528586d7799d71e9131 protocols/groupwise/ui/gwchatsearchdialog.cpp ae23311cafb8c318f2da671e0809bf0a57f4b373 protocols/groupwise/ui/gwchatsearch.ui f7e95071f8b9cd8b2c3815306b4fed4ac2afeec8 protocols/groupwise/ui/gwchatpropsdialog.cpp 7361241c6f6380338774315332530daa6fb3705f protocols/gadu/ui/gadusearch.ui 8b1ecc1898f74f49f3efcf2346241545ff876de1 Diff: https://git.reviewboard.kde.org/r/124173/diff/ Testing --- Build succeeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124184: Remove Qt3 dependencies from meanwhile protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124184/#review81823 --- protocols/meanwhile/ui/meanwhileeditaccount.ui (line 346) https://git.reviewboard.kde.org/r/124184/#comment56161 Remove it... Please read diff before to upload it Thanks - Laurent Montel On juin 27, 2015, 5:20 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124184/ --- (Updated juin 27, 2015, 5:20 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the Q3GroupBox widgets with QGroupBox instead. Diffs - protocols/meanwhile/CMakeLists.txt 5b3e7d468bda985add7a83c1b3f9a9939c8ef81f protocols/meanwhile/ui/meanwhileeditaccount.ui 5e61aed483fb2501a26aa2452247e0a61782ed8d Diff: https://git.reviewboard.kde.org/r/124184/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124800: Remove Qt3Support library from urlpicpreview plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124800/#review83978 --- Ship it! Seems good. Ship it - Laurent Montel On août 18, 2015, 7:44 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124800/ --- (Updated août 18, 2015, 7:44 matin) Review request for Kopete and Laurent Montel. Repository: kopete Description --- Modify CMakeLists.txt and use QGroupBox classes instead Diffs - plugins/urlpicpreview/CMakeLists.txt 9fa72ea53bbb7b679bbe5970df8c17a6c3b3f734 plugins/urlpicpreview/urlpicpreviewprefsbase.ui 8db3d1025f860999ec5c7a975fffbace67129c09 Diff: https://git.reviewboard.kde.org/r/124800/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124691: Port K3Socketbase class in libkyahoo to qt4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124691/#review83991 --- protocols/yahoo/libkyahoo/client.cpp (line 29) https://git.reviewboard.kde.org/r/124691/#comment58180 KLocalizedString - Laurent Montel On août 10, 2015, 8:49 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124691/ --- (Updated août 10, 2015, 8:49 après-midi) Review request for Kopete and Laurent Montel. Repository: kopete Description --- Replace the k3socketbase class with QAbstractSocket Diffs - protocols/yahoo/libkyahoo/client.cpp 1f94219e59928c7a1e6a96b1f91d67779fe0a044 Diff: https://git.reviewboard.kde.org/r/124691/diff/ Testing --- Build succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/#review83992 --- protocols/groupwise/ui/gwprivacydialog.cpp (line 278) https://git.reviewboard.kde.org/r/124181/#comment58181 ? isSelected = isHidden ? - Laurent Montel On août 9, 2015, 9:19 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/ --- (Updated août 9, 2015, 9:19 après-midi) Review request for Kopete and Laurent Montel. Repository: kopete Description --- Remove the K3ListBox and needless includes from groupwise. Diffs - protocols/groupwise/gwconnector.cpp d1330ad824dc7c731dc37a95b8735273c4890a46 protocols/groupwise/ui/gwchatprops.ui f93fb5db8269323d5b28bd60181bbe3a209f80e3 protocols/groupwise/ui/gwchatpropsdialog.cpp 5226bb3959439e0c954c7416c10ce839988f8d2e protocols/groupwise/ui/gwprivacy.ui 34fc4e41a669994d90e0fd2de218367d4e2917ea protocols/groupwise/ui/gwprivacydialog.h 595a031de6383ea27e9b2d54e270044b4e715cf2 protocols/groupwise/ui/gwprivacydialog.cpp 3b2210f6907d29931de50e27f299fa67b6c7fdc6 Diff: https://git.reviewboard.kde.org/r/124181/diff/ Testing --- Build succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124721: Adapt CMakeLists.txt to kf5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review83993
---
doc-dev/t2/CMakeLists.txt (line 16)
https://git.reviewboard.kde.org/r/124721/#comment58182
/kopete ? perhaps ${CMAKE_SOURCE_DIR}/kopete
doc-dev/t3/CMakeLists.txt (line 16)
https://git.reviewboard.kde.org/r/124721/#comment58183
same here
kopete/CMakeLists.txt (line 62)
https://git.reviewboard.kde.org/r/124721/#comment58184
remove it and all KDE4_*
kopete/contactlist/CMakeLists.txt (line 4)
https://git.reviewboard.kde.org/r/124721/#comment58185
remove it
protocols/groupwise/libgroupwise/tests/CMakeLists.txt (line 11)
https://git.reviewboard.kde.org/r/124721/#comment58186
qt-mt ?
protocols/sms/services/CMakeLists.txt (line 9)
https://git.reviewboard.kde.org/r/124721/#comment58187
Add info about commented code ?
MESSAGE(STATUS commented code )
- Laurent Montel
On août 12, 2015, 8:19 après-midi, R.Harish Navnit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/
---
(Updated août 12, 2015, 8:19 après-midi)
Review request for Kopete, Laurent Montel and Pali Rohár.
Repository: kopete
Description
---
Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script.
Adapt CMakeLists.txt for kf5 port.
Diffs
-
kopete/addaccountwizard/CMakeLists.txt
e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c
kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a
icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8
doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350
doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3
doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d
CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8
kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2
kopete/chatwindow/a11y/CMakeLists.txt
f20cf4404ee0d21b224bf6d2c1cf849db29401de
kopete/chatwindow/tests/CMakeLists.txt
adc6129fb6a08a69d63d27d3c5642c32af76805d
kopete/config/accounts/CMakeLists.txt
f0a463d187df10ea9e4f6a79aceb2a8e7b09e866
kopete/config/appearance/CMakeLists.txt
abfe7aef01d7de40f8a50341e6155def2b76ecab
kopete/config/avdevice/CMakeLists.txt
c4e3eb2a44383bcd237afe6406907692040ef0b6
kopete/config/behavior/CMakeLists.txt
bba08e0725068e00b85d182008b55aa4e6b1e83b
kopete/config/chatwindow/CMakeLists.txt
89e6faec8310da9e63c6ab1253b3db4fba38b6d3
kopete/config/plugins/CMakeLists.txt
5dc269d072d86662647d189c3fa887406ab8c2bd
kopete/config/status/CMakeLists.txt
8cab8f1cfb735bb81663a8e47e394c0f08458562
kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295
kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb
kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908
libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea
libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146
libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df
plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b
plugins/addbookmarks/CMakeLists.txt
84fe18c20fae30af8ac025ec7b1f59ce86709089
plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6
plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff
plugins/autoreplace/icons/CMakeLists.txt
c62b24b1187bce066c7b7438a980b79f3954851f
plugins/contactnotes/CMakeLists.txt
3742e4b9304f9dcefa82291268691dba5129e590
plugins/cryptography/CMakeLists.txt
f1faffac6ed17209195194242889521a03d34f4d
plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8
plugins/highlight/icons/CMakeLists.txt
1a9fa43e0cbf836dae76112c55ccd69b709f67f1
plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73
plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa
plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8
plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a
plugins/nowlistening/CMakeLists.txt
d910afc14c00c4bac80b934753aadb70561d
plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f
plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d
plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a
plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b
plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84
plugins/statistics/CMakeLists.txt
Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81842 --- protocols/gadu/ui/gadusearch.ui (line 441) https://git.reviewboard.kde.org/r/124173/#comment56178 Remove it as usual it's a native widget - Laurent Montel On juin 28, 2015, 8:04 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated juin 28, 2015, 8:04 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removing the K3ListViews, Q3ListViews and Q3ListViewItem classes from the groupwise protocol. Diffs - protocols/gadu/ui/gadusearch.ui 8b1ecc1898f74f49f3efcf2346241545ff876de1 protocols/groupwise/ui/gwaddcontactpage.cpp be2ead4e8fd4b521cf11b70fe81afad8f27a9f01 protocols/groupwise/ui/gwchatpropsdialog.cpp 7361241c6f6380338774315332530daa6fb3705f protocols/groupwise/ui/gwchatsearch.ui f7e95071f8b9cd8b2c3815306b4fed4ac2afeec8 protocols/groupwise/ui/gwchatsearchdialog.cpp ae23311cafb8c318f2da671e0809bf0a57f4b373 protocols/groupwise/ui/gwcontactproperties.h b0a68812dffbe618205c4528586d7799d71e9131 protocols/groupwise/ui/gwcontactprops.ui 19425b934a018f614642d3d48599a1d532ee5def protocols/groupwise/ui/gwcustomstatus.ui bbd7e5052975810963bde1f84c3efdc9a7074769 protocols/groupwise/ui/gwprivacydialog.cpp 95328c738a3d21556a598408cfadd4a8bbeda227 Diff: https://git.reviewboard.kde.org/r/124173/diff/ Testing --- Build succeeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/#review83407 --- protocols/groupwise/ui/gwchatpropsdialog.cpp (line 108) https://git.reviewboard.kde.org/r/124181/#comment57658 verify signal please :) are you sure that it's value ands not pointer ? - Laurent Montel On juil. 26, 2015, 11:17 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124181/ --- (Updated juil. 26, 2015, 11:17 matin) Review request for Kopete and Laurent Montel. Repository: kopete Description --- Remove the K3ListBox and needless includes from groupwise. Diffs - protocols/groupwise/gwconnector.cpp d1330ad824dc7c731dc37a95b8735273c4890a46 protocols/groupwise/ui/gwchatprops.ui f93fb5db8269323d5b28bd60181bbe3a209f80e3 protocols/groupwise/ui/gwchatpropsdialog.cpp 5226bb3959439e0c954c7416c10ce839988f8d2e Diff: https://git.reviewboard.kde.org/r/124181/diff/ Testing --- Build succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124349: Remove kde3 dependencies from gadu protocol
On juil. 15, 2015, 4:43 matin, Laurent Montel wrote:
protocols/gadu/gadueditcontact.cpp, line 111
https://git.reviewboard.kde.org/r/124349/diff/1/?file=385399#file385399line111
So item which is not selectable and disable ?
R.Harish Navnit wrote:
The default value for flags is { Qt::ItemIsSelectable |
Qt::ItemIsUserCheckable | Qt::ItemIsEnabled | Qt::ItemIsDragEnabled }. That
works better perhaps. Is that what you're saying ?
yep but you change flags you don't have new feature you assign just to
ItemIsUserCheckable
On juil. 15, 2015, 4:43 matin, Laurent Montel wrote:
protocols/gadu/gadupubdir.cpp, line 80
https://git.reviewboard.kde.org/r/124349/diff/1/?file=385400#file385400line80
Read doc it's a QStackedWidget...
R.Harish Navnit wrote:
Q3WidgetStack::raiseWidget(int id) raises the widget with Id 'id' to the
top of the widget stack. Isn't that what QWidget::raise() does as well ?
no.
Read doc.
- Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124349/#review82519
---
On juil. 14, 2015, 6:07 après-midi, R.Harish Navnit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124349/
---
(Updated juil. 14, 2015, 6:07 après-midi)
Review request for Kopete, Laurent Montel and Pali Rohár.
Repository: kopete
Description
---
Q3WidgetStack, Q3ButtonGroup, Q3ListViews and other classes removed.
Diffs
-
protocols/gadu/CMakeLists.txt b6da7736c94a1174b507aac3055b88c76da6aec2
protocols/gadu/gaduaddcontactpage.cpp
e55bd301b2bf4a6205c88b02c798b0094ceced5f
protocols/gadu/gadueditaccount.cpp 20635e38b1bb4a99d220830747cc48731c7ccc63
protocols/gadu/gadueditcontact.h 6b93fa3d84f7e54ec7ca3269f423e3b29e117449
protocols/gadu/gadueditcontact.cpp 7475a4954173da0e9aac657cf90f4a3d2986bb4a
protocols/gadu/gadupubdir.cpp c264519c44aa273039f0acb664e1a5df90b1640f
protocols/gadu/gadusession.h 401a8eb16acf8e3263d20a36cd14b7eeb393783e
protocols/gadu/ui/gaduadd.ui fdbe4a63fe1336095479b8f690a039e1652e7195
protocols/gadu/ui/gadusearch.ui 3011347434e10205a390adf872a6a80077afb6b2
Diff: https://git.reviewboard.kde.org/r/124349/diff/
Testing
---
Build succeeded.
Thanks,
R.Harish Navnit
___
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review83409 --- Ship it! Seems good. I hope that it works as expected. - Laurent Montel On juil. 26, 2015, 7:19 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated juil. 26, 2015, 7:19 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82813 --- Ship it! Seems good. Ship it - Laurent Montel On juil. 21, 2015, 7:35 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated juil. 21, 2015, 7:35 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124227: Remove Q3ListViews from autoreplace
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/#review82812 --- plugins/autoreplace/autoreplacepreferences.cpp (line 51) https://git.reviewboard.kde.org/r/124227/#comment57131 It's duplicate no ? - Laurent Montel On juil. 21, 2015, 1:10 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/ --- (Updated juil. 21, 2015, 1:10 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the Q3ListView classes with QTreeWidgets. Diffs - plugins/autoreplace/autoreplacepreferences.cpp dab6645f0552e6066ae8da09a35654d7dbaca8db plugins/autoreplace/autoreplaceprefs.ui 034013d41f90dd3d2e4c1e2dc94a0fbded8a7782 Diff: https://git.reviewboard.kde.org/r/124227/diff/ Testing --- Build Succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review82968 --- kopete/contactlist/kopeteaddrbookexport.cpp (line 108) https://git.reviewboard.kde.org/r/124305/#comment57256 Why you don't : QListWidgetItem *item = new QListWidgetITem(QIcon, QString); QListWidget::addITem(item); ? - Laurent Montel On juil. 26, 2015, 5:43 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated juil. 26, 2015, 5:43 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124349: Remove kde3 dependencies from gadu protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124349/#review82519 --- protocols/gadu/gadueditcontact.cpp (line 110) https://git.reviewboard.kde.org/r/124349/#comment56923 So item which is not selectable and disable ? protocols/gadu/gadueditcontact.cpp (line 136) https://git.reviewboard.kde.org/r/124349/#comment56924 As usual you didn't read doc protocols/gadu/gadupubdir.cpp (line 80) https://git.reviewboard.kde.org/r/124349/#comment56925 Read doc it's a QStackedWidget... protocols/gadu/gadupubdir.cpp (line 120) https://git.reviewboard.kde.org/r/124349/#comment56926 ? - Laurent Montel On juil. 14, 2015, 6:07 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124349/ --- (Updated juil. 14, 2015, 6:07 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Q3WidgetStack, Q3ButtonGroup, Q3ListViews and other classes removed. Diffs - protocols/gadu/CMakeLists.txt b6da7736c94a1174b507aac3055b88c76da6aec2 protocols/gadu/gaduaddcontactpage.cpp e55bd301b2bf4a6205c88b02c798b0094ceced5f protocols/gadu/gadueditaccount.cpp 20635e38b1bb4a99d220830747cc48731c7ccc63 protocols/gadu/gadueditcontact.h 6b93fa3d84f7e54ec7ca3269f423e3b29e117449 protocols/gadu/gadueditcontact.cpp 7475a4954173da0e9aac657cf90f4a3d2986bb4a protocols/gadu/gadupubdir.cpp c264519c44aa273039f0acb664e1a5df90b1640f protocols/gadu/gadusession.h 401a8eb16acf8e3263d20a36cd14b7eeb393783e protocols/gadu/ui/gaduadd.ui fdbe4a63fe1336095479b8f690a039e1652e7195 protocols/gadu/ui/gadusearch.ui 3011347434e10205a390adf872a6a80077afb6b2 Diff: https://git.reviewboard.kde.org/r/124349/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124345: Use treeWidgets instead of listviews in libkopete accountSelector
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/#review82518 --- libkopete/ui/accountselector.cpp (line 46) https://git.reviewboard.kde.org/r/124345/#comment56921 Why it's not ported ? libkopete/ui/accountselector.cpp (line 109) https://git.reviewboard.kde.org/r/124345/#comment56922 Please reread doc - Laurent Montel On juil. 14, 2015, 7:20 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/ --- (Updated juil. 14, 2015, 7:20 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace K3ListViews/Q3ListViews with QTreeWidget classes. Diffs - libkopete/ui/accountselector.h ff42a881f9151fe3b4db175577807fa191351467 libkopete/ui/accountselector.cpp e6d5ee5f788cbc7606be25d8a9e3aff9b4866468 Diff: https://git.reviewboard.kde.org/r/124345/diff/ Testing --- Build Succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82517 --- When I read doc I see: * @deprecated Use QLabel. (QLabel::setOpenExternalLinks(true) for labels with hyperlinks; * QLabel::setTextInteractionFlags(Qt::TextSelectableByMouse|Qt::TextSelectableByKeyboard) for labels whose text * should be selectable by user.) But you replace just by QLabel it's normal ? - Laurent Montel On juil. 14, 2015, 7:04 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated juil. 14, 2015, 7:04 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124227: Remove Q3ListViews from autoreplace
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/#review82643 --- plugins/autoreplace/autoreplacepreferences.cpp (line 49) https://git.reviewboard.kde.org/r/124227/#comment56995 why it's better ? you know how many column you added. = so not necessary to recalculate the number of column. - Laurent Montel On juil. 19, 2015, 12:15 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/ --- (Updated juil. 19, 2015, 12:15 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the Q3ListView classes with QTreeWidgets. Diffs - plugins/autoreplace/autoreplacepreferences.cpp dab6645f0552e6066ae8da09a35654d7dbaca8db plugins/autoreplace/autoreplaceprefs.ui 034013d41f90dd3d2e4c1e2dc94a0fbded8a7782 Diff: https://git.reviewboard.kde.org/r/124227/diff/ Testing --- Build Succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124345: Use treeWidgets instead of listviews in libkopete accountSelector
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/#review82724 --- libkopete/ui/accountselector.cpp (line 127) https://git.reviewboard.kde.org/r/124345/#comment57045 when do you increase *it ? (see doc ) libkopete/ui/accountselector.cpp (line 141) https://git.reviewboard.kde.org/r/124345/#comment57046 same here - Laurent Montel On juil. 20, 2015, 1:30 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/ --- (Updated juil. 20, 2015, 1:30 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace K3ListViews/Q3ListViews with QTreeWidget classes. Diffs - libkopete/ui/accountselector.h ff42a881f9151fe3b4db175577807fa191351467 libkopete/ui/accountselector.cpp e6d5ee5f788cbc7606be25d8a9e3aff9b4866468 Diff: https://git.reviewboard.kde.org/r/124345/diff/ Testing --- Build Succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124227: Remove Q3ListViews from autoreplace
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review82722
---
plugins/autoreplace/autoreplacepreferences.cpp (line 119)
https://git.reviewboard.kde.org/r/124227/#comment57044
What do you think about
for (int i = 0; i prefer...-m_list-toplevelitemcount() ; ++i) {
QTreeWidgetItem *item = ...-m_list-toplevelitem(i);
newWords[item-text(0)] = ...;
}
?
- Laurent Montel
On juil. 20, 2015, 5:18 après-midi, R.Harish Navnit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/
---
(Updated juil. 20, 2015, 5:18 après-midi)
Review request for Kopete, Laurent Montel and Pali Rohár.
Repository: kopete
Description
---
Replace the Q3ListView classes with QTreeWidgets.
Diffs
-
plugins/autoreplace/autoreplacepreferences.cpp
dab6645f0552e6066ae8da09a35654d7dbaca8db
plugins/autoreplace/autoreplaceprefs.ui
034013d41f90dd3d2e4c1e2dc94a0fbded8a7782
Diff: https://git.reviewboard.kde.org/r/124227/diff/
Testing
---
Build Succeeds.
Thanks,
R.Harish Navnit
___
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82723 --- Ship it! Seems ok. Ship it - Laurent Montel On juil. 20, 2015, 2:01 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated juil. 20, 2015, 2:01 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review82747 --- Ship it! Seems good. Ship it - Laurent Montel On juil. 10, 2015, 12:54 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/ --- (Updated juil. 10, 2015, 12:54 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the K3ListBox classes with QListWidget. Diffs - plugins/texteffect/texteffectpreferences.cpp 35fac60d419cbac5644a8e143be1fc7c640385a9 plugins/texteffect/texteffectprefs.ui 1b82f3de4b449373a3dedb39b664c0f645f1d02a Diff: https://git.reviewboard.kde.org/r/124094/diff/ Testing --- Build succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124227: Remove Q3ListViews from autoreplace
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/#review82520 --- plugins/autoreplace/autoreplacepreferences.cpp (line 49) https://git.reviewboard.kde.org/r/124227/#comment56927 Why ? Why not add directly setColumCount(2) ? plugins/autoreplace/autoreplacepreferences.cpp (line 214) https://git.reviewboard.kde.org/r/124227/#comment56928 indent - Laurent Montel On juil. 14, 2015, 6:28 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/ --- (Updated juil. 14, 2015, 6:28 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the Q3ListView classes with QTreeWidgets. Diffs - plugins/autoreplace/autoreplacepreferences.cpp dab6645f0552e6066ae8da09a35654d7dbaca8db plugins/autoreplace/autoreplaceprefs.ui 034013d41f90dd3d2e4c1e2dc94a0fbded8a7782 Diff: https://git.reviewboard.kde.org/r/124227/diff/ Testing --- Build Succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review82303 --- plugins/texteffect/texteffectpreferences.cpp (line 204) https://git.reviewboard.kde.org/r/124094/#comment56671 takeItem(p) is enough no ? - Laurent Montel On juin 21, 2015, 11:41 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/ --- (Updated juin 21, 2015, 11:41 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the K3ListBox classes with QListWidget. Diffs - plugins/texteffect/texteffectpreferences.cpp 35fac60d419cbac5644a8e143be1fc7c640385a9 plugins/texteffect/texteffectprefs.ui 1b82f3de4b449373a3dedb39b664c0f645f1d02a Diff: https://git.reviewboard.kde.org/r/124094/diff/ Testing --- Build succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review82267 --- plugins/texteffect/texteffectpreferences.cpp (line 204) https://git.reviewboard.kde.org/r/124094/#comment56646 you want to take currentitem no ? so why to get item from listWidget()-row(i) ? - Laurent Montel On juin 21, 2015, 11:41 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/ --- (Updated juin 21, 2015, 11:41 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Replace the K3ListBox classes with QListWidget. Diffs - plugins/texteffect/texteffectpreferences.cpp 35fac60d419cbac5644a8e143be1fc7c640385a9 plugins/texteffect/texteffectprefs.ui 1b82f3de4b449373a3dedb39b664c0f645f1d02a Diff: https://git.reviewboard.kde.org/r/124094/diff/ Testing --- Build succeeds. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review82268 --- kopete/contactlist/kopeteaddrbookexport.cpp (line 131) https://git.reviewboard.kde.org/r/124305/#comment56647 -1... = crash. - Laurent Montel On juil. 9, 2015, 12:20 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated juil. 9, 2015, 12:20 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124332: Compile without KDE3/Qt3 support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/#review82448 --- Ship it! I didn't test compile so I hope that it's ok. Please commit in master - Laurent Montel On juil. 12, 2015, 2:14 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/ --- (Updated juil. 12, 2015, 2:14 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Some plugins have been ported and compile without KDE3/Qt3 support libraries. Diffs - plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff plugins/nowlistening/CMakeLists.txt d910afc14c00c4bac80b934753aadb70561d plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 Diff: https://git.reviewboard.kde.org/r/124332/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130155/#review103566 --- tests/libkopete/kopetestatusgrouptest.cpp (line 45) <https://git.reviewboard.kde.org/r/130155/#comment68931> QCOMPARE tests/libkopete/kopetestatusgrouptest.cpp (line 49) <https://git.reviewboard.kde.org/r/130155/#comment68930> QCOMPARE(...) - Laurent Montel On July 4, 2017, 9:15 p.m., Vijay Krishnavanshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130155/ > --- > > (Updated July 4, 2017, 9:15 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > These autotests cover following classes - > - Kopete::PropertyTemplate > - Kopete::StatusGroup > - Kopete::Status::Status > - Kopete::PropertyContainer > - Kopete::Property > > > Diffs > - > > HACKING f3b9fd1 > INSTALL 059197b > tests/libkopete/CMakeLists.txt 236284b > tests/libkopete/kopetepropertycontainertest.cpp PRE-CREATION > tests/libkopete/kopetepropertytemplatetest.cpp PRE-CREATION > tests/libkopete/kopetepropertytest.cpp PRE-CREATION > tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION > tests/libkopete/kopetestatustest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/130155/diff/ > > > Testing > --- > > > Thanks, > > Vijay Krishnavanshi > >
Re: GSoC 2017 - Announcement of Kopete projects
Le jeudi 11 mai 2017, 10:15:05 CEST Pali Rohár a écrit : > Ok, finish timetime and send it to mailing list. I hope that Montel > would comment it as one big part is automatic testing and should have > better idea about it then me. Arg I was not registred in kopete ML... I will do it now. Regards > > On Wednesday 10 May 2017 03:14:08 vijay krishnavanshi wrote: > > Hi, > > > > I was taking my exams. Now that they are over I would like to share the > > timeline till the review of phase - 1. I am planning on first writing the > > test cases for plugins and then the lib kopete and Kopete during this > > period. I am not sure about the test coverage of lib kopete and Kopete > > that > > I will be able to get. > > > > I will try my best to maximise it :) I will also make room for revisiting > > it later also in my timeline. > > > > Link to google docs (with comment rights): https://goo.gl/o1HCZq > > > > Regards, > > Vijay Krishnavanshi > > > > On 7 May 2017 at 23:43, Paulo Lieuthier <paulolieuth...@gmail.com> wrote: > > > Hi all, > > > > > > Thanks for the oportunity. I'm finishing my timeline and will send to > > > the > > > ML soon. > > > > > > Congratulations, Vijay! Let's do it! > > > > > > Paulo > > > > > > On 05/05/17 17:25, Pali Rohár wrote: > > > > On Friday 05 May 2017 22:16:48 vijay krishnavanshi wrote: > > > >> Do we have to give updates on kde-devel also or just updates on > > > >> kopete-devel are fine? > > > > > > > > kopete-devel is enough. It is public list with public email archive > > > > at: > > > > https://marc.info/?l=kopete-devel -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: GSoC 2017 - Announcement of Kopete projects
Le jeudi 11 mai 2017, 10:36:10 CEST laurent Montel a écrit : > Le jeudi 11 mai 2017, 10:15:05 CEST Pali Rohár a écrit : > > Ok, finish timetime and send it to mailing list. I hope that Montel > > would comment it as one big part is automatic testing and should have > > better idea about it then me. > > Arg I was not registred in kopete ML... > I will do it now. > Regards Is it possible to resend it please ?:) Thanks Regards > > > On Wednesday 10 May 2017 03:14:08 vijay krishnavanshi wrote: > > > Hi, > > > > > > I was taking my exams. Now that they are over I would like to share the > > > timeline till the review of phase - 1. I am planning on first writing > > > the > > > test cases for plugins and then the lib kopete and Kopete during this > > > period. I am not sure about the test coverage of lib kopete and Kopete > > > that > > > I will be able to get. > > > > > > I will try my best to maximise it :) I will also make room for > > > revisiting > > > it later also in my timeline. > > > > > > Link to google docs (with comment rights): https://goo.gl/o1HCZq > > > > > > Regards, > > > Vijay Krishnavanshi > > > > > > On 7 May 2017 at 23:43, Paulo Lieuthier <paulolieuth...@gmail.com> wrote: > > > > Hi all, > > > > > > > > Thanks for the oportunity. I'm finishing my timeline and will send to > > > > the > > > > ML soon. > > > > > > > > Congratulations, Vijay! Let's do it! > > > > > > > > Paulo > > > > > > > > On 05/05/17 17:25, Pali Rohár wrote: > > > > > On Friday 05 May 2017 22:16:48 vijay krishnavanshi wrote: > > > > >> Do we have to give updates on kde-devel also or just updates on > > > > >> kopete-devel are fine? > > > > > > > > > > kopete-devel is enough. It is public list with public email archive > > > > > at: > > > > > https://marc.info/?l=kopete-devel -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: CMake 3+, C++11 in Kopete
Le mardi 16 mai 2017, 10:31:24 CEST Pali Rohár a écrit : > On Sunday 14 May 2017 16:08:10 Paulo Lieuthier wrote: > > Hi everyone, > > Hi! > > > Is there a reason not to upgrade to CMake 3.0.2 or to use C++11 in Kopete > > code, following KDE general path (both cmake 3.0.2 and C++11-capable GCC > > are present in Debian stable repositories)? > > Reason is historical. In time when CMakeLists.txt files were written > CMake 3.0 have not existed yet. Same for C++11. > > About CMake 3.0 important question is: Is there any problem with > current CMakeLists.txt files that it is needed to rewrite them? Is not > CMake 3.0 backward compatible with CMake 2.x? Or what is reason for > rewriting them? > > About C++11... I do not see problem to start using, but I dislike mixing > style of C++98 and C++11 in one class/component. So for new code it is > OK. But adding C++11 constructs into random places in C++98 files is > bad. Becareful you can't use all C++11 feature in kf5 (for example we still need to use Q_DECL_OVERRIDE and others) But I use a lot of c++11 feature in kf5 > > > I'm working in Kopete for GSoC (history plugin), and will be sending my > > schedule in the next days. I have been studying the code and wonderind > > why is that. Maybe that is supposed to come only with the KF5 port? > > Montel should know more about KF5 port. Hi, For me it will better to work on kf5 port directly as it's disable in kf5 and in next release 17.08 we will merge kf5 branch in master So starting your Gsoc against kf5 branch is a better idea. Regards > > > If I was willing to upgrade to Kopete as part of my GSoC project, even > > before Qt5/KF5, would it be welcome? -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols
> On June 19, 2017, 4:51 a.m., Laurent Montel wrote: > > protocols/gadu/gaduaccount.cpp, line 287 > > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496313#file496313line287> > > > > it's not debug categories changes no ?:) > > Paulo Lieuthier wrote: > I had to change it for it to compile. So why it compiles before ? > On June 19, 2017, 4:51 a.m., Laurent Montel wrote: > > protocols/gadu/gaduaccount.cpp, line 1043 > > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496313#file496313line1043> > > > > same here > > Paulo Lieuthier wrote: > Same here. same answer from previous comment :) > On June 19, 2017, 4:51 a.m., Laurent Montel wrote: > > protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp, line 22 > > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496637#file496637line22> > > > > why renamed it ? > > Paulo Lieuthier wrote: > Same here. So why it compiled before ?:) - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130161/#review103341 --- On June 18, 2017, 2:09 p.m., Paulo Lieuthier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130161/ > ------- > > (Updated June 18, 2017, 2:09 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > This was done mostly using regex, and now KDebug is no longer needed to link > the protocols. > > Pull from here: > https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging > > > Diffs > - > > protocols/bonjour/CMakeLists.txt ebe86af6a > protocols/bonjour/bonjouraccount.cpp 0ea32aca3 > protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 > protocols/bonjour/bonjourcontact.cpp 0bb91e703 > protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 > protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 > protocols/bonjour/bonjourprotocol.cpp fb265f2af > protocols/gadu/CMakeLists.txt 4734b6258 > protocols/gadu/gaduaccount.cpp 830016eb1 > protocols/gadu/gaduaddcontactpage.cpp 431c5c8af > protocols/gadu/gaducommands.cpp 94d4b5bc7 > protocols/gadu/gaducontact.h cacc598c9 > protocols/gadu/gaducontact.cpp 3ebb270bb > protocols/gadu/gaducontactlist.cpp e80025cce > protocols/gadu/gadudcc.cpp 19bef1a4d > protocols/gadu/gadudccserver.cpp 85d26b1aa > protocols/gadu/gadudcctransaction.cpp 27d501867 > protocols/gadu/gadueditaccount.cpp 21e111545 > protocols/gadu/gadueditcontact.cpp 691acb1e6 > protocols/gadu/gaduprotocol.cpp 4c102f6a2 > protocols/gadu/gadupubdir.h 45761facd > protocols/gadu/gadupubdir.cpp c73fa0741 > protocols/gadu/gaduregisteraccount.cpp 56cfca52a > protocols/gadu/gadurichtextformat.cpp 1974dfe0c > protocols/gadu/gadusession.cpp 4b9d02747 > protocols/groupwise/CMakeLists.txt 33f7e435e > protocols/groupwise/gwaccount.cpp 43220e984 > protocols/groupwise/gwbytestream.cpp 0ae83090c > protocols/groupwise/gwconnector.cpp 1677fe3bc > protocols/groupwise/gwcontact.cpp 831af63c6 > protocols/groupwise/gwcontactlist.cpp a54773588 > protocols/groupwise/gwmessagemanager.cpp 9075a7014 > protocols/groupwise/gwprotocol.cpp 8251921f3 > protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd > protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 > protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 > protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 > protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 > protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 > protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 > protocols/groupwise/libgroupwise/gwerror.h 31d576902 > protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 > protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 > protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 > protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 > protocols/groupwise/libgroupwise/rtf2html.h 53952c694 > protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa > protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e > protocols/groupwise/libgroupwise/tasks/getchatsearchresultstask.cpp > a6432353c > protocols/groupwise/libgroupwise/tasks/logintask.cp
Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols
> On June 19, 2017, 4:51 a.m., Laurent Montel wrote: > > protocols/gadu/gaduaccount.cpp, line 326 > > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496313#file496313line326> > > > > same here etc. > > Paulo Lieuthier wrote: > Same here. > > Paulo Lieuthier wrote: > `QIcon::fromTheme()` expects a QString, not a QIcon. I don't understand > how it worked before. Could you please help me with that? yep it expects it. So it's a definition which avoid cast from ascii > On June 19, 2017, 4:51 a.m., Laurent Montel wrote: > > protocols/gadu/gaduaccount.cpp, line 1043 > > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496313#file496313line1043> > > > > same here > > Paulo Lieuthier wrote: > Same here. > > Laurent Montel wrote: > same answer from previous comment :) > > Paulo Lieuthier wrote: > I couldn't find `setCaption` in either KFileDialog or QDialog in Qt4 or > Qt5. I found it was deprecated [1], and changed it so it could build. What am > I supposed to do here? > > [1] > https://api.kde.org/frameworks/kdelibs4support/html/deprecated.html#_deprecated000220 indeed it's setWindowTitle in qt5. Perhaps code was not compiles previously But for sure it doesn't build on qt5 > On June 19, 2017, 4:51 a.m., Laurent Montel wrote: > > protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp, line 22 > > <https://git.reviewboard.kde.org/r/130161/diff/1/?file=496637#file496637line22> > > > > why renamed it ? > > Paulo Lieuthier wrote: > Same here. > > Laurent Montel wrote: > So why it compiled before ?:) > > Paulo Lieuthier wrote: > This one compiled before, I just wanted all protocols to be named in the > same way. I will revert it if you prefer. it's protocol so it's better to use it and we use protocol in other place as jabber no ? - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130161/#review103341 --- On June 18, 2017, 2:09 p.m., Paulo Lieuthier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130161/ > --- > > (Updated June 18, 2017, 2:09 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > This was done mostly using regex, and now KDebug is no longer needed to link > the protocols. > > Pull from here: > https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging > > > Diffs > - > > protocols/bonjour/CMakeLists.txt ebe86af6a > protocols/bonjour/bonjouraccount.cpp 0ea32aca3 > protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 > protocols/bonjour/bonjourcontact.cpp 0bb91e703 > protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 > protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 > protocols/bonjour/bonjourprotocol.cpp fb265f2af > protocols/gadu/CMakeLists.txt 4734b6258 > protocols/gadu/gaduaccount.cpp 830016eb1 > protocols/gadu/gaduaddcontactpage.cpp 431c5c8af > protocols/gadu/gaducommands.cpp 94d4b5bc7 > protocols/gadu/gaducontact.h cacc598c9 > protocols/gadu/gaducontact.cpp 3ebb270bb > protocols/gadu/gaducontactlist.cpp e80025cce > protocols/gadu/gadudcc.cpp 19bef1a4d > protocols/gadu/gadudccserver.cpp 85d26b1aa > protocols/gadu/gadudcctransaction.cpp 27d501867 > protocols/gadu/gadueditaccount.cpp 21e111545 > protocols/gadu/gadueditcontact.cpp 691acb1e6 > protocols/gadu/gaduprotocol.cpp 4c102f6a2 > protocols/gadu/gadupubdir.h 45761facd > protocols/gadu/gadupubdir.cpp c73fa0741 > protocols/gadu/gaduregisteraccount.cpp 56cfca52a > protocols/gadu/gadurichtextformat.cpp 1974dfe0c > protocols/gadu/gadusession.cpp 4b9d02747 > protocols/groupwise/CMakeLists.txt 33f7e435e > protocols/groupwise/gwaccount.cpp 43220e984 > protocols/groupwise/gwbytestream.cpp 0ae83090c > protocols/groupwise/gwconnector.cpp 1677fe3bc > protocols/groupwise/gwcontact.cpp 831af63c6 > protocols/groupwise/gwcontactlist.cpp a54773588 > protocols/groupwise/gwmessagemanager.cpp 9075a7014 > protocols/groupwise/gwprotocol.cpp 8251921f3 > protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd > protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 > protocols/groupwise/libgroupwise/chatroommanager.cpp
Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130161/#review103378 --- Ship it! Ship It! - Laurent Montel On June 25, 2017, 5:24 p.m., Paulo Lieuthier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130161/ > --- > > (Updated June 25, 2017, 5:24 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > This was done mostly using regex, and now KDebug is no longer needed to link > the protocols. > > Pull from here: > https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging > > > Diffs > - > > protocols/bonjour/CMakeLists.txt ebe86af6a > protocols/bonjour/bonjouraccount.cpp 0ea32aca3 > protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 > protocols/bonjour/bonjourcontact.cpp 0bb91e703 > protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 > protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 > protocols/bonjour/bonjourprotocol.cpp fb265f2af > protocols/gadu/CMakeLists.txt 4734b6258 > protocols/gadu/gaduaccount.cpp 830016eb1 > protocols/gadu/gaduaddcontactpage.cpp 431c5c8af > protocols/gadu/gaducommands.cpp 94d4b5bc7 > protocols/gadu/gaducontact.h cacc598c9 > protocols/gadu/gaducontact.cpp 3ebb270bb > protocols/gadu/gaducontactlist.cpp e80025cce > protocols/gadu/gadudcc.cpp 19bef1a4d > protocols/gadu/gadudccserver.cpp 85d26b1aa > protocols/gadu/gadudcctransaction.cpp 27d501867 > protocols/gadu/gadueditaccount.cpp 21e111545 > protocols/gadu/gadueditcontact.cpp 691acb1e6 > protocols/gadu/gaduprotocol.cpp 4c102f6a2 > protocols/gadu/gadupubdir.h 45761facd > protocols/gadu/gadupubdir.cpp c73fa0741 > protocols/gadu/gaduregisteraccount.cpp 56cfca52a > protocols/gadu/gadurichtextformat.cpp 1974dfe0c > protocols/gadu/gadusession.cpp 4b9d02747 > protocols/groupwise/CMakeLists.txt 33f7e435e > protocols/groupwise/gwaccount.cpp 43220e984 > protocols/groupwise/gwbytestream.cpp 0ae83090c > protocols/groupwise/gwconnector.cpp 1677fe3bc > protocols/groupwise/gwcontact.cpp 831af63c6 > protocols/groupwise/gwcontactlist.cpp a54773588 > protocols/groupwise/gwmessagemanager.cpp 9075a7014 > protocols/groupwise/gwprotocol.cpp 8251921f3 > protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd > protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 > protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 > protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 > protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 > protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 > protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 > protocols/groupwise/libgroupwise/gwerror.h 31d576902 > protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 > protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 > protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 > protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 > protocols/groupwise/libgroupwise/rtf2html.h 53952c694 > protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa > protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e > protocols/groupwise/libgroupwise/tasks/getchatsearchresultstask.cpp > a6432353c > protocols/groupwise/libgroupwise/tasks/logintask.cpp 756c662d6 > protocols/groupwise/libgroupwise/tasks/searchchattask.cpp f597721b4 > protocols/groupwise/libgroupwise/tasks/searchusertask.cpp 9f8614472 > protocols/groupwise/libgroupwise/tests/clientstream_test.cpp 24a07ecd9 > protocols/groupwise/libgroupwise/userdetailsmanager.cpp 2850c0d65 > protocols/groupwise/ui/gwaddcontactpage.cpp 2c1b8b084 > protocols/groupwise/ui/gwchatpropsdialog.cpp 138f38016 > protocols/groupwise/ui/gwchatsearchdialog.cpp c5719c8d6 > protocols/groupwise/ui/gwcontactproperties.cpp ed7ff4fa5 > protocols/groupwise/ui/gweditaccountwidget.cpp a48351383 > protocols/groupwise/ui/gwprivacydialog.cpp 8dd11f1ab > protocols/groupwise/ui/gwsearch.cpp 50a15730d > protocols/jabber/CMakeLists.txt 6ea47b82e > protocols/jabber/jabberaccount.cpp 4829934b6 > protocols/jabber/jabbercapabilitiesmanager.cpp 4afc5489d > protocols/jabber/jabberchatsession.cpp 0aa3c852d > protocols/jabber/jabberclient.cpp 33c4873e2 > prot
Re: Regarding GSoC Project Autotests for Kopete
Le samedi 27 mai 2017, 08:18:38 CEST vijay krishnavanshi a écrit : > Hi, > > I am facing an issue with one of the cmake module build. The issue is about > the classes and library handling. I am making a derived class and am unable > to call the function of the base class in it. It has something to do with > CMake build. I went through the stack overflow and it says that it happens > when compiler is not able to see the included library file. I have also > pasted the files in the pastebin which I think will describe the issue. > > Link to Error Log: https://pastebin.com/UnMTuZBH > Link to tests/latex/CMakeLists.txt: https://pastebin.com/NFX5nTK2 > Link to tests/latex/testLatexPlugin.cpp: https://pastebin.com/Y8MgeDhs > > Test case for three plugins are done. I have tried to keep the logs short. > > If this is ambiguous, Should I create a Review Request and describe the > issue? > > I know this needs to be figured out by me and I am doing it. But I thought > its better to ask for help :) > > Regards, > Vijay Krishnavanshi Missing export symbol perhaps no ? -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130155/#review103332 --- tests/libkopete/kopetepropertytemplatetest.cpp (line 84) <https://git.reviewboard.kde.org/r/130155/#comment68740> use different string it's better tests/libkopete/kopetestatusgrouptest.cpp (line 36) <https://git.reviewboard.kde.org/r/130155/#comment68741> same string here. Cache value Remove space before after -> use QStringLiteral tests/libkopete/kopetestatustest.cpp (line 43) <https://git.reviewboard.kde.org/r/130155/#comment68742> remove space before/after -> use QStringLiteral etc. - Laurent Montel On June 17, 2017, 9:03 a.m., Vijay Krishnavanshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130155/ > --- > > (Updated June 17, 2017, 9:03 a.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > These autotests cover following classes - > - Kopete::PropertyTemplate > - Kopete::StatusGroup > - Kopete::Status::Status > - Kopete::PropertyContainer > - Kopete::Property > > > Diffs > - > > tests/libkopete/CMakeLists.txt 236284b > tests/libkopete/kopetepropertycontainertest.cpp PRE-CREATION > tests/libkopete/kopetepropertytemplatetest.cpp PRE-CREATION > tests/libkopete/kopetepropertytest.cpp PRE-CREATION > tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION > tests/libkopete/kopetestatustest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/130155/diff/ > > > Testing > --- > > > Thanks, > > Vijay Krishnavanshi > >
Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130155/#review103334
---
tests/libkopete/kopetepropertycontainertest.cpp (line 61)
<https://git.reviewboard.kde.org/r/130155/#comment68743>
remove space before/after ->
tests/libkopete/kopetestatusgrouptest.cpp (line 37)
<https://git.reviewboard.kde.org/r/130155/#comment68744>
remove space before/after ...
tests/libkopete/kopetestatustest.cpp (line 46)
<https://git.reviewboard.kde.org/r/130155/#comment68745>
now you can test 2 signal etc.
Perhaps emit signal when same message etc.
you need to create more autotests which is more complex.
Regards
- Laurent Montel
On June 17, 2017, 8:21 p.m., Vijay Krishnavanshi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130155/
> ---
>
> (Updated June 17, 2017, 8:21 p.m.)
>
>
> Review request for Kopete, Laurent Montel and Pali Rohár.
>
>
> Repository: kopete
>
>
> Description
> ---
>
> These autotests cover following classes -
> - Kopete::PropertyTemplate
> - Kopete::StatusGroup
> - Kopete::Status::Status
> - Kopete::PropertyContainer
> - Kopete::Property
>
>
> Diffs
> -
>
> tests/libkopete/CMakeLists.txt 236284b
> tests/libkopete/kopetepropertycontainertest.cpp PRE-CREATION
> tests/libkopete/kopetepropertytemplatetest.cpp PRE-CREATION
> tests/libkopete/kopetepropertytest.cpp PRE-CREATION
> tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION
> tests/libkopete/kopetestatustest.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/130155/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Vijay Krishnavanshi
>
>
Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130154/#review103302
---
plugins/history/historyguiclient.cpp (line 30)
<https://git.reviewboard.kde.org/r/130154/#comment68728>
use qDebug here. kdebug is kdelibs4support
plugins/history/historyplugin.cpp (line 32)
<https://git.reviewboard.kde.org/r/130154/#comment68729>
qDebug
and perhaps you need to convert kdebug to qDebug/qCDebug
plugins/history/historypreferences.cpp (line 27)
<https://git.reviewboard.kde.org/r/130154/#comment68730>
same here.
- Laurent Montel
On June 10, 2017, 3 p.m., Paulo Lieuthier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130154/
> ---
>
> (Updated June 10, 2017, 3 p.m.)
>
>
> Review request for Kopete, Laurent Montel and Pali Rohár.
>
>
> Repository: kopete
>
>
> Description
> ---
>
> The history plugin port was not completed, so it is disabled. This patch
> re-enables it, fixes it's building failures and fixes not saving the history
> file when the directory doesn't exist.
>
> Pull from here:
> https://github.com/paulolieuthier/kopete/commits/fix-history-plugin.
>
>
> Diffs
> -
>
> libkopete/ui/kopeteview.h 070a3b8a2
> plugins/CMakeLists.txt 6216058ef
> plugins/history/CMakeLists.txt ce90b84a3
> plugins/history/converter.cpp 3175beac1
> plugins/history/historyguiclient.cpp 41745bfe0
> plugins/history/historylogger.cpp 66b627030
> plugins/history/historyplugin.cpp 48cd98010
> plugins/history/historypreferences.cpp 9c64b4418
>
> Diff: https://git.reviewboard.kde.org/r/130154/diff/
>
>
> Testing
> ---
>
> Tested last messages appearance on reopening a chat window, using Jabber and
> Test Protocol.
>
>
> Thanks,
>
> Paulo Lieuthier
>
>
Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving
> On June 10, 2017, 4:26 p.m., Laurent Montel wrote: > > > > Paulo Lieuthier wrote: > I had already started translating those (and all others) in my main > branch, and didn't want to mess with that here. Next review request will be > such translation, isn't that better? > > By the way, I does it mean to "`kDebug(14308)`" (there is a lot of that > in the codebase). Where does that number come from? Is it the category? Then > qCDebug should be used, then? > > Paulo Lieuthier wrote: > I meant "what does it mean to '`kDebug(14380)`'"? Yep you need to use qCDebug(...) + define categories see in kf5 I already started to do it. For example "ecm_qt_declare_logging_category(kopete_LIB_SRCS HEADER libkopete_debug.h IDENTIFIER LIBKOPETE_LOG CATEGORY_NAME org.kde.kopete.libkopete)" we have a cmake macro for defininig it. You need to create your own log category. you need to add your new log category in kopete.categories too. - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/#review103302 --- On June 10, 2017, 3 p.m., Paulo Lieuthier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130154/ > ----------- > > (Updated June 10, 2017, 3 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > The history plugin port was not completed, so it is disabled. This patch > re-enables it, fixes it's building failures and fixes not saving the history > file when the directory doesn't exist. > > Pull from here: > https://github.com/paulolieuthier/kopete/commits/fix-history-plugin. > > > Diffs > - > > libkopete/ui/kopeteview.h 070a3b8a2 > plugins/CMakeLists.txt 6216058ef > plugins/history/CMakeLists.txt ce90b84a3 > plugins/history/converter.cpp 3175beac1 > plugins/history/historyguiclient.cpp 41745bfe0 > plugins/history/historylogger.cpp 66b627030 > plugins/history/historyplugin.cpp 48cd98010 > plugins/history/historypreferences.cpp 9c64b4418 > > Diff: https://git.reviewboard.kde.org/r/130154/diff/ > > > Testing > --- > > Tested last messages appearance on reopening a chat window, using Jabber and > Test Protocol. > > > Thanks, > > Paulo Lieuthier > >
Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving
> On June 11, 2017, 9:52 a.m., Paulo Lieuthier wrote: > > Ship It! Do you know it's not the creator of request which must click on "ship it" - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/#review103308 --- On June 10, 2017, 3 p.m., Paulo Lieuthier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130154/ > --- > > (Updated June 10, 2017, 3 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > The history plugin port was not completed, so it is disabled. This patch > re-enables it, fixes it's building failures and fixes not saving the history > file when the directory doesn't exist. > > Pull from here: > https://github.com/paulolieuthier/kopete/commits/fix-history-plugin > > > Diffs > - > > libkopete/ui/kopeteview.h 070a3b8a2 > plugins/CMakeLists.txt 6216058ef > plugins/history/CMakeLists.txt ce90b84a3 > plugins/history/converter.cpp 3175beac1 > plugins/history/historyguiclient.cpp 41745bfe0 > plugins/history/historylogger.cpp 66b627030 > plugins/history/historyplugin.cpp 48cd98010 > plugins/history/historypreferences.cpp 9c64b4418 > > Diff: https://git.reviewboard.kde.org/r/130154/diff/ > > > Testing > --- > > Tested last messages appearance on reopening a chat window, using Jabber and > Test Protocol. > > > Thanks, > > Paulo Lieuthier > >
Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130161/#review103341 --- protocols/gadu/gaduaccount.cpp (line 284) <https://git.reviewboard.kde.org/r/130161/#comment68755> it's not debug categories changes no ?:) protocols/gadu/gaduaccount.cpp (line 321) <https://git.reviewboard.kde.org/r/130161/#comment68756> same here etc. protocols/gadu/gaduaccount.cpp (line 321) <https://git.reviewboard.kde.org/r/130161/#comment68757> same here etc. protocols/gadu/gaduaccount.cpp (line 1034) <https://git.reviewboard.kde.org/r/130161/#comment68758> same here protocols/gadu/gaduaccount.cpp (line 1077) <https://git.reviewboard.kde.org/r/130161/#comment68759> same here protocols/jabber/jabberformtranslator.cpp (line 23) <https://git.reviewboard.kde.org/r/130161/#comment68760> Why ? why rename include file ? protocols/jabber/jingle/jinglecontentdialog.cpp (line 20) <https://git.reviewboard.kde.org/r/130161/#comment68761> same here protocols/jabber/ui/dlgahcommand.cpp (line 22) <https://git.reviewboard.kde.org/r/130161/#comment68762> same here... protocols/yahoo/libkyahoo/alivetask.cpp <https://git.reviewboard.kde.org/r/130161/#comment68763> you removed all debug ? protocols/yahoo/libkyahoo/receivefiletask.cpp <https://git.reviewboard.kde.org/r/130161/#comment68764> Why removed all debug ? protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp (line 22) <https://git.reviewboard.kde.org/r/130161/#comment68765> why renamed it ? - Laurent Montel On June 18, 2017, 2:09 p.m., Paulo Lieuthier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130161/ > --- > > (Updated June 18, 2017, 2:09 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > This was done mostly using regex, and now KDebug is no longer needed to link > the protocols. > > Pull from here: > https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging > > > Diffs > - > > protocols/bonjour/CMakeLists.txt ebe86af6a > protocols/bonjour/bonjouraccount.cpp 0ea32aca3 > protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 > protocols/bonjour/bonjourcontact.cpp 0bb91e703 > protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 > protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 > protocols/bonjour/bonjourprotocol.cpp fb265f2af > protocols/gadu/CMakeLists.txt 4734b6258 > protocols/gadu/gaduaccount.cpp 830016eb1 > protocols/gadu/gaduaddcontactpage.cpp 431c5c8af > protocols/gadu/gaducommands.cpp 94d4b5bc7 > protocols/gadu/gaducontact.h cacc598c9 > protocols/gadu/gaducontact.cpp 3ebb270bb > protocols/gadu/gaducontactlist.cpp e80025cce > protocols/gadu/gadudcc.cpp 19bef1a4d > protocols/gadu/gadudccserver.cpp 85d26b1aa > protocols/gadu/gadudcctransaction.cpp 27d501867 > protocols/gadu/gadueditaccount.cpp 21e111545 > protocols/gadu/gadueditcontact.cpp 691acb1e6 > protocols/gadu/gaduprotocol.cpp 4c102f6a2 > protocols/gadu/gadupubdir.h 45761facd > protocols/gadu/gadupubdir.cpp c73fa0741 > protocols/gadu/gaduregisteraccount.cpp 56cfca52a > protocols/gadu/gadurichtextformat.cpp 1974dfe0c > protocols/gadu/gadusession.cpp 4b9d02747 > protocols/groupwise/CMakeLists.txt 33f7e435e > protocols/groupwise/gwaccount.cpp 43220e984 > protocols/groupwise/gwbytestream.cpp 0ae83090c > protocols/groupwise/gwconnector.cpp 1677fe3bc > protocols/groupwise/gwcontact.cpp 831af63c6 > protocols/groupwise/gwcontactlist.cpp a54773588 > protocols/groupwise/gwmessagemanager.cpp 9075a7014 > protocols/groupwise/gwprotocol.cpp 8251921f3 > protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd > protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 > protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 > protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 > protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 > protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 > protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 > protocols/groupwise/libgroupwise/gwerror.h 31d576902 > protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 > protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 > protocols/groupwise/libgroupwis
Re: Review Request 130225: Added autotests for kopete chat window
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130225/#review103811 --- Ship it! Ship It! - Laurent Montel On août 12, 2017, 10:23 après-midi, Vijay Krishnavanshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130225/ > --- > > (Updated août 12, 2017, 10:23 après-midi) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > This autotest attempts to tets the kopete chat window style. But one issue > that I am facing is that it looks for style in > QStandardPaths::DataLocation/styles for styles but I want to change it to the > current CMAKE_SOURCE_DIR. > > > Diffs > - > > tests/kopete/CMakeLists.txt 2f9b0db > tests/kopete/kopetechatwindowtest.cpp PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Info.plist PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Resources/Header.html PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Resources/Incoming/Content.html > PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Resources/Incoming/NextContent.html > PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/Content.html > PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/NextContent.html > PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Resources/Status.html PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant1.css > PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant2.css > PRE-CREATION > tests/kopete/styles/TestStyle/Contents/Resources/main.css PRE-CREATION > > > Diff: https://git.reviewboard.kde.org/r/130225/diff/1/ > > > Testing > --- > > > Thanks, > > Vijay Krishnavanshi > >
Re: Review Request 130183: Added autotests for autoreplace plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130183/#review103810 --- Ship it! Ship It! - Laurent Montel On août 27, 2017, 3:33 matin, Vijay Krishnavanshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130183/ > --- > > (Updated août 27, 2017, 3:33 matin) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > Finally I have under stood how the autotests for plugins can be written. > This patch does not test the config file of auto replace plugin. > > > Diffs > - > > tests/plugins/CMakeLists.txt e69de29 > tests/plugins/autoreplace/CMakeLists.txt PRE-CREATION > tests/plugins/autoreplace/kopeteautoreplaceplugintest.cpp PRE-CREATION > > > Diff: https://git.reviewboard.kde.org/r/130183/diff/3/ > > > Testing > --- > > > Thanks, > > Vijay Krishnavanshi > >
Re: Using Phabricator for new review requests
Hi ok good idea. Regards Le samedi 26 août 2017, 15:08:53 CEST vijay krishnavanshi a écrit : > Hi, > > As the git.reviewboard.kde.org is being phased out I will create all new > review requests on phabricator.kde.org. > > Link to the Review Request I recently created: > https://phabricator.kde.org/D7556 > Please confirm that you got the email notification of it :) > > Link to repo on phabricator: https://phabricator.kde.org/source/kopete/ > > I will first fix the issues in git.reviewboard's review requests and will > either submit them or discard. They will be available on > git.reviewboard for reference later. > > Regards, > Vijay Krishnavanshi -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
D8319: Split the UI initialization and fix the about box
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R434 Kopete BRANCH kf5-fix-aboutbox REVISION DETAIL https://phabricator.kde.org/D8319 To: ltoscano, pali, mlaurent Cc: #kopete
D7635: Update History Plugin and create logs in xml format
mlaurent added a comment. qCDebug not only qDebug :) Otherwise we can't disable debug. thanks REPOSITORY R434 Kopete REVISION DETAIL https://phabricator.kde.org/D7635 To: vijaykrishnavanshi, pali, mlaurent Cc: #kopete
D7635: Update History Plugin and create logs in xml format
mlaurent abandoned this revision. mlaurent added a comment. no change from 1 years 1/2 REPOSITORY R434 Kopete REVISION DETAIL https://phabricator.kde.org/D7635 To: mlaurent, pali, vijaykrishnavanshi Cc: kopete-devel, himanshuvishwakarma, cochise
D7635: Update History Plugin and create logs in xml format
mlaurent commandeered this revision. mlaurent edited reviewers, added: vijaykrishnavanshi; removed: mlaurent. Herald edited subscribers, added: kopete-devel; removed: Kopete. REPOSITORY R434 Kopete REVISION DETAIL https://phabricator.kde.org/D7635 To: mlaurent, pali, vijaykrishnavanshi Cc: kopete-devel, himanshuvishwakarma, cochise, #kopete
