Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated March 13, 2016, 3:24 p.m.) Status -- This change has been marked as submitted. Review request for Kopete and Pali Rohár. Changes --- Submitted with commit f2c2a33716d6577648389b7160e5f1cc56f93c04 by Pali Rohár on behalf of R. Harish Navnit to branch master. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated March 11, 2016, 4:24 p.m.) Status -- This change has been marked as submitted. Review request for Kopete and Pali Rohár. Changes --- Submitted with commit 5bedb08b7d3b43c41a472a76b0f85fe8f7c9228e by R. Harish Navnit to branch kf5. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated Sept. 6, 2015, 7:50 p.m.) Status -- This change has been marked as submitted. Review request for Kopete and Pali Rohár. Changes --- Submitted with commit aabee25960afc77dd5d92f01361f1ba251eb4279 by R. Harish Navnit to branch commit_merge. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review84200 --- Ship it! approved - Pali Rohár On júl 3, 2015, 8:34 dopoludnia, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated júl 3, 2015, 8:34 dopoludnia) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review84199 --- reopening as it is not in kopete master yet - Pali Rohár On júl 3, 2015, 8:34 dopoludnia, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated júl 3, 2015, 8:34 dopoludnia) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated July 3, 2015, 6:34 a.m.) Status -- This change has been marked as submitted. Review request for Kopete and Pali Rohár. Changes --- Submitted with commit 1eaae102da8987a8215ec82a8e6a83719722d700 by R. Harish Navnit to branch frameworks. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
On jún 23, 2015, 9:41 dopoludnia, R.Harish Navnit wrote: This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? Laurent Montel wrote: As Pali Rohar told you in comment Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). you forgot to add REVIEW: If you have some commits ready for merging into kopete master, please create new branch in your clonned repository and add that commits into that branch. Then ping back and we can merge your branch into kopete master. Until now you did not send any information what you want to merge... - Pali --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- On máj 9, 2015, 8:58 dopoludnia, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated máj 9, 2015, 8:58 dopoludnia) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
On June 23, 2015, 1:11 p.m., R.Harish Navnit wrote: This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? Laurent Montel wrote: As Pali Rohar told you in comment Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). you forgot to add REVIEW: Pali Rohár wrote: If you have some commits ready for merging into kopete master, please create new branch in your clonned repository and add that commits into that branch. Then ping back and we can merge your branch into kopete master. Until now you did not send any information what you want to merge... I was thinking of creating a new branch and adding commits as soon as kde3 dependencies are completely removed. Just the kopete/protocols remain now in this respect, I thought it would be better to wait. No ? - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- On May 9, 2015, 12:28 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated May 9, 2015, 12:28 p.m.) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
On jún 23, 2015, 9:41 dopoludnia, R.Harish Navnit wrote: This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? Laurent Montel wrote: As Pali Rohar told you in comment Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). you forgot to add REVIEW: Pali Rohár wrote: If you have some commits ready for merging into kopete master, please create new branch in your clonned repository and add that commits into that branch. Then ping back and we can merge your branch into kopete master. Until now you did not send any information what you want to merge... R.Harish Navnit wrote: I was thinking of creating a new branch and adding commits as soon as kde3 dependencies are completely removed. Just the kopete/protocols remain now in this respect, I thought it would be better to wait. No ? If you do not tell me location of git repository and branch (which contains your commits) I cannot merge them into kopete -- because I do not know what to merge. This one review request is OK and can be merged into kopete master. - Pali --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- On máj 9, 2015, 8:58 dopoludnia, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated máj 9, 2015, 8:58 dopoludnia) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? - R.Harish Navnit On May 9, 2015, 12:28 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated May 9, 2015, 12:28 p.m.) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
On juin 23, 2015, 7:41 matin, R.Harish Navnit wrote: This change has been pushed to the frameworks scratch repo : http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.gita=commith=1b3909d2d81042804a217bfe9f81b8caa38bdb86 Should this be closed/marked as submitted now ? As Pali Rohar told you in comment Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). you forgot to add REVIEW: - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 --- On mai 9, 2015, 6:58 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated mai 9, 2015, 6:58 matin) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated May 9, 2015, 12:28 p.m.) Review request for Kopete and Pali Rohár. Changes --- Removing one more similar and useless include. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs (updated) - kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review79757 --- Patch is OK. Now try to setup your own personal cloned git repository and commit this patch into it (do not remember REVIEW: 123489 keywoard in commit message). - Pali Rohár On apr. 26, 2015, 7:54 popoludní, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated apr. 26, 2015, 7:54 popoludní) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated April 26, 2015, 11:24 p.m.) Review request for Kopete and Pali Rohár. Changes --- Removed unintended whitspaces changes in the patch. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs (updated) - kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123489: Remove unnecessary k3listview includes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review79477 --- plugins/alias/aliaspreferences.cpp (line 191) https://git.reviewboard.kde.org/r/123489/#comment54310 additional whitespace change... please do not include whitespace changes into commit which doing something else if you want to remove additional spaces, please do it in separate commit. it is really hard to understand functionality of this because it is too big (due to that whitespace changes). please fix it before merging code. - Pali Rohár On apr. 24, 2015, 1:01 popoludní, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/ --- (Updated apr. 24, 2015, 1:01 popoludní) Review request for Kopete and Pali Rohár. Repository: kopete Description --- The following k3listview includes do not affect complilation and/or run of the kopete application. Diffs - protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 Diff: https://git.reviewboard.kde.org/r/123489/diff/ Testing --- Compiled and ran kopete shell application. No exceptions or warnings thrown. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
