Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated March 13, 2016, 3:24 p.m.) Status -- This change has been marked as submitted. Review request for Kopete, Laurent Montel and Pali Rohár. Changes --- Submitted with commit f3c0fb1cb11645e873b75479d2d2468519bdd0e4 by Pali Rohár on behalf of R. Harish Navnit to branch master. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated March 11, 2016, 3:24 p.m.) Status -- This change has been marked as submitted. Review request for Kopete, Laurent Montel and Pali Rohár. Changes --- Submitted with commit 510c16de31e67bcf4ffc50229337f4ef3c87d732 by R. Harish Navnit to branch kf5. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated Sept. 6, 2015, 7:50 p.m.) Status -- This change has been marked as submitted. Review request for Kopete, Laurent Montel and Pali Rohár. Changes --- Submitted with commit 0dfa7cfa86fa1757c1e0693a25d457293b1cdf14 by R. Harish Navnit to branch commit_merge. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
On July 21, 2015, 10:33 p.m., Pali Rohár wrote: libkopete/ui/addressbookselectorwidget.cpp, line 143 https://git.reviewboard.kde.org/r/124344/diff/2/?file=386361#file386361line143 TextEditorInteraction = TextSelectableByMouse | TextSelectableByKeyboard | TextEditable Why it is needed? Have you looked what this lblHeader means and where is used? Pali Rohár wrote: I'm reopening this issue because: 1) it does not have comment any comment or answers to my questions 2) I bet answer to my second question is No, because it is really not needed (or correct me if I'm wrong!) I have looked at this label header and Qt::TextEditorInteraction was not required for the same and hence I updated the patch, replacing it with Qt::NoTextInteraction (since I felt there needn't be any text interaction for a header label) https://git.reviewboard.kde.org/r/124344/diff/2-3/ - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82775 --- On July 22, 2015, 1:05 a.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 22, 2015, 1:05 a.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
On júl 21, 2015, 7:03 popoludní, Pali Rohár wrote: libkopete/ui/addressbookselectorwidget.cpp, line 143 https://git.reviewboard.kde.org/r/124344/diff/2/?file=386361#file386361line143 TextEditorInteraction = TextSelectableByMouse | TextSelectableByKeyboard | TextEditable Why it is needed? Have you looked what this lblHeader means and where is used? Pali Rohár wrote: I'm reopening this issue because: 1) it does not have comment any comment or answers to my questions 2) I bet answer to my second question is No, because it is really not needed (or correct me if I'm wrong!) R.Harish Navnit wrote: I have looked at this label header and Qt::TextEditorInteraction was not required for the same and hence I updated the patch, replacing it with Qt::NoTextInteraction (since I felt there needn't be any text interaction for a header label) https://git.reviewboard.kde.org/r/124344/diff/2-3/ Remove that explicit call for setting text interaction. It will be easier to understand that we do not care about it and default value Qt::LinksAccessibleByMouse is also OK. On júl 21, 2015, 7:03 popoludní, Pali Rohár wrote: libkopete/ui/metacontactselectorwidget.cpp, line 21 https://git.reviewboard.kde.org/r/124344/diff/2/?file=386363#file386363line21 Is this change needed? And if yes it is cosmetic, should be in separate commit and should change all includes qclass.h to QClass. Not just only one. Then we will have big mess. R.Harish Navnit wrote: Since this whole patch does some porting to KDE4/Qt4, and deals directly with the QLabel class, I thought it'd be sensible to do this change, keeping in line with the Qt4 documentation. Revert it, nevertheless and create a separate patch ? Pali Rohár wrote: Rewriting qclass.h to QClass is non functional change and should be done in separate patch. And should change every qclass.h. R.Harish Navnit wrote: Yes, I've reverted this one as well, in the updated patch : https://git.reviewboard.kde.org/r/124344/diff/2-3/ In patch 3 I still see diff which change qlabel.h to QLabel. - Pali --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82775 --- On júl 21, 2015, 9:35 popoludní, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated júl 21, 2015, 9:35 popoludní) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82813 --- Ship it! Seems good. Ship it - Laurent Montel On juil. 21, 2015, 7:35 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated juil. 21, 2015, 7:35 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
On July 21, 2015, 10:33 p.m., Pali Rohár wrote: libkopete/ui/metacontactselectorwidget.cpp, line 21 https://git.reviewboard.kde.org/r/124344/diff/2/?file=386363#file386363line21 Is this change needed? And if yes it is cosmetic, should be in separate commit and should change all includes qclass.h to QClass. Not just only one. Then we will have big mess. R.Harish Navnit wrote: Since this whole patch does some porting to KDE4/Qt4, and deals directly with the QLabel class, I thought it'd be sensible to do this change, keeping in line with the Qt4 documentation. Revert it, nevertheless and create a separate patch ? Pali Rohár wrote: Rewriting qclass.h to QClass is non functional change and should be done in separate patch. And should change every qclass.h. Yes, I've reverted this one as well, in the updated patch : https://git.reviewboard.kde.org/r/124344/diff/2-3/ - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82775 --- On July 22, 2015, 1:05 a.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 22, 2015, 1:05 a.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
On July 21, 2015, 10:33 p.m., Pali Rohár wrote: libkopete/ui/metacontactselectorwidget.cpp, line 21 https://git.reviewboard.kde.org/r/124344/diff/2/?file=386363#file386363line21 Is this change needed? And if yes it is cosmetic, should be in separate commit and should change all includes qclass.h to QClass. Not just only one. Then we will have big mess. R.Harish Navnit wrote: Since this whole patch does some porting to KDE4/Qt4, and deals directly with the QLabel class, I thought it'd be sensible to do this change, keeping in line with the Qt4 documentation. Revert it, nevertheless and create a separate patch ? Pali Rohár wrote: Rewriting qclass.h to QClass is non functional change and should be done in separate patch. And should change every qclass.h. R.Harish Navnit wrote: Yes, I've reverted this one as well, in the updated patch : https://git.reviewboard.kde.org/r/124344/diff/2-3/ Pali Rohár wrote: In patch 3 I still see diff which change qlabel.h to QLabel. Yeah, I noticed that too and I find it really strange. Revisions 1,2 - 3 show QLabel being reverted back to qlabel.h , but origin-3rd revision shows the exact opposite o.O - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82775 --- On July 22, 2015, 1:05 a.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 22, 2015, 1:05 a.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82777 --- libkopete/ui/addressbookselectorwidget.cpp (line 140) https://git.reviewboard.kde.org/r/124344/#comment57087 Also you need to enforce plain text, because QLabel::setText() doing magic detection. - Pali Rohár On júl 20, 2015, 4:01 popoludní, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated júl 20, 2015, 4:01 popoludní) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
On July 21, 2015, 10:33 p.m., Pali Rohár wrote: libkopete/ui/metacontactselectorwidget.cpp, line 21 https://git.reviewboard.kde.org/r/124344/diff/2/?file=386363#file386363line21 Is this change needed? And if yes it is cosmetic, should be in separate commit and should change all includes qclass.h to QClass. Not just only one. Then we will have big mess. Since this whole patch does some porting to KDE4/Qt4, and deals directly with the QLabel class, I thought it'd be sensible to do this change, keeping in line with the Qt4 documentation. Revert it, nevertheless and create a separate patch ? - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82775 --- On July 20, 2015, 7:31 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 20, 2015, 7:31 p.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 22, 2015, 1:05 a.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Changes --- Correct text interaction. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs (updated) - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
On July 15, 2015, 10:08 a.m., Laurent Montel wrote: When I read doc I see: * @deprecated Use QLabel. (QLabel::setOpenExternalLinks(true) for labels with hyperlinks; * QLabel::setTextInteractionFlags(Qt::TextSelectableByMouse|Qt::TextSelectableByKeyboard) for labels whose text * should be selectable by user.) But you replace just by QLabel it's normal ? Uhm sorry, I was following the Qt-assistant document, somehow missed this. Later found it out in https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/raw/KDE4PORTING.html - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82517 --- On July 14, 2015, 12:34 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 14, 2015, 12:34 p.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 20, 2015, 7:31 p.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Changes --- Handle text interactions and external links. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs (updated) - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82723 --- Ship it! Seems ok. Ship it - Laurent Montel On juil. 20, 2015, 2:01 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated juil. 20, 2015, 2:01 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82517 --- When I read doc I see: * @deprecated Use QLabel. (QLabel::setOpenExternalLinks(true) for labels with hyperlinks; * QLabel::setTextInteractionFlags(Qt::TextSelectableByMouse|Qt::TextSelectableByKeyboard) for labels whose text * should be selectable by user.) But you replace just by QLabel it's normal ? - Laurent Montel On juil. 14, 2015, 7:04 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated juil. 14, 2015, 7:04 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Use QLabel instead of K3ActiveLabel Diffs - libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 Diff: https://git.reviewboard.kde.org/r/124344/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
