Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2017-10-04 Thread Luigi Toscano
> On Set. 30, 2017, 8:10 p.m., Luigi Toscano wrote: > > Can this be dropped? The kf5 branch is way more updated. > > > > @rharishnavnit (and all the others), can you please recheck which of your > > patches are outdated and can be dropped (because already applied or not > > relevant anymore)?

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2017-10-01 Thread Luigi Toscano
> On Set. 30, 2017, 8:10 p.m., Luigi Toscano wrote: > > Can this be dropped? The kf5 branch is way more updated. > > > > @rharishnavnit (and all the others), can you please recheck which of your > > patches are outdated and can be dropped (because already applied or not > > relevant anymore)?

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2017-09-30 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124721/#review103753 --- Can this be dropped? The kf5 branch is way more updated.

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2017-03-12 Thread Pali Rohár
> On aug. 18, 2015, 4:31 popoludní, Laurent Montel wrote: > > protocols/groupwise/libgroupwise/tests/CMakeLists.txt, line 11 > > > > > > qt-mt ? > > R.Harish Navnit wrote: > Not sure what this serves, maybe

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2016-01-05 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124721/#review90661 --- plugins/CMakeLists.txt (line 3)

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2016-01-05 Thread R.Harish Navnit
> On Jan. 4, 2016, 11:52 p.m., Pali Rohár wrote: > > plugins/CMakeLists.txt, line 3 > > > > > > Reason for this? Because the history plugin was being re-written right ? - R.Harish

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2016-01-04 Thread Pali Rohár
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124721/#review90585 --- CMakeLists.txt (line 136)

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2015-12-30 Thread Pali Rohár
> On aug. 18, 2015, 4:31 popoludní, Laurent Montel wrote: > > protocols/groupwise/libgroupwise/tests/CMakeLists.txt, line 11 > > > > > > qt-mt ? > > R.Harish Navnit wrote: > Not sure what this serves, maybe

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2015-12-30 Thread R.Harish Navnit
> On Aug. 18, 2015, 8:01 p.m., Laurent Montel wrote: > > protocols/groupwise/libgroupwise/tests/CMakeLists.txt, line 11 > > > > > > qt-mt ? > > R.Harish Navnit wrote: > Not sure what this serves, maybe Pali

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2015-09-17 Thread R.Harish Navnit
> On Aug. 18, 2015, 8:01 p.m., Laurent Montel wrote: > > protocols/groupwise/libgroupwise/tests/CMakeLists.txt, line 11 > > > > > > qt-mt ? Not sure what this serves, maybe Pali can explain. - R.Harish

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2015-08-18 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124721/#review83993 --- doc-dev/t2/CMakeLists.txt (line 16)

Review Request 124721: Adapt CMakeLists.txt to kf5

2015-08-12 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124721/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository: