Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-10-05 Thread Luigi Toscano 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103799
---



Sorry for the delay, but it should be changed. For example there are multiple 
declaration of ecm_qt_declare_logging_category for the same header file; but 
it's not needed, you can just define it once, defining the "sources" in a 
separate cmake variable and reusing it multiple times.

Please note that you can use a script to do this change globally (even if it 
requires some changes in this case, when you use the same category in multiple  
sections of the code):
https://cgit.kde.org/kde-dev-scripts.git/tree/kf5/convert-qkdebug-to-qcdebug.sh

I'm going to detach the commit containing " Fix build failure in Gadu protocol 
" and commit it, as it is needed independently from the main change (and 
separate changs should be committed separately; yes, they are separated on 
github, but the place for the review is here on kde.org)

Can you please rebase this on the current kf5 branch? Also please note that 
reviewboard is closed for new reviews and will shut down in few days, 
https://phabricator.kde.org is the way to go (see 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist ).

- Luigi Toscano


On Giu. 25, 2017, 7:24 p.m., Paulo Lieuthier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130161/
> ---
> 
> (Updated Giu. 25, 2017, 7:24 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This was done mostly using regex, and now KDebug is no longer needed to link 
> the protocols.
> 
> Pull from here: 
> https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging
> 
> 
> Diffs
> -
> 
>   protocols/bonjour/CMakeLists.txt ebe86af6a 
>   protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
>   protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
>   protocols/bonjour/bonjourcontact.cpp 0bb91e703 
>   protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
>   protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
>   protocols/bonjour/bonjourprotocol.cpp fb265f2af 
>   protocols/gadu/CMakeLists.txt 4734b6258 
>   protocols/gadu/gaduaccount.cpp 830016eb1 
>   protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
>   protocols/gadu/gaducommands.cpp 94d4b5bc7 
>   protocols/gadu/gaducontact.h cacc598c9 
>   protocols/gadu/gaducontact.cpp 3ebb270bb 
>   protocols/gadu/gaducontactlist.cpp e80025cce 
>   protocols/gadu/gadudcc.cpp 19bef1a4d 
>   protocols/gadu/gadudccserver.cpp 85d26b1aa 
>   protocols/gadu/gadudcctransaction.cpp 27d501867 
>   protocols/gadu/gadueditaccount.cpp 21e111545 
>   protocols/gadu/gadueditcontact.cpp 691acb1e6 
>   protocols/gadu/gaduprotocol.cpp 4c102f6a2 
>   protocols/gadu/gadupubdir.h 45761facd 
>   protocols/gadu/gadupubdir.cpp c73fa0741 
>   protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
>   protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
>   protocols/gadu/gadusession.cpp 4b9d02747 
>   protocols/groupwise/CMakeLists.txt 33f7e435e 
>   protocols/groupwise/gwaccount.cpp 43220e984 
>   protocols/groupwise/gwbytestream.cpp 0ae83090c 
>   protocols/groupwise/gwconnector.cpp 1677fe3bc 
>   protocols/groupwise/gwcontact.cpp 831af63c6 
>   protocols/groupwise/gwcontactlist.cpp a54773588 
>   protocols/groupwise/gwmessagemanager.cpp 9075a7014 
>   protocols/groupwise/gwprotocol.cpp 8251921f3 
>   protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
>   protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
>   protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
>   protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
>   protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
>   protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
>   protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
>   protocols/groupwise/libgroupwise/gwerror.h 31d576902 
>   protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 
>   protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 
>   protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 
>   protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 
>   protocols/groupwise/libgroupwise/rtf2html.h 53952c694 
>   protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa 
>   protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e 
>   protocols/groupwise/libgroupwise/tasks/getchatsearchresultstask.cpp 
> a6432353c 
>   protocols/groupwise/libgroupwise/tasks/logintask.cpp 756c662d6 
>   protocols/groupwise/libgroupwise/tasks/searchchattask.cpp f597721b4 
>   protocols/groupwise/libgroupwise/tasks/searchusertask.cpp 9f8614472 
>

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-26 Thread Laurent Montel 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103378
---


Ship it!




Ship It!

- Laurent Montel


On June 25, 2017, 5:24 p.m., Paulo Lieuthier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130161/
> ---
> 
> (Updated June 25, 2017, 5:24 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This was done mostly using regex, and now KDebug is no longer needed to link 
> the protocols.
> 
> Pull from here: 
> https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging
> 
> 
> Diffs
> -
> 
>   protocols/bonjour/CMakeLists.txt ebe86af6a 
>   protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
>   protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
>   protocols/bonjour/bonjourcontact.cpp 0bb91e703 
>   protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
>   protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
>   protocols/bonjour/bonjourprotocol.cpp fb265f2af 
>   protocols/gadu/CMakeLists.txt 4734b6258 
>   protocols/gadu/gaduaccount.cpp 830016eb1 
>   protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
>   protocols/gadu/gaducommands.cpp 94d4b5bc7 
>   protocols/gadu/gaducontact.h cacc598c9 
>   protocols/gadu/gaducontact.cpp 3ebb270bb 
>   protocols/gadu/gaducontactlist.cpp e80025cce 
>   protocols/gadu/gadudcc.cpp 19bef1a4d 
>   protocols/gadu/gadudccserver.cpp 85d26b1aa 
>   protocols/gadu/gadudcctransaction.cpp 27d501867 
>   protocols/gadu/gadueditaccount.cpp 21e111545 
>   protocols/gadu/gadueditcontact.cpp 691acb1e6 
>   protocols/gadu/gaduprotocol.cpp 4c102f6a2 
>   protocols/gadu/gadupubdir.h 45761facd 
>   protocols/gadu/gadupubdir.cpp c73fa0741 
>   protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
>   protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
>   protocols/gadu/gadusession.cpp 4b9d02747 
>   protocols/groupwise/CMakeLists.txt 33f7e435e 
>   protocols/groupwise/gwaccount.cpp 43220e984 
>   protocols/groupwise/gwbytestream.cpp 0ae83090c 
>   protocols/groupwise/gwconnector.cpp 1677fe3bc 
>   protocols/groupwise/gwcontact.cpp 831af63c6 
>   protocols/groupwise/gwcontactlist.cpp a54773588 
>   protocols/groupwise/gwmessagemanager.cpp 9075a7014 
>   protocols/groupwise/gwprotocol.cpp 8251921f3 
>   protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
>   protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
>   protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
>   protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
>   protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
>   protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
>   protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
>   protocols/groupwise/libgroupwise/gwerror.h 31d576902 
>   protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 
>   protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 
>   protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 
>   protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 
>   protocols/groupwise/libgroupwise/rtf2html.h 53952c694 
>   protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa 
>   protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e 
>   protocols/groupwise/libgroupwise/tasks/getchatsearchresultstask.cpp 
> a6432353c 
>   protocols/groupwise/libgroupwise/tasks/logintask.cpp 756c662d6 
>   protocols/groupwise/libgroupwise/tasks/searchchattask.cpp f597721b4 
>   protocols/groupwise/libgroupwise/tasks/searchusertask.cpp 9f8614472 
>   protocols/groupwise/libgroupwise/tests/clientstream_test.cpp 24a07ecd9 
>   protocols/groupwise/libgroupwise/userdetailsmanager.cpp 2850c0d65 
>   protocols/groupwise/ui/gwaddcontactpage.cpp 2c1b8b084 
>   protocols/groupwise/ui/gwchatpropsdialog.cpp 138f38016 
>   protocols/groupwise/ui/gwchatsearchdialog.cpp c5719c8d6 
>   protocols/groupwise/ui/gwcontactproperties.cpp ed7ff4fa5 
>   protocols/groupwise/ui/gweditaccountwidget.cpp a48351383 
>   protocols/groupwise/ui/gwprivacydialog.cpp 8dd11f1ab 
>   protocols/groupwise/ui/gwsearch.cpp 50a15730d 
>   protocols/jabber/CMakeLists.txt 6ea47b82e 
>   protocols/jabber/jabberaccount.cpp 4829934b6 
>   protocols/jabber/jabbercapabilitiesmanager.cpp 4afc5489d 
>   protocols/jabber/jabberchatsession.cpp 0aa3c852d 
>   protocols/jabber/jabberclient.cpp 33c4873e2 
>   protocols/jabber/jabbercontact.cpp bc7794175 
>   protocols/jabber/jabbergroupchatmanager.cpp 2347fd2da 
>   protocols/jabber/jabbergroupcontact.cpp 5f764bbad 
>   protocols/jabber/jabbergroupmembercontact.cpp 57ee80e38 
>   protocols/jabber/jabberprotocol.cpp e5dfecd1d 
>

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-25 Thread Paulo Lieuthier 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/
---

(Updated June 25, 2017, 2:24 p.m.)


Review request for Kopete, Laurent Montel and Pali Rohár.


Changes
---

Rename generated categoric logging files to include "`_protocol_`".


Repository: kopete


Description
---

This was done mostly using regex, and now KDebug is no longer needed to link 
the protocols.

Pull from here: 
https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging


Diffs (updated)
-

  protocols/bonjour/CMakeLists.txt ebe86af6a 
  protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
  protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
  protocols/bonjour/bonjourcontact.cpp 0bb91e703 
  protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
  protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
  protocols/bonjour/bonjourprotocol.cpp fb265f2af 
  protocols/gadu/CMakeLists.txt 4734b6258 
  protocols/gadu/gaduaccount.cpp 830016eb1 
  protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
  protocols/gadu/gaducommands.cpp 94d4b5bc7 
  protocols/gadu/gaducontact.h cacc598c9 
  protocols/gadu/gaducontact.cpp 3ebb270bb 
  protocols/gadu/gaducontactlist.cpp e80025cce 
  protocols/gadu/gadudcc.cpp 19bef1a4d 
  protocols/gadu/gadudccserver.cpp 85d26b1aa 
  protocols/gadu/gadudcctransaction.cpp 27d501867 
  protocols/gadu/gadueditaccount.cpp 21e111545 
  protocols/gadu/gadueditcontact.cpp 691acb1e6 
  protocols/gadu/gaduprotocol.cpp 4c102f6a2 
  protocols/gadu/gadupubdir.h 45761facd 
  protocols/gadu/gadupubdir.cpp c73fa0741 
  protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
  protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
  protocols/gadu/gadusession.cpp 4b9d02747 
  protocols/groupwise/CMakeLists.txt 33f7e435e 
  protocols/groupwise/gwaccount.cpp 43220e984 
  protocols/groupwise/gwbytestream.cpp 0ae83090c 
  protocols/groupwise/gwconnector.cpp 1677fe3bc 
  protocols/groupwise/gwcontact.cpp 831af63c6 
  protocols/groupwise/gwcontactlist.cpp a54773588 
  protocols/groupwise/gwmessagemanager.cpp 9075a7014 
  protocols/groupwise/gwprotocol.cpp 8251921f3 
  protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
  protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
  protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
  protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
  protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
  protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
  protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
  protocols/groupwise/libgroupwise/gwerror.h 31d576902 
  protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 
  protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 
  protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 
  protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 
  protocols/groupwise/libgroupwise/rtf2html.h 53952c694 
  protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa 
  protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e 
  protocols/groupwise/libgroupwise/tasks/getchatsearchresultstask.cpp a6432353c 
  protocols/groupwise/libgroupwise/tasks/logintask.cpp 756c662d6 
  protocols/groupwise/libgroupwise/tasks/searchchattask.cpp f597721b4 
  protocols/groupwise/libgroupwise/tasks/searchusertask.cpp 9f8614472 
  protocols/groupwise/libgroupwise/tests/clientstream_test.cpp 24a07ecd9 
  protocols/groupwise/libgroupwise/userdetailsmanager.cpp 2850c0d65 
  protocols/groupwise/ui/gwaddcontactpage.cpp 2c1b8b084 
  protocols/groupwise/ui/gwchatpropsdialog.cpp 138f38016 
  protocols/groupwise/ui/gwchatsearchdialog.cpp c5719c8d6 
  protocols/groupwise/ui/gwcontactproperties.cpp ed7ff4fa5 
  protocols/groupwise/ui/gweditaccountwidget.cpp a48351383 
  protocols/groupwise/ui/gwprivacydialog.cpp 8dd11f1ab 
  protocols/groupwise/ui/gwsearch.cpp 50a15730d 
  protocols/jabber/CMakeLists.txt 6ea47b82e 
  protocols/jabber/jabberaccount.cpp 4829934b6 
  protocols/jabber/jabbercapabilitiesmanager.cpp 4afc5489d 
  protocols/jabber/jabberchatsession.cpp 0aa3c852d 
  protocols/jabber/jabberclient.cpp 33c4873e2 
  protocols/jabber/jabbercontact.cpp bc7794175 
  protocols/jabber/jabbergroupchatmanager.cpp 2347fd2da 
  protocols/jabber/jabbergroupcontact.cpp 5f764bbad 
  protocols/jabber/jabbergroupmembercontact.cpp 57ee80e38 
  protocols/jabber/jabberprotocol.cpp e5dfecd1d 
  protocols/jabber/jabbertransport.cpp e3a98e858 
  protocols/jabber/jingle/jabberjinglecontent.cpp a831e9818 
  protocols/jabber/jingle/jabberjinglesession.cpp ce0e6d121 
  protocols/jabber/jingle/jinglertpsession.cpp 7acc720ab 
  protocols/jabber/kioslave/jabberdisco.cpp 44bb46ac7 
  protocols/jabber/libiris/CMakeLists.txt f9ff6ada6 
  protocols/jabber/libiris/src/irisnet/corelib/netnames.cpp 963f6c29b

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-24 Thread Laurent Montel 


> On June 19, 2017, 4:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 326
> > 
> >
> > same here etc.
> 
> Paulo Lieuthier wrote:
> Same here.
> 
> Paulo Lieuthier wrote:
> `QIcon::fromTheme()` expects a QString, not a QIcon. I don't understand 
> how it worked before. Could you please help me with that?

yep it expects it. So it's a definition which avoid cast from ascii


> On June 19, 2017, 4:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 1043
> > 
> >
> > same here
> 
> Paulo Lieuthier wrote:
> Same here.
> 
> Laurent Montel wrote:
> same answer from previous comment :)
> 
> Paulo Lieuthier wrote:
> I couldn't find `setCaption` in either KFileDialog or QDialog in Qt4 or 
> Qt5. I found it was deprecated [1], and changed it so it could build. What am 
> I supposed to do here?
> 
> [1] 
> https://api.kde.org/frameworks/kdelibs4support/html/deprecated.html#_deprecated000220

indeed it's setWindowTitle in qt5. Perhaps code was not compiles previously But 
for sure it doesn't build on qt5


> On June 19, 2017, 4:51 a.m., Laurent Montel wrote:
> > protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp, line 22
> > 
> >
> > why renamed it ?
> 
> Paulo Lieuthier wrote:
> Same here.
> 
> Laurent Montel wrote:
> So why it compiled before ?:)
> 
> Paulo Lieuthier wrote:
> This one compiled before, I just wanted all protocols to be named in the 
> same way. I will revert it if you prefer.

it's protocol so it's better to use it and we use protocol in other place as 
jabber no ?


- Laurent


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103341
---


On June 18, 2017, 2:09 p.m., Paulo Lieuthier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130161/
> ---
> 
> (Updated June 18, 2017, 2:09 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This was done mostly using regex, and now KDebug is no longer needed to link 
> the protocols.
> 
> Pull from here: 
> https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging
> 
> 
> Diffs
> -
> 
>   protocols/bonjour/CMakeLists.txt ebe86af6a 
>   protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
>   protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
>   protocols/bonjour/bonjourcontact.cpp 0bb91e703 
>   protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
>   protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
>   protocols/bonjour/bonjourprotocol.cpp fb265f2af 
>   protocols/gadu/CMakeLists.txt 4734b6258 
>   protocols/gadu/gaduaccount.cpp 830016eb1 
>   protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
>   protocols/gadu/gaducommands.cpp 94d4b5bc7 
>   protocols/gadu/gaducontact.h cacc598c9 
>   protocols/gadu/gaducontact.cpp 3ebb270bb 
>   protocols/gadu/gaducontactlist.cpp e80025cce 
>   protocols/gadu/gadudcc.cpp 19bef1a4d 
>   protocols/gadu/gadudccserver.cpp 85d26b1aa 
>   protocols/gadu/gadudcctransaction.cpp 27d501867 
>   protocols/gadu/gadueditaccount.cpp 21e111545 
>   protocols/gadu/gadueditcontact.cpp 691acb1e6 
>   protocols/gadu/gaduprotocol.cpp 4c102f6a2 
>   protocols/gadu/gadupubdir.h 45761facd 
>   protocols/gadu/gadupubdir.cpp c73fa0741 
>   protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
>   protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
>   protocols/gadu/gadusession.cpp 4b9d02747 
>   protocols/groupwise/CMakeLists.txt 33f7e435e 
>   protocols/groupwise/gwaccount.cpp 43220e984 
>   protocols/groupwise/gwbytestream.cpp 0ae83090c 
>   protocols/groupwise/gwconnector.cpp 1677fe3bc 
>   protocols/groupwise/gwcontact.cpp 831af63c6 
>   protocols/groupwise/gwcontactlist.cpp a54773588 
>   protocols/groupwise/gwmessagemanager.cpp 9075a7014 
>   protocols/groupwise/gwprotocol.cpp 8251921f3 
>   protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
>   protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
>   protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
>   protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
>   protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
>   protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
>   protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
>   protocols/groupwise/libgroupwise/gwerror.h 31d576902 
>   protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 
>

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-20 Thread Paulo Lieuthier 


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 287
> > 
> >
> > it's not debug categories changes no ?:)
> 
> Paulo Lieuthier wrote:
> I had to change it for it to compile.
> 
> Laurent Montel wrote:
> So why it compiles before ?

I have no idea why it compiled before (it never compiled for me). I can't find 
`QMenu::addTitle()` in Qt5 or Qt4 docs. Could you please help me?


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 326
> > 
> >
> > same here etc.
> 
> Paulo Lieuthier wrote:
> Same here.

`QIcon::fromTheme()` expects a QString, not a QIcon. I don't understand how it 
worked before. Could you please help me with that?


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 1043
> > 
> >
> > same here
> 
> Paulo Lieuthier wrote:
> Same here.
> 
> Laurent Montel wrote:
> same answer from previous comment :)

I couldn't find `setCaption` in either KFileDialog or QDialog in Qt4 or Qt5. I 
found it was deprecated [1], and changed it so it could build. What am I 
supposed to do here?

[1] 
https://api.kde.org/frameworks/kdelibs4support/html/deprecated.html#_deprecated000220


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp, line 22
> > 
> >
> > why renamed it ?
> 
> Paulo Lieuthier wrote:
> Same here.
> 
> Laurent Montel wrote:
> So why it compiled before ?:)

This one compiled before, I just wanted all protocols to be named in the same 
way. I will revert it if you prefer.


- Paulo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103341
---


On June 18, 2017, 11:09 a.m., Paulo Lieuthier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130161/
> ---
> 
> (Updated June 18, 2017, 11:09 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This was done mostly using regex, and now KDebug is no longer needed to link 
> the protocols.
> 
> Pull from here: 
> https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging
> 
> 
> Diffs
> -
> 
>   protocols/bonjour/CMakeLists.txt ebe86af6a 
>   protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
>   protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
>   protocols/bonjour/bonjourcontact.cpp 0bb91e703 
>   protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
>   protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
>   protocols/bonjour/bonjourprotocol.cpp fb265f2af 
>   protocols/gadu/CMakeLists.txt 4734b6258 
>   protocols/gadu/gaduaccount.cpp 830016eb1 
>   protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
>   protocols/gadu/gaducommands.cpp 94d4b5bc7 
>   protocols/gadu/gaducontact.h cacc598c9 
>   protocols/gadu/gaducontact.cpp 3ebb270bb 
>   protocols/gadu/gaducontactlist.cpp e80025cce 
>   protocols/gadu/gadudcc.cpp 19bef1a4d 
>   protocols/gadu/gadudccserver.cpp 85d26b1aa 
>   protocols/gadu/gadudcctransaction.cpp 27d501867 
>   protocols/gadu/gadueditaccount.cpp 21e111545 
>   protocols/gadu/gadueditcontact.cpp 691acb1e6 
>   protocols/gadu/gaduprotocol.cpp 4c102f6a2 
>   protocols/gadu/gadupubdir.h 45761facd 
>   protocols/gadu/gadupubdir.cpp c73fa0741 
>   protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
>   protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
>   protocols/gadu/gadusession.cpp 4b9d02747 
>   protocols/groupwise/CMakeLists.txt 33f7e435e 
>   protocols/groupwise/gwaccount.cpp 43220e984 
>   protocols/groupwise/gwbytestream.cpp 0ae83090c 
>   protocols/groupwise/gwconnector.cpp 1677fe3bc 
>   protocols/groupwise/gwcontact.cpp 831af63c6 
>   protocols/groupwise/gwcontactlist.cpp a54773588 
>   protocols/groupwise/gwmessagemanager.cpp 9075a7014 
>   protocols/groupwise/gwprotocol.cpp 8251921f3 
>   protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
>   protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
>   protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
>   protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
>   protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
>   protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
>   protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
>

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-19 Thread Laurent Montel 


> On June 19, 2017, 4:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 287
> > 
> >
> > it's not debug categories changes no ?:)
> 
> Paulo Lieuthier wrote:
> I had to change it for it to compile.

So why it compiles before ?


> On June 19, 2017, 4:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 1043
> > 
> >
> > same here
> 
> Paulo Lieuthier wrote:
> Same here.

same answer from previous comment :)


> On June 19, 2017, 4:51 a.m., Laurent Montel wrote:
> > protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp, line 22
> > 
> >
> > why renamed it ?
> 
> Paulo Lieuthier wrote:
> Same here.

So why it compiled before ?:)


- Laurent


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103341
---


On June 18, 2017, 2:09 p.m., Paulo Lieuthier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130161/
> ---
> 
> (Updated June 18, 2017, 2:09 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This was done mostly using regex, and now KDebug is no longer needed to link 
> the protocols.
> 
> Pull from here: 
> https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging
> 
> 
> Diffs
> -
> 
>   protocols/bonjour/CMakeLists.txt ebe86af6a 
>   protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
>   protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
>   protocols/bonjour/bonjourcontact.cpp 0bb91e703 
>   protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
>   protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
>   protocols/bonjour/bonjourprotocol.cpp fb265f2af 
>   protocols/gadu/CMakeLists.txt 4734b6258 
>   protocols/gadu/gaduaccount.cpp 830016eb1 
>   protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
>   protocols/gadu/gaducommands.cpp 94d4b5bc7 
>   protocols/gadu/gaducontact.h cacc598c9 
>   protocols/gadu/gaducontact.cpp 3ebb270bb 
>   protocols/gadu/gaducontactlist.cpp e80025cce 
>   protocols/gadu/gadudcc.cpp 19bef1a4d 
>   protocols/gadu/gadudccserver.cpp 85d26b1aa 
>   protocols/gadu/gadudcctransaction.cpp 27d501867 
>   protocols/gadu/gadueditaccount.cpp 21e111545 
>   protocols/gadu/gadueditcontact.cpp 691acb1e6 
>   protocols/gadu/gaduprotocol.cpp 4c102f6a2 
>   protocols/gadu/gadupubdir.h 45761facd 
>   protocols/gadu/gadupubdir.cpp c73fa0741 
>   protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
>   protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
>   protocols/gadu/gadusession.cpp 4b9d02747 
>   protocols/groupwise/CMakeLists.txt 33f7e435e 
>   protocols/groupwise/gwaccount.cpp 43220e984 
>   protocols/groupwise/gwbytestream.cpp 0ae83090c 
>   protocols/groupwise/gwconnector.cpp 1677fe3bc 
>   protocols/groupwise/gwcontact.cpp 831af63c6 
>   protocols/groupwise/gwcontactlist.cpp a54773588 
>   protocols/groupwise/gwmessagemanager.cpp 9075a7014 
>   protocols/groupwise/gwprotocol.cpp 8251921f3 
>   protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
>   protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
>   protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
>   protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
>   protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
>   protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
>   protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
>   protocols/groupwise/libgroupwise/gwerror.h 31d576902 
>   protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 
>   protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 
>   protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 
>   protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 
>   protocols/groupwise/libgroupwise/rtf2html.h 53952c694 
>   protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa 
>   protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e 
>   protocols/groupwise/libgroupwise/tasks/getchatsearchresultstask.cpp 
> a6432353c 
>   protocols/groupwise/libgroupwise/tasks/logintask.cpp 756c662d6 
>   protocols/groupwise/libgroupwise/tasks/searchchattask.cpp f597721b4 
>   protocols/groupwise/libgroupwise/tasks/searchusertask.cpp 9f8614472 
>   protocols/groupwise/libgroupwise/tests/clientstream_test.cpp 24a07ecd9 
>   protocols/groupwise/libgroupwise/userdetailsmanager.cpp 2850c0d65 
>   protocols/groupwise/ui/gwaddcontactpage.cpp 2c1b8b084 
>

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-19 Thread Paulo Lieuthier 


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 287
> > 
> >
> > it's not debug categories changes no ?:)

I had to change it for it to compile.


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 326
> > 
> >
> > same here etc.

Same here.


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 326
> > 
> >
> > same here etc.

Same here.


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 1043
> > 
> >
> > same here

Same here.


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/gadu/gaduaccount.cpp, line 1087
> > 
> >
> > same here

Same here.


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/jabber/jabberformtranslator.cpp, line 23
> > 
> >
> > Why ? why rename include file ?

Same here.


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/jabber/jingle/jinglecontentdialog.cpp, line 20
> > 
> >
> > same here

Same here.


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/jabber/ui/dlgahcommand.cpp, line 22
> > 
> >
> > same here...

Same here.


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp, line 22
> > 
> >
> > why renamed it ?

Same here.


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/yahoo/libkyahoo/alivetask.cpp, line 38
> > 
> >
> > you removed all debug ?

I removed all empty debugs. Are they worth keeping, even with no message?


> On June 19, 2017, 1:51 a.m., Laurent Montel wrote:
> > protocols/yahoo/libkyahoo/receivefiletask.cpp, line 173
> > 
> >
> > Why removed all debug ?

Same here.


- Paulo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103341
---


On June 18, 2017, 11:09 a.m., Paulo Lieuthier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130161/
> ---
> 
> (Updated June 18, 2017, 11:09 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This was done mostly using regex, and now KDebug is no longer needed to link 
> the protocols.
> 
> Pull from here: 
> https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging
> 
> 
> Diffs
> -
> 
>   protocols/bonjour/CMakeLists.txt ebe86af6a 
>   protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
>   protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
>   protocols/bonjour/bonjourcontact.cpp 0bb91e703 
>   protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
>   protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
>   protocols/bonjour/bonjourprotocol.cpp fb265f2af 
>   protocols/gadu/CMakeLists.txt 4734b6258 
>   protocols/gadu/gaduaccount.cpp 830016eb1 
>   protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
>   protocols/gadu/gaducommands.cpp 94d4b5bc7 
>   protocols/gadu/gaducontact.h cacc598c9 
>   protocols/gadu/gaducontact.cpp 3ebb270bb 
>   protocols/gadu/gaducontactlist.cpp e80025cce 
>   protocols/gadu/gadudcc.cpp 19bef1a4d 
>   protocols/gadu/gadudccserver.cpp 85d26b1aa 
>   protocols/gadu/gadudcctransaction.cpp 27d501867 
>   protocols/gadu/gadueditaccount.cpp 21e111545 
>   protocols/gadu/gadueditcontact.cpp 691acb1e6 
>   protocols/gadu/gaduprotocol.cpp 4c102f6a2 
>   protocols/gadu/gadupubdir.h 45761facd 
>   protocols/gadu/gadupubdir.cpp c73fa0741 
>   protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
>   protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
>   protocols/gadu/gadusession.cpp 4b9d02747 
>   protocols/groupwise/CMakeLists.txt 33f7e435e 
>   protocols/groupwise/gwaccount.cpp 43220e984 
>   protocols/groupwise/gwbytestream.cpp 0ae83090c

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-18 Thread Laurent Montel 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103341
---




protocols/gadu/gaduaccount.cpp (line 284)


it's not debug categories changes no ?:)



protocols/gadu/gaduaccount.cpp (line 321)


same here etc.



protocols/gadu/gaduaccount.cpp (line 321)


same here etc.



protocols/gadu/gaduaccount.cpp (line 1034)


same here



protocols/gadu/gaduaccount.cpp (line 1077)


same here



protocols/jabber/jabberformtranslator.cpp (line 23)


Why ? why rename include file ?



protocols/jabber/jingle/jinglecontentdialog.cpp (line 20)


same here



protocols/jabber/ui/dlgahcommand.cpp (line 22)


same here...



protocols/yahoo/libkyahoo/alivetask.cpp 


you removed all debug ?



protocols/yahoo/libkyahoo/receivefiletask.cpp 


Why removed all debug ?



protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp (line 22)


why renamed it ?


- Laurent Montel


On June 18, 2017, 2:09 p.m., Paulo Lieuthier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130161/
> ---
> 
> (Updated June 18, 2017, 2:09 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This was done mostly using regex, and now KDebug is no longer needed to link 
> the protocols.
> 
> Pull from here: 
> https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging
> 
> 
> Diffs
> -
> 
>   protocols/bonjour/CMakeLists.txt ebe86af6a 
>   protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
>   protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
>   protocols/bonjour/bonjourcontact.cpp 0bb91e703 
>   protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
>   protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
>   protocols/bonjour/bonjourprotocol.cpp fb265f2af 
>   protocols/gadu/CMakeLists.txt 4734b6258 
>   protocols/gadu/gaduaccount.cpp 830016eb1 
>   protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
>   protocols/gadu/gaducommands.cpp 94d4b5bc7 
>   protocols/gadu/gaducontact.h cacc598c9 
>   protocols/gadu/gaducontact.cpp 3ebb270bb 
>   protocols/gadu/gaducontactlist.cpp e80025cce 
>   protocols/gadu/gadudcc.cpp 19bef1a4d 
>   protocols/gadu/gadudccserver.cpp 85d26b1aa 
>   protocols/gadu/gadudcctransaction.cpp 27d501867 
>   protocols/gadu/gadueditaccount.cpp 21e111545 
>   protocols/gadu/gadueditcontact.cpp 691acb1e6 
>   protocols/gadu/gaduprotocol.cpp 4c102f6a2 
>   protocols/gadu/gadupubdir.h 45761facd 
>   protocols/gadu/gadupubdir.cpp c73fa0741 
>   protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
>   protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
>   protocols/gadu/gadusession.cpp 4b9d02747 
>   protocols/groupwise/CMakeLists.txt 33f7e435e 
>   protocols/groupwise/gwaccount.cpp 43220e984 
>   protocols/groupwise/gwbytestream.cpp 0ae83090c 
>   protocols/groupwise/gwconnector.cpp 1677fe3bc 
>   protocols/groupwise/gwcontact.cpp 831af63c6 
>   protocols/groupwise/gwcontactlist.cpp a54773588 
>   protocols/groupwise/gwmessagemanager.cpp 9075a7014 
>   protocols/groupwise/gwprotocol.cpp 8251921f3 
>   protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
>   protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
>   protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
>   protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
>   protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
>   protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
>   protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
>   protocols/groupwise/libgroupwise/gwerror.h 31d576902 
>   protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 
>   protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 
>   protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 
>   protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 
>   protocols/groupwise/libgroupwise/rtf2html.h 53952c694 
>   protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa 
>   protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e 
>

Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-18 Thread Paulo Lieuthier 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103338
---



I'm not sure if you wanted all of this, but now here it is.

- Paulo Lieuthier


On June 18, 2017, 11:09 a.m., Paulo Lieuthier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130161/
> ---
> 
> (Updated June 18, 2017, 11:09 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This was done mostly using regex, and now KDebug is no longer needed to link 
> the protocols.
> 
> Pull from here: 
> https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging
> 
> 
> Diffs
> -
> 
>   protocols/bonjour/CMakeLists.txt ebe86af6a 
>   protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
>   protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
>   protocols/bonjour/bonjourcontact.cpp 0bb91e703 
>   protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
>   protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
>   protocols/bonjour/bonjourprotocol.cpp fb265f2af 
>   protocols/gadu/CMakeLists.txt 4734b6258 
>   protocols/gadu/gaduaccount.cpp 830016eb1 
>   protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
>   protocols/gadu/gaducommands.cpp 94d4b5bc7 
>   protocols/gadu/gaducontact.h cacc598c9 
>   protocols/gadu/gaducontact.cpp 3ebb270bb 
>   protocols/gadu/gaducontactlist.cpp e80025cce 
>   protocols/gadu/gadudcc.cpp 19bef1a4d 
>   protocols/gadu/gadudccserver.cpp 85d26b1aa 
>   protocols/gadu/gadudcctransaction.cpp 27d501867 
>   protocols/gadu/gadueditaccount.cpp 21e111545 
>   protocols/gadu/gadueditcontact.cpp 691acb1e6 
>   protocols/gadu/gaduprotocol.cpp 4c102f6a2 
>   protocols/gadu/gadupubdir.h 45761facd 
>   protocols/gadu/gadupubdir.cpp c73fa0741 
>   protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
>   protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
>   protocols/gadu/gadusession.cpp 4b9d02747 
>   protocols/groupwise/CMakeLists.txt 33f7e435e 
>   protocols/groupwise/gwaccount.cpp 43220e984 
>   protocols/groupwise/gwbytestream.cpp 0ae83090c 
>   protocols/groupwise/gwconnector.cpp 1677fe3bc 
>   protocols/groupwise/gwcontact.cpp 831af63c6 
>   protocols/groupwise/gwcontactlist.cpp a54773588 
>   protocols/groupwise/gwmessagemanager.cpp 9075a7014 
>   protocols/groupwise/gwprotocol.cpp 8251921f3 
>   protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
>   protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
>   protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
>   protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
>   protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
>   protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
>   protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
>   protocols/groupwise/libgroupwise/gwerror.h 31d576902 
>   protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 
>   protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 
>   protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 
>   protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 
>   protocols/groupwise/libgroupwise/rtf2html.h 53952c694 
>   protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa 
>   protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e 
>   protocols/groupwise/libgroupwise/tasks/getchatsearchresultstask.cpp 
> a6432353c 
>   protocols/groupwise/libgroupwise/tasks/logintask.cpp 756c662d6 
>   protocols/groupwise/libgroupwise/tasks/searchchattask.cpp f597721b4 
>   protocols/groupwise/libgroupwise/tasks/searchusertask.cpp 9f8614472 
>   protocols/groupwise/libgroupwise/tests/clientstream_test.cpp 24a07ecd9 
>   protocols/groupwise/libgroupwise/userdetailsmanager.cpp 2850c0d65 
>   protocols/groupwise/ui/gwaddcontactpage.cpp 2c1b8b084 
>   protocols/groupwise/ui/gwchatpropsdialog.cpp 138f38016 
>   protocols/groupwise/ui/gwchatsearchdialog.cpp c5719c8d6 
>   protocols/groupwise/ui/gwcontactproperties.cpp ed7ff4fa5 
>   protocols/groupwise/ui/gweditaccountwidget.cpp a48351383 
>   protocols/groupwise/ui/gwprivacydialog.cpp 8dd11f1ab 
>   protocols/groupwise/ui/gwsearch.cpp 50a15730d 
>   protocols/jabber/CMakeLists.txt 6ea47b82e 
>   protocols/jabber/jabberaccount.cpp 4829934b6 
>   protocols/jabber/jabberbasecontact.cpp 658875e05 
>   protocols/jabber/jabberbookmarks.cpp efe9e40d2 
>   protocols/jabber/jabbercapabilitiesmanager.cpp 4afc5489d 
>   protocols/jabber/jabberchatsession.cpp 0aa3c852d 
>   protocols/jabber/jabberclient.cpp 33c4873e2 
>   protocols/jabber/jabbercontact.cpp bc7794175 
>   protocols/jabber/jabbercontactpool.cpp e0ce7b0f1 
>   protocols/jabber/jabberfiletransfer.cpp db47cc701

Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

2017-06-18 Thread Paulo Lieuthier 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/
---

Review request for Kopete, Laurent Montel and Pali Rohár.


Repository: kopete


Description
---

This was done mostly using regex, and now KDebug is no longer needed to link 
the protocols.

Pull from here: 
https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging


Diffs
-

  protocols/bonjour/CMakeLists.txt ebe86af6a 
  protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
  protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
  protocols/bonjour/bonjourcontact.cpp 0bb91e703 
  protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
  protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
  protocols/bonjour/bonjourprotocol.cpp fb265f2af 
  protocols/gadu/CMakeLists.txt 4734b6258 
  protocols/gadu/gaduaccount.cpp 830016eb1 
  protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
  protocols/gadu/gaducommands.cpp 94d4b5bc7 
  protocols/gadu/gaducontact.h cacc598c9 
  protocols/gadu/gaducontact.cpp 3ebb270bb 
  protocols/gadu/gaducontactlist.cpp e80025cce 
  protocols/gadu/gadudcc.cpp 19bef1a4d 
  protocols/gadu/gadudccserver.cpp 85d26b1aa 
  protocols/gadu/gadudcctransaction.cpp 27d501867 
  protocols/gadu/gadueditaccount.cpp 21e111545 
  protocols/gadu/gadueditcontact.cpp 691acb1e6 
  protocols/gadu/gaduprotocol.cpp 4c102f6a2 
  protocols/gadu/gadupubdir.h 45761facd 
  protocols/gadu/gadupubdir.cpp c73fa0741 
  protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
  protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
  protocols/gadu/gadusession.cpp 4b9d02747 
  protocols/groupwise/CMakeLists.txt 33f7e435e 
  protocols/groupwise/gwaccount.cpp 43220e984 
  protocols/groupwise/gwbytestream.cpp 0ae83090c 
  protocols/groupwise/gwconnector.cpp 1677fe3bc 
  protocols/groupwise/gwcontact.cpp 831af63c6 
  protocols/groupwise/gwcontactlist.cpp a54773588 
  protocols/groupwise/gwmessagemanager.cpp 9075a7014 
  protocols/groupwise/gwprotocol.cpp 8251921f3 
  protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
  protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
  protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
  protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
  protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
  protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
  protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
  protocols/groupwise/libgroupwise/gwerror.h 31d576902 
  protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 
  protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 
  protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 
  protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 
  protocols/groupwise/libgroupwise/rtf2html.h 53952c694 
  protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa 
  protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e 
  protocols/groupwise/libgroupwise/tasks/getchatsearchresultstask.cpp a6432353c 
  protocols/groupwise/libgroupwise/tasks/logintask.cpp 756c662d6 
  protocols/groupwise/libgroupwise/tasks/searchchattask.cpp f597721b4 
  protocols/groupwise/libgroupwise/tasks/searchusertask.cpp 9f8614472 
  protocols/groupwise/libgroupwise/tests/clientstream_test.cpp 24a07ecd9 
  protocols/groupwise/libgroupwise/userdetailsmanager.cpp 2850c0d65 
  protocols/groupwise/ui/gwaddcontactpage.cpp 2c1b8b084 
  protocols/groupwise/ui/gwchatpropsdialog.cpp 138f38016 
  protocols/groupwise/ui/gwchatsearchdialog.cpp c5719c8d6 
  protocols/groupwise/ui/gwcontactproperties.cpp ed7ff4fa5 
  protocols/groupwise/ui/gweditaccountwidget.cpp a48351383 
  protocols/groupwise/ui/gwprivacydialog.cpp 8dd11f1ab 
  protocols/groupwise/ui/gwsearch.cpp 50a15730d 
  protocols/jabber/CMakeLists.txt 6ea47b82e 
  protocols/jabber/jabberaccount.cpp 4829934b6 
  protocols/jabber/jabberbasecontact.cpp 658875e05 
  protocols/jabber/jabberbookmarks.cpp efe9e40d2 
  protocols/jabber/jabbercapabilitiesmanager.cpp 4afc5489d 
  protocols/jabber/jabberchatsession.cpp 0aa3c852d 
  protocols/jabber/jabberclient.cpp 33c4873e2 
  protocols/jabber/jabbercontact.cpp bc7794175 
  protocols/jabber/jabbercontactpool.cpp e0ce7b0f1 
  protocols/jabber/jabberfiletransfer.cpp db47cc701 
  protocols/jabber/jabberformtranslator.cpp 7172fa794 
  protocols/jabber/jabbergroupchatmanager.cpp 2347fd2da 
  protocols/jabber/jabbergroupcontact.cpp 5f764bbad 
  protocols/jabber/jabbergroupmembercontact.cpp 57ee80e38 
  protocols/jabber/jabberprotocol.cpp e5dfecd1d 
  protocols/jabber/jabberresource.cpp 0a5c34c0e 
  protocols/jabber/jabberresourcepool.cpp 1619cce38 
  protocols/jabber/jabbertransport.cpp e3a98e858 
  protocols/jabber/jabberxdatawidget.cpp cb35854d9 
  protocols/jabber/jingle/alsaio.cpp cfcb9538e 
  protocols/jabber/jingle/jabberjinglecontent.cpp a831e9818