Re: Review Request 130225: Added autotests for kopete chat window

2017-10-15 Thread Luigi Toscano

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130225/#review103818
---



It seems to fail for me (I had to tweak tests/kopete/CMakeLists.txt to make it 
compile, but I don't think thats the issue)

- Luigi Toscano


On Ago. 13, 2017, 12:23 a.m., Vijay Krishnavanshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130225/
> ---
> 
> (Updated Ago. 13, 2017, 12:23 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This autotest attempts to tets the kopete chat window style. But one issue 
> that I am facing is that it looks for style in  
> QStandardPaths::DataLocation/styles for styles but I want to change it to the 
> current CMAKE_SOURCE_DIR.
> 
> 
> Diffs
> -
> 
>   tests/kopete/CMakeLists.txt 2f9b0db 
>   tests/kopete/kopetechatwindowtest.cpp PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Info.plist PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Header.html PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Incoming/Content.html 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Incoming/NextContent.html 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/Content.html 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/NextContent.html 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Status.html PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant1.css 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant2.css 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/main.css PRE-CREATION 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130225/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vijay Krishnavanshi
> 
>



Re: Review Request 130225: Added autotests for kopete chat window

2017-10-08 Thread Laurent Montel

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130225/#review103811
---


Ship it!




Ship It!

- Laurent Montel


On août 12, 2017, 10:23 après-midi, Vijay Krishnavanshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130225/
> ---
> 
> (Updated août 12, 2017, 10:23 après-midi)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> This autotest attempts to tets the kopete chat window style. But one issue 
> that I am facing is that it looks for style in  
> QStandardPaths::DataLocation/styles for styles but I want to change it to the 
> current CMAKE_SOURCE_DIR.
> 
> 
> Diffs
> -
> 
>   tests/kopete/CMakeLists.txt 2f9b0db 
>   tests/kopete/kopetechatwindowtest.cpp PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Info.plist PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Header.html PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Incoming/Content.html 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Incoming/NextContent.html 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/Content.html 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Outgoing/NextContent.html 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Status.html PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant1.css 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/Variants/Variant2.css 
> PRE-CREATION 
>   tests/kopete/styles/TestStyle/Contents/Resources/main.css PRE-CREATION 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130225/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vijay Krishnavanshi
> 
>