Re: Review Request 124345: Use treeWidgets instead of listviews in libkopete accountSelector

2015-07-20 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/ --- (Updated July 20, 2015, 7 p.m.) Review request for Kopete, Laurent

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-20 Thread R.Harish Navnit
On July 15, 2015, 10:08 a.m., Laurent Montel wrote: When I read doc I see: * @deprecated Use QLabel. (QLabel::setOpenExternalLinks(true) for labels with hyperlinks; * QLabel::setTextInteractionFlags(Qt::TextSelectableByMouse|Qt::TextSelectableByKeyboard) for labels whose text

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-20 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/ --- (Updated July 20, 2015, 7:31 p.m.) Review request for Kopete, Laurent

Re: Review Request 124227: Remove Q3ListViews from autoreplace

2015-07-20 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/ --- (Updated July 20, 2015, 10:48 p.m.) Review request for Kopete, Laurent

Re: Review Request 124349: Remove kde3 dependencies from gadu protocol

2015-07-20 Thread R.Harish Navnit
On July 15, 2015, 10:13 a.m., Laurent Montel wrote: protocols/gadu/gadueditcontact.cpp, line 111 https://git.reviewboard.kde.org/r/124349/diff/1/?file=385399#file385399line111 So item which is not selectable and disable ? The default value for flags is { Qt::ItemIsSelectable |

Re: Review Request 124345: Use treeWidgets instead of listviews in libkopete accountSelector

2015-07-20 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124345/#review82724 --- libkopete/ui/accountselector.cpp (line 127)

NO_CAST policy for new kopete code

2015-07-20 Thread Pali Rohár
Hello, I would be happy if Kopete could be compiled with defines: -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_TO_ASCII It disables automatic conversion between C strings char* (which are in unknown/any encoding) and QString (which is unicode). It prevents that mess of 8bit encodings (Utf-8, Latin1,

Re: Review Request 124227: Remove Q3ListViews from autoreplace

2015-07-20 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124227/#review82722 --- plugins/autoreplace/autoreplacepreferences.cpp (line 119)

Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

2015-07-20 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124344/#review82723 --- Ship it! Seems ok. Ship it - Laurent Montel On juil. 20,

Re: NO_CAST policy for new kopete code

2015-07-20 Thread kaushik
On 20 July 2015 at 15:45, Pali Rohár pali.ro...@gmail.com wrote: Hello, I would be happy if Kopete could be compiled with defines: -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_TO_ASCII It disables automatic conversion between C strings char* (which are in unknown/any encoding) and QString (which