Re: [Ksecretservice-devel] Review Request 119969: Port from ksecretsservicemacros.h to ksecrets_export.h
> On Oct. 1, 2014, 1:46 p.m., Valentin Rusu wrote: > > Ship It! > > Valentin Rusu wrote: > Heya, did you commit this change? > > Alexander Volkov wrote: > I can't commit, I have no contributor account. > > Valentin Rusu wrote: > You can ask for one by filing a bug to the sysadmin. Interested? Sure, may I mention you as a supporter? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119969/#review67759 --- On Aug. 28, 2014, 2:38 p.m., Alexander Volkov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119969/ > --- > > (Updated Aug. 28, 2014, 2:38 p.m.) > > > Review request for KSecretService. > > > Repository: ksecrets > > > Description > --- > > ksecrets_export.h is already generated and it's preferable to use it. > > > Diffs > - > > src/api/ksecrets/ksecretsservicecollectionjobs.h beb6082 > src/api/ksecrets/ksecretsserviceitem.h d35a96e > src/api/ksecrets/ksecretsserviceitemjobs.h e673485 > src/api/ksecrets/ksecretsservicemacros.h 877353a > src/api/ksecrets/ksecretsservicesecret.h d91a617 > src/api/ksecrets/ksecretsservicecodec.h d5edb8a > src/api/ksecrets/ksecretsservicecollection.h bbc3140 > > Diff: https://git.reviewboard.kde.org/r/119969/diff/ > > > Testing > --- > > > Thanks, > > Alexander Volkov > > ___ Ksecretservice-devel mailing list Ksecretservice-devel@kde.org https://mail.kde.org/mailman/listinfo/ksecretservice-devel
Re: [Ksecretservice-devel] Review Request 119969: Port from ksecretsservicemacros.h to ksecrets_export.h
> On Oct. 1, 2014, 9:46 a.m., Valentin Rusu wrote: > > Ship It! > > Valentin Rusu wrote: > Heya, did you commit this change? > > Alexander Volkov wrote: > I can't commit, I have no contributor account. You can ask for one by filing a bug to the sysadmin. Interested? - Valentin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119969/#review67759 --- On Aug. 28, 2014, 10:38 a.m., Alexander Volkov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119969/ > --- > > (Updated Aug. 28, 2014, 10:38 a.m.) > > > Review request for KSecretService. > > > Repository: ksecrets > > > Description > --- > > ksecrets_export.h is already generated and it's preferable to use it. > > > Diffs > - > > src/api/ksecrets/ksecretsservicecollectionjobs.h beb6082 > src/api/ksecrets/ksecretsserviceitem.h d35a96e > src/api/ksecrets/ksecretsserviceitemjobs.h e673485 > src/api/ksecrets/ksecretsservicemacros.h 877353a > src/api/ksecrets/ksecretsservicesecret.h d91a617 > src/api/ksecrets/ksecretsservicecodec.h d5edb8a > src/api/ksecrets/ksecretsservicecollection.h bbc3140 > > Diff: https://git.reviewboard.kde.org/r/119969/diff/ > > > Testing > --- > > > Thanks, > > Alexander Volkov > > ___ Ksecretservice-devel mailing list Ksecretservice-devel@kde.org https://mail.kde.org/mailman/listinfo/ksecretservice-devel
Re: [Ksecretservice-devel] Review Request 119969: Port from ksecretsservicemacros.h to ksecrets_export.h
> On Oct. 1, 2014, 1:46 p.m., Valentin Rusu wrote: > > Ship It! > > Valentin Rusu wrote: > Heya, did you commit this change? I can't commit, I have no contributor account. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119969/#review67759 --- On Aug. 28, 2014, 2:38 p.m., Alexander Volkov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119969/ > --- > > (Updated Aug. 28, 2014, 2:38 p.m.) > > > Review request for KSecretService. > > > Repository: ksecrets > > > Description > --- > > ksecrets_export.h is already generated and it's preferable to use it. > > > Diffs > - > > src/api/ksecrets/ksecretsservicecollectionjobs.h beb6082 > src/api/ksecrets/ksecretsserviceitem.h d35a96e > src/api/ksecrets/ksecretsserviceitemjobs.h e673485 > src/api/ksecrets/ksecretsservicemacros.h 877353a > src/api/ksecrets/ksecretsservicesecret.h d91a617 > src/api/ksecrets/ksecretsservicecodec.h d5edb8a > src/api/ksecrets/ksecretsservicecollection.h bbc3140 > > Diff: https://git.reviewboard.kde.org/r/119969/diff/ > > > Testing > --- > > > Thanks, > > Alexander Volkov > > ___ Ksecretservice-devel mailing list Ksecretservice-devel@kde.org https://mail.kde.org/mailman/listinfo/ksecretservice-devel
Re: [Ksecretservice-devel] Review Request 119969: Port from ksecretsservicemacros.h to ksecrets_export.h
> On Oct. 1, 2014, 9:46 a.m., Valentin Rusu wrote: > > Ship It! Heya, did you commit this change? - Valentin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119969/#review67759 --- On Aug. 28, 2014, 10:38 a.m., Alexander Volkov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119969/ > --- > > (Updated Aug. 28, 2014, 10:38 a.m.) > > > Review request for KSecretService. > > > Repository: ksecrets > > > Description > --- > > ksecrets_export.h is already generated and it's preferable to use it. > > > Diffs > - > > src/api/ksecrets/ksecretsservicecollectionjobs.h beb6082 > src/api/ksecrets/ksecretsserviceitem.h d35a96e > src/api/ksecrets/ksecretsserviceitemjobs.h e673485 > src/api/ksecrets/ksecretsservicemacros.h 877353a > src/api/ksecrets/ksecretsservicesecret.h d91a617 > src/api/ksecrets/ksecretsservicecodec.h d5edb8a > src/api/ksecrets/ksecretsservicecollection.h bbc3140 > > Diff: https://git.reviewboard.kde.org/r/119969/diff/ > > > Testing > --- > > > Thanks, > > Alexander Volkov > > ___ Ksecretservice-devel mailing list Ksecretservice-devel@kde.org https://mail.kde.org/mailman/listinfo/ksecretservice-devel
Re: [Ksecretservice-devel] Review Request 119969: Port from ksecretsservicemacros.h to ksecrets_export.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119969/#review67759 --- Ship it! Ship It! - Valentin Rusu On Aug. 28, 2014, 10:38 a.m., Alexander Volkov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119969/ > --- > > (Updated Aug. 28, 2014, 10:38 a.m.) > > > Review request for KSecretService. > > > Repository: ksecrets > > > Description > --- > > ksecrets_export.h is already generated and it's preferable to use it. > > > Diffs > - > > src/api/ksecrets/ksecretsservicecollectionjobs.h beb6082 > src/api/ksecrets/ksecretsserviceitem.h d35a96e > src/api/ksecrets/ksecretsserviceitemjobs.h e673485 > src/api/ksecrets/ksecretsservicemacros.h 877353a > src/api/ksecrets/ksecretsservicesecret.h d91a617 > src/api/ksecrets/ksecretsservicecodec.h d5edb8a > src/api/ksecrets/ksecretsservicecollection.h bbc3140 > > Diff: https://git.reviewboard.kde.org/r/119969/diff/ > > > Testing > --- > > > Thanks, > > Alexander Volkov > > ___ Ksecretservice-devel mailing list Ksecretservice-devel@kde.org https://mail.kde.org/mailman/listinfo/ksecretservice-devel
