[ksh93-integration-discuss] ksh93 update1 codereview, Dec 15th

2008-12-16 Thread Jennifer Pioch 
On 12/15/08, April Chin  wrote:
> Here are hopefully the final changes for ksh93 update1.
>
>  An incremental webrev from the Dec 4th review is at:
> http://cr.opensolaris.org/~chin/ksh93-update1.non-ast.dec4-vs-dec15/
>
>  A full webrev of the Solaris file changes is at:
> http://cr.opensolaris.org/~chin/ksh93-update1.non-ast.dec15/
>
>  These changes include fixes to the last code review comments:
>
>  - Removed non-substantive changes (CDDL or ident line only) to the
>   files cited by James Carlson:
>   - usr/src/Makefile.ksh93switch
>   - usr/src/lib/libcmd//Makefile (4 files)
>
>  - Removed "cmd/sum" entry from usr/src/Makefile.lint.
>   These changes were already reviewed on Dec 6th
>
>  - Removal of ident line to a changed file:
>   usr/src/pkgdefs/SUNWcsu/prototype_i386
>
>  - Addition of the ksh93 license to SUNWosdem (demo files) and
>   addition of missing license entries to SUNWcsl, for
>   /usr/lib/{libast,libcmd,libdll,libshell,libsum}.so.1 (only
>   libshell and libdll entries were already present).
>
>   These changes now follow the rules in this flag day from April 2008:
>   http://opensolaris.org/os/community/on/flag-days/pages/2008041102/
>
>   An off-line discussion with Mark J. Nelson and Bonnie Corwin concluded
>   that the SUNWhea (header files) and SUNW0on (message files) packages
>   do not require the third party licenses.
>
>   Mark J. Nelson has reviewed these license changes to:
>
>   - usr/src/SUNWcsl/Makefile
>   - usr/src/SUWNosdem/Makefile
>
>  Thanks,
>
> April
>
>

I've reviewed 
http://cr.opensolaris.org/~chin/ksh93-update1.non-ast.dec4-vs-dec15/
and the changes look good to me.

Jenny
-- 
Jennifer Pioch, Uni Frankfurt

[ksh93-integration-discuss] ksh93 update1 codereview, Dec 15th

2008-12-15 Thread I. Szczesniak 
The changes look good to me.

Irek

On 12/15/08, April Chin  wrote:
> Here are hopefully the final changes for ksh93 update1.
>
>  An incremental webrev from the Dec 4th review is at:
> http://cr.opensolaris.org/~chin/ksh93-update1.non-ast.dec4-vs-dec15/
>
>  A full webrev of the Solaris file changes is at:
> http://cr.opensolaris.org/~chin/ksh93-update1.non-ast.dec15/
>
>  These changes include fixes to the last code review comments:
>
>  - Removed non-substantive changes (CDDL or ident line only) to the
>   files cited by James Carlson:
>   - usr/src/Makefile.ksh93switch
>   - usr/src/lib/libcmd//Makefile (4 files)
>
>  - Removed "cmd/sum" entry from usr/src/Makefile.lint.
>   These changes were already reviewed on Dec 6th
>
>  - Removal of ident line to a changed file:
>   usr/src/pkgdefs/SUNWcsu/prototype_i386
>
>  - Addition of the ksh93 license to SUNWosdem (demo files) and
>   addition of missing license entries to SUNWcsl, for
>   /usr/lib/{libast,libcmd,libdll,libshell,libsum}.so.1 (only
>   libshell and libdll entries were already present).
>
>   These changes now follow the rules in this flag day from April 2008:
>   http://opensolaris.org/os/community/on/flag-days/pages/2008041102/
>
>   An off-line discussion with Mark J. Nelson and Bonnie Corwin concluded
>   that the SUNWhea (header files) and SUNW0on (message files) packages
>   do not require the third party licenses.
>
>   Mark J. Nelson has reviewed these license changes to:
>
>   - usr/src/SUNWcsl/Makefile
>   - usr/src/SUWNosdem/Makefile
>
>  Thanks,
>
> April
>
>

[ksh93-integration-discuss] ksh93 update1 codereview, Dec 15th

2008-12-15 Thread James Carlson 
April Chin writes:
> An incremental webrev from the Dec 4th review is at:
>   http://cr.opensolaris.org/~chin/ksh93-update1.non-ast.dec4-vs-dec15/

I looked this over; the changes look fine to me.

-- 
James Carlson, Solaris Networking  
Sun Microsystems / 35 Network Drive71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677

[ksh93-integration-discuss] ksh93 update1 codereview, Dec 15th

2008-12-15 Thread April Chin 
Thank you everyone for the code reviews!
We're doing final testing and hope to integrate into build 106.

April

[ksh93-integration-discuss] ksh93 update1 codereview, Dec 15th

2008-12-15 Thread April Chin 
Here are hopefully the final changes for ksh93 update1.

An incremental webrev from the Dec 4th review is at:
http://cr.opensolaris.org/~chin/ksh93-update1.non-ast.dec4-vs-dec15/

A full webrev of the Solaris file changes is at:
http://cr.opensolaris.org/~chin/ksh93-update1.non-ast.dec15/

These changes include fixes to the last code review comments:

- Removed non-substantive changes (CDDL or ident line only) to the
  files cited by James Carlson:
  - usr/src/Makefile.ksh93switch
  - usr/src/lib/libcmd//Makefile (4 files)
  
- Removed "cmd/sum" entry from usr/src/Makefile.lint.
  These changes were already reviewed on Dec 6th
  
- Removal of ident line to a changed file:
  usr/src/pkgdefs/SUNWcsu/prototype_i386
  
- Addition of the ksh93 license to SUNWosdem (demo files) and
  addition of missing license entries to SUNWcsl, for
  /usr/lib/{libast,libcmd,libdll,libshell,libsum}.so.1 (only
  libshell and libdll entries were already present).
  
  These changes now follow the rules in this flag day from April 2008:
  http://opensolaris.org/os/community/on/flag-days/pages/2008041102/
  
  An off-line discussion with Mark J. Nelson and Bonnie Corwin concluded
  that the SUNWhea (header files) and SUNW0on (message files) packages
  do not require the third party licenses.
  
  Mark J. Nelson has reviewed these license changes to:
  
  - usr/src/SUNWcsl/Makefile
  - usr/src/SUWNosdem/Makefile
  
Thanks,
April