From: Avi Kivity [EMAIL PROTECTED]
Set operand type and size to get correct writeback behavior.
Signed-off-by: Avi Kivity [EMAIL PROTECTED]
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index 72ae86b..e8c87cc 100644
--- a/arch/x86/kvm/x86_emulate.c
+++
From: Xiantao Zhang [EMAIL PROTECTED]
Use TARGET_I386 to exclude other archs.
Signed-off-by: Xiantao Zhang [EMAIL PROTECTED]
Signed-off-by: Avi Kivity [EMAIL PROTECTED]
diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c
index cf0e85d..b6c8288 100644
--- a/qemu/qemu-kvm.c
+++ b/qemu/qemu-kvm.c
@@
From: Mark McLoughlin [EMAIL PROTECTED]
add_assigned_device() returns a pointer, so don't check the return
value is less than zero.
Signed-off-by: Mark McLoughlin [EMAIL PROTECTED]
Signed-off-by: Avi Kivity [EMAIL PROTECTED]
diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c
index 37f2de7..c0ac9eb
From: Mark McLoughlin [EMAIL PROTECTED]
Merge two copies of the same code and cleanup with no functional
changes.
Signed-off-by: Mark McLoughlin [EMAIL PROTECTED]
Signed-off-by: Avi Kivity [EMAIL PROTECTED]
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index
From: Mark McLoughlin [EMAIL PROTECTED]
Undo the effects of assigned_dev_register_regions(); made
unneccessarily difficult by the twisty data structures.
Signed-off-by: Mark McLoughlin [EMAIL PROTECTED]
Signed-off-by: Avi Kivity [EMAIL PROTECTED]
diff --git a/qemu/hw/device-assignment.c
From: Mark McLoughlin [EMAIL PROTECTED]
It's standard practice in qemu to exit if command line parameter
fails, so do that here too.
Signed-off-by: Mark McLoughlin [EMAIL PROTECTED]
Signed-off-by: Avi Kivity [EMAIL PROTECTED]
diff --git a/qemu/hw/device-assignment.c
From: Mark McLoughlin [EMAIL PROTECTED]
Signed-off-by: Mark McLoughlin [EMAIL PROTECTED]
Signed-off-by: Avi Kivity [EMAIL PROTECTED]
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index a6c292f..7f4c67d 100644
--- a/qemu/hw/device-assignment.c
+++
From: Mark McLoughlin [EMAIL PROTECTED]
Associate the AssignedDevice with the AssignedDevInfo as soon as
we have allocated it and don't try and free it in init_assigned_device()
if an error occurs.
This ensures that the mmio region is unmapped by free_assigned_device()
if init_assigned_device()
From: Mark McLoughlin [EMAIL PROTECTED]
If kvm_assign_pci_device(), there's no need for us to print
two lines of error messages. The string translation of errno
is very useful though, so include that in the message using
strerror().
Signed-off-by: Mark McLoughlin [EMAIL PROTECTED]
Signed-off-by:
From: Hannes Eder [EMAIL PROTECTED]
Impact: make global function static
virt/kvm/kvm_main.c:85:6: warning: symbol 'kvm_rebooting' was not declared.
Should it be static?
Signed-off-by: Hannes Eder [EMAIL PROTECTED]
Signed-off-by: Avi Kivity [EMAIL PROTECTED]
diff --git a/virt/kvm/kvm_main.c
Abhishek Saksena wrote:
Hi,
I am using kvm-79 and see some issues while trying to build/run some
tests ( located in /kvm-79/user/test/x86 directory)
1)The first test I try to build is irq.flat from /kvm-79/user directory
make test/x86/irq.flat
the test build
Linus, please pull some kvm fixes from repo and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git kvm-updates/2.6.28
There are a couple of fixes for the out-of-sync mmu, a fix for a lost irq
while injecting an nmi (which causes guests with an nmi watchdog to hang),
as well
Joerg Roedel wrote:
On Thu, Nov 27, 2008 at 06:32:56PM +0200, Avi Kivity wrote:
Joerg Roedel wrote:
Impace: file renamed
impact?
Yeah, patches for x86 should have such a line in the description. I just
added it here too because of the many x86-patches I did in the
Hannes Eder wrote:
Impact: make global function static
arch/x86/kvm/vmx.c:134:3: warning: symbol 'vmx_capability' was not declared.
Should it be static?
Applied, thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line
Hannes Eder wrote:
Impact: make global function static
virt/kvm/kvm_main.c:85:6: warning: symbol 'kvm_rebooting' was not declared.
Should it be static?
Applied, thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line
Mark McLoughlin wrote:
Allow kvm_free_irq_source_id() to be called with a zero ID.
Zero is reserved for KVM_USERSPACE_IRQ_SOURCE_ID, so we can
guarantee that kvm_request_irq_source_id() will never return
zero and use zero to indicate no source ID allocated.
Zero is a legal value for irq
Mark McLoughlin wrote:
Hi Avi,
Sorry ... forgot to 'git send-email --compose' :-)
The patchset is just a bunch of fixes to the device-assignment error
handling code. Shouldn't be anything too controversial there.
No, all applied. Patch 2 looks like two patches munged together; I
applied
John Rousseau wrote:
-perror(assigned_dev_update_irq);
-fprintf(stderr, Are you assigning a device
-that shares IRQ with some other device?\n);
+fprintf(stderr, Failed to assign irq for \%s\:
%s\n,
+
I don't think the first one works without the second. Calling getcpu()
on startup is meaningless since the initial placement doesn't take the
Who said anything about startup? The idea behind getcpu() is to call
it every time you allocate someting.
Anyways it's not ideal either, but in my
Andi Kleen wrote:
I don't think the first one works without the second. Calling getcpu()
on startup is meaningless since the initial placement doesn't take the
Who said anything about startup? The idea behind getcpu() is to call
it every time you allocate someting.
Qemu only
On Sun, Nov 30, 2008 at 05:38:34PM +0200, Avi Kivity wrote:
Andi Kleen wrote:
I don't think the first one works without the second. Calling getcpu()
on startup is meaningless since the initial placement doesn't take the
Who said anything about startup? The idea behind getcpu() is to
Andi Kleen wrote:
Please explain. When would you call getcpu() and what would you do at
that time?
When the guest allocates on the node of its current CPU get memory on
the node pool getcpu() tells you it is running on. More tricky
is handling guest explicitely accessing other node for
On Sun, Nov 30, 2008 at 06:38:14PM +0200, Avi Kivity wrote:
The guest allocates when it touches the page for the first time. This
means very little since all of memory may be touched during guest bootup
or shortly afterwards. Even if not, it is still a one-time operation,
and any choices
Andi Kleen wrote:
On Sun, Nov 30, 2008 at 06:38:14PM +0200, Avi Kivity wrote:
The guest allocates when it touches the page for the first time. This
means very little since all of memory may be touched during guest bootup
or shortly afterwards. Even if not, it is still a one-time
On Sun, Nov 30, 2008 at 07:11:40PM +0200, Avi Kivity wrote:
Andi Kleen wrote:
On Sun, Nov 30, 2008 at 06:38:14PM +0200, Avi Kivity wrote:
The guest allocates when it touches the page for the first time. This
means very little since all of memory may be touched during guest bootup
or
Andi Kleen wrote:
I was more thinking about some heuristics that checks when a page
is first mapped into user space. The only problem is that it is zeroed
through the direct mapping before, but perhaps there is a way around it.
That's one of the rare cases when 32bit highmem actually makes
The page is allocated at an uninteresting point in time. For example,
the boot loaded allocates a bunch of pages.
The far majority of pages are allocated when a process wants them
or the kernel uses them for file cache.
executes. First access happens somewhat later, but still we cannot
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Andi Kleen
Sent: Sunday, November 30, 2008 1:56 PM
To: Avi Kivity
Cc: Andi Kleen; Andre Przywara; kvm@vger.kernel.org
Subject: Re: [PATCH 0/3] KVM-userspace: add NUMA support for guests
The page is
Hi,
Maybe this is duplicated bug report, but since I was not able to find any
reference to it, I am reporting it anyway.
I am running 2.6.28-rc6-7-ged31348 on x86_64.
I just tried to start kvm and got the following:
[ 883.483978] [ cut here ]
[ 883.483995] kernel
Skywing wrote:
The far majority of pages are allocated when a process wants them
or the kernel uses them for file cache.
Is that not going to be fairly guest-specific? For example, Windows has a thread that
does background zeroing of unallocated pages that aren't marked as zeroed
Luis Henriques wrote:
Hi,
Maybe this is duplicated bug report, but since I was not able to find any
reference to it, I am reporting it anyway.
I am running 2.6.28-rc6-7-ged31348 on x86_64.
I just tried to start kvm and got the following:
[ 883.483978] [ cut here
On Sun, Nov 30, 2008 at 10:20:45PM +0200, Avi Kivity wrote:
Luis Henriques wrote:
Hi,
Maybe this is duplicated bug report, but since I was not able to find any
reference to it, I am reporting it anyway.
I am running 2.6.28-rc6-7-ged31348 on x86_64.
I just tried to start kvm and got
Luis Henriques wrote:
No, I was not able to reproduce the issue. Please let me know if you need some
more information on my system (.config, for instance).
Were you using some other virtualization product? Were you running
suspend/resume?
--
I have a truly marvellous patch that fixes
On Sun, Nov 30, 2008 at 10:44:55PM +0200, Avi Kivity wrote:
Luis Henriques wrote:
No, I was not able to reproduce the issue. Please let me know if you need
some
more information on my system (.config, for instance).
Were you using some other virtualization product? Were you running
On Sun, Nov 30, 2008 at 10:07:01PM +0200, Avi Kivity wrote:
Right. Allocated from the guest kernel's perspective. This may be
different from the host kernel's perspective.
Linux will delay touching memory until the last moment, Windows will not
(likely it zeros pages on their own nodes,
On Sun, Nov 23, 2008 at 09:29:48AM -0800, walt wrote:
Everything above works perfectly. I can reboot vista,
check for new updates, create user accounts, all the
normal stuff. Now comes the trouble:
#qemu-img commit vista.delta [takes 1 hour]
The facts it takes very long is fixed in
Andi Kleen wrote:
On Sun, Nov 30, 2008 at 10:07:01PM +0200, Avi Kivity wrote:
Right. Allocated from the guest kernel's perspective. This may be
different from the host kernel's perspective.
Linux will delay touching memory until the last moment, Windows will not
(likely it zeros pages
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Avi Kivity
Sent: Sunday, November 30, 2008 4:50 PM
To: Andi Kleen
Cc: Andre Przywara; kvm@vger.kernel.org
Subject: Re: [PATCH 0/3] KVM-userspace: add NUMA support for guests
Well, testing is the only way to
On Friday 28 November 2008 18:25:51 Mark McLoughlin wrote:
Hi,
I just got an oops (with 2.6.28-rc6) when running qemu-kvm -S
-pcidevice ... and immediately quitting rather than starting the guest.
The issue is that at this point ASSIGN_PCI_DEVICE has been called, but
not ASSIGN_IRQ, so
It's developed based on commit 0f7d3ee6 on avi/master, but it still can be
applied on latest avi/master (commit 90755652).
Regards,
Weidong
Joerg Roedel wrote:
Hmm, I tried to apply this patch against avi/master and linus/master
but get merge conflicts. Where do these patches apply cleanly?
40 matches
Mail list logo
