[KVM-AUTOTEST][PATCH] kvm_tests.cfg: adding some missing iso image md5sum values

2009-04-29 Thread Uri Lublin
From: Uri Lublin u...@redhat.com Signed-off-by: Uri Lublin u...@redhat.com diff --git a/client/tests/kvm_runtest_2/kvm_tests.cfg.sample b/client/tests/kvm_runtest_2/kvm_tests.cfg.sample index 22d7798..c73da7c 100644 --- a/client/tests/kvm_runtest_2/kvm_tests.cfg.sample +++

Re: [KVM PATCH v3 0/2] irqfd

2009-04-29 Thread Andrew Morton
On Mon, 27 Apr 2009 14:33:24 -0400 Gregory Haskins ghask...@novell.com wrote: (Applies to kvm.git 41b76d8d0487c26d6d4d3fe53c1ff59b3236f096) This series implements a mechanism called irqfd. It lets you create an eventfd based file-desriptor to inject interrupts to a kvm guest. We associate

Re: [PATCH] Assign the correct pci id range to virtio_pci

2009-04-29 Thread Pantelis Koukousoulas
On Tue, Apr 28, 2009 at 6:19 PM, Gerd Hoffmann kra...@redhat.com wrote:  Hi, Ok, since a day has passed with no further comments, I 'll dare to assume everyone is happy with this solution. So, here is an implementation. I 've tested locally with my driver that uses 0x10f5 and it seems to

Re: [KVM PATCH v3 0/2] irqfd

2009-04-29 Thread Avi Kivity
Andrew Morton wrote: On Mon, 27 Apr 2009 14:33:24 -0400 Gregory Haskins ghask...@novell.com wrote: (Applies to kvm.git 41b76d8d0487c26d6d4d3fe53c1ff59b3236f096) This series implements a mechanism called irqfd. It lets you create an eventfd based file-desriptor to inject interrupts to a

Re: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c

2009-04-29 Thread Jes Sorensen
Zhang, Xiantao wrote: Avi Kivity wrote: I haven't pushed this out yet, so I can apply a replacement patch. We don't need flush_icache_range here, because I believe it is called in cpu_physical_memory_write. Xiantao Hi Xiantao, Good point, I hadn't spotted that, and worse I mangled

Re: kvm-77 Excessive Disk Access causes real time clock hang!

2009-04-29 Thread Avi Kivity
Erik Rull wrote: Hi Avi, Avi Kivity wrote: interface: virtio cache: none format: raw, using a partition or logical volume What are you using? uhm, I'm not sure, I call qemu with: qemu-system-x86_64 -usb -hda /dev/hda2 -m 1536 -net nic,macaddr=$MACADDR -net tap,script=/etc/qemu-ifup

vnc protocol broken

2009-04-29 Thread Dietmar Maurer
Hi all, the new vnc code seems to be broken. At least all java based viewers have serious problems, also realvnc for X For example: # kvm -cdrom ubuntu-9.04-desktop-amd64.iso -vnc :0 vncviewer :0 CConn: Throughput 2 kbit/s - changing to hextile encoding CConn: Throughput

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Hollis Blanchard wrote: On Thu, 2009-04-23 at 18:40 +0300, Avi Kivity wrote: Still missing: - I have not tested powerpc or ia64. Patches welcome! This repository seems pretty messed up; I'm not even sure what you want from me. Some of the bigger problems: * configure

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Hollis Blanchard wrote: Since PPC is now supported in upstream QEMU, does it really matter if it works in qemu-kvm.git? I was going to take that position too, except Avi asked me specifically if some of the code inside TARGET_I386 ifdefs in qemu-kvm.c works for other architectures.

RE: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c

2009-04-29 Thread Zhang, Xiantao
Jes Sorensen wrote: Zhang, Xiantao wrote: Avi Kivity wrote: I haven't pushed this out yet, so I can apply a replacement patch. We don't need flush_icache_range here, because I believe it is called in cpu_physical_memory_write. Xiantao Hi Xiantao, Good point, I hadn't spotted that, and

Re: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c

2009-04-29 Thread Jes Sorensen
Zhang, Xiantao wrote: Jes Sorensen wrote: What do you think of this one? Hi, Jes Except nvram stuff, I don't see the difference with my patch. Could you provide an incremental patch to fix nvram stuff ? :) Xiantao Hi Xiantao, The main difference is that my patch cleans up the

Re: qemu-kvm.git now live

2009-04-29 Thread Jan Kiszka
Avi Kivity wrote: After a lengthy testing phase, qemu-kvm.git has replaced kvm-userspace.git as the source repository for kvm userspace development. Differences from kvm-userspace.git are as follows: - everything under qemu/ has been moved to the top-level directory - everything not under

[PATCH] qemu-kvm: Remove duplicate set_link monitor command

2009-04-29 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- monitor.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 11e48c7..674630b 100644 --- a/monitor.c +++ b/monitor.c @@ -1792,7 +1792,6 @@ static const mon_cmd_t mon_cmds[] = {

Re: [PATCH 02/04] qemu-kvm: Add header files for ia64.

2009-04-29 Thread Jes Sorensen
Xiantao == Zhang, Xiantao xiantao.zh...@intel.com writes: Xiantao From bbaeed10e1629a1c86a497e5a4e18e5d51b5df69 Mon Sep 17 Xiantao 00:00:00 2001 From: Xiantao Zhang xiantao.zh...@intel.com Xiantao Date: Tue, 28 Apr 2009 15:05:30 +0800 Subject: [PATCH] Xiantao qemu-kvm: Add header files for ia64.

Re: [PATCH v2 00/16] interrupt injection rework

2009-04-29 Thread Jan Kiszka
Avi Kivity wrote: Gleb Natapov wrote: Hi, This patch series aims to consolidate IRQ injection code for in kernel IRQ chip and userspace one. Also to move IRQ injection logic from SVM/VMX specific code to x86.c. Applied all, thanks for this excellent patchset. Hmm, to which branch?

RE: [PATCH 02/04] qemu-kvm: Add header files for ia64.

2009-04-29 Thread Zhang, Xiantao
Hi, Jes There should be no issue here. You may refer to qemu-kvm/kvm/kernel/arch/x86/include/asm/kvm.h, and it also includes this stuff. I remebered this stuff was used to solve the issues when uses kernel header files in userspace and the author should be Avi:-) You know, kernel header

Re: [PATCH 02/04] qemu-kvm: Add header files for ia64.

2009-04-29 Thread Jes Sorensen
Zhang, Xiantao wrote: Hi, Jes There should be no issue here. You may refer to qemu-kvm/kvm/kernel/arch/x86/include/asm/kvm.h, and it also includes this stuff. I remebered this stuff was used to solve the issues when uses kernel header files in userspace and the author should be Avi:-) You

RE: [PATCH 02/04] qemu-kvm: Add header files for ia64.

2009-04-29 Thread Zhang, Xiantao
Jes Sorensen wrote: Zhang, Xiantao wrote: Hi, Jes There should be no issue here. You may refer to qemu-kvm/kvm/kernel/arch/x86/include/asm/kvm.h, and it also includes this stuff. I remebered this stuff was used to solve the issues when uses kernel header files in userspace and the

Re: [PATCH v2 00/16] interrupt injection rework

2009-04-29 Thread Gleb Natapov
On Wed, Apr 29, 2009 at 11:30:46AM +0200, Jan Kiszka wrote: Avi Kivity wrote: Gleb Natapov wrote: Hi, This patch series aims to consolidate IRQ injection code for in kernel IRQ chip and userspace one. Also to move IRQ injection logic from SVM/VMX specific code to x86.c.

Re: [PATCH v2 00/16] interrupt injection rework

2009-04-29 Thread Gleb Natapov
On Wed, Apr 29, 2009 at 12:33:09PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Apr 29, 2009 at 11:30:46AM +0200, Jan Kiszka wrote: Avi Kivity wrote: Gleb Natapov wrote: Hi, This patch series aims to consolidate IRQ injection code for in kernel IRQ chip and userspace one.

Re: [PATCH v2 00/16] interrupt injection rework

2009-04-29 Thread Avi Kivity
Jan Kiszka wrote: Hmm, to which branch? Or did you just forget to also push it... In general, if I apply and don't push a couple of hours later, it means there are regressions. I think these regressions are from the recent qemu merge, not the interrupt rework. -- I have a truly

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Jan Kiszka wrote: Avi Kivity wrote: After a lengthy testing phase, qemu-kvm.git has replaced kvm-userspace.git as the source repository for kvm userspace development. Differences from kvm-userspace.git are as follows: - everything under qemu/ has been moved to the top-level directory -

Re: [PATCH v2 00/16] interrupt injection rework

2009-04-29 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Apr 29, 2009 at 12:33:09PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Apr 29, 2009 at 11:30:46AM +0200, Jan Kiszka wrote: Avi Kivity wrote: Gleb Natapov wrote: Hi, This patch series aims to consolidate IRQ injection code for in kernel IRQ chip and

Re: [PATCH v2 00/16] interrupt injection rework

2009-04-29 Thread Jan Kiszka
Avi Kivity wrote: Jan Kiszka wrote: Hmm, to which branch? Or did you just forget to also push it... In general, if I apply and don't push a couple of hours later, it means there are regressions. I think these regressions are from the recent qemu merge, not the interrupt rework. I

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

2009-04-29 Thread Christoph Hellwig
On Tue, Apr 28, 2009 at 09:09:52PM +0200, Christian Borntraeger wrote: Yes, virtio-scsi is also something we were thinking of. The last time we discussed this idea of SCSI passthrough internally, we stumbled over error recovery. Who is responsible for the error recovery? The host, the guest,

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

2009-04-29 Thread Christoph Hellwig
On Tue, Apr 28, 2009 at 11:37:01AM -0500, Anthony Liguori wrote: Ah, excellent. I think that's a great thing to do. So do you think virtio-scsi would deprecate virtio-blk? I don't think so. If you have an image format or a non-scsi blockdevice underneath virtio-block avoids the encoding

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

2009-04-29 Thread Christian Borntraeger
Am Wednesday 29 April 2009 12:50:04 schrieb Christoph Hellwig: On Tue, Apr 28, 2009 at 09:09:52PM +0200, Christian Borntraeger wrote: Yes, virtio-scsi is also something we were thinking of. The last time we discussed this idea of SCSI passthrough internally, we stumbled over error

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

2009-04-29 Thread Paul Brook
On Wednesday 29 April 2009, Christoph Hellwig wrote: On Tue, Apr 28, 2009 at 11:37:01AM -0500, Anthony Liguori wrote: Ah, excellent. I think that's a great thing to do. So do you think virtio-scsi would deprecate virtio-blk? I don't think so. If you have an image format or a non-scsi

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Jan Kiszka wrote: I'm unhappy with both qemu.git and qemu-kvm.git memory slot management; qemu-kvm.git is clumsy, and qemu.git is too simplistic (for example, it ignores the fact that dirty logging is a global resource with multiple users). Don't get your point yet. Can you name a

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

2009-04-29 Thread Christian Borntraeger
Am Wednesday 29 April 2009 13:11:19 schrieb Paul Brook: On Wednesday 29 April 2009, Christoph Hellwig wrote: On Tue, Apr 28, 2009 at 11:37:01AM -0500, Anthony Liguori wrote: Ah, excellent. I think that's a great thing to do. So do you think virtio-scsi would deprecate virtio-blk? I

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

2009-04-29 Thread Christoph Hellwig
On Wed, Apr 29, 2009 at 12:11:19PM +0100, Paul Brook wrote: Is this actually measurably faster, or just infinitesimally faster in theory? On normal disks it's rather theoretical. On high-end SSDs and arrays the impact is noticeable, mostly due to the additional latency. -- To unsubscribe from

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

2009-04-29 Thread Paul Brook
On Wednesday 29 April 2009, Christian Borntraeger wrote: Am Wednesday 29 April 2009 13:11:19 schrieb Paul Brook: On Wednesday 29 April 2009, Christoph Hellwig wrote: On Tue, Apr 28, 2009 at 11:37:01AM -0500, Anthony Liguori wrote: Ah, excellent. I think that's a great thing to do. So

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

2009-04-29 Thread Paul Brook
On Wednesday 29 April 2009, Christoph Hellwig wrote: On Wed, Apr 29, 2009 at 12:11:19PM +0100, Paul Brook wrote: Is this actually measurably faster, or just infinitesimally faster in theory? On normal disks it's rather theoretical. On high-end SSDs and arrays the impact is noticeable,

maybe stability issues

2009-04-29 Thread jens
Hi, I maybe notized for me hard to reproduce stability issues with kvm and therefore I would like to ask the list for a hint how to solve the problem. The kernel I use for the smp host and guest is a 2.6.29.1 kernel.org kernel and I compiled kvm-85 with '--with-patched-kernel'. For the three

Live Migration fails Windows 2008 64bit

2009-04-29 Thread Vadim Korschok
Hi all, we're running 2 Dell PowerEdge 1950 on Gentoo. The Migration of Windows 2008 Server fails, first the source Qemu-Monitor says migration complete. After that the destination VNC Screen screw up. Then you can see that Windows reboot. CPU: Intel(R) Xeon(R) E5335 @ 2.00GHz KVM-Version: 85

RE: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c

2009-04-29 Thread Zhang, Xiantao
Jes Sorensen wrote: Zhang, Xiantao wrote: Jes Sorensen wrote: What do you think of this one? Hi, Jes Except nvram stuff, I don't see the difference with my patch. Could you provide an incremental patch to fix nvram stuff ? :) Xiantao Hi Xiantao, The main difference is that my

Re: Re: Is guest OS oriented scheduling welcome?

2009-04-29 Thread alex
Hello, It will take some time for me to add the feature to CFS. Would you mind using credit scheduler instead? These days, I have changed my port into a separate module, with only adding some hooks to KVM. I have tested the case that the KVM is an external module. But I fail to insert my module

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Jan Kiszka wrote: If migration disables dirty memory logging, it must keep the vga logging enabled, and vice versa. So we need some notifier callbacks on slot changes so that all users can re-enable dirty logging after the update as required. Simpler to do reference counting. When a

KVM performance vs. Xen

2009-04-29 Thread Andrew Theurer
I wanted to share some performance data for KVM and Xen. I thought it would be interesting to share some performance results especially compared to Xen, using a more complex situation like heterogeneous server consolidation. The Workload: The workload is one that simulates a consolidation of

virtio disk and network performances

2009-04-29 Thread Riccardo Veraldi
Hello, I am little bit disappointed about virtio perormance. speaking about virtio disk performance I get about the same performances of non-virtio quests. I am using centos 5.3 2.6.18-128.1.6.el5 as host and the same centos 5.3 2.6.18-128.1.6.el5 as kvm guests with virtio backported to

Re: [x86] - technical questions about HV implementation on Intel VT

2009-04-29 Thread Eric Lacombe
Hi, Le mardi 21 avril 2009 13:16:06 Eric Lacombe, vous avez écrit : Le lundi 20 avril 2009 20:22:21 Avi Kivity, vous avez écrit : Eric Lacombe wrote: [...] echo and pwd are part of bash, so they are probably in memory. I guess once you go to disk things fail. Try to boot the entire

Re: [PATCH 04/04] qemu-kvm: other archs should maintain memory mapping also.

2009-04-29 Thread Jes Sorensen
Avi == Avi Kivity a...@redhat.com writes: Avi Zhang, Xiantao wrote: From d184d9b0a91ca674961000ed3d35b7fc25d29e03 Mon Sep 17 00:00:00 2001 From: Xiantao Zhang xiantao.zh...@intel.com Date: Tue, 28 Apr 2009 16:59:36 +0800 Subject: [PATCH] qemu-kvm: other archs should maintain memory mapping

[PATCH 1/2] Add serial number support for virtio_blk

2009-04-29 Thread john cooper
-- john.coo...@third-harmonic.com hw/virtio-blk.c | 15 ++- hw/virtio-blk.h |3 +++ sysemu.h|4 +++- 3 files changed, 20 insertions(+), 2 deletions(-) = --- a/qemu/hw/virtio-blk.h +++

[PATCH 2/2] Add serial number support for virtio_blk

2009-04-29 Thread john cooper
-- john.coo...@third-harmonic.com drivers/block/virtio_blk.c | 36 +--- include/linux/virtio_blk.h | 10 ++ 2 files changed, 43 insertions(+), 3 deletions(-) = ---

[PATCH 0/2] Add serial number support for virtio_blk

2009-04-29 Thread john cooper
This patch allows passing of a virtio_blk drive serial number from qemu into a guest's virtio_blk driver, and provides a means to access the serial number from a guest's userspace. Equivalent functionality currently exists for IDE and SCSI, however it is not yet implemented for virtio.

Re: Re: [PATCH 04/04] qemu-kvm: other archs should maintain memory mapping also.

2009-04-29 Thread Jes Sorensen
Avi Kivity wrote: Currently, use TARGET_I386 to comment out the mapping machanism for other archs, but mapping machanism should be useful for other archs to maintain guest's memory mapping. Hollis, does this work for you? If now, you can add a new define KVM_WANT_MAPPING or something, and

Re: [PATCH 04/04] qemu-kvm: other archs should maintain memory mapping also.

2009-04-29 Thread Jes Sorensen
Avi Kivity wrote: Hollis, does this work for you? If now, you can add a new define KVM_WANT_MAPPING or something, and define it for I386 and IA64. Hi, This is the one implementing the KVM_WANT_MAPPING change. Cheers, Jes Introduce KVM_WANT_MAPPING define to switch on mapping code,

Re: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c

2009-04-29 Thread Jes Sorensen
Zhang, Xiantao wrote: Jes Sorensen wrote: The main difference is that my patch cleans up the interfaces and calls to the various functions, and removes a bunch of global variables as well. I still can't see the difference with the patch in Avi's tree except nvram stuff. And I believe the

Re: vnc protocol broken

2009-04-29 Thread Cam Macdonell
Dietmar Maurer wrote: Hi all, the new vnc code seems to be broken. At least all java based viewers have serious problems, also realvnc for X For example: # kvm -cdrom ubuntu-9.04-desktop-amd64.iso -vnc :0 vncviewer :0 CConn: Throughput 2 kbit/s - changing to hextile encoding

RE: KVM performance vs. Xen

2009-04-29 Thread Nakajima, Jun
On 4/29/2009 7:41:50 AM, Andrew Theurer wrote: I wanted to share some performance data for KVM and Xen. I thought it would be interesting to share some performance results especially compared to Xen, using a more complex situation like heterogeneous server consolidation. The Workload: The

Re: [PATCH 1/2] Add serial number support for virtio_blk

2009-04-29 Thread Anthony Liguori
Hi John, Please send this to qemu-devel. Regards, Anthony Liguori -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: KVM performance vs. Xen

2009-04-29 Thread Andrew Theurer
Nakajima, Jun wrote: On 4/29/2009 7:41:50 AM, Andrew Theurer wrote: I wanted to share some performance data for KVM and Xen. I thought it would be interesting to share some performance results especially compared to Xen, using a more complex situation like heterogeneous server

Re: qemu-kvm.git now live

2009-04-29 Thread Jan Kiszka
Avi Kivity wrote: Jan Kiszka wrote: If migration disables dirty memory logging, it must keep the vga logging enabled, and vice versa. So we need some notifier callbacks on slot changes so that all users can re-enable dirty logging after the update as required. Simpler to do

[PATCH 1/2] Add serial number support for virtio_blk

2009-04-29 Thread john cooper
-- john.coo...@third-harmonic.com hw/virtio-blk.c | 15 ++- hw/virtio-blk.h |3 +++ sysemu.h|4 +++- 3 files changed, 20 insertions(+), 2 deletions(-) = --- a/qemu/hw/virtio-blk.h +++

[PATCH 2/2] Add serial number support for virtio_blk

2009-04-29 Thread john cooper
-- john.coo...@third-harmonic.com drivers/block/virtio_blk.c | 36 +--- include/linux/virtio_blk.h | 10 ++ 2 files changed, 43 insertions(+), 3 deletions(-) = ---

Re: [x86] - technical questions about HV implementation on Intel VT

2009-04-29 Thread Eric Lacombe
Yeah, I got it! All seems to work well now ;) It was simply the host_cr3 field that I did not correctly fill... When I started to write my module, I used the cr3 of the current process to fill the host_cr3 VMCS field big mistake !!! as the process (insmod) dies after loading my module, the

Missing symlink in qemu-kvm.git?

2009-04-29 Thread walt
When building on x86 I get this error: make[2]: Entering directory `/home/wa1ter/src/qemu-kvm/kvm/libkvm' make[2]: *** No rule to make target `/home/wa1ter/src/qemu-kvm/kvm/kernel/include/asm/kvm.h', needed by `libkvm.o'. I fixed it by adding the same symlink that I add to Linus's kernel.git for

Re: [patch 0/4] use smp_send_reschedule in vcpu_kick / assigned dev host intx race fix

2009-04-29 Thread Marcelo Tosatti
On Tue, Apr 28, 2009 at 03:08:46PM +0800, Sheng Yang wrote: Ack all. This also solved one bug by my hand. Thanks! I observe one point: the performance of high workload interrupt(e.g. 10 gigabyte oplin card) dropped dramatically with smp_send_reschedule() method... In one environment(the

Re: Missing symlink in qemu-kvm.git?

2009-04-29 Thread Cam Macdonell
walt wrote: When building on x86 I get this error: make[2]: Entering directory `/home/wa1ter/src/qemu-kvm/kvm/libkvm' make[2]: *** No rule to make target `/home/wa1ter/src/qemu-kvm/kvm/kernel/include/asm/kvm.h', needed by `libkvm.o'. I fixed it by adding the same symlink that I add to Linus's

[PATCH 0/2] Fix cpu hotplug in upstream kvm

2009-04-29 Thread Glauber Costa
Hello. Here are a couple of fixes for upstream cpu_hotplug. (currently broken) After the first patch, it ceases to segfault, and will work with -no-kvm-irqchip. The second one fixes the issues with kvm-irqchip -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

[PATCH 1/2] don't start cpu main loop while there is still init work to do.

2009-04-29 Thread Glauber Costa
As soon as we call kvm_init_vcpu(), we start the vcpu thread. However, there is still things that has to be done, as soon as the new CPUState is created. Examples include initializing the apic, halting the cpu, etc. Without this patch, it is possible that the cpu may want to start using those

[PATCH 2/2] Present kvm with corret apic phys id.

2009-04-29 Thread Glauber Costa
KVM will 24-shift bits in addr 0x20 (APIC_ID) before actually using it. We currently load phys_id as s-id. After shifted by 24 bits, it will result in a meaningless value. We should really be doing s-id 24, which, after shifted, will lead to the correct value. This is for the load function. save

[PATCH] Fix build when objdir != srcdir

2009-04-29 Thread Anthony Liguori
This requires adding the necessary bits to configure to create the directories and symlinks for libkvm. It also requires sticking KVM_CFLAGS in config-host.mak to ensure that it gets the right set of includes for the kernel headers. Signed-off-by: Anthony Liguori aligu...@us.ibm.com ---

[PATCH 0/2] Make savevm versioning compatible with upstream QEMU

2009-04-29 Thread Anthony Liguori
Right now, there is no way savevm versioning can be compatible with upstream QEMU because KVM adds fields to existing savevm structures without incrementing the versions. If you assume that KVM will eventually merge into upstream QEMU, this means that eventually KVM is going to have to break

[PATCH 1/2] Increment virtio-net savevm version to avoid conflict with upstream QEMU.

2009-04-29 Thread Anthony Liguori
When TAP_VNET_HDR eventually merges into upstream QEMU, it cannot change the format of the version 6 savevm data. This means that we're going to have to bump the version up to 7. I'm happy to reserve version 7 as having TAP_VNET_HDR support to allow time to include this support in upstream QEMU.

[PATCH 2/2] Increment version id for CPU save state

2009-04-29 Thread Anthony Liguori
9 is reserved for KVM. KVM cannot support migration from any other version. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- target-i386/cpu.h |4 +++- target-i386/machine.c |3 +++ 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.h

[PATCH 0/21] Remove merge artifacts from qemu-kvm

2009-04-29 Thread Anthony Liguori
Now that we've got qemu-kvm, it's pretty easy to look at what's different between upstream QEMU and qemu-kvm. Unfortunately, there's still a lot of gunk that seems to keep surviving merges. This series removes all of the gunk I could find. I also culled out a number of fixes that should be in

[PATCH 01/21] Remove memalign call for guess_disk_lchs

2009-04-29 Thread Anthony Liguori
This code doesn't exist in upstream QEMU because it is not necessary to provide an aligned buffer to bdrv_read. The API has always worked this way although at one point, the bouncing was broken which is what led to this patch. The places where qemu_memalign() is used in QEMU are only where

[PATCH 02/21] Remove devfn from BlockDriverState

2009-04-29 Thread Anthony Liguori
It's no longer used. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- block_int.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/block_int.h b/block_int.h index 951ff02..e10b906 100644 --- a/block_int.h +++ b/block_int.h @@ -150,8 +150,6 @@ struct

[PATCH 03/21] Remove use of signalfd in block-raw-posix.c

2009-04-29 Thread Anthony Liguori
We don't use signalfd in upstream QEMU. Instead, we always emulate it. It's not necessarily a bad thing to use signalfd, but this is something that should be done upstream. It certainly does qemu-kvm no harm to use the upstream code. Signed-off-by: Anthony Liguori aligu...@us.ibm.com ---

[PATCH 05/21] Remove extra call to kvm_cpu_exec()

2009-04-29 Thread Anthony Liguori
It's just duplicated code now since we do the same thing in upstream. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- cpu-exec.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index bb77b5e..f959f4e 100644 --- a/cpu-exec.c +++

[PATCH 06/21] Remove dead functions from cutils

2009-04-29 Thread Anthony Liguori
These are leftover from the old migration code. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- cutils.c | 39 --- qemu-common.h |2 -- 2 files changed, 0 insertions(+), 41 deletions(-) diff --git a/cutils.c b/cutils.c index 4bf4fcd..e2bee1e

[PATCH 04/21] Remove stray whitespace

2009-04-29 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- block-vmdk.c |1 + vl.c |1 - 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block-vmdk.c b/block-vmdk.c index ff5007c..d47d483 100644 --- a/block-vmdk.c +++ b/block-vmdk.c @@ -93,6 +93,7 @@ typedef struct

[PATCH 07/21] Remove dead macros likely/unlikely in exec.c

2009-04-29 Thread Anthony Liguori
More left overs from the old migration code. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- exec.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c index 16d3cf8..e9d83a8 100644 --- a/exec.c +++ b/exec.c @@ -3500,14 +3500,6 @@ uint32_t

[PATCH 11/21] Remove unused variables in vga.c

2009-04-29 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- hw/vga.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index 4931b69..d96f1be 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -1585,12 +1585,11 @@ static void vga_sync_dirty_bitmap(VGAState *s) */

[PATCH 12/21] Remove odd hack in vga.c

2009-04-29 Thread Anthony Liguori
I looked closely at the vga code in kvm-userspace a while ago and merged every fix I could understand into upstream QEMU. This particular change makes no sense to me. I could not figure out from revision history what it actually fixed. I'm fairly certain it's not useful today. Signed-off-by:

[PATCH 08/21] Remove leftovers in device-hotplug.c

2009-04-29 Thread Anthony Liguori
Post merge into upstream, device-hotplug.c is carrying stray #includes, #defines, and whitespace changes. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- hw/device-hotplug.c |9 + 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/hw/device-hotplug.c

[PATCH 13/21] Remove virtio-console PIF change

2009-04-29 Thread Anthony Liguori
If this change should happen, it should happen in upstream QEMU. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- hw/virtio-console.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 89e8be0..b263281 100644 ---

[PATCH 09/21] Remove unnecessary setting of cmos smp_cpu count

2009-04-29 Thread Anthony Liguori
This is duplicate code. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- hw/pc.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 35f9527..db34f53 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -265,7 +265,6 @@ static void cmos_init(ram_addr_t

[PATCH 15/21] Remove defined(TARGET_X86_64)

2009-04-29 Thread Anthony Liguori
TARGET_I386 is always defined when TARGET_X86_64 is defined. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 11e48c7..1a531f2 100644 --- a/monitor.c +++ b/monitor.c @@ -1764,7

[PATCH 16/21] Remove clean rule change

2009-04-29 Thread Anthony Liguori
It's not in upstream QEMU so apparently it's not useful. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- pc-bios/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pc-bios/Makefile b/pc-bios/Makefile index dabeb4c..315288d 100644 --- a/pc-bios/Makefile +++

[PATCH 17/21] Remove #define __user in usb-linux.c

2009-04-29 Thread Anthony Liguori
This has been consistently nacked in upstream QEMU. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- usb-linux.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 26643bd..70d7a1c 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -34,10

[PATCH 18/21] Remove host_alarm_timer hacks.

2009-04-29 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- vl.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 3b0e3dc..848a8f8 100644 --- a/vl.c +++ b/vl.c @@ -1367,8 +1367,7 @@ static void host_alarm_handler(int host_signum) last_clock = ti;

[PATCH 14/21] Remove -cpu-vendor-string

2009-04-29 Thread Anthony Liguori
This isn't in upstream QEMU and is of little utility to KVM. It's unlikely to appear in upstream QEMU either. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- linux-user/main.c|1 - qemu-options.hx |2 -- target-i386/helper.c |5 - vl.c |4

[PATCH 19/21] Use QEMU_PKGVERSION to declare kvm-devel

2009-04-29 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- configure |4 +--- vl.c |2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/configure b/configure index c41e269..6b6cf5b 100755 --- a/configure +++ b/configure @@ -194,7 +194,7 @@ blobs=yes fdt=yes sdl_x11=no

[PATCH 20/21] Get rid of qemu_get_launch_info()

2009-04-29 Thread Anthony Liguori
This is left over from the old ssh migration implementation Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- sysemu.h |3 --- vl.c | 13 - 2 files changed, 0 insertions(+), 16 deletions(-) diff --git a/sysemu.h b/sysemu.h index e8dd381..cf6b48a 100644 --- a/sysemu.h

[PATCH] fix apic_debug instances

2009-04-29 Thread Glauber Costa
Appearently nobody turned this on in a while... setting apic_debug to something compilable, generates some errors. This patch fixes it. Signed-off-by: Glauber Costa glom...@redhat.com --- arch/x86/kvm/lapic.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 10/21] Remove IBM copyright in unmodified file in upstream

2009-04-29 Thread Hollis Blanchard
On Wed, 2009-04-29 at 16:20 -0500, Anthony Liguori wrote: Presumably, it would carry an IBM copyright upstream if needed. qemu-kvm introduces no additional code over upstream QEMU in this file. Avi: please let Hollis ack/nack this before committing. Signed-off-by: Anthony Liguori

Re: Boot problems with qemu-kvm

2009-04-29 Thread Cam Macdonell
Xu, Jiajun wrote: On Tuesday, April 28, 2009 7:11 AM kvm-ow...@vger.kernel.org wrote: Cam Macdonell wrote: Hi, I've tried booting two VMs (Ubuntu and Fedora 11) that previously worked with the latest kvm-userspace. At start, I get the following warning: Could not open '/dev/kqemu' - QEMU

Re: [patch 0/4] use smp_send_reschedule in vcpu_kick / assigned dev host intx race fix

2009-04-29 Thread Sheng Yang
On Thursday 30 April 2009 01:47:57 Marcelo Tosatti wrote: On Tue, Apr 28, 2009 at 03:08:46PM +0800, Sheng Yang wrote: Ack all. This also solved one bug by my hand. Thanks! I observe one point: the performance of high workload interrupt(e.g. 10 gigabyte oplin card) dropped dramatically

Re: [patch 0/4] use smp_send_reschedule in vcpu_kick / assigned dev host intx race fix

2009-04-29 Thread Sheng Yang
On Thursday 30 April 2009 08:56:57 Sheng Yang wrote: On Thursday 30 April 2009 01:47:57 Marcelo Tosatti wrote: On Tue, Apr 28, 2009 at 03:08:46PM +0800, Sheng Yang wrote: Ack all. This also solved one bug by my hand. Thanks! I observe one point: the performance of high workload

RE: Boot problems with qemu-kvm

2009-04-29 Thread Xu, Jiajun
On Thursday, April 30, 2009 6:38 AM Cam Macdonell wrote: I also met the same problem with 2.6.30-rc3. Guest can not get IP and qemu process cpu utilization is always ~100%. Well, I don't get the X display problem with -no-kvm. It's only X that's the problem, terminal output and curses

[PATCH] KVM: No disable_irq for MSI/MSI-X interrupt on device assignment

2009-04-29 Thread Sheng Yang
Disable interrupt at interrupt handler and enable it when guest ack is for the level triggered interrupt, to prevent reinjected interrupt. MSI/MSI-X don't need it. One possible problem is multiply same vector interrupt injected between irq handler and scheduled work handler would be merged as one

Re: [kvm] [PATCH 1/2] Increment virtio-net savevm version to avoid conflict with upstream QEMU.

2009-04-29 Thread Alex Williamson
On Wed, 2009-04-29 at 15:53 -0500, Anthony Liguori wrote: -#define VIRTIO_NET_VM_VERSION6 +/* Version 7 has TAP_VNET_HDR support. This is reserved in upstream QEMU to + * avoid future conflict. + * We can't assume verisons 7 have TAP_VNET_HDR support until this is merged + * in

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Hollis Blanchard wrote: On Thu, 2009-04-23 at 18:40 +0300, Avi Kivity wrote: Still missing: - I have not tested powerpc or ia64. Patches welcome! This repository seems pretty messed up; I'm not even sure what you want from me. Some of the bigger problems: * configure

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Hollis Blanchard wrote: Since PPC is now supported in upstream QEMU, does it really matter if it works in qemu-kvm.git? I was going to take that position too, except Avi asked me specifically if some of the code inside TARGET_I386 ifdefs in qemu-kvm.c works for other architectures.

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Jan Kiszka
Liu Yu-B13201 wrote: -Original Message- From: qemu-devel-bounces+yu.liu=freescale@nongnu.org [mailto:qemu-devel-bounces+yu.liu=freescale@nongnu.org] On Behalf Of Jan Kiszka Sent: Sunday, April 12, 2009 1:20 AM To: qemu-de...@nongnu.org Subject: [Qemu-devel] [PATCH 4/7]

Re: qemu-kvm.git now live

2009-04-29 Thread Jan Kiszka
Avi Kivity wrote: Jan Kiszka wrote: Avi Kivity wrote: After a lengthy testing phase, qemu-kvm.git has replaced kvm-userspace.git as the source repository for kvm userspace development. Differences from kvm-userspace.git are as follows: - everything under qemu/ has been moved to the

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Jan Kiszka
Liu Yu-B13201 wrote: -Original Message- From: Jan Kiszka [mailto:jan.kis...@siemens.com] Sent: Wednesday, April 29, 2009 6:38 PM To: Liu Yu-B13201 Cc: qemu-de...@nongnu.org; kvm-ppc@vger.kernel.org Subject: Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Jan Kiszka wrote: If migration disables dirty memory logging, it must keep the vga logging enabled, and vice versa. So we need some notifier callbacks on slot changes so that all users can re-enable dirty logging after the update as required. Simpler to do reference counting. When a

  1   2   >