No sound

2010-02-02 Thread satimis
Hi folks, Host - Debian 5.0 KVM VM - Ubuntu 9.10 No sound on playing youtube. Volume on host and VM has been turned to max, Virtual Machine Manager Edit - Preferences Install Audio Device [check] Local VM Please help. TIA B.R. Stephen L -- To unsubscribe from this list: send the line

[PATCH 10/21] KVM: Move and rename regs_modified

2010-02-02 Thread Jan Kiszka
Touching the user space representation of KVM's VCPU state is - naturally - a per-VCPU thing. So move the dirty flag into KVM_CPU_COMMON and rename it at this chance to reflect its true meaning. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- cpu-defs.h |1 + kvm-all.c | 12

[PATCH 04/21] KVM: x86: Fix up misreported CPU features

2010-02-02 Thread Jan Kiszka
From qemu-kvm: Kernels before 2.6.30 misreported some essential CPU features via KVM_GET_SUPPORTED_CPUID. Fix them up. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/kvm.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/target-i386/kvm.c

[PATCH 05/21] qemu-kvm: Use upstream kvm_enabled and cpu_synchronize_state

2010-02-02 Thread Jan Kiszka
They are identical, no need for private copies. This requires replacing qemu-kvm.h includes with kvm.h, a good thing anyway, and reveals that there is no need for QEMU_KVM_NO_CPU protection. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/i8254.c|2 +- hw/i8259.c|2 +-

[PATCH 15/21] qemu-kvm: Clean up mpstate synchronization

2010-02-02 Thread Jan Kiszka
Push mpstate reading/writing into kvm_arch_load/save_regs and, on x86, properly synchronize with halted in the accessor functions. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/apic.c |7 qemu-kvm-ia64.c |4 ++- qemu-kvm-x86.c| 88

[PATCH 21/21] qemu-kvm: Bring qemu_init_vcpu back home

2010-02-02 Thread Jan Kiszka
There is no need for the this hack anymore, initialization is now robust against reordering as it doesn't try to write the VCPU state on its own. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/pc.c |5 - target-i386/helper.c |2 ++ 2 files changed, 2

[PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

2010-02-02 Thread Jan Kiszka
Setting the boot CPU ID is arch-specific KVM stuff. So push it where it belongs to. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/pc.c|3 --- qemu-kvm-x86.c |3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 6c15a9f..3df6195

[PATCH 19/21] qemu-kvm: Clean up KVM's APIC hooks

2010-02-02 Thread Jan Kiszka
The APIC is part of the VCPU state, so trigger its readout and writeback from kvm_arch_save/load_regs. Thanks to the transparent sync on reset and vmsave/load, we can also drop explicit sync code, reducing the diff to upstream. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/apic.c

[PATCH 16/21] KVM: x86: Restrict writeback of VCPU state

2010-02-02 Thread Jan Kiszka
Do not write nmi_pending, sipi_vector, and mpstate unless we at least go through a reset. And TSC as well as KVM wallclocks should only be written on full sync, otherwise we risk to drop some time on during state read-modify-write. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm.h

[PATCH 06/21] qemu-kvm: Use upstream kvm_setup_guest_memory

2010-02-02 Thread Jan Kiszka
Nothing missing in upstream kvm_setup_guest_memory, it is even more careful about error handling. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c |3 --- kvm.h |3 +-- qemu-kvm.c | 15 --- qemu-kvm.h |1 - 4 files changed, 1 insertions(+), 21

[PATCH 09/21] qemu-kvm: Use upstream kvm_pit_in_kernel

2010-02-02 Thread Jan Kiszka
Drop private version in favor of recently added upstream service and track it state directly in KVMState. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/i8254.c |4 ++-- hw/pc.c|2 +- hw/pcspk.c |4 ++-- kvm-all.c |2 +- kvm.h |2 +-

[PATCH 01/21] qemu-kvm: Drop vmport changes

2010-02-02 Thread Jan Kiszka
This attempt to make vmport KVM compatible is half-broken and is scheduled to be replaced by proper upstream support. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vmport.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/hw/vmport.c b/hw/vmport.c

[PATCH 12/21] qemu-kvm: Use upstream kvm_vcpu_dirty

2010-02-02 Thread Jan Kiszka
Drop regs_modified in favor of upstream's equivalent and clean up kvm_cpu_synchronize_state at this chance. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- cpu-defs.h |1 - hw/pc.c|2 +- qemu-kvm.c | 18 +- 3 files changed, 10 insertions(+), 11 deletions(-)

[PATCH 08/21] qemu-kvm: Use upstream kvm_arch_get_supported_cpuid

2010-02-02 Thread Jan Kiszka
It is idential to our version now, so drop the copy. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm.h |3 - qemu-kvm-x86.c| 106 - qemu-kvm.h|5 -- target-i386/kvm.c |4 +- 4 files changed, 2

[PATCH 03/21] qemu-kvm: Clean up register access API

2010-02-02 Thread Jan Kiszka
qemu-kvm's functios for accessing the VCPU registers are kvm_arch_load/save_regs. Use them directly instead of going through various wrappers. Specifically, we do not need on_vcpu wrapping as all users either already run in the related thread or call while the vm is stopped. Signed-off-by: Jan

[PATCH 18/21] qemu-kvm: Cleanup/fix TSC and PV clock writeback

2010-02-02 Thread Jan Kiszka
Drop kvm_load_tsc in favor of level-dependent writeback in kvm_arch_load_regs. KVM's PV clock MSRs fall in the same category and should therefore only be written back on full sync. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- qemu-kvm-x86.c| 19 +-- qemu-kvm.h

[PATCH 07/21] qemu-kvm: Use some more upstream prototypes

2010-02-02 Thread Jan Kiszka
Drop our private typedef of KVMState and use more identical upstream prototypes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm.h | 10 +++--- qemu-kvm.c |4 +++- qemu-kvm.h | 24 +++- 3 files changed, 13 insertions(+), 25 deletions(-) diff --git

[PATCH 13/21] qemu-kvm: Use upstream guest debug code

2010-02-02 Thread Jan Kiszka
Code was absolute identical except for previous cleanup in upstream. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c |7 +- kvm.h |4 - qemu-kvm-x86.c| 178 ++-- qemu-kvm.c| 44 -

[PATCH 11/21] KVM: Rework of guest debug state writing

2010-02-02 Thread Jan Kiszka
So far we synchronized any dirty VCPU state back into the kernel before updating the guest debug state. This was a tribute to a deficite in x86 kernels before 2.6.33. But as this is an arch-dependent issue, it is better handle in the x86 part of KVM and remove the writeback point for generic code.

[PATCH 17/21] qemu-kvm: Use VCPU event state for reset and vmsave/load

2010-02-02 Thread Jan Kiszka
Push reading/writing of vcpu_events into kvm_arch_load/save_regs to avoid KVM-specific hooks in generic code. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm.h |2 -- qemu-kvm-x86.c|6 -- target-i386/kvm.c |4 ++-- target-i386/machine.c |6

[PATCH 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-02 Thread Jan Kiszka
This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) - cpu_synchronize_all_post_init in qemu_loadvm_state (writeback after

Re: Can VM be copied to another PC (Solved)

2010-02-02 Thread satimis
Hi kashyap, Thanks for your advice. Quoting Kashyap Chamarthy kashyap...@gmail.com: On Mon, Feb 1, 2010 at 9:32 AM, sati...@pacific.net.hk wrote: - snip - 1) 'virsh dumpxml domain(s) (or) id '(this will dump the guest machine info. into XML) 2) copy your qcow2(or whatever format)

Re: virtio GSO makes IPv6 unbearably slow

2010-02-02 Thread Bernhard Schmidt
On Mon, Feb 01, 2010 at 10:08:53PM -0800, Sridhar Samudrala wrote: According to ethtool GSO is enabled on the guest, but disabling it using ethtool does not have any effect. But giving the kernel virtio_net.gso=0 in append fixes the issue completely. Anyone having any ideas? I ran into a

[ kvm-Bugs-2944508 ] QEMU (0.12.2) startup problem with kvm and flag -no-reboot

2010-02-02 Thread SourceForge.net
Bugs item #2944508, was opened at 2010-02-02 09:46 Message generated for change (Tracker Item Submitted) made by nsnkern You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2944508group_id=180599 Please note that this message will contain a full copy of the

Re: KVM call agenda for Feb 2

2010-02-02 Thread Jan Kiszka
Chris Wright wrote: Please send in any agenda items you are interested in covering. [not sure, though, if I'll manage to join do to overlapping meeting] - state of in-kernel APIC/IOAPIC/PIT upstream merge - road map to get rid of qemu-kvm's slot management (IMHO: qemu-kvm-0.13) - any further

Re: [PATCH] Add cpu model configuration support.. (resend)

2010-02-02 Thread Andre Przywara
john cooper wrote: [target-x86_64.conf was unintentionally omitted from the earlier patch] This is a reimplementation of prior versions which adds the ability to define cpu models for contemporary processors. The added models are likewise selected via -cpu name, and are intended to displace

Re: [PATCH 00/21] qemu-kvm: Hook cleanups and extended use of upstream code

2010-02-02 Thread Alexander Graf
On 02.02.2010, at 09:18, Jan Kiszka wrote: Let's start with the overall stats: 31 files changed, 274 insertions(+), 822 deletions(-) So this series drops far more than 500 lines of redundant code, moving qemu-kvm yet a bit closer to upstream. The other highlight is the simplification

Re: [PATCH] Add cpu model configuration support.. (resend)

2010-02-02 Thread Andre Przywara
John, just two comments from skimming through the patch: diff --git a/sysconfigs/target/target-x86_64.conf b/sysconfigs/target/target-x86_64.conf new file mode 100644 index 000..43ad282 --- /dev/null +++ b/sysconfigs/target/target-x86_64.conf @@ -0,0 +1,86 @@ +# x86 CPU MODELS + +[cpudef]

[PATCH v2] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-02 Thread Liu Yu
Old method prematurely sets ESR and DEAR. Move this part after we decide to inject interrupt, which is more like hardware behave. Signed-off-by: Liu Yu yu@freescale.com --- v2: use new fields queued_esr queued_dear to queue flags arch/powerpc/include/asm/kvm_host.h |2 +

Re: [PATCH 03/21] qemu-kvm: Clean up register access API

2010-02-02 Thread Jan Kiszka
Gleb Natapov wrote: On Tue, Feb 02, 2010 at 09:18:49AM +0100, Jan Kiszka wrote: qemu-kvm's functios for accessing the VCPU registers are kvm_arch_load/save_regs. Use them directly instead of going through various wrappers. Specifically, we do not need on_vcpu wrapping as all users either

Re: [PATCH 00/21] qemu-kvm: Hook cleanups and extended use of upstream code

2010-02-02 Thread Jan Kiszka
Alexander Graf wrote: On 02.02.2010, at 09:18, Jan Kiszka wrote: Let's start with the overall stats: 31 files changed, 274 insertions(+), 822 deletions(-) So this series drops far more than 500 lines of redundant code, moving qemu-kvm yet a bit closer to upstream. The other highlight is

Re: [PATCH v2] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-02 Thread Alexander Graf
On 02.02.2010, at 12:01, Liu Yu wrote: Old method prematurely sets ESR and DEAR. Move this part after we decide to inject interrupt, which is more like hardware behave. In general the patch looks good. I only have minor questions. Signed-off-by: Liu Yu yu@freescale.com --- v2: use

[PATCH v3] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-02 Thread Liu Yu
Old method prematurely sets ESR and DEAR. Move this part after we decide to inject interrupt, which is more like hardware behave. Signed-off-by: Liu Yu yu@freescale.com --- v3: change some functions to static arch/powerpc/include/asm/kvm_host.h |2 + arch/powerpc/kvm/booke.c

Re: [PATCH v3] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-02 Thread Alexander Graf
On 02.02.2010, at 12:44, Liu Yu wrote: Old method prematurely sets ESR and DEAR. Move this part after we decide to inject interrupt, which is more like hardware behave. Signed-off-by: Liu Yu yu@freescale.com Acked-by: Alexander Graf ag...@suse.de Alex -- To unsubscribe from this

Re: [PATCH 15/21] qemu-kvm: Clean up mpstate synchronization

2010-02-02 Thread Gleb Natapov
On Tue, Feb 02, 2010 at 09:19:01AM +0100, Jan Kiszka wrote: Push mpstate reading/writing into kvm_arch_load/save_regs and, on x86, properly synchronize with halted in the accessor functions. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/apic.c |7

Re: [PATCH 15/21] qemu-kvm: Clean up mpstate synchronization

2010-02-02 Thread Jan Kiszka
Gleb Natapov wrote: On Tue, Feb 02, 2010 at 09:19:01AM +0100, Jan Kiszka wrote: Push mpstate reading/writing into kvm_arch_load/save_regs and, on x86, properly synchronize with halted in the accessor functions. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/apic.c |

Re: [PATCH 15/21] qemu-kvm: Clean up mpstate synchronization

2010-02-02 Thread Gleb Natapov
On Tue, Feb 02, 2010 at 01:31:50PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 02, 2010 at 09:19:01AM +0100, Jan Kiszka wrote: Push mpstate reading/writing into kvm_arch_load/save_regs and, on x86, properly synchronize with halted in the accessor functions. Signed-off-by:

Re: [PATCH v2] KVM: fix load_guest_segment_descriptor() to return X86EMUL_*

2010-02-02 Thread Takuya Yoshikawa
A bit more explanation, Takuya Yoshikawa wrote: This patch fixes load_guest_segment_descriptor() to return X86EMUL_PROPAGATE_FAULT when it tries to access the descriptor table beyond the limit of it: suggested by Marcelo. I have checked current callers of this helper function, -

Resolution 1920 x 1080

2010-02-02 Thread Patrik Hrkút
mode and unfortunately my LCD has a native resolution 1920x1080. My parameters: Host system: Ubuntu 9.10 Virtual machine: Windows 7 QEMU version: 0.11.0 Thank you Best regard Patrik Hrkut University of Zilina __ Informacia od ESET NOD32 Antivirus, verzia databazy 4827 (20100202

Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

2010-02-02 Thread Gleb Natapov
On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote: Setting the boot CPU ID is arch-specific KVM stuff. So push it where it belongs to. pc_init1 is also arch-specific, no? TCG should also be able to have BSP apic_id != 0. Signed-off-by: Jan Kiszka jan.kis...@siemens.com ---

Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

2010-02-02 Thread Jan Kiszka
Gleb Natapov wrote: On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote: Setting the boot CPU ID is arch-specific KVM stuff. So push it where it belongs to. pc_init1 is also arch-specific, no? TCG should also be able to have BSP apic_id != 0. But not kvm-specific. I don't understand

Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

2010-02-02 Thread Gleb Natapov
On Tue, Feb 02, 2010 at 03:20:02PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote: Setting the boot CPU ID is arch-specific KVM stuff. So push it where it belongs to. pc_init1 is also arch-specific, no? TCG should also be able to

Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

2010-02-02 Thread Jan Kiszka
Gleb Natapov wrote: On Tue, Feb 02, 2010 at 03:20:02PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote: Setting the boot CPU ID is arch-specific KVM stuff. So push it where it belongs to. pc_init1 is also arch-specific, no? TCG should

Re: [PATCH 2/3] Autotest: Porting all hash operations to use utils.hash

2010-02-02 Thread John Admanski
On Mon, Feb 1, 2010 at 7:04 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: Replace all functions that evaluate md5 and sha1 hexdigests with the function utils.hash(). Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com ---  client/tests/kvm/kvm_utils.py     |   16 +++-

Re: [PATCH v2] KVM: fix load_guest_segment_descriptor() to return X86EMUL_*

2010-02-02 Thread Marcelo Tosatti
On Tue, Feb 02, 2010 at 09:49:35PM +0900, Takuya Yoshikawa wrote: A bit more explanation, Takuya Yoshikawa wrote: This patch fixes load_guest_segment_descriptor() to return X86EMUL_PROPAGATE_FAULT when it tries to access the descriptor table beyond the limit of it: suggested by Marcelo.

Re: -smp =2 + -no-kvm-irqchip broken

2010-02-02 Thread Gleb Natapov
On Tue, Feb 02, 2010 at 05:29:53PM +0100, Jan Kiszka wrote: Hi, notice while testing v2 of my vcpu state series: Starting SMP guests like Linux or Vista without in-kernel irqchip and with more than one CPU make them lock up during boot (Vista) or spit out messages like udevd[112] trap

Re: -smp =2 + -no-kvm-irqchip broken

2010-02-02 Thread Jan Kiszka
Gleb Natapov wrote: On Tue, Feb 02, 2010 at 05:29:53PM +0100, Jan Kiszka wrote: Hi, notice while testing v2 of my vcpu state series: Starting SMP guests like Linux or Vista without in-kernel irqchip and with more than one CPU make them lock up during boot (Vista) or spit out messages like

Re: -smp =2 + -no-kvm-irqchip broken

2010-02-02 Thread Gleb Natapov
On Tue, Feb 02, 2010 at 05:41:03PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 02, 2010 at 05:29:53PM +0100, Jan Kiszka wrote: Hi, notice while testing v2 of my vcpu state series: Starting SMP guests like Linux or Vista without in-kernel irqchip and with more than one CPU

[PATCH] KVM test: Allways pass nic_model explicitly

2010-02-02 Thread Lucas Meneghel Rodrigues
Since qemu-kvm has as default nic rtl8139, and qemu has as default e1000, let's allways pass on the nic_model parameter. Also, let's append an @ to e1000 session, so its name is not appended to the test tag. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com ---

Re: [PATCH v2 2/2] virtio_net: Defer skb allocation in receive path

2010-02-02 Thread Shirley Ma
On Fri, 2010-01-29 at 16:05 +0200, Michael S. Tsirkin wrote: Now that's in, how does the send patch look? Thanks. I will submit it today. It's a simple patch. Shirley -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

No longer working on HPET

2010-02-02 Thread Beth Kon
I have decided to take a job outside of IBM and so will not be involved with HPET any longer. Working on KVM has been great fun... top-notch people and a top-notch technology. Wishing KVM and you all the best! -- Regards, Beth Kon -- To unsubscribe from this list: send the line unsubscribe

Re: -smp =2 + -no-kvm-irqchip broken

2010-02-02 Thread Jan Kiszka
Gleb Natapov wrote: On Tue, Feb 02, 2010 at 05:41:03PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 02, 2010 at 05:29:53PM +0100, Jan Kiszka wrote: Hi, notice while testing v2 of my vcpu state series: Starting SMP guests like Linux or Vista without in-kernel irqchip and with

Re: -smp =2 + -no-kvm-irqchip broken

2010-02-02 Thread Jan Kiszka
Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 02, 2010 at 05:41:03PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 02, 2010 at 05:29:53PM +0100, Jan Kiszka wrote: Hi, notice while testing v2 of my vcpu state series: Starting SMP guests like Linux or Vista without in-kernel

Re: [PATCH] Add cpu model configuration support.. (resend)

2010-02-02 Thread john cooper
Andre Przywara wrote: +[cpudef] + name = Conroe + level = 2 + vendor = GenuineIntel + family = 6 + model = 2 + stepping = 3 + feature_edx = sse2 sse fxsr mmx pat cmov pge sep apic cx8 mce pae msr tsc pse de fpumtrr clflush mca pse36 + feature_ecx = sse3 ssse3 +

[PATCH 0/1 net-next] virtio_net: remove send queue

2010-02-02 Thread Shirley Ma
This patch is built on top of net-next + defer skb patch for virtio_net. The patch has been tested and some performance has been gained by removing skb link unlink for each packet in send queue. thanks Shirley -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: How to edit *.qcow2

2010-02-02 Thread Asias He
you can try guestfish. http://libguestfs.org/recipes.html 2010/2/1 sati...@pacific.net.hk: Hi folks, KVM host – Debian 5.0 I need to mount kvm/qemu *.qcow2 image amending/reading its content. I can't figure out the type of file -t   1. mount -t mke2fs -o loop VM/vm30.qcow2 /mnt   2.

Re: [Autotest] [RFC] KVM test: Ship rss.exe and finish.exe binaries with KVM test

2010-02-02 Thread Yolkfull Chow
On Tue, Feb 02, 2010 at 09:48:34AM -0200, Lucas Meneghel Rodrigues wrote: Hi folks: We're on an effort of streamlining the KVM test experience, by choosing sane defaults and helper scripts that can overcome the initial barrier with getting the KVM test running. On one of the conversations

[PATCH v2] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-02 Thread Liu Yu
Old method prematurely sets ESR and DEAR. Move this part after we decide to inject interrupt, which is more like hardware behave. Signed-off-by: Liu Yu yu@freescale.com --- v2: use new fields queued_esr queued_dear to queue flags arch/powerpc/include/asm/kvm_host.h |2 +

Re: [PATCH v2] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-02 Thread Alexander Graf
On 02.02.2010, at 12:01, Liu Yu wrote: Old method prematurely sets ESR and DEAR. Move this part after we decide to inject interrupt, which is more like hardware behave. In general the patch looks good. I only have minor questions. Signed-off-by: Liu Yu yu@freescale.com --- v2: use

[PATCH v3] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-02 Thread Liu Yu
Old method prematurely sets ESR and DEAR. Move this part after we decide to inject interrupt, which is more like hardware behave. Signed-off-by: Liu Yu yu@freescale.com --- v3: change some functions to static arch/powerpc/include/asm/kvm_host.h |2 + arch/powerpc/kvm/booke.c

Re: [PATCH v3] kvmppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-02 Thread Alexander Graf
On 02.02.2010, at 12:44, Liu Yu wrote: Old method prematurely sets ESR and DEAR. Move this part after we decide to inject interrupt, which is more like hardware behave. Signed-off-by: Liu Yu yu@freescale.com Acked-by: Alexander Graf ag...@suse.de Alex -- To unsubscribe from this