KVM call agenda for Apr 13

2010-04-13 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6] KVM MMU: optimize for writing cr4

2010-04-13 Thread Avi Kivity
On 04/13/2010 06:07 AM, Xiao Guangrong wrote: And i found the commit 87778d60ee: |KVM: MMU: Segregate mmu pages created with different cr4.pge settings | |Don't allow a vcpu with cr4.pge cleared to use a shadow page created with |cr4.pge set; this might cause a cr3 switch not to

Re: VM performance issue in KVM guests.

2010-04-13 Thread Avi Kivity
On 04/13/2010 03:50 AM, Zhang, Xiantao wrote: Avi Kivity wrote: On 04/12/2010 05:04 AM, Zhang, Xiantao wrote: What was the performance hit? What was your I/O setup (image format, using aio?) The issue only happens when vcpu number is over-committed(e.g.

Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows

2010-04-13 Thread Takuya Yoshikawa
BTW, just from my curiosity, are there any cases in which we use such huge number of pages currently? ALIGN(memslot-npages, BITS_PER_LONG) / 8; More than G pages need really big memory! -- We are assuming some special cases like short int size? No, int is 32 bits, but memslot-npages is not

[PATCHv2] KVM: move DR register access handling into generic code

2010-04-13 Thread Gleb Natapov
Currently both SVM and VMX have their own DR handling code. Move it to x86.c. Changelog: v1-v2 - kvm_set_dr() always return 1 in a case of error Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 0c49c88..5d5e0a9

Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows

2010-04-13 Thread Avi Kivity
On 04/13/2010 10:03 AM, Takuya Yoshikawa wrote: It's better to limit memory slots to something that can be handled by everything, then. 2^31 pages is plenty. Return -EINVAL if the slot is too large. I agree with that, so we make this patch pending to fix like that? -- or should make a new

[PATCH] get rid of mmu_only parameter in emulator_write_emulated()

2010-04-13 Thread Gleb Natapov
May be I am missing something here, but it seams we can call kvm_mmu_pte_write() directly from emulator_cmpxchg_emulated() instead of passing mmu_only down to emulator_write_emulated_onepage() and call it there. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/arch/x86/kvm/x86.c

Re: [PATCH] get rid of mmu_only parameter in emulator_write_emulated()

2010-04-13 Thread Avi Kivity
On 04/13/2010 10:21 AM, Gleb Natapov wrote: May be I am missing something here, but it seams we can call kvm_mmu_pte_write() directly from emulator_cmpxchg_emulated() instead of passing mmu_only down to emulator_write_emulated_onepage() and call it there. @@ -3460,7 +3444,9 @@ static int

Re: [PATCH] get rid of mmu_only parameter in emulator_write_emulated()

2010-04-13 Thread Avi Kivity
On 04/13/2010 10:26 AM, Gleb Natapov wrote: On Tue, Apr 13, 2010 at 10:24:40AM +0300, Avi Kivity wrote: On 04/13/2010 10:21 AM, Gleb Natapov wrote: May be I am missing something here, but it seams we can call kvm_mmu_pte_write() directly from emulator_cmpxchg_emulated() instead of

Re: [PATCH] get rid of mmu_only parameter in emulator_write_emulated()

2010-04-13 Thread Gleb Natapov
On Tue, Apr 13, 2010 at 10:35:53AM +0300, Avi Kivity wrote: On 04/13/2010 10:26 AM, Gleb Natapov wrote: On Tue, Apr 13, 2010 at 10:24:40AM +0300, Avi Kivity wrote: On 04/13/2010 10:21 AM, Gleb Natapov wrote: May be I am missing something here, but it seams we can call kvm_mmu_pte_write()

Re: [PATCH v2 3/6] Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap.

2010-04-13 Thread Yoshiaki Tamura
Avi Kivity wrote: On 04/12/2010 01:58 PM, Yoshiaki Tamura wrote: Is it necessary to update migration and vga bitmaps? We can simply update the master bitmap, and update the migration and vga bitmaps only when they need it. That can be done in a different patch. Let me explain the role of

Re: [PATCH v2 3/6] Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap.

2010-04-13 Thread Avi Kivity
On 04/13/2010 11:01 AM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 04/12/2010 01:58 PM, Yoshiaki Tamura wrote: Is it necessary to update migration and vga bitmaps? We can simply update the master bitmap, and update the migration and vga bitmaps only when they need it. That can be done in a

Re: [PATCH v2 3/6] Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap.

2010-04-13 Thread Yoshiaki Tamura
Avi Kivity wrote: On 04/13/2010 11:01 AM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 04/12/2010 01:58 PM, Yoshiaki Tamura wrote: Is it necessary to update migration and vga bitmaps? We can simply update the master bitmap, and update the migration and vga bitmaps only when they need it. That

[PATCH] qemu-kvm: emulator tests: fix msr test

2010-04-13 Thread Naphtali Sprei
use correct 64 bit mode inline assembly constraints use a canonical form address when writing to the MSR_KERNEL_GS_BASE MSR Signed-off-by: Naphtali Sprei nsp...@redhat.com --- kvm/user/test/x86/msr.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] vhost-net: fix vq_memory_access_ok error checking

2010-04-13 Thread Michael S. Tsirkin
On Wed, Apr 07, 2010 at 09:59:10AM -0400, Jeff Dike wrote: vq_memory_access_ok needs to check whether mem == NULL Signed-off-by: Jeff Dike jd...@linux.intel.com Signed-off-by: Michael S. Tsirkin m...@redhat.com This was already queued by me, you do not need to fill Dave's inbox with vhost

Re: [PATCH] vhost-net: fix vq_memory_access_ok error checking

2010-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2010 at 06:01:21PM +0300, Michael S. Tsirkin wrote: On Wed, Apr 07, 2010 at 09:59:10AM -0400, Jeff Dike wrote: vq_memory_access_ok needs to check whether mem == NULL Signed-off-by: Jeff Dike jd...@linux.intel.com Signed-off-by: Michael S. Tsirkin m...@redhat.com This

Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking parent unsync

2010-04-13 Thread Marcelo Tosatti
On Tue, Apr 13, 2010 at 09:53:07AM +0800, Xiao Guangrong wrote: Marcelo Tosatti wrote: Xiao, Did you actually see this codepath as being performance sensitive? Actually, i not run benchmarks to contrast the performance before this patch and after this patch. I'd prefer to

Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its calling path

2010-04-13 Thread Marcelo Tosatti
On Tue, Apr 13, 2010 at 09:34:14AM +0800, Xiao Guangrong wrote: Marcelo Tosatti wrote: @@ -1483,8 +1483,8 @@ static int mmu_zap_unsync_children(struct kvm *kvm, for_each_sp(pages, sp, parents, i) { kvm_mmu_zap_page(kvm, sp);

Re: [PATCHv2] KVM: move DR register access handling into generic code

2010-04-13 Thread Jan Kiszka
Gleb Natapov wrote: Currently both SVM and VMX have their own DR handling code. Move it to x86.c. Changelog: v1-v2 - kvm_set_dr() always return 1 in a case of error Signed-off-by: Gleb Natapov g...@redhat.com Acked-by: Jan Kiszka jan.kis...@siemens.com diff --git

Re: [PATCHv2] KVM: move DR register access handling into generic code

2010-04-13 Thread Marcelo Tosatti
On Tue, Apr 13, 2010 at 10:05:23AM +0300, Gleb Natapov wrote: Currently both SVM and VMX have their own DR handling code. Move it to x86.c. Changelog: v1-v2 - kvm_set_dr() always return 1 in a case of error Signed-off-by: Gleb Natapov g...@redhat.com Applied, thanks. -- To

Re: [PATCH] vhost: fix sparse warnings

2010-04-13 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig h...@lst.de Index: linux-2.6/drivers/vhost/net.c === --- linux-2.6.orig/drivers/vhost/net.c 2010-04-05 21:13:24.196004388 +0200 +++ linux-2.6/drivers/vhost/net.c 2010-04-05 21:13:32.726004109

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

2010-04-13 Thread Mohammed Gamal
On Tue, Apr 13, 2010 at 9:08 PM, jvrao jv...@linux.vnet.ibm.com wrote: jvrao wrote: Alexander Graf wrote: On 12.04.2010, at 13:58, Jamie Lokier wrote: Mohammed Gamal wrote: On Mon, Apr 12, 2010 at 12:29 AM, Jamie Lokier ja...@shareable.org wrote: Javier Guerra Giraldez wrote: On Sat, Apr

Re: [Autotest] [PATCH] KVM test: Memory ballooning test for KVM guest

2010-04-13 Thread Lucas Meneghel Rodrigues
On Tue, Apr 13, 2010 at 1:24 AM, pradeep psuri...@linux.vnet.ibm.com wrote: Lucas Any comments?? No pradeep, Sudhir's comments are very reasonable, please implement the changes he suggested and re-send the patch, I am going to do some testing on it on my local systems and then commit it

kvmtrace and debugging kvm

2010-04-13 Thread Manish Regmi
hi, I am trying to use kvmtrace but it looks like its no longer used. in kvm_main.c it is returning -EOPNOTSUP. kvmtrace -V -D test -o mykvmtest does not seem to do anything. is it no longer used? is there any better way of debugging kvm? Thank you.

RE: VM performance issue in KVM guests.

2010-04-13 Thread Zhang, Xiantao
Avi Kivity wrote: On 04/13/2010 03:50 AM, Zhang, Xiantao wrote: Avi Kivity wrote: On 04/12/2010 05:04 AM, Zhang, Xiantao wrote: What was the performance hit? What was your I/O setup (image format, using aio?) The issue only happens when vcpu number is over-committed(e.g.

Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking parent unsync

2010-04-13 Thread Xiao Guangrong
Marcelo Tosatti wrote: I'd prefer to not touch it. This patch avoids walk all parents and i think this overload is really unnecessary. It has other tricks in this codepath but i not noticed? :-) My point is that there is no point in optimizing something unless its performance