From: Alex Williamson alex.william...@redhat.com
We keep a qlist of assigned devices for irq updates, but we forgot to
remove entries from it if they're hot unplugged. This makes
assigned_dev_update_irqs() a timebomb that goes off when the guest is
rebooted.
Signed-off-by: Alex Williamson
From: Glauber Costa glom...@redhat.com
Currently, in the linux kernel, we reset kvmclock if we are rebooting
into a crash kernel through kexec. The rationale, is that a new kernel
won't follow the same memory addresses, and the memory where kvmclock is
located in the first kernel, will be
From: Avi Kivity a...@redhat.com
Signed-off-by: Avi Kivity a...@redhat.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/kvm/user/test/x86/emulator.c b/kvm/user/test/x86/emulator.c
index 5406062..e677e3a 100644
--- a/kvm/user/test/x86/emulator.c
+++
From: Mohammed Gamal m.gamal...@gmail.com
Adds test for xor acc, imm
Signed-off-by: Mohammed Gamal m.gamal...@gmail.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/kvm/user/test/x86/realmode.c b/kvm/user/test/x86/realmode.c
index 41e2aea..70a1e05 100644
---
From: Alex Williamson alex.william...@redhat.com
Since c1699988, piix config space isn't programmed until the first
system reset. This means that when we call assign_irq() from
assigned_initfn(), we're going to get back an irq of 0x0, which
unfortunately matches our initialization value, so we
From: Mohammed Gamal m.gamal...@gmail.com
Adds tests fot sub acc, imm
Signed-off-by: Mohammed Gamal m.gamal...@gmail.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/kvm/user/test/x86/realmode.c b/kvm/user/test/x86/realmode.c
index bc4ed97..41e2aea 100644
---
From: Gui Jianfeng guijianf...@cn.fujitsu.com
There's no member cr4_nxe in struct kvm_mmu_page_role, it names nxe now.
Update mmu document.
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/Documentation/kvm/mmu.txt
From: Dongxiao Xu dongxiao...@intel.com
cpuid_update may operate VMCS, so vcpu_load() and vcpu_put()
should be called to ensure correctness.
Signed-off-by: Dongxiao Xu dongxiao...@intel.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
From: Marcelo Tosatti mtosa...@redhat.com
Conflicts:
arch/x86/kernel/process.c
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe kvm-commits in
the body of a message to majord...@vger.kernel.org
More majordomo info at
From: Jan Kiszka jan.kis...@siemens.com
As the processor may not consider GUEST_INTR_STATE_STI as a reason for
blocking NMI, it could return immediately with EXIT_REASON_NMI_WINDOW
when we asked for it. But as we consider this state as NMI-blocking, we
can run into an endless loop.
Resolve this
From: Dongxiao Xu dongxiao...@intel.com
Define vmcs_load() and kvm_cpu_vmxon() to avoid direct call of asm
code. Also move VMXE bit operation out of kvm_cpu_vmxoff().
Signed-off-by: Dongxiao Xu dongxiao...@intel.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git
From: Glauber Costa glom...@redhat.com
This cpuid, KVM_CPUID_CLOCKSOURCE2, will indicate to the guest
that kvmclock is available through a new set of MSRs. The old ones
are deprecated.
Signed-off-by: Glauber Costa glom...@redhat.com
Acked-by: Zachary Amsden zams...@redhat.com
Signed-off-by:
From: Dongxiao Xu dongxiao...@intel.com
Originally VMCLEAR/VMPTRLD is called on vcpu migration. To
support hosted VMM coexistance, VMCLEAR is executed on vcpu
schedule out, and VMPTRLD is executed on vcpu schedule in.
This could also eliminate the IPI when doing VMCLEAR.
Signed-off-by: Dongxiao
From: Glauber Costa glom...@redhat.com
This patch removes one padding byte and transform it into a flags
field. New versions of guests using pvclock will query these flags
upon each read.
Flags, however, will only be interpreted when the guest decides to.
It uses the pvclock_valid_flags function
From: Glauber Costa glom...@redhat.com
If the HV told us we can fully trust the TSC, skip any
correction
Signed-off-by: Glauber Costa glom...@redhat.com
Acked-by: Zachary Amsden zams...@redhat.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/include/asm/kvm_para.h
From: Dongxiao Xu dongxiao...@intel.com
SDM suggests VMXON should be called before VMPTRLD, and VMXOFF
should be called after doing VMCLEAR.
Therefore in vmm coexistence case, we should firstly call VMXON
before any VMCS operation, and then call VMXOFF after the
operation is done.
From: Glauber Costa glom...@redhat.com
In recent stress tests, it was found that pvclock-based systems
could seriously warp in smp systems. Using ingo's time-warp-test.c,
I could trigger a scenario as bad as 1.5mi warps a minute in some systems.
(to be fair, it wasn't that bad in most of them).
From: Glauber Costa glom...@redhat.com
Right now, we were using individual KVM_CAP entities to communicate
userspace about which cpuids we support. This is suboptimal, since it
generates a delay between the feature arriving in the host, and
being available at the guest.
A much better mechanism
From: Mohammed Gamal m.gamal...@gmail.com
This adds missing decoder flags for sub instructions (opcodes 0x2c - 0x2d)
Signed-off-by: Mohammed Gamal m.gamal...@gmail.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index
From: Marcelo Tosatti mtosa...@redhat.com
Code removed upstream sneaked in through the merge.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 83ccfdf..8bcc21f 100644
--- a/arch/x86/kernel/process.c
+++
From: Glauber Costa glom...@redhat.com
This file documents cpuid bits used by KVM.
Signed-off-by: Glauber Costa glom...@redhat.com
Acked-by: Zachary Amsden zams...@redhat.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/Documentation/kvm/cpuid.txt
From: Sheng Yang sh...@linux.intel.com
Only modifying some bits of CR0/CR4 needs paging mode switch.
Modify EFER.NXE bit would result in reserved bit updates.
Signed-off-by: Sheng Yang sh...@linux.intel.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/x86.c
From: Mohammed Gamal m.gamal...@gmail.com
This adds test acc, imm instruction to the x86 emulator
Signed-off-by: Mohammed Gamal m.gamal...@gmail.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index b43ac98..35dd57c 100644
---
From: Avi Kivity a...@redhat.com
The current lmsw implementation allows the guest to clear cr0.pe, contrary
to the manual, which breaks EMM386.EXE.
Fix by ORing the old cr0.pe with lmsw's operand.
Signed-off-by: Avi Kivity a...@redhat.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff
From: Xiao Guangrong xiaoguangr...@cn.fujitsu.com
Use kmem_cache_free to free objects allocated by kmem_cache_alloc.
Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index
From: Avi Kivity a...@redhat.com
When cr0.wp=0, we may shadow a gpte having u/s=1 and r/w=0 with an spte
having u/s=0 and r/w=1. This allows excessive access if the guest sets
cr0.wp=1 and accesses through this spte.
Fix by making cr0.wp part of the base role; we'll have different sptes for
the
From: Xiao Guangrong xiaoguangr...@cn.fujitsu.com
sp-gfns[] contain unaliased gfns, but gpte might contain pointer
to aliased region.
Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/paging_tmpl.h
From: Sheng Yang sh...@linux.intel.com
mmu.free() already set root_hpa to INVALID_PAGE, no need to do it again in the
destory_kvm_mmu().
kvm_x86_ops-set_cr4() and set_efer() already assign cr4/efer to
vcpu-arch.cr4/efer, no need to do it again later.
Signed-off-by: Sheng Yang
From: Avi Kivity a...@redhat.com
Signed-off-by: Avi Kivity a...@redhat.com
diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
index 11f226f..b998abf 100644
--- a/arch/powerpc/kvm/book3s.c
+++ b/arch/powerpc/kvm/book3s.c
@@ -1110,6 +1110,8 @@ int
From: Avi Kivity a...@redhat.com
Signed-off-by: Avi Kivity a...@redhat.com
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index e80f55e..28cd8fd 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -363,9 +363,7 @@ int kvm_arch_vcpu_runnable(struct kvm_vcpu
From: Avi Kivity a...@redhat.com
Signed-off-by: Avi Kivity a...@redhat.com
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index bfe0730..7167109 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1854,6 +1854,7 @@ static int kvm_vcpu_ioctl_get_cpuid2(struct kvm_vcpu
*vcpu,
{
From: Marcelo Tosatti mtosa...@redhat.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 604eb3f..fd2c8f4 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -2067,7 +2067,7 @@ static int mmu_alloc_roots(struct kvm_vcpu
From: Sheng Yang sh...@linux.intel.com
kvm_x86_ops-set_efer() would execute vcpu-arch.efer = efer, so the
checking of LMA bit didn't work.
Signed-off-by: Sheng Yang sh...@linux.intel.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
From: Avi Kivity a...@redhat.com
Signed-off-by: Avi Kivity a...@redhat.com
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 75a6e8a..ce4e943 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1541,16 +1541,12 @@ static int __msr_io(struct kvm_vcpu *vcpu, struct
kvm_msrs
From: Alex Williamson alex.william...@redhat.com
Remove this check in an effort to allow kvm guests to run without
root privileges. This capability check doesn't seem to add any
security since the device needs to have already been added via the
assign device ioctl and the io actually occurs
From: Xiao Guangrong xiaoguangr...@cn.fujitsu.com
fix:
arch/x86/kvm/x86.c: In function ‘handle_emulation_failure’:
arch/x86/kvm/x86.c:3844: warning: unused variable ‘ctxt’
Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
diff --git
From: Avi Kivity a...@redhat.com
Now that all arch specific ioctls have centralized locking, it is easy to
move it to the central dispatcher.
Signed-off-by: Avi Kivity a...@redhat.com
diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
index caeed7b..a1d8750 100644
---
On 05/16/2010 04:00 AM, Alexander Graf wrote:
On 15.05.2010, at 19:30, Avi Kivity wrote:
On 05/15/2010 11:26 AM, Alexander Graf wrote:
That means you never inject an interrupt from the iothread (or from a different
vcpu thread)?
If that's the case we might make it part of
On Thu, May 13, 2010 at 07:49:40PM +0300, Avi Kivity wrote:
On 05/10/2010 06:58 PM, Anthony Liguori wrote:
Isn't this problem unrelated to this patch? I mean if I start qemu with
two ide devices can I specify from qemu command line which one I want to
boot from?
That's sort of what I'm
On 16.05.2010, at 10:23, Avi Kivity wrote:
On 05/16/2010 04:00 AM, Alexander Graf wrote:
On 15.05.2010, at 19:30, Avi Kivity wrote:
On 05/15/2010 11:26 AM, Alexander Graf wrote:
That means you never inject an interrupt from the iothread (or from a
different vcpu
On 05/16/2010 12:01 PM, Alexander Graf wrote:
That's what the world looked like in 2006.
We could change it, but there's not much point, since having the local apic in
the kernel is pretty much a requirement for reasonable performance.
Well, I'm not convinced yet that's the case for
On 16.05.2010, at 11:09, Avi Kivity wrote:
On 05/16/2010 12:01 PM, Alexander Graf wrote:
That's what the world looked like in 2006.
We could change it, but there's not much point, since having the local apic
in the kernel is pretty much a requirement for reasonable performance.
On 05/16/2010 12:35 PM, Alexander Graf wrote:
So let me think this through. With remote interrupt injection we have.
* thread 1 does vcpu_run
* thread 2 triggers KVM_INTERRUPT on fd
* thread 2 signals thread 1 so we're sure the interrupt gets injected
* thread 1 exits into qemu
On 16.05.2010, at 11:47, Avi Kivity wrote:
1: vcpu_run
2: KVM_INTERRUPT
2k: sets flag, if msr.ee IPIs 1 or wakes up 1 if halted
Doesn't that break when we have a while(1) loop in the guest with msr.ee=0
while no timer is scheduled on the host? But then again with msr.ee=0 we don't
get
On 05/15/2010 03:03 AM, Marcelo Tosatti wrote:
On Thu, May 13, 2010 at 02:17:35PM +0300, Avi Kivity wrote:
All vcpu ioctls need to be locked, so instead of locking each one specifically
we lock at the generic dispatcher.
This patch only updates generic ioctls and leaves arch specific
On 05/15/2010 04:19 AM, Teck Choon Giam wrote:
Hi,
Anyone encountered the same issue as me about system_powerdown no
longer working since upgraded to qemu-kvm 0.12.4?
Compared with what version?
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this
On 05/12/2010 02:11 AM, Juan Quintela wrote:
Peter Lievenp...@dlh.net wrote:
Hi Qemu/KVM Devel Team,
Live Migration from a 0.12.2 qemu-kvm to a 0.12.3 (and 0.12.4)
does not work: load of migration failed
Is there any way to find out, why exactly it fails? I have
a lot of VMs running on
On 05/14/2010 09:24 PM, Andrej Podzimek wrote:
Hello,
when I enable Intel TXT (Trusted Execution Technology) in the BIOS
settings of my Lenovo W510, the kvm-intel module does not load and
says 'kvm: disabled by bios', despite the fact that both VT-x and VT-d
are enabled. Disabling TXT
On Sat, May 15, 2010 at 06:30:52AM -0700, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a special BlockDriverState-sg check in
block.c:find_image_format()
after bdrv_file_open() - block/raw-posix.c:hdev_open() has been called to
determine
if
On Sat, May 15, 2010 at 06:30:59AM -0700, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a BlockDriverState-sg check in block.c:bdrv_common_open()
to skip the new refresh_total_sectors() call once we know we are working with
a scsi-generic device.
Avi Kivity a...@redhat.com wrote:
On 05/12/2010 02:11 AM, Juan Quintela wrote:
Peter Lievenp...@dlh.net wrote:
Hi Qemu/KVM Devel Team,
Live Migration from a 0.12.2 qemu-kvm to a 0.12.3 (and 0.12.4)
does not work: load of migration failed
Is there any way to find out, why exactly it
On 05/16/2010 05:42 PM, Juan Quintela wrote:
Any idea why it fails? And how to fix it?
Lack of proper subsections. IDE is something like:
const VMStateDescription vmstate_ide_drive = {
.version_id = 4,
}
static const VMStateDescription vmstate_bmdma = {
.name = ide
Juan Quintela wrote:
Lack of proper subsections. IDE is something like:
const VMStateDescription vmstate_ide_drive = {
.version_id = 4,
}
static const VMStateDescription vmstate_bmdma = {
.name = ide bmdma,
.version_id = 4,
...
}
const VMStateDescription
Avi Kivity a...@redhat.com wrote:
On 05/16/2010 05:42 PM, Juan Quintela wrote:
Any idea why it fails? And how to fix it?
Lack of proper subsections. IDE is something like:
const VMStateDescription vmstate_ide_drive = {
.version_id = 4,
}
static const
Jan Kiszka jan.kis...@web.de wrote:
Juan Quintela wrote:
Lack of proper subsections. IDE is something like:
const VMStateDescription vmstate_ide_drive = {
.version_id = 4,
}
static const VMStateDescription vmstate_bmdma = {
.name = ide bmdma,
.version_id = 4,
...
}
On Sun, 2010-05-16 at 15:29 +0200, Christoph Hellwig wrote:
On Sat, May 15, 2010 at 06:30:52AM -0700, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a special BlockDriverState-sg check in
block.c:find_image_format()
after bdrv_file_open() -
On Sun, 2010-05-16 at 15:30 +0200, Christoph Hellwig wrote:
On Sat, May 15, 2010 at 06:30:59AM -0700, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a BlockDriverState-sg check in block.c:bdrv_common_open()
to skip the new
From: Nicholas Bellinger n...@linux-iscsi.org
Greetings,
Attached are the updated patches following hch's comments to fix scsi-generic
device breakage with find_image_format() and refresh_total_sectors().
These are being resent as the last attachments where in MBOX format from
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a special case check for scsi-generic devices in
refresh_total_sectors()
to skip the subsequent BlockDriver-bdrv_getlength() that will be returning
-ESPIPE from block/raw-posic.c:raw_getlength() for BlockDriverState-sg=1
devices.
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a special BlockDriverState-sg check in
block.c:find_image_format()
after bdrv_file_open() - block/raw-posix.c:hdev_open() has been called to
determine
if we are dealing with a Linux host scsi-generic device.
The patch then returns
On 05/16/2010 04:00 AM, Alexander Graf wrote:
On 15.05.2010, at 19:30, Avi Kivity wrote:
On 05/15/2010 11:26 AM, Alexander Graf wrote:
That means you never inject an interrupt from the iothread (or from a different
vcpu thread)?
If that's the case we might make it part of
On 16.05.2010, at 10:23, Avi Kivity wrote:
On 05/16/2010 04:00 AM, Alexander Graf wrote:
On 15.05.2010, at 19:30, Avi Kivity wrote:
On 05/15/2010 11:26 AM, Alexander Graf wrote:
That means you never inject an interrupt from the iothread (or from a
different vcpu
On 16.05.2010, at 11:09, Avi Kivity wrote:
On 05/16/2010 12:01 PM, Alexander Graf wrote:
That's what the world looked like in 2006.
We could change it, but there's not much point, since having the local apic
in the kernel is pretty much a requirement for reasonable performance.
On 05/16/2010 12:35 PM, Alexander Graf wrote:
So let me think this through. With remote interrupt injection we have.
* thread 1 does vcpu_run
* thread 2 triggers KVM_INTERRUPT on fd
* thread 2 signals thread 1 so we're sure the interrupt gets injected
* thread 1 exits into qemu
On 16.05.2010, at 11:47, Avi Kivity wrote:
1: vcpu_run
2: KVM_INTERRUPT
2k: sets flag, if msr.ee IPIs 1 or wakes up 1 if halted
Doesn't that break when we have a while(1) loop in the guest with msr.ee=0
while no timer is scheduled on the host? But then again with msr.ee=0 we don't
get
65 matches
Mail list logo