[PATCH] Re: Tracing backends : Fix for building with --prefix

2010-06-08 Thread Prerna Saxena
This patch is a minor fix over Stefan's tracing framework, to enable compilation when the build directory is different from source. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile

Re: [PATCH v2 0/4] Fix accessed bit tracking

2010-06-08 Thread Xiao Guangrong
Avi Kivity wrote: On 06/08/2010 05:35 AM, Xiao Guangrong wrote: We can avoid the exchange in most cases, for example if the new spte has the accessed bit set (already in the patch set) or if the page is already marked as accessed, or if we see the old spte has the accessed bit set (so no

[PATCH 0/3] Monitor commands for 'simple' trace backend

2010-06-08 Thread Prerna Saxena
This patchset is based on Stefan's trace framework: ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html ) This adds the following monitor commands for the 'simple' backend: - trace : to view current contents of the trace buffer - info tracepoints : to view

[PATCH 1/3] export tdb_hash()

2010-06-08 Thread Prerna Saxena
This exports tdb_hash() for use by tracing framework. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- qdict.c |2 +- qdict.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qdict.c b/qdict.c index 175bc17..5261872 100644 --- a/qdict.c +++ b/qdict.c @@

[PATCH 2/3] Monitor command 'trace'

2010-06-08 Thread Prerna Saxena
This introduces the monitor command 'trace' to read current contents of trace buffer. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- configure |3 +++ monitor.c |3 +++ qemu-monitor.hx | 16 simpletrace.c | 15 +++ tracetool

[PATCH 3/3] Toggle tracepoint state

2010-06-08 Thread Prerna Saxena
This patch adds support for dynamically enabling/disabling of tracepoints. Monitor commands added : 1) info tracepoints : to view all available tracepoints and their state. 2) tracepoint NAME on|off : to enable/disable data logging from a

Re: KVM call agenda for June 8

2010-06-08 Thread Juan Quintela
Anthony Liguori anth...@codemonkey.ws wrote: On 06/07/2010 05:26 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. - Accelerating counters (aka moving PIT to userspace, keeping HPET in

Re: [PATCH v2 0/4] Fix accessed bit tracking

2010-06-08 Thread Avi Kivity
On 06/08/2010 09:53 AM, Xiao Guangrong wrote: Avi Kivity wrote: On 06/08/2010 05:35 AM, Xiao Guangrong wrote: We can avoid the exchange in most cases, for example if the new spte has the accessed bit set (already in the patch set) or if the page is already marked as

[PATCH] KVM-test: kvm.py: Code style fix

2010-06-08 Thread Marc Enthus
From: Marc Enthus cxz...@gmail.com According to autotest coding style and http://www.python.org/dev/peps/pep-0008/ use if pa_type is not None: instead of if pa_type: Signed-off-by: Marc Enthus cxz...@gmail.com --- client/tests/kvm/kvm_vm.py |2 +- 1 files changed, 1

Re: [PATCH] KVM: VMX: fix rcu usage warning

2010-06-08 Thread Avi Kivity
On 06/08/2010 05:15 AM, Xiao Guangrong wrote: fix: [ INFO: suspicious rcu_dereference_check() usage. ] --- include/linux/kvm_host.h:258 invoked rcu_dereference_check() without protection! other info that might help us debug this:

Re: [PATCH v2 0/4] Fix accessed bit tracking

2010-06-08 Thread Xiao Guangrong
Avi Kivity wrote: On 06/08/2010 09:53 AM, Xiao Guangrong wrote: Avi Kivity wrote: On 06/08/2010 05:35 AM, Xiao Guangrong wrote: We can avoid the exchange in most cases, for example if the new spte has the accessed bit set (already in the patch set) or if the page is

Re: KVM call agenda for June 8

2010-06-08 Thread Avi Kivity
On 06/08/2010 01:26 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. APIC wiring problems (attached slides) -- error compiling committee.c: too many arguments to function apic-wiring-mess.odp Description:

Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-bit opensuse-11.2 VM, the incoming VM shows the following error after the mem transfer has finished: kvm: unhandled exit 8022

Re: [Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 - 0.12.3/4 broken?

2010-06-08 Thread Peter Lieven
Jan Kiszka wrote: Juan Quintela wrote: Jan Kiszka jan.kis...@web.de wrote: Juan Quintela wrote: Lack of proper subsections. IDE is something like: const VMStateDescription vmstate_ide_drive = { .version_id = 4, } static const VMStateDescription vmstate_bmdma = {

Re: KVM call agenda for June 8

2010-06-08 Thread Avi Kivity
On 06/08/2010 11:50 AM, Avi Kivity wrote: On 06/08/2010 01:26 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. APIC wiring problems (attached slides) See also http://www.intel.com/design/pentium/datashts/242016.HTM. -- error compiling committee.c:

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-bit opensuse-11.2 VM, the incoming VM shows the following error after the mem transfer

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 02:29 PM, Avi Kivity wrote: On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-bit opensuse-11.2 VM, the incoming VM shows

Re: [Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-bit opensuse-11.2 VM, the incoming VM shows the following error

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 02:31 PM, Avi Kivity wrote: On 06/08/2010 02:29 PM, Avi Kivity wrote: On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a

[PATCH 1/3] KVM: MMU: remove unnecessary remote tlb flush

2010-06-08 Thread Xiao Guangrong
This remote tlb flush is no necessary since we have synced while sp is zapped Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com --- arch/x86/kvm/mmu.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 6b2c644..959c248

[PATCH 2/3] KVM: MMU: using wrapper function to flush local tlb

2010-06-08 Thread Xiao Guangrong
Using kvm_mmu_flush_tlb() function instead of calling kvm_x86_ops-tlb_flush(vcpu) directly Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com --- arch/x86/kvm/mmu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index

[PATCH 3/3] KVM: MMU: delay local tlb flush

2010-06-08 Thread Xiao Guangrong
delay local tlb flush until enter guest moden, it can reduce vpid flush frequency and reduce remote tlb flush IPI(if KVM_REQ_TLB_FLUSH bit is already set, IPI is not sent) Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com --- arch/x86/kvm/mmu.c |2 +- 1 files changed, 1

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 02:31 PM, Avi Kivity wrote: On 06/08/2010 02:29 PM, Avi Kivity wrote: On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 03:49 PM, Peter Lieven wrote: And finally, perhaps you have NX disabled in the bios of one of the machines? What does 'dmesg | grep NX' show on both hosts? nx was disabled on one of the nodes. That explains the problem. i will retry the case later today and send info

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 03:49 PM, Peter Lieven wrote: And finally, perhaps you have NX disabled in the bios of one of the machines? What does 'dmesg | grep NX' show on both hosts? nx was disabled on one of the nodes. That explains the problem. i will retry the case later

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 03:49 PM, Peter Lieven wrote: And finally, perhaps you have NX disabled in the bios of one of the machines? What does 'dmesg | grep NX' show on both hosts? nx was disabled on one of the nodes. That explains the problem. i will retry the case later

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 04:28 PM, Peter Lieven wrote: i will retry the case later today and send info register output. what is the recommended value for nx (and why)? Enabled (so you get no-execute memory protection). do you have a guideline which flags should be identical to ensure proper live

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 04:28 PM, Peter Lieven wrote: i will retry the case later today and send info register output. what is the recommended value for nx (and why)? Enabled (so you get no-execute memory protection). do you have a guideline which flags should be identical to

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 04:38 PM, Peter Lieven wrote: Avi Kivity wrote: On 06/08/2010 04:28 PM, Peter Lieven wrote: i will retry the case later today and send info register output. what is the recommended value for nx (and why)? Enabled (so you get no-execute memory protection). do you have a

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 04:38 PM, Peter Lieven wrote: Avi Kivity wrote: On 06/08/2010 04:28 PM, Peter Lieven wrote: i will retry the case later today and send info register output. what is the recommended value for nx (and why)? Enabled (so you get no-execute memory protection).

Re: [PATCH 2/2] qemu-kvm tests: make sieve test runable on 32-bit host

2010-06-08 Thread Avi Kivity
On 06/07/2010 06:11 PM, Asias He wrote: Signed-off-by: Asias Heasias.he...@gmail.com --- kvm/test/config-x86-common.mak |4 +- kvm/test/config-x86_64.mak |4 +- kvm/test/x86/sieve.c | 48 --- Applied both, thanks. -- error

Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 04:44 PM, Peter Lieven wrote: -cpu host is good if you have identical machines and don't plan to add new ones. i will likely add new ones, but my plan would be to use qemu64 and then add all flags manually that are common to all cpus in the pool. would that be safe? Yes. --

KVM call minutes for June 8

2010-06-08 Thread Chris Wright
Accelerating counters (aka moving PIT to userspace, keeping HPET in userspace) - PIT (in-kernel, userspace, or split) - userspace PIT, too slow - kernel PIT (already seen bugs) - split PIT, not realistic w/out a sane interface (see bugs above) - exit to userspace is a base cost, add MSR

[RFC/T/D][PATCH 0/2] KVM page cache optimization (v2)

2010-06-08 Thread Balbir Singh
This is version 2 of the page cache control patches for KVM. This series has two patches, the first controls the amount of unmapped page cache usage via a boot parameter and sysctl. The second patch controls page and slab cache via the balloon driver. Both the patches make heavy use of the

[RFC][PATCH 1/2] Linux/Guest unmapped page cache control

2010-06-08 Thread Balbir Singh
Selectively control Unmapped Page Cache (nospam version) From: Balbir Singh bal...@linux.vnet.ibm.com This patch implements unmapped page cache control via preferred page cache reclaim. The current patch hooks into kswapd and reclaims page cache if the user has requested for unmapped page

[RFC/T/D][PATCH 2/2] Linux/Guest cooperative unmapped page cache control

2010-06-08 Thread Balbir Singh
Balloon unmapped page cache pages first From: Balbir Singh bal...@linux.vnet.ibm.com This patch builds on the ballooning infrastructure by ballooning unmapped page cache pages first. It looks for low hanging fruit first and tries to reclaim clean unmapped pages first. This patch brings

Re: KVM call minutes for June 8

2010-06-08 Thread Anthony Liguori
On 06/08/2010 10:05 AM, Chris Wright wrote: Accelerating counters (aka moving PIT to userspace, keeping HPET in userspace) - PIT (in-kernel, userspace, or split) - userspace PIT, too slow - kernel PIT (already seen bugs) - split PIT, not realistic w/out a sane interface (see bugs above) - exit

[RFC][PATCH 1/3] Introduce a workqueue to deliver PIT timer interrupts.

2010-06-08 Thread Chris Lalancette
We really want to kvm_set_irq during the hrtimer callback, but that is risky because that is during interrupt context. Instead, offload the work to a workqueue, which is a bit safer and should provide most of the same functionality. Signed-off-by: Chris Lalancette clala...@redhat.com ---

[RFC][PATCH 2/3] Allow any LAPIC to accept PIC interrupts.

2010-06-08 Thread Chris Lalancette
If the guest wants to accept timer interrupts on a CPU other than the BSP, we need to remove this gate. Signed-off-by: Chris Lalancette clala...@redhat.com --- arch/x86/kvm/lapic.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/x86/kvm/lapic.c

[RFC][PATCH 3/3] In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's

2010-06-08 Thread Chris Lalancette
Otherwise we might try to deliver a timer interrupt to a cpu that can't possibly handle it. Signed-off-by: Chris Lalancette clala...@redhat.com --- virt/kvm/irq_comm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c index

Re: [PATCH] KVM-test: kvm.py: Code style fix

2010-06-08 Thread Lucas Meneghel Rodrigues
On Tue, 2010-06-08 at 20:50 +0300, Michael Goldish wrote: On 06/08/2010 11:02 AM, Marc Enthus wrote: From: Marc Enthus cxz...@gmail.com According to autotest coding style and http://www.python.org/dev/peps/pep-0008/ use if pa_type is not None: instead of if pa_type:

kvm test: vmexit: enable NX

2010-06-08 Thread Marcelo Tosatti
Enable NX to disable MSR autoload/save. This is the common case anyway. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/kvm/test/x86/vmexit.c b/kvm/test/x86/vmexit.c index c3a01e0..f267a19 100644 --- a/kvm/test/x86/vmexit.c +++ b/kvm/test/x86/vmexit.c @@ -45,6 +45,24 @@ static

KSM For All Via LD_PRELOAD?

2010-06-08 Thread Gordan Bobic
Is this plausible? I'm trying to work out if it's even worth considering this approach to enable all memory used by in a system to be open to KSM page merging, rather than only memory used by specific programs aware of it (e.g. kvm/qemu). Something like this would address the fact that

[RFC PATCH 6/6] savevm: Use RAM blocks for basis of migration

2010-06-08 Thread Alex Williamson
We don't want to assume a contiguous address space, so migrate based on RAM blocks instead of a fixed linear address map. Signed-off-by: Alex Williamson alex.william...@redhat.com --- arch_init.c | 67 +-- 1 files changed, 42

[RFC PATCH 0/6] RAM migration overhaul

2010-06-08 Thread Alex Williamson
As we discussed at the KVM developer call this morning, there are a number of issues with how we migrate RAM in the presence of hotplug, particularly: - RAM allocated on the source may not match the target - Abiguity of ram_addr_t between source and target - Inability to remove RAM - etc...

[RFC PATCH 2/6] ram_blocks: Convert to a QLIST

2010-06-08 Thread Alex Williamson
This makes the RAM block list easier to manipulate. Also incorporate relevant variables into the RAMList struct. Signed-off-by: Alex Williamson alex.william...@redhat.com --- arch_init.c | 14 ++- cpu-all.h | 28 --- exec.c | 72

[RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Alex Williamson
The offset given to a block created via qemu_ram_alloc/map() is arbitrary, let the caller specify a name so we can make a positive match. Note, this only addresses the qemu-kvm callers so far. Signed-off-by: Alex Williamson alex.william...@redhat.com --- cpu-all.h |1 +

[RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

2010-06-08 Thread Alex Williamson
Synchronize RAM blocks with the target and migrate using name/offset pairs. This ensures both source and target have the same view of RAM and that we get the right bits into the right slot. Signed-off-by: Alex Williamson alex.william...@redhat.com --- arch_init.c | 103

Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Anthony Liguori
On 06/08/2010 02:15 PM, Alex Williamson wrote: The offset given to a block created via qemu_ram_alloc/map() is arbitrary, let the caller specify a name so we can make a positive match. Note, this only addresses the qemu-kvm callers so far. Signed-off-by: Alex

Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 15:07 -0500, Anthony Liguori wrote: On 06/08/2010 02:15 PM, Alex Williamson wrote: The offset given to a block created via qemu_ram_alloc/map() is arbitrary, let the caller specify a name so we can make a positive match. Note, this only addresses the qemu-kvm callers

Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

2010-06-08 Thread Anthony Liguori
On 06/08/2010 02:16 PM, Alex Williamson wrote: Synchronize RAM blocks with the target and migrate using name/offset pairs. This ensures both source and target have the same view of RAM and that we get the right bits into the right slot. Signed-off-by: Alex Williamsonalex.william...@redhat.com

Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

2010-06-08 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: @@ -257,7 +272,7 @@ int ram_load(QEMUFile *f, void *opaque, int version_id) ram_addr_t addr; int flags; -if (version_id != 3) { +if (version_id 3) { return -EINVAL; Should we clamp to 3 and 4? }

Re: [Qemu-devel] Re: KVM call minutes for June 8

2010-06-08 Thread Luiz Capitulino
On Tue, 08 Jun 2010 11:01:19 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 06/08/2010 10:05 AM, Chris Wright wrote: [...] migration events? - QMP (wire protocol) has nice async events - QError reasonable - migration is async command, can complete w/ error or success -

Re: [RFC PATCH 1/6] qemu_ram_alloc: Remove duplicate code

2010-06-08 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: No reason not to call qemu_ram_map() once we have the allocation and remove duplicate code. Signed-off-by: Alex Williamson alex.william...@redhat.com good cleanup regardless Acked-by: Chris Wright chr...@redhat.com -- To unsubscribe from

Re: VIA Nano support

2010-06-08 Thread Rusty Burchfield
On Mon, May 3, 2010 at 9:42 AM, Rusty Burchfield gicodewarr...@gmail.com wrote: On Sun, May 2, 2010 at 1:21 AM, Yuhong Bao yuhongbao_...@hotmail.com wrote: What about details? This old thread seems to have more details. http://www.mail-archive.com/kvm@vger.kernel.org/msg11704.html Any new

Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 15:12 -0500, Anthony Liguori wrote: On 06/08/2010 02:16 PM, Alex Williamson wrote: if (is_dup_page(p, *p)) { -qemu_put_be64(f, current_addr | RAM_SAVE_FLAG_COMPRESS); +qemu_put_be64(f, offset | RAM_SAVE_FLAG_COMPRESS); +

Re: [Qemu-devel] Re: KVM call minutes for June 8

2010-06-08 Thread Anthony Liguori
On 06/08/2010 03:59 PM, Luiz Capitulino wrote: Now, QError. This is something I think we should fix for 0.13. However, I still don't know how to get it right: most of what you say in the wiki page has already been discussed before. For example, you suggest the error object should be

[RFC PATCH 7/6] savevm: Create a new continue flag to avoid resending block name

2010-06-08 Thread Alex Williamson
Allows us to compress the protocol a bit. Signed-off-by: Alex Williamson alex.william...@redhat.com --- arch_init.c | 77 +-- 1 files changed, 43 insertions(+), 34 deletions(-) diff --git a/arch_init.c b/arch_init.c index

Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 13:54 -0700, Chris Wright wrote: * Alex Williamson (alex.william...@redhat.com) wrote: @@ -257,7 +272,7 @@ int ram_load(QEMUFile *f, void *opaque, int version_id) ram_addr_t addr; int flags; -if (version_id != 3) { +if (version_id 3) {

Re: [RFC PATCH 2/6] ram_blocks: Convert to a QLIST

2010-06-08 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: extern int phys_ram_fd; -extern uint8_t *phys_ram_dirty; extern ram_addr_t ram_size; -extern ram_addr_t last_ram_offset; + +typedef struct RAMBlock { +uint8_t *host; +ram_addr_t offset; +ram_addr_t length; +

Re: [PATCH] VFIO driver: Non-privileged user level PCI drivers

2010-06-08 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 12:01:04PM -0700, Tom Lyon wrote: On Sunday 06 June 2010 02:54:51 am Michael S. Tsirkin wrote: On Thu, Jun 03, 2010 at 02:41:38PM -0700, Tom Lyon wrote: OK, in the interest of making progress, I am about to embark on the following: 1. Create a

Re: [RFC PATCH 7/6] savevm: Create a new continue flag to avoid resending block name

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 15:11 -0600, Alex Williamson wrote: Allows us to compress the protocol a bit. ... @@ -284,6 +290,33 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque) return (stage == 2) (expected_time = migrate_max_downtime()); } +static inline void

Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: +// XXX check duplicates Yes, definitely. You created a notion of a hierarchical namespace, can this be formalized any more? Currently scattered... +char name[14]; +snprintf(name, sizeof(name),

Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

2010-06-08 Thread Randy Dunlap
On Tue, 08 Jun 2010 14:21:52 -0700 Tom Lyon wrote: one missing piece (again): Documentation/ioctl/ioctl-number.txt |1 Documentation/vfio.txt | 177 +++ MAINTAINERS |7 drivers/Kconfig |2 drivers/Makefile

Re: [RFC PATCH 2/6] ram_blocks: Convert to a QLIST

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 14:26 -0700, Chris Wright wrote: * Alex Williamson (alex.william...@redhat.com) wrote: extern int phys_ram_fd; -extern uint8_t *phys_ram_dirty; extern ram_addr_t ram_size; -extern ram_addr_t last_ram_offset; + +typedef struct RAMBlock { +uint8_t *host;

Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

2010-06-08 Thread Randy Dunlap
On Tue, 08 Jun 2010 14:21:52 -0700 Tom Lyon wrote: diff -uprN linux-2.6.34/Documentation/vfio.txt vfio-linux-2.6.34/Documentation/vfio.txt --- linux-2.6.34/Documentation/vfio.txt 1969-12-31 16:00:00.0 -0800 +++ vfio-linux-2.6.34/Documentation/vfio.txt 2010-06-07

[KVM-AUTOTEST PATCH v2 1/4] KVM test: support -kernel and -append command line options

2010-06-08 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 94bacdf..f3c05f3 100755 --- a/client/tests/kvm/kvm_vm.py +++

[KVM-AUTOTEST PATCH v2 2/4] KVM test: add boolean 'testdev' VM parameter for RHEL-6 style unit tests

2010-06-08 Thread Michael Goldish
Should be set to yes to enable testdev. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 28 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index

[KVM-AUTOTEST PATCH v2 3/4] KVM test: add wrapper for RHEL-6 style unittests

2010-06-08 Thread Michael Goldish
Based on Naphtali Sprei's patches. Changes from v1: - Determine success/failure by exit status instead of output - Restructure loop so that vm.is_dead() is called less often - Copy test log to debugdir/unittest.log - Change parameters passed to wait_for() Signed-off-by: Michael Goldish

[KVM-AUTOTEST PATCH v2 4/4] KVM test: add sample RHEL-6 style unittest config file

2010-06-08 Thread Michael Goldish
Based on Naphtali Sprei's patches. Changes from v1: - Remove reference_output parameter Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/unittests.cfg.sample | 83 + 1 files changed, 83 insertions(+), 0 deletions(-) create mode 100644

Re: [RFC PATCH 2/6] ram_blocks: Convert to a QLIST

2010-06-08 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: On Tue, 2010-06-08 at 14:26 -0700, Chris Wright wrote: * Alex Williamson (alex.william...@redhat.com) wrote: extern int phys_ram_fd; -extern uint8_t *phys_ram_dirty; extern ram_addr_t ram_size; -extern ram_addr_t

Re: [RFC PATCH 7/6] savevm: Create a new continue flag to avoid resending block name

2010-06-08 Thread Paolo Bonzini
On 06/08/2010 11:32 PM, Alex Williamson wrote: On Tue, 2010-06-08 at 15:11 -0600, Alex Williamson wrote: Allows us to compress the protocol a bit. ... @@ -284,6 +290,33 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque) return (stage == 2) (expected_time=

Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

2010-06-08 Thread Michael S. Tsirkin
On Tue, Jun 08, 2010 at 02:21:52PM -0700, Tom Lyon wrote: The VFIO driver is used to allow privileged AND non-privileged processes to implement user-level device drivers for any well-behaved PCI, PCI-X, and PCIe devices. Signed-off-by: Tom Lyon p...@cisco.com Some general comments: -

Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

2010-06-08 Thread Tom Lyon
On Tuesday 08 June 2010 03:38:44 pm Michael S. Tsirkin wrote: On Tue, Jun 08, 2010 at 02:21:52PM -0700, Tom Lyon wrote: The VFIO driver is used to allow privileged AND non-privileged processes to implement user-level device drivers for any well-behaved PCI, PCI-X, and PCIe devices.

Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Paul Brook
The offset given to a block created via qemu_ram_alloc/map() is arbitrary, let the caller specify a name so we can make a positive match. @@ -1924,7 +1925,9 @@ static int pci_add_option_rom(PCIDevice *pdev) +snprintf(name, sizeof(name), pci:%02x.%x.rom, +

Re: [RFC][PATCH 1/3] Introduce a workqueue to deliver PIT timer interrupts.

2010-06-08 Thread Zachary Amsden
On 06/08/2010 07:55 AM, Chris Lalancette wrote: We really want to kvm_set_irq during the hrtimer callback, but that is risky because that is during interrupt context. Instead, offload the work to a workqueue, which is a bit safer and should provide most of the same functionality. Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Anthony Liguori
On 06/08/2010 09:30 PM, Paul Brook wrote: The offset given to a block created via qemu_ram_alloc/map() is arbitrary, let the caller specify a name so we can make a positive match. @@ -1924,7 +1925,9 @@ static int pci_add_option_rom(PCIDevice *pdev) +snprintf(name, sizeof(name),

Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Paul Brook
On 06/08/2010 09:30 PM, Paul Brook wrote: The offset given to a block created via qemu_ram_alloc/map() is arbitrary, let the caller specify a name so we can make a positive match. @@ -1924,7 +1925,9 @@ static int pci_add_option_rom(PCIDevice *pdev) +snprintf(name,

Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 14:41 -0700, Chris Wright wrote: * Alex Williamson (alex.william...@redhat.com) wrote: +// XXX check duplicates Yes, definitely. Yep, I was just thinking that without freeing, the uniqueness really falls apart. If we hotplug a nic multiple times on the source,

[RFC] para virt interface of perf to support kvm guest os statistics collection in guest os

2010-06-08 Thread Zhang, Yanmin
From: Zhang, Yanmin yanmin_zh...@linux.intel.com Based on Ingo's idea, I implement a para virt interface for perf to support statistics collection in guest os. That means we could run tool perf in guest os directly. Great thanks to Peter Zijlstra. He is really the architect and gave me

Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Alex Williamson
On Wed, 2010-06-09 at 03:54 +0100, Paul Brook wrote: On 06/08/2010 09:30 PM, Paul Brook wrote: The offset given to a block created via qemu_ram_alloc/map() is arbitrary, let the caller specify a name so we can make a positive match. @@ -1924,7 +1925,9 @@ static int

applications running in KVM crashing?

2010-06-08 Thread Nikola Ciprich
Hi, on two of my KVM machines, some applications started to crash. I'm not sure, but I think it might be related to some host update I've made recently. I also can't find any difference to guests, on which I don't see any such problems. It's usually sendmail or postgres, crashing with following

Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

2010-06-08 Thread Michael S. Tsirkin
On Tue, Jun 08, 2010 at 04:54:43PM -0700, Tom Lyon wrote: On Tuesday 08 June 2010 03:38:44 pm Michael S. Tsirkin wrote: On Tue, Jun 08, 2010 at 02:21:52PM -0700, Tom Lyon wrote: The VFIO driver is used to allow privileged AND non-privileged processes to implement user-level device