Bugs item #2832416, was opened at 2009-08-05 09:49
Message generated for change (Comment added) made by haoxudong
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=893831aid=2832416group_id=180599
Please note that this message will contain a full copy of the comment
Hi, all,
This is KVM biweekly test result against kvm.git:
cfe149e91b823a75eb7a86e81bfa7c6fce42c744 and qemu-kvm.git:
bc3a9ccc5ddea4c0c713ef6fb3c11d9a88cec169.
There is 2 qemu issues found, the first one is qemu fail to parse B:D.F with
old qemu command; the other is qemu fail to parse -net
On 06/29/2010 04:17 AM, Xiao Guangrong wrote:
If B is writeable-and-dirty, then it's D bit is already set, and we
don't need to do anything.
If B is writeable-and-clean, then we'll have an spte pointing to a
read-only sp, so we'll get a write fault on access and an opportunity to
set the D
On Mon, Jun 28, 2010 at 4:55 PM, Marcelo Tosatti mtosa...@redhat.com wrote:
On Wed, Jun 23, 2010 at 10:24:02PM +0100, Stefan Hajnoczi wrote:
The virtio block device holds a lock during I/O request processing.
Kicking the virtqueue while the lock is held results in long lock hold
times and
On 06/29/2010 10:08 AM, Stefan Hajnoczi wrote:
Is it incorrect to have the following pattern?
spin_lock_irqsave(q-queue_lock);
spin_unlock(q-queue_lock);
spin_lock(q-queue_lock);
spin_unlock_irqrestore(q-queue_lock);
Perfectly legitimate. spin_lock_irqsave() is equivalent to
On PowerPC it's very normal to not support all of the physical
RAM in real mode.
Oh? Are you referring to real mode limit, or 32-bit
implementations with
more than 32 address lines, or something else?
The former.
Okay. In that case, the hypervisor can usually access all of physical
Thanks Markus,
(2010/06/29 14:28), Markus Armbruster wrote:
Hidetoshi Seto seto.hideto...@jp.fujitsu.com writes:
Hao, Xudong xudong@intel.com writes:
When assign one PCI device, qemu fail to parse the command line:
qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0
From: Michael S. Tsirkin m...@redhat.com
Date: Mon, 28 Jun 2010 13:08:07 +0300
Userspace virtio server has the following hack
so guests rely on it, and we have to replicate it, too:
Use port number to detect incoming IPv4 DHCP response packets,
and fill in the checksum for these.
The
There is also a form of mtmsr where all bits need to be
addressed. While the
PPC64 Linux kernel behaves resonably well here, the PPC32 one
never uses the
L=1 form but does mtmsr even for simple things like only changing
EE.
You make it sound like the 32-bit kernel does something stupid,
On 06/29/2010 10:06 AM, Avi Kivity wrote:
On 06/29/2010 04:17 AM, Xiao Guangrong wrote:
If B is writeable-and-dirty, then it's D bit is already set, and we
don't need to do anything.
If B is writeable-and-clean, then we'll have an spte pointing to a
read-only sp, so we'll get a write fault
Avi Kivity wrote:
On 06/29/2010 04:17 AM, Xiao Guangrong wrote:
If B is writeable-and-dirty, then it's D bit is already set, and we
don't need to do anything.
If B is writeable-and-clean, then we'll have an spte pointing to a
read-only sp, so we'll get a write fault on access and an
Avi Kivity wrote:
Note:
- modifying walk_addr() to call kvm_mmu_pte_write() is probably not so
bad. It's rare that a large pte walk sets the dirty bit, and it's
probably rare to share those large ptes. Still, I think the fetch()
change is better since it's more local.
- there was
On 29.06.2010, at 09:52, Segher Boessenkool wrote:
Also, it seems you construct the physical address by masking out bits from
the effective address. Most implementations will trap or machine check if
you address outside of physical address space, instead.
Well the only case where I
Marcelo Tosatti wrote:
+
+if (sp-role.level PT_PAGE_TABLE_LEVEL)
+return;
+
+if (sp-role.direct)
+return direct_pte_prefetch(vcpu, sptep);
Can never happen.
Marcelo,
Thanks for your comment. You mean that we can't meet sp-role.direct here?
could you
On 06/29/2010 10:45 AM, Xiao Guangrong wrote:
- there was once talk that instead of folding pt_access and pte_access
together into the leaf sp-role.access, each sp level would have its own
access permissions. In this case we don't even have to get a new direct
sp, only change the
Avi Kivity wrote:
On 06/29/2010 10:35 AM, Xiao Guangrong wrote:
We have now
if (is_shadow_present_pte(*sptep) !is_large_pte(*sptep))
continue;
So we need to add a check, if sp-role.access doesn't match pt_access
pte_access, we need to get a new sp with the correct
On 06/29/2010 12:04 PM, Xiao Guangrong wrote:
Simply replace (*spte SPTE_NO_DIRTY) with a condition that checks
whether sp-access is consistent with gw-pt(e)_access.
If the guest mapping is writable and it !dirty, we mark SPTE_NO_DIRTY flag in
the spte, when the next #PF occurs, we
Avi Kivity wrote:
On 06/29/2010 12:04 PM, Xiao Guangrong wrote:
Simply replace (*spte SPTE_NO_DIRTY) with a condition that checks
whether sp-access is consistent with gw-pt(e)_access.
If the guest mapping is writable and it !dirty, we mark SPTE_NO_DIRTY
flag in
the spte, when the
On 06/29/2010 06:16 AM, Sheng Yang wrote:
Some guest device driver may leverage the Non-Snoop I/O, and explicitly
WBINVD or CLFLUSH to a RAM space. Since migration may occur before WBINVD or
CLFLUSH, we need to maintain data consistency either by:
1: flushing cache (wbinvd) when the guest is
On 06/29/2010 07:49 AM, ewheeler wrote:
Hello,
I have been scouring mailing lists, the wiki, and talked with iggy on
freenode/#kvm who suggested that I ask on the list. KVM reports that I
do not have an IOMMU, however, dmesg reports both DMAR and IOMMU. In
addition, I know that this board
On 06/28/2010 07:20 PM, Anthony Liguori wrote:
To avoid this I'd like to see the pinning done from within QEMU. I
am not sure whether calling numactl via system() and friends is
OK, I'd prefer to run the syscalls directly (like in patch 3/3)
and pull the necessary options into the -numa
On 06/28/2010 07:17 PM, Anthony Liguori wrote:
On 06/24/2010 06:12 AM, Avi Kivity wrote:
On 06/24/2010 01:58 PM, Andre Przywara wrote:
So who would create the /dev/shm/nodeXX files?
Currently it is QEMU. It creates a somewhat unique filename, opens
and unlinks it. The difference would be to
Avi Kivity wrote:
On 06/26/2010 02:24 AM, Alexander Graf wrote:
For transparent variable sharing between the hypervisor and guest, I
introduce
a shared page. This shared page will contain all the registers the
guest can
read and write safely without exiting guest context.
This patch only
On 06/29/2010 04:33 AM, Chen Cao wrote:
On Mon, Jun 28, 2010 at 05:54:18PM +0300, Michael Goldish wrote:
The telnet service isn't used by kvm-autotest (AFAIK) and may interfere with
rss.exe (port 23).
Michael,
I think it is better to leave the port 23 (and also 22) alone, people
may
Avi Kivity wrote:
On 06/29/2010 06:16 AM, Sheng Yang wrote:
Some guest device driver may leverage the Non-Snoop I/O, and explicitly
WBINVD or CLFLUSH to a RAM space. Since migration may occur before WBINVD or
CLFLUSH, we need to maintain data consistency either by:
1: flushing cache (wbinvd)
On Mon, Jun 28, 2010 at 11:16:59PM -0400, Sheng Yang wrote:
Some guest device driver may leverage the Non-Snoop I/O, and explicitly
WBINVD or CLFLUSH to a RAM space. Since migration may occur before WBINVD or
CLFLUSH, we need to maintain data consistency either by:
1: flushing cache (wbinvd)
On 06/29/2010 01:32 PM, Jan Kiszka wrote:
Avi Kivity wrote:
On 06/29/2010 06:16 AM, Sheng Yang wrote:
Some guest device driver may leverage the Non-Snoop I/O, and explicitly
WBINVD or CLFLUSH to a RAM space. Since migration may occur before WBINVD or
CLFLUSH, we need to maintain data
On 06/29/2010 01:14 PM, Roedel, Joerg wrote:
On Mon, Jun 28, 2010 at 11:16:59PM -0400, Sheng Yang wrote:
Some guest device driver may leverage the Non-Snoop I/O, and explicitly
WBINVD or CLFLUSH to a RAM space. Since migration may occur before WBINVD or
CLFLUSH, we need to maintain data
On 06/29/2010 12:54 PM, Alexander Graf wrote:
Code repeats 3x. Share please.
Looking at this again, I could combine the 3 lines of init code into 3
lines of code that do a generic function call and then error checking.
And I could convert the one free_page line with one function call
On Tue, Jun 29, 2010 at 04:07:40PM +0800, Xiao Guangrong wrote:
Marcelo Tosatti wrote:
+
+ if (sp-role.level PT_PAGE_TABLE_LEVEL)
+ return;
+
+ if (sp-role.direct)
+ return direct_pte_prefetch(vcpu, sptep);
Can never happen.
Marcelo,
Thanks for
See details in docstrings in rss_file_transfer.py.
See protocol details in rss.cpp.
Changes from v2:
- Raise FileTransferNotFoundError if no files/dirs are transferred (due to
a bad path or wildcard pattern)
- Make all connection related errors in the base class raise
FileTransferConnectError
On 06/28/2010 08:28 PM, BuraphaLinux Server wrote:
Hello,
I have tried qemu_kvm 0.12.4 release and also git from about 1/2
an hour ago. In both cases, I crash in the post_kvm_run() function on
the line about:
pthread_mutex_lock(qemu_mutex);
The command I use to run qemu worked great
Enable RSS to send/receive files and directory trees (recursively).
See protocol details in rss.cpp.
Changes from v2:
- Use ports 10022 and 10023 by default instead of 22 and 23.
Changes from v1:
- Expand environment variables (e.g. %WinDir%) in all paths.
- Change text box limit to 16384
This will only work with the most recent rss.exe.
Usage examples:
vm.copy_files_from(r'C:\foobar\*', test.debugdir, timeout=30)
vm.copy_files_from(r'%SystemRoot%\memory.dmp', '/tmp/', timeout=60)
vm.copy_files_to('/usr/local', r'C:\Windows', timeout=600)
Changes from v1:
- Use ports 10022 and
In addition to 'netsh firewall ...' use 'netsh advfirewall ...' which seems to
be the preferred way of changing firewall settings in Win7.
('netsh firewall ...' results in the firewall being disabled only for one type
of network (e.g. public networks) but not for the other (home networks).)
Don't tell rss.exe to use port 22.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/deps/setuprss.bat |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm/deps/setuprss.bat
b/client/tests/kvm/deps/setuprss.bat
index 1adff0f..97298cd
This will result in more informative messages, e.g.:
Test failed: FileTransferConnectError: Could not connect to server
instead of
Test failed: Could not connect to server
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm.py |3 ++-
1 files changed, 2
On Tue, Jun 29, 2010 at 06:44:25AM -0400, Avi Kivity wrote:
On 06/29/2010 01:14 PM, Roedel, Joerg wrote:
On Mon, Jun 28, 2010 at 11:16:59PM -0400, Sheng Yang wrote:
Some guest device driver may leverage the Non-Snoop I/O, and explicitly
WBINVD or CLFLUSH to a RAM space. Since
On Tue, Jun 29, 2010 at 06:42:57AM -0400, Avi Kivity wrote:
On 06/29/2010 01:32 PM, Jan Kiszka wrote:
Correctness is more important than performance. Since we don't know
whether the guest needs it or not, we have to enable it. The user may
disable it if he likes.
Can't this code only be
On 06/29/2010 03:28 PM, Roedel, Joerg wrote:
Do you mean, KVM_IOMMU_CACHE_COHERENCY should be set for the AMD IOMMU?
No, as far as I understand it the KVM_IOMMU_CACHE_COHERENCY flag is only
there because there are VT-d IOMMUs that does not support the snoop
force bit. In the AMD IOMMU
On 06/29/2010 03:32 PM, Roedel, Joerg wrote:
On Tue, Jun 29, 2010 at 06:42:57AM -0400, Avi Kivity wrote:
On 06/29/2010 01:32 PM, Jan Kiszka wrote:
Correctness is more important than performance. Since we don't know
whether the guest needs it or not, we have to enable it. The
Avi Kivity wrote:
On 06/28/2010 11:55 AM, Alexander Graf wrote:
+
+static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) {
+return hash_64(eaddr PTE_SIZE, HPTEG_HASH_BITS_PTE);
+}
+
+static inline u64 kvmppc_mmu_hash_vpte(u64 vpage) {
+return hash_64(vpage 0xfULL,
On 06/29/2010 03:56 PM, Alexander Graf wrote:
Avi Kivity wrote:
On 06/28/2010 11:55 AM, Alexander Graf wrote:
+
+static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) {
+return hash_64(eaddrPTE_SIZE, HPTEG_HASH_BITS_PTE);
+}
+
+static inline u64 kvmppc_mmu_hash_vpte(u64
Avi Kivity wrote:
On 06/29/2010 03:56 PM, Alexander Graf wrote:
Avi Kivity wrote:
On 06/28/2010 11:55 AM, Alexander Graf wrote:
+
+static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) {
+return hash_64(eaddrPTE_SIZE, HPTEG_HASH_BITS_PTE);
+}
+
+static inline u64
On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote:
From: Michael S. Tsirkin m...@redhat.com
Date: Mon, 28 Jun 2010 13:08:07 +0300
Userspace virtio server has the following hack
so guests rely on it, and we have to replicate it, too:
Use port number to detect incoming IPv4
On 06/29/2010 04:06 PM, Alexander Graf wrote:
Are we looking at the same link? Looks good to me there.
We're probably looking at the same link but looking at different
things. I'm whining about
static u64 f() {
...
}
as opposed to the more sober
static u64 f()
On Tue, Jun 29, 2010 at 11:16:59AM +0800, Sheng Yang wrote:
Some guest device driver may leverage the Non-Snoop I/O, and explicitly
WBINVD or CLFLUSH to a RAM space. Since migration may occur before WBINVD or
CLFLUSH, we need to maintain data consistency either by:
1: flushing cache (wbinvd)
On 06/29/2010 04:25 PM, Marcelo Tosatti wrote:
+ smp_call_function_single(vcpu-cpu,
+ wbinvd_ipi, NULL, 1);
+ }
+
kvm_x86_ops-vcpu_load(vcpu, cpu);
if (unlikely(per_cpu(cpu_tsc_khz, cpu) == 0)) {
On Tue, Jun 29, 2010 at 04:28:35PM +0300, Avi Kivity wrote:
On 06/29/2010 04:25 PM, Marcelo Tosatti wrote:
+ smp_call_function_single(vcpu-cpu,
+ wbinvd_ipi, NULL, 1);
+ }
+
kvm_x86_ops-vcpu_load(vcpu, cpu);
if
On Tue, Jun 29, 2010 at 08:35:35AM -0400, Avi Kivity wrote:
On 06/29/2010 03:28 PM, Roedel, Joerg wrote:
The flag indicates to kvm that it doesn't need to worry about iommu
cache coherency issues (for example, it can ignore wbinvd), so it needs
to be set. THe following code
if
On 06/28/2010 02:03 PM, Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
If we have a lack of agenda items I'll cancel the week's call.
After last week debacle, I will wait until 10 mins before call to cancel
it.
Thanks for posting earlier this week.
* Anthony Liguori (anth...@codemonkey.ws) wrote:
On 06/28/2010 02:03 PM, Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
If we have a lack of agenda items I'll cancel the week's call.
After last week debacle, I will wait until 10 mins before call to
On 06/29/2010 04:35 PM, Marcelo Tosatti wrote:
work_on_cpu() loop instead of smp_call_function_many(), to avoid executing
wbinvd with interrupts disabled.
Why? wbinvd is not interruptible.
Right. But still, smp_call_function_many() is going to busy-spin until
the target CPUs
On Tue, 2010-06-29 at 12:42 +0300, Avi Kivity wrote:
On 06/29/2010 07:49 AM, ewheeler wrote:
KVM reports that I
do not have an IOMMU, however, dmesg reports both DMAR and IOMMU. In
addition, I know that this board supports VT-d.
Specific details are available here:
On 06/29/2010 05:11 PM, ewheeler wrote:
On Tue, 2010-06-29 at 12:42 +0300, Avi Kivity wrote:
On 06/29/2010 07:49 AM, ewheeler wrote:
KVM reports that I
do not have an IOMMU, however, dmesg reports both DMAR and IOMMU. In
addition, I know that this board supports VT-d.
Specific
On Tue, 2010-06-29 at 17:49 +0300, Avi Kivity wrote:
On 06/29/2010 05:11 PM, ewheeler wrote:
On Tue, 2010-06-29 at 12:42 +0300, Avi Kivity wrote:
On 06/29/2010 07:49 AM, ewheeler wrote:
KVM reports that I
do not have an IOMMU, however, dmesg reports both DMAR and IOMMU. In
Bugs item #3022896, was opened at 2010-06-29 18:39
Message generated for change (Tracker Item Submitted) made by
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=893831aid=3022896group_id=180599
Please note that this message will contain a full copy of the comment
Bugs item #3022896, was opened at 2010-06-29 18:39
Message generated for change (Comment added) made by jessorensen
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=893831aid=3022896group_id=180599
Please note that this message will contain a full copy of the comment
Hi everybody,
Here's a status update (a public one this time) on my work:
---
Accomplishments:
- [DONE] Generic IOMMU API for devices
- [DONE] PIIX IDE uses the new API
- [DONE] Permissions handling
Bonus:
- [DONE] RTL8139 converted
Objectives:
- [WIP] Reporting IO page faults in the event
Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled,
but what we really want is to clear assigned_dev-irq_requested_type.
Signed-off-by: Alex Williamson alex.william...@redhat.com
Found-by: Juan Quintela quint...@redhat.com
---
hw/device-assignment.c |4 ++--
1 files
* Alex Williamson (alex.william...@redhat.com) wrote:
Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled,
but what we really want is to clear assigned_dev-irq_requested_type.
Signed-off-by: Alex Williamson alex.william...@redhat.com
Found-by: Juan Quintela
On Tue, Jun 29, 2010 at 04:50:49PM +0300, Avi Kivity wrote:
On 06/29/2010 04:35 PM, Marcelo Tosatti wrote:
work_on_cpu() loop instead of smp_call_function_many(), to avoid executing
wbinvd with interrupts disabled.
Why? wbinvd is not interruptible.
Right. But still,
Alex Williamson alex.william...@redhat.com wrote:
Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled,
but what we really want is to clear assigned_dev-irq_requested_type.
Signed-off-by: Alex Williamson alex.william...@redhat.com
Found-by: Juan Quintela quint...@redhat.com
Hello,
Requirement:
I have the need to support my apps(running on a Linux VM) on different
*nix hypervisors(ESX/Xen etc). I need to know on which hypervisor my
app is running. I read the CPUID usage thread -
http://thread.gmane.org/gmane.comp.emulators.kvm.devel/22643 but to be
honest in the end
On 06/29/2010 04:25 PM, Chetan Loke wrote:
Hello,
Requirement:
I have the need to support my apps(running on a Linux VM) on different
*nix hypervisors(ESX/Xen etc). I need to know on which hypervisor my
app is running. I read the CPUID usage thread -
With this makefile, it's possible to comfortably compile
both rss.exe and finish.exe on a recent Fedora box with
the mingw packages installed. This is a nice convenience
and saves people of memorizing the compiler command lines.
Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com
---
Brief discussion thread - http://lkml.org/lkml/2010/6/29/355
Added VMware detection via cpuid.Mimic'd VMware's balloon driver's init-time
check(cpuid followed by dmi-checks). Moved the existing logic into a simple
function to achieve that.
Tested virt-what.in(ran as a script) and
On Tue, Jun 29, 2010 at 5:44 PM, Anthony Liguori anth...@codemonkey.ws wrote:
On 06/29/2010 04:25 PM, Chetan Loke wrote:
It can be done entirely in userspace. Take a look at virt-what:
http://people.redhat.com/~rjones/virt-what/
Just posted a patch for virt-what.in which can be used as a
Marcelo Tosatti wrote:
Also prefetch should be disabled for EPT, due to lack of accessed bit.
But we call mmu_set_spte() with speculative == false, it not touch the
accessed bit.
There is no accessed bit on EPT. So the aging code (kvm_age_rmapp)
considers any present translation as
Some guest device driver may leverage the Non-Snoop I/O, and explicitly
WBINVD or CLFLUSH to a RAM space. Since migration may occur before WBINVD or
CLFLUSH, we need to maintain data consistency either by:
1: flushing cache (wbinvd) when the guest is scheduled out if there is no
wbinvd exit, or
2:
It would buy us the ability to schedule compared to smp_call_function().
Signed-off-by: Sheng Yang sh...@linux.intel.com
---
But I am not sure if it worth the complexity. Anyway WBINVD itself can't be
interrupted, so the benefit should come to the caller cpu I think. And that
would extended the
On PowerPC it's very normal to not support all of the physical
RAM in real mode.
Oh? Are you referring to real mode limit, or 32-bit
implementations with
more than 32 address lines, or something else?
The former.
Okay. In that case, the hypervisor can usually access all of physical
On 29.06.2010, at 09:32, Segher Boessenkool wrote:
On PowerPC it's very normal to not support all of the physical RAM in real
mode.
Oh? Are you referring to real mode limit, or 32-bit implementations with
more than 32 address lines, or something else?
The former.
Okay. In that
On 29.06.2010, at 09:52, Segher Boessenkool wrote:
Also, it seems you construct the physical address by masking out bits from
the effective address. Most implementations will trap or machine check if
you address outside of physical address space, instead.
Well the only case where I
Avi Kivity wrote:
On 06/26/2010 02:24 AM, Alexander Graf wrote:
For transparent variable sharing between the hypervisor and guest, I
introduce
a shared page. This shared page will contain all the registers the
guest can
read and write safely without exiting guest context.
This patch only
On 06/29/2010 12:54 PM, Alexander Graf wrote:
Code repeats 3x. Share please.
Looking at this again, I could combine the 3 lines of init code into 3
lines of code that do a generic function call and then error checking.
And I could convert the one free_page line with one function call
Avi Kivity wrote:
On 06/28/2010 11:55 AM, Alexander Graf wrote:
+
+static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) {
+return hash_64(eaddr PTE_SIZE, HPTEG_HASH_BITS_PTE);
+}
+
+static inline u64 kvmppc_mmu_hash_vpte(u64 vpage) {
+return hash_64(vpage 0xfULL,
On 06/29/2010 03:56 PM, Alexander Graf wrote:
Avi Kivity wrote:
On 06/28/2010 11:55 AM, Alexander Graf wrote:
+
+static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) {
+return hash_64(eaddrPTE_SIZE, HPTEG_HASH_BITS_PTE);
+}
+
+static inline u64 kvmppc_mmu_hash_vpte(u64
Avi Kivity wrote:
On 06/29/2010 03:56 PM, Alexander Graf wrote:
Avi Kivity wrote:
On 06/28/2010 11:55 AM, Alexander Graf wrote:
+
+static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) {
+return hash_64(eaddrPTE_SIZE, HPTEG_HASH_BITS_PTE);
+}
+
+static inline u64
On 06/29/2010 04:06 PM, Alexander Graf wrote:
Are we looking at the same link? Looks good to me there.
We're probably looking at the same link but looking at different
things. I'm whining about
static u64 f() {
...
}
as opposed to the more sober
static u64 f()
80 matches
Mail list logo
