Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > +/* > > > + * This function returns device list as an array in a below format: > > > + * +-+---

Re: [PATCH 6/7] KVM: assigned dev: MSI-X mask support

2010-11-14 Thread Sheng Yang
On Monday 15 November 2010 15:42:50 Michael S. Tsirkin wrote: > On Mon, Nov 15, 2010 at 03:37:21PM +0800, Sheng Yang wrote: > > > > We can back to them if there is someone really did it in that way. > > > > But for all hypervisors using QEmu, I think we haven't seen such > > > > kind of behavior ye

Re: [PATCH 6/7] KVM: assigned dev: MSI-X mask support

2010-11-14 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 03:37:21PM +0800, Sheng Yang wrote: > > > We can back to them if there is someone really did it in that way. But > > > for all hypervisors using QEmu, I think we haven't seen such kind of > > > behavior yet. > > > > I would rather stick to the spec than go figure out what d

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Gleb Natapov
On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > +/* > > + * This function returns device list as an array in a below format: > > + * +-+-+---+-+---+-- > > + * | n | l1 | devp

Re: [PATCH 6/7] KVM: assigned dev: MSI-X mask support

2010-11-14 Thread Sheng Yang
On Friday 12 November 2010 19:25:16 Michael S. Tsirkin wrote: > On Fri, Nov 12, 2010 at 06:54:01PM +0800, Sheng Yang wrote: > > On Friday 12 November 2010 18:47:29 Michael S. Tsirkin wrote: > > > On Fri, Nov 12, 2010 at 06:13:48PM +0800, Sheng Yang wrote: > > > > On Friday 12 November 2010 17:53:13

Re: Why so many vm exits caused by ept violation

2010-11-14 Thread lidong chen
the address is the Region 1 of virtio_net. why virtio_net use this address caused ept violation? 00:04.0 Ethernet controller: Unknown device 1af4:1000 Subsystem: Unknown device 1af4:0001 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-

Re: Why so many vm exits caused by ept violation

2010-11-14 Thread lidong chen
the gpa caused ept violation is below: most of them is F202.(4060217344) error gpa is 4060217344 error gpa is 4060217344 error gpa is 4060217344 error gpa is 4060217344 error gpa is 4060217344 error gpa is 4060217344 error gpa is 4060217344 error gpa is 4060217344 error gpa is 4060217344 erro

Re: [PATCH 3/4] KVM: MMU: notrap it if gpte's reserved is set

2010-11-14 Thread Xiao Guangrong
On 11/14/2010 06:56 PM, Avi Kivity wrote: > On 11/12/2010 12:34 PM, Xiao Guangrong wrote: >> We can past the page fault to guest directly if gpte's reserved >> is set >> > > How can that work? shadow_notrap_nonpresent_pte causes a fault with > PFEC.P=PFEC.RSVD=0, while we need PFEC.P=PFEC.RSVD=1.

Re: [PATCH 1/4] KVM: MMU: don't drop spte if overwrite it from W to RO

2010-11-14 Thread Xiao Guangrong
On 11/14/2010 06:52 PM, Avi Kivity wrote: > On 11/12/2010 12:30 PM, Xiao Guangrong wrote: >> We just need flush tlb if overwrite a writable spte with a read-only one >> > > What are the advantages? Avoid playing with rmap, and avoid a window > where the spte is missing? > Both, but only the fir

Re: [PATCH v2 5/5] KVM: MMU: retry #PF for softmmu

2010-11-14 Thread Xiao Guangrong
On 11/14/2010 06:46 PM, Avi Kivity wrote: > On 11/12/2010 08:50 AM, Xiao Guangrong wrote: >> Retry #PF for softmmu only when the current vcpu has the same >> root shadow page as the time when #PF occurs. it means they >> have same paging environment >> > Hi Avi, Thanks for your review. > The pr

Re: Why so many vm exits caused by ept violation

2010-11-14 Thread lidong chen
i use the virtio dirvier of rhle6, the guest os version is 2.6.16. the vm exits which caused by io instruction and apic access reduce a lot. the total number of vm exits decreased by 50% :) but the ept violation seem increase on cpu 0, cpu 1, cpu 2, cpu3. (KVM)10 times on cpu 2, 0, 1989 1, 9

Re: [PATCH v2 9/9] pci: Store capability offsets in PCIDevice

2010-11-14 Thread Alex Williamson
On Sat, 2010-11-13 at 23:05 +0200, Michael S. Tsirkin wrote: > On Fri, Nov 12, 2010 at 10:47:21AM -0700, Alex Williamson wrote: > > This not only makes pci_find_capability a directly lookup, but also > > allows us to better track added capabilities and avoids the proliferation > > of random additio

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Kevin O'Connor
On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > +/* > + * This function returns device list as an array in a below format: > + * +-+-+---+-+---+-- > + * | n | l1 | devpath1| l2 | devpath2 | ... > + * +-+-+---+---

Re: [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-14 Thread Chris Wright
* Hidetoshi Seto (seto.hideto...@jp.fujitsu.com) wrote: > This patch introduce a fallback mechanism for old systems that do not > support utimensat(). This fix build failure with following warnings: > > hw/virtio-9p-local.c: In function 'local_utimensat': > hw/virtio-9p-local.c:479: warning: impl

[PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-14 Thread Hidetoshi Seto
This patch introduce a fallback mechanism for old systems that do not support utimensat(). This fix build failure with following warnings: hw/virtio-9p-local.c: In function 'local_utimensat': hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat' hw/virtio-9p-local.c:479:

Re: [Qemu-devel] Re: [PATCH] virtio-9p: fix build on !CONFIG_UTIMENSAT v2

2010-11-14 Thread Hidetoshi Seto
(2010/11/14 14:58), Chris Wright wrote: > * Hidetoshi Seto (seto.hideto...@jp.fujitsu.com) wrote: >> +/* >> + * Fallback: use utimes() instead of utimensat(). >> + * See commit 74bc02b2d2272dc88fb98d43e631eb154717f517 for known >> problem. >> + */ >> +struct timeval tv[2]; >> +

Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address

2010-11-14 Thread Huang Ying
On Sun, 2010-11-14 at 19:08 +0800, Avi Kivity wrote: > On 11/12/2010 03:16 AM, Huang Ying wrote: > > On Thu, 2010-11-11 at 17:39 +0800, Avi Kivity wrote: > > > On 11/11/2010 02:56 AM, Huang Ying wrote: > > > > On Thu, 2010-11-11 at 00:49 +0800, Anthony Liguori wrote: > > > > > On 11/10/2010

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.c |   14 ++ >  hw/fw_cfg.h |    4 +++- >  sysemu.h    |    1 + >  vl.c        |   51 +++ >  4 files changed, 69 insertions(+), 1 dele

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 09:13:03PM +, Blue Swirl wrote: > On Sun, Nov 14, 2010 at 8:54 PM, Michael S. Tsirkin wrote: > > On Sun, Nov 14, 2010 at 08:49:59PM +, Blue Swirl wrote: > >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > >> > > >> > Signed-off-by: Gleb Natapov > >> > ---

Re: [PATCHv4 13/15] Add bootindex for option roms.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > Extend -option-rom command to have additional parameter ,bootindex=. This patch is broken: CCarm-softmmu/palm.o /src/qemu/hw/palm.c: In function 'palmte_init': /src/qemu/hw/palm.c:237: error: incompatible type for argument 1 of 'get_ima

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 8:54 PM, Michael S. Tsirkin wrote: > On Sun, Nov 14, 2010 at 08:49:59PM +, Blue Swirl wrote: >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: >> > >> > Signed-off-by: Gleb Natapov >> > --- >> >  hw/fw_cfg.c |   14 ++ >> >  hw/fw_cfg.h |    4 +++- >>

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 08:52:37PM +0200, Gleb Natapov wrote: > > > + > > > +len = strlen(bootpath); > > > +list = qemu_realloc(list, total + len + 1); > > > +list[total++] = len; > > > +memcpy(&list[total], bootpath, len); > > > +total += len; > > > +

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 08:52:37PM +0200, Gleb Natapov wrote: > On Sun, Nov 14, 2010 at 08:41:37PM +0200, Michael S. Tsirkin wrote: > > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > > > > Signed-off-by: Gleb Natapov > > > --- > > > hw/fw_cfg.c | 14 ++ > > > h

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 08:49:59PM +, Blue Swirl wrote: > On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > >  hw/fw_cfg.c |   14 ++ > >  hw/fw_cfg.h |    4 +++- > >  sysemu.h    |    1 + > >  vl.c        |   51

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.c |   14 ++ >  hw/fw_cfg.h |    4 +++- >  sysemu.h    |    1 + >  vl.c        |   51 +++ >  4 files changed, 69 insertions(+), 1 dele

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Gleb Natapov
On Sun, Nov 14, 2010 at 08:41:37PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > > hw/fw_cfg.c | 14 ++ > > hw/fw_cfg.h |4 +++- > > sysemu.h|1 + > > vl.c| 51 +++

Re: [PATCHv4 08/15] Add get_fw_dev_path callback for pci bus.

2010-11-14 Thread Gleb Natapov
On Sun, Nov 14, 2010 at 08:27:20PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 14, 2010 at 05:39:34PM +0200, Gleb Natapov wrote: > > +static char *pcibus_get_fw_dev_path(DeviceState *dev) > > +{ > > +PCIDevice *d = (PCIDevice *)dev; > > +char path[50], name[33]; > > +int off; > > + >

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- > hw/fw_cfg.c | 14 ++ > hw/fw_cfg.h |4 +++- > sysemu.h|1 + > vl.c| 51 +++ > 4 files changed, 69 insertions(+

Re: [PATCHv4 08/15] Add get_fw_dev_path callback for pci bus.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 05:39:34PM +0200, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- > hw/pci.c | 108 - > 1 files changed, 85 insertions(+), 23 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 962886e..114b435

Re: PCI passthrough on Sony Vaio F11 laptop...

2010-11-14 Thread Jan Kiszka
Am 14.11.2010 14:21, Erik Brakkee wrote: > Jan Kiszka wrote: >> >> Strange, should work. I would suggest to post your full kernel log, >> maybe there is some enlightening message hidden. >> >> I don't think it is a problem of your kernel version, but I'm able to >> pass through devices on OpenSUSE

[PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/fw_cfg.c | 14 ++ hw/fw_cfg.h |4 +++- sysemu.h|1 + vl.c| 51 +++ 4 files changed, 69 insertions(+), 1 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index 7b9434f..f6a67

[PATCHv4 14/15] Add notifier that will be called when machine is fully created.

2010-11-14 Thread Gleb Natapov
Action that depends on fully initialized device model should register with this notifier chain. Signed-off-by: Gleb Natapov --- sysemu.h |2 ++ vl.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index 48f8eee..c42f33a 100644 -

[PATCHv4 12/15] Change fw_cfg_add_file() to get full file path as a parameter.

2010-11-14 Thread Gleb Natapov
Change fw_cfg_add_file() to get full file path as a parameter instead of building one internally. Two reasons for that. First caller may need to know how file is named. Second this moves policy of file naming out from fw_cfg. Platform may want to use more then two levels of directories for instance

[PATCHv4 00/15] boot order specification

2010-11-14 Thread Gleb Natapov
This is current state of the patch series for people to comment on. I am using open firmware naming scheme to specify device path names. In this submission I addressed all comment from previous one and added option rom support and rebased to qemu upstream. Kevin can you double check that the names

[PATCHv4 13/15] Add bootindex for option roms.

2010-11-14 Thread Gleb Natapov
Extend -option-rom command to have additional parameter ,bootindex=. Signed-off-by: Gleb Natapov --- hw/loader.c| 16 +++- hw/loader.h|8 hw/multiboot.c |3 ++- hw/ne2000.c|2 +- hw/nseries.c |2 +- hw/pc.c|7 --- hw/pci.c

[PATCHv4 03/15] Keep track of ISA ports ISA device is using in qdev.

2010-11-14 Thread Gleb Natapov
Store all io ports used by device in ISADevice structure. Signed-off-by: Gleb Natapov --- hw/cs4231a.c |1 + hw/fdc.c |3 +++ hw/gus.c |4 hw/ide/isa.c |2 ++ hw/isa-bus.c | 25 + hw/isa.h |4 hw/m48t59.c

[PATCHv4 09/15] Record which USBDevice USBPort belongs too.

2010-11-14 Thread Gleb Natapov
Ports on root hub will have NULL here. This is needed to reconstruct path from device to its root hub to build device path. Signed-off-by: Gleb Natapov --- hw/usb-bus.c |3 ++- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |2 +- hw/usb-uhci.c |2 +- hw/usb.h

[PATCHv4 06/15] Add get_fw_dev_path callback to IDE bus.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/ide/qdev.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 88ff657..01a181b 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -24,9 +24,12 @@ /* - */

[PATCHv4 10/15] Add get_dev_path callback for usb bus.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/usb-bus.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 256b881..8b4583c 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -5,11 +5,13 @@ #include "monitor.h"

[PATCHv4 08/15] Add get_fw_dev_path callback for pci bus.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/pci.c | 108 - 1 files changed, 85 insertions(+), 23 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 962886e..114b435 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -43,12 +43,14 @@ static void pcibu

[PATCHv4 07/15] Add get_dev_path callback for system bus.

2010-11-14 Thread Gleb Natapov
Prints out mmio or pio used to access child device. Signed-off-by: Gleb Natapov --- hw/pci_host.c |2 ++ hw/sysbus.c | 30 ++ hw/sysbus.h |4 3 files changed, 36 insertions(+), 0 deletions(-) diff --git a/hw/pci_host.c b/hw/pci_host.c index bc5b771

[PATCHv4 11/15] Add bootindex parameter to net/block/fd device

2010-11-14 Thread Gleb Natapov
If bootindex is specified on command line a string that describes device in firmware readable way is added into sorted list. Later this list will be passed into firmware to control boot order. Signed-off-by: Gleb Natapov --- block_int.h |4 +++- hw/e1000.c |4 hw/eepro100.c

[PATCHv4 05/15] Store IDE bus id in IDEBus structure for easy access.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/ide/cmd646.c |4 ++-- hw/ide/internal.h |3 ++- hw/ide/isa.c |2 +- hw/ide/piix.c |4 ++-- hw/ide/qdev.c |3 ++- hw/ide/via.c |4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/ide/cmd646.c b/

[PATCHv4 01/15] Introduce fw_name field to DeviceInfo structure.

2010-11-14 Thread Gleb Natapov
Add "fw_name" to DeviceInfo to use in device path building. In contrast to "name" "fw_name" should refer to functionality device provides instead of particular device model like "name" does. Signed-off-by: Gleb Natapov --- hw/fdc.c|1 + hw/ide/isa.c|1 + hw/ide/qdev.c |

[PATCHv4 04/15] Add get_fw_dev_path callback to ISA bus in qdev.

2010-11-14 Thread Gleb Natapov
Use device ioports to create unique device path. Signed-off-by: Gleb Natapov --- hw/isa-bus.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index c0ac7e9..c423c1b 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -31,11 +31,13

[PATCHv4 02/15] Introduce new BusInfo callback get_fw_dev_path.

2010-11-14 Thread Gleb Natapov
New get_fw_dev_path callback will be used for build device path usable by firmware in contrast to qdev qemu internal device path. Signed-off-by: Gleb Natapov --- hw/qdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index 9f90efe..dc669b3 10064

[PATCH] KVM test: Add Fedora 14 to the list of guests

2010-11-14 Thread Lucas Meneghel Rodrigues
As usual, make it the default guest on the default kvm autotest run. Signed-off-by: Lucas Meneghel Rodrigues --- client/tests/kvm/get_started.py|6 +++--- client/tests/kvm/tests.cfg.sample | 14 +++--- client/tests/kvm/tests_base.cfg.sample | 26 +

Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2010-11-14 Thread Dragos Tatulea
I'd like to pick up this patch and rework it based on your suggestions. Need it for [1]. Most opinions seem to be pointing to a generic software mac filtering in the VLAN layer with hw support if necessary. Here's what I had in mind: - For the generic mac filtering we can use something similar to V

Re: PCI passthrough on Sony Vaio F11 laptop...

2010-11-14 Thread Erik Brakkee
Jan Kiszka wrote: Strange, should work. I would suggest to post your full kernel log, maybe there is some enlightening message hidden. I don't think it is a problem of your kernel version, but I'm able to pass through devices on OpenSUSE 11.3 with kernel-desktop-2.6.36-90.1.x86_64 from their ke

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-14 Thread Avi Kivity
On 11/14/2010 01:05 PM, Avi Kivity wrote: I agree, but let's enable virtio-ioeventfd carefully because bad code is out there. Sure. Note as long as the thread waiting on ioeventfd doesn't consume too much cpu, it will awaken quickly and we won't have the "transaction per timeslice" effect.

Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address

2010-11-14 Thread Avi Kivity
On 11/14/2010 01:08 PM, Avi Kivity wrote: > 4) Use -mempath on /dev/shm and poison a page in the backing file If we can poison a page in the backing file, how do we know the corresponding gpa and hpa? I think you currently can't know it's gpa (why do you want to?); the upcoming NUMA enhanc

Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address

2010-11-14 Thread Avi Kivity
On 11/12/2010 03:16 AM, Huang Ying wrote: On Thu, 2010-11-11 at 17:39 +0800, Avi Kivity wrote: > On 11/11/2010 02:56 AM, Huang Ying wrote: > > On Thu, 2010-11-11 at 00:49 +0800, Anthony Liguori wrote: > > > On 11/10/2010 02:34 AM, Avi Kivity wrote: > > > >> Why the gpa ->hva mapp

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-14 Thread Avi Kivity
On 11/14/2010 12:37 PM, Stefan Hajnoczi wrote: On Sun, Nov 14, 2010 at 10:34 AM, Avi Kivity wrote: > On 11/12/2010 11:20 AM, Stefan Hajnoczi wrote: >> >> >Who guarantees that less common virtio-blk and virtio-net guest drivers >> >for non-Linux OSes are fine with it? Maybe you should

Re: [PATCH] KVM: VMX: Inform user about INTEL_TXT dependency

2010-11-14 Thread Avi Kivity
On 11/14/2010 12:41 PM, Jan Kiszka wrote: Am 14.11.2010 11:30, Avi Kivity wrote: > On 11/14/2010 11:18 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Without CONFIG_INTEL_TXT, the user must not enable this feature in the >> BIOS. Otherwise, KVM will not work. Explain this dependency via a ke

Re: [PATCH 3/4] KVM: MMU: notrap it if gpte's reserved is set

2010-11-14 Thread Avi Kivity
On 11/12/2010 12:34 PM, Xiao Guangrong wrote: We can past the page fault to guest directly if gpte's reserved is set How can that work? shadow_notrap_nonpresent_pte causes a fault with PFEC.P=PFEC.RSVD=0, while we need PFEC.P=PFEC.RSVD=1. Signed-off-by: Xiao Guangrong --- arch/x86/kvm/pa

Fwd: [PATCH]: An implementation of HyperV KVP functionality

2010-11-14 Thread Dor Laor
FYI. Long ago we discussed key value approach on top of virtio-serial. Original Message Subject: [PATCH]: An implementation of HyperV KVP functionality Date: Thu, 11 Nov 2010 13:03:10 -0700 From: Ky Srinivasan To: , CC: Haiyang Zhang , Greg KH I am enclosing a patch that i

Re: [PATCH 1/4] KVM: MMU: don't drop spte if overwrite it from W to RO

2010-11-14 Thread Avi Kivity
On 11/12/2010 12:30 PM, Xiao Guangrong wrote: We just need flush tlb if overwrite a writable spte with a read-only one What are the advantages? Avoid playing with rmap, and avoid a window where the spte is missing? (they are worth the patch, just seeing if I'm not missing something) -- er

Re: [PATCH v2 5/5] KVM: MMU: retry #PF for softmmu

2010-11-14 Thread Avi Kivity
On 11/12/2010 08:50 AM, Xiao Guangrong wrote: Retry #PF for softmmu only when the current vcpu has the same root shadow page as the time when #PF occurs. it means they have same paging environment The process could have been killed and replaced by another using the same cr3. Or we may be run

Re: [PATCH] KVM: VMX: Inform user about INTEL_TXT dependency

2010-11-14 Thread Jan Kiszka
Am 14.11.2010 11:30, Avi Kivity wrote: > On 11/14/2010 11:18 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Without CONFIG_INTEL_TXT, the user must not enable this feature in the >> BIOS. Otherwise, KVM will not work. Explain this dependency via a kernel >> log message. >> >> Signed-off-by: Jan Ki

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-14 Thread Stefan Hajnoczi
On Sun, Nov 14, 2010 at 10:34 AM, Avi Kivity wrote: > On 11/12/2010 11:20 AM, Stefan Hajnoczi wrote: >> >> >  Who guarantees that less common virtio-blk and virtio-net guest drivers >> >  for non-Linux OSes are fine with it?  Maybe you should add a feature >> > flag >> >  that the guest has to ACK

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-14 Thread Avi Kivity
On 11/12/2010 11:20 AM, Stefan Hajnoczi wrote: > Who guarantees that less common virtio-blk and virtio-net guest drivers > for non-Linux OSes are fine with it? Maybe you should add a feature flag > that the guest has to ACK to enable it. Virtio-blk and virtio-net are fine. Both of those dev

Re: [PATCH] KVM: VMX: Inform user about INTEL_TXT dependency

2010-11-14 Thread Avi Kivity
On 11/14/2010 11:18 AM, Jan Kiszka wrote: From: Jan Kiszka Without CONFIG_INTEL_TXT, the user must not enable this feature in the BIOS. Otherwise, KVM will not work. Explain this dependency via a kernel log message. Signed-off-by: Jan Kiszka --- arch/x86/kvm/vmx.c |7 ++- 1 files cha

Re: [PATCH] intel-iommu: Fix use after release during device attach

2010-11-14 Thread Jan Kiszka
Am 02.11.2010 08:31, Sheng Yang wrote: > On Tuesday 02 November 2010 15:05:51 Jan Kiszka wrote: >> From: Jan Kiszka >> >> Obtail the new pgd pointer before releasing the page containing this >> value. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Who is taking care of this? The kvm tree? >> >> dr

[PATCH] KVM: VMX: Inform user about INTEL_TXT dependency

2010-11-14 Thread Jan Kiszka
From: Jan Kiszka Without CONFIG_INTEL_TXT, the user must not enable this feature in the BIOS. Otherwise, KVM will not work. Explain this dependency via a kernel log message. Signed-off-by: Jan Kiszka --- arch/x86/kvm/vmx.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff