[PATCH 11/19] ioport: insert event_tap_ioport() to ioport_write().

2010-12-27 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index aa4188a..74aebf5 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7 @@

[PATCH 17/19] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled.

2010-12-27 Thread Yoshiaki Tamura
When ft_mode is set in the header, tcp_accept_incoming_migration() sets ft_trans_incoming() as a callback, and call qemu_file_get_notify() to receive FT transaction iteratively. We also need a hack no to close fd before moving to ft_transaction mode, so that we can reuse the fd for it.

[PATCH 19/19] migration: add a parser to accept FT migration incoming mode.

2010-12-27 Thread Yoshiaki Tamura
The option looks like, -incoming protocol:address:port,ft_mode Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index a4a39eb..14d7089 100644 --- a/migration.c

[PATCH 06/19] virtio: decrement last_avail_idx with inuse before saving.

2010-12-27 Thread Yoshiaki Tamura
For regular migration inuse == 0 always as requests are flushed before save. However, event-tap log when enabled introduces an extra queue for requests which is not being flushed, thus the last inuse requests are left in the event-tap queue. Move the last_avail_idx value sent to the remote back

[PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin,commit}.

2010-12-27 Thread Yoshiaki Tamura
Introduce qemu_savevm_state_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- savevm.c | 88 ++ sysemu.h |

[PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer.

2010-12-27 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |5 ++ savevm.c | 148 ++ 2 files changed, 153 insertions(+), 0 deletions(-) diff

[PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2010-12-27 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- block.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 9b5e9e1..39009fc 100644

[PATCH 09/19] Introduce event-tap.

2010-12-27 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by:

[PATCH 16/19] migration: introduce migrate_ft_trans_{put,get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2010-12-27 Thread Yoshiaki Tamura
Introduce migrate_ft_trans_put_ready() which kicks the FT transaction cycle. When ft_mode is on, migrate_fd_put_ready() would open ft_trans_file and turn on event_tap. To end or cancel FT transaction, ft_mode and event_tap is turned off. migrate_ft_trans_get_ready() is called to receive ack

[PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state().

2010-12-27 Thread Yoshiaki Tamura
Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c |2 +- savevm.c| 24 +--- sysemu.h|2 +- 3 files changed, 15

[PATCH 04/19] qemu-char: export socket_set_nodelay().

2010-12-27 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index edc9ad6..737d347 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2116,7 +2116,7 @@ static

[PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2010-12-27 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index 49c28b1..4a171cc 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7 @@

[PATCH 02/19] Introduce read() to FdMigrationState.

2010-12-27 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration-tcp.c | 15 +++ migration.c | 12 migration.h |3 +++ 3 files

[PATCH 00/19] Kemari for KVM v0.2.2

2010-12-27 Thread Yoshiaki Tamura
Hi, This patch series is a revised version of Kemari for KVM, which applied comments for the previous post. The current code is based on qemu.git 9ed5726c043958359b0f1fa44ab3e4f25f9d9a47. The changes from v0.2.1 - v0.2.2 are: - decrement last_avaid_idx with inuse before saving (MST) - remove

[PATCH 13/19] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2010-12-27 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index 9ba5be2..1176124 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include

[PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2010-12-27 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index

[PATCH 07/19] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2010-12-27 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by:

[PATCH 10/19] Call init handler of event-tap at main() in vl.c.

2010-12-27 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index f3b4a5b..c79d614 100644 --- a/vl.c +++ b/vl.c @@ -162,6 +162,7 @@ int main(int argc, char **argv) #include qemu-queue.h #include

[PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Yoshiaki Tamura
When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hmp-commands.hx |7 --- migration.c |3 +++ qmp-commands.hx |7 --- 3 files changed, 11 insertions(+), 6

[PATCH 05/19] vl.c: add deleted flag for deleting the handler.

2010-12-27 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c

Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Michael S. Tsirkin
On Mon, Dec 27, 2010 at 05:25:36PM +0900, Yoshiaki Tamura wrote: When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hmp-commands.hx |7 --- migration.c |3

Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Yoshiaki Tamura
2010/12/27 Michael S. Tsirkin m...@redhat.com: On Mon, Dec 27, 2010 at 05:25:36PM +0900, Yoshiaki Tamura wrote: When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp ---  

Re: [PATCH] KVM: MMU: Don't flush shadow when enabling dirty tracking

2010-12-27 Thread Avi Kivity
On 12/27/2010 06:06 AM, Takuya Yoshikawa wrote: Avi Kivitya...@redhat.com wrote: Instead, drop large mappings, which were the reason we dropped shadow. Signed-off-by: Avi Kivitya...@redhat.com --- arch/x86/kvm/mmu.c | 10 ++ virt/kvm/kvm_main.c |7 +-- 2 files

Re: [PATCH] KVM: MMU: Don't flush shadow when enabling dirty tracking

2010-12-27 Thread Avi Kivity
On 12/27/2010 11:16 AM, Avi Kivity wrote: On 12/27/2010 06:06 AM, Takuya Yoshikawa wrote: Avi Kivitya...@redhat.com wrote: Instead, drop large mappings, which were the reason we dropped shadow. Signed-off-by: Avi Kivitya...@redhat.com --- arch/x86/kvm/mmu.c | 10 ++

Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Michael S. Tsirkin
On Mon, Dec 27, 2010 at 06:11:27PM +0900, Yoshiaki Tamura wrote: 2010/12/27 Michael S. Tsirkin m...@redhat.com: On Mon, Dec 27, 2010 at 05:25:36PM +0900, Yoshiaki Tamura wrote: When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari).

[PATCH v2] KVM: MMU: Don't flush shadow when enabling dirty tracking

2010-12-27 Thread Avi Kivity
Instead, drop large mappings, which were the reason we dropped shadow. Signed-off-by: Avi Kivity a...@redhat.com --- v2: maintain largepage stats arch/x86/kvm/mmu.c | 12 virt/kvm/kvm_main.c |7 +-- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git

Re: kvm bug in kernel 2.6.37rc7

2010-12-27 Thread nicolas prochazka
hello again, in fact seven 32bit is also concerned cpuinfo and cmdline. Regards, NP DEV-10.98.98.1:~# cat /proc/cpuinfo processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 23 model name : Intel(R) Core(TM)2 Duo CPU E8400 @ 3.00GHz stepping:

Re: [PATCH v2] KVM: MMU: Don't flush shadow when enabling dirty tracking

2010-12-27 Thread Takuya Yoshikawa
On Mon, 27 Dec 2010 12:08:45 +0200 Avi Kivity a...@redhat.com wrote: Instead, drop large mappings, which were the reason we dropped shadow. Signed-off-by: Avi Kivity a...@redhat.com --- v2: maintain largepage stats arch/x86/kvm/mmu.c | 12 virt/kvm/kvm_main.c |7

Re: [PATCH v2] KVM: MMU: Don't flush shadow when enabling dirty tracking

2010-12-27 Thread Avi Kivity
On 12/27/2010 12:35 PM, Takuya Yoshikawa wrote: On Mon, 27 Dec 2010 12:08:45 +0200 Avi Kivitya...@redhat.com wrote: Instead, drop large mappings, which were the reason we dropped shadow. Signed-off-by: Avi Kivitya...@redhat.com --- v2: maintain largepage stats arch/x86/kvm/mmu.c

Re: [PATCH v2] KVM: MMU: Don't flush shadow when enabling dirty tracking

2010-12-27 Thread Takuya Yoshikawa
On Mon, 27 Dec 2010 12:43:59 +0200 Avi Kivity a...@redhat.com wrote: rmap_write_protect() protects a 4k page, so it uses update_spte() to drop the W bit, and drops large mappings that point to the same 4k page. We can't drop the W bit from the large page, because that will write protect

Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Yoshiaki Tamura
2010/12/27 Michael S. Tsirkin m...@redhat.com: On Mon, Dec 27, 2010 at 06:11:27PM +0900, Yoshiaki Tamura wrote: 2010/12/27 Michael S. Tsirkin m...@redhat.com: On Mon, Dec 27, 2010 at 05:25:36PM +0900, Yoshiaki Tamura wrote: When -k option is set to migrate command, it will turn on ft_mode to

Passthrough VIA CPU Features

2010-12-27 Thread Nico Prenzel
Hello KVM developers, I've recently bought such a nice low-power board from VIA (EPIA M-850). The included VIA cpu (VIA NANO U3100) contains of in-silicon features (esp. AES and SHA encryption): /* VIA/Cyrix/Centaur-defined CPU features, CPUID level 0xC001, word 5 */ #define

Re: Passthrough VIA CPU Features

2010-12-27 Thread Avi Kivity
On 12/27/2010 02:37 PM, Nico Prenzel wrote: Hello KVM developers, I've recently bought such a nice low-power board from VIA (EPIA M-850). The included VIA cpu (VIA NANO U3100) contains of in-silicon features (esp. AES and SHA encryption): /* VIA/Cyrix/Centaur-defined CPU features, CPUID level

[PATCH] KVM: when entering real mode aling segment base to 16 bytes

2010-12-27 Thread Gleb Natapov
VMX checks that base is equal segment shifted 4 bites left. Otherwise guest entry fails. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 2260783..45014ba 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -1736,7 +1736,7 @@ static

[PATCH RESEND] KVM: when entering real mode align segment base to 16 bytes

2010-12-27 Thread Gleb Natapov
VMX checks that base is equal segment shifted 4 bites left. Otherwise guest entry fails. Signed-off-by: Gleb Natapov g...@redhat.com -- Same as previous one but with correct (I hope) To: header. diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 2260783..45014ba 100644 ---

Antwort: Re: Passthrough VIA CPU Features

2010-12-27 Thread Nico Prenzel
Hello Avi, thanks for your quick respone. That doesn't sound bad! I've found the needed documentation (I think): http://www.via.com.tw/en/downloads/whitepapers/initiatives/padlock/programming_guide.pdf As my C knowloedge isn't hardware related, i don't understand what to look for. Of course,

Re: Antwort: Re: Passthrough VIA CPU Features

2010-12-27 Thread Avi Kivity
On 12/27/2010 04:05 PM, Nico Prenzel wrote: Hello Avi, thanks for your quick respone. That doesn't sound bad! I've found the needed documentation (I think): http://www.via.com.tw/en/downloads/whitepapers/initiatives/padlock/programming_guide.pdf As my C knowloedge isn't hardware related, i

Re: [PATCH RESEND] KVM: when entering real mode align segment base to 16 bytes

2010-12-27 Thread Avi Kivity
On 12/27/2010 03:01 PM, Gleb Natapov wrote: VMX checks that base is equal segment shifted 4 bites left. Otherwise guest entry fails. Signed-off-by: Gleb Natapovg...@redhat.com -- Same as previous one but with correct (I hope) To: header. diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c

target dev name ignored?

2010-12-27 Thread Erik Brakkee
Hi, When I define a domain XML with a virtio disk then the target device setting is ignored. For instance, given this disk declaration the target device name is still 'vda' and not 'sda': disk type='block' device='disk' driver name='qemu' type='raw'/ source dev='/dev/system/linux32'/

Re: [PATCH RESEND] KVM: when entering real mode align segment base to 16 bytes

2010-12-27 Thread Gleb Natapov
On Mon, Dec 27, 2010 at 04:21:53PM +0200, Avi Kivity wrote: On 12/27/2010 03:01 PM, Gleb Natapov wrote: VMX checks that base is equal segment shifted 4 bites left. Otherwise guest entry fails. Signed-off-by: Gleb Natapovg...@redhat.com -- Same as previous one but with correct (I hope) To:

kvm: grub breakage due to SS.RPL/DPL alignment

2010-12-27 Thread Jan Kiszka
Hi, when interrupting a guest (grub in graphical mode) in this state EAX=0011 EBX=0004bc88 ECX=000d EDX=000db51d ESI=08ff EDI=002462da EBP= ESP=1fbc EIP=78b6 EFL=0006 [-P-] CPL=0 II=0 A20=1 SMM=0 HLT=0 ES = 9300 DPL=0 DS16 [-WA] CS

Re: kvm: grub breakage due to SS.RPL/DPL alignment

2010-12-27 Thread Avi Kivity
On 12/27/2010 04:37 PM, Jan Kiszka wrote: Hi, when interrupting a guest (grub in graphical mode) in this state EAX=0011 EBX=0004bc88 ECX=000d EDX=000db51d ESI=08ff EDI=002462da EBP= ESP=1fbc EIP=78b6 EFL=0006 [-P-] CPL=0 II=0 A20=1 SMM=0 HLT=0 ES =

Re: [PATCH RESEND] KVM: when entering real mode align segment base to 16 bytes

2010-12-27 Thread Avi Kivity
On 12/27/2010 04:37 PM, Gleb Natapov wrote: What's the scenario here? And what segment is involved? if it's fs or gs, or maybe ss, I can see it working out, but hardly otherwise. The scenario is older Seabios that lefts DS segment unaligned during switch to real mode in int1587 function

[PATCH] kvm: x86: Fix DPL write back of segment registers

2010-12-27 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com The DPL is stored in the flags and not in the selector. In fact, the RPL may differ from the DPL at some point in time, and so we were corrupting the guest state so far. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/kvm.c |2 +- 1

[PATCH] kvm: x86: Prevent sign extension of DR7 in guest debugging mode

2010-12-27 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com This unbreaks guest debugging when the 4th hardware breakpoint used for guest debugging is a watchpoint of 4 or 8 byte lenght. The 31st bit of DR7 is set in that case and used to cause a sign extension to the high word which was breaking the guest state (vm

Re: [PATCH RESEND] KVM: when entering real mode align segment base to 16 bytes

2010-12-27 Thread Avi Kivity
On 12/27/2010 04:58 PM, Gleb Natapov wrote: On Mon, Dec 27, 2010 at 04:55:08PM +0200, Avi Kivity wrote: On 12/27/2010 04:37 PM, Gleb Natapov wrote: What's the scenario here? And what segment is involved? if it's fs or gs, or maybe ss, I can see it working out, but hardly otherwise.

[PATCH] kvm: x86: Fix a few coding style violations

2010-12-27 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com No functional changes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Applies on top of previously posted uq patches. target-i386/kvm.c | 335 + 1 files changed, 182 insertions(+), 153

[PATCHv2] KVM: when entering real mode align segment base to 16 bytes

2010-12-27 Thread Gleb Natapov
VMX checks that base is equal segment shifted 4 bites left. Otherwise guest entry fails. Signed-off-by: Gleb Natapov g...@redhat.com --- v1-v2 add printk_once. diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 2260783..e1eecf0 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c

Re: [PATCHv2] KVM: when entering real mode align segment base to 16 bytes

2010-12-27 Thread Avi Kivity
On 12/27/2010 05:25 PM, Gleb Natapov wrote: VMX checks that base is equal segment shifted 4 bites left. Otherwise guest entry fails. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH] kvm: x86: Fix DPL write back of segment registers

2010-12-27 Thread Avi Kivity
On 12/27/2010 04:56 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com The DPL is stored in the flags and not in the selector. In fact, the RPL may differ from the DPL at some point in time, and so we were corrupting the guest state so far. Applied to uq/master; thanks. -- error

Re: [PATCH] kvm: x86: Remove obsolet SS.RPL/DPL aligment

2010-12-27 Thread Avi Kivity
On 12/27/2010 04:57 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com This seems to date back to the days KVM didn't support real mode. The check is no longer needed and, even worse, is corrupting the guest state in case SS.RPL != DPL. Applied to uq/master (nice how obsolete code

Re: [PATCH] kvm: x86: Prevent sign extension of DR7 in guest debugging mode

2010-12-27 Thread Avi Kivity
On 12/27/2010 04:58 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com This unbreaks guest debugging when the 4th hardware breakpoint used for guest debugging is a watchpoint of 4 or 8 byte lenght. The 31st bit of DR7 is set in that case and used to cause a sign extension to the high

Re: [PATCH] kvm: x86: Fix a few coding style violations

2010-12-27 Thread Avi Kivity
On 12/27/2010 05:19 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com No functional changes. Applied to uq/master, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

[KVM-AUTOTEST PATCH 02/28] KVM test: kvm_utils.py: add a convenience function to run functions in parallel

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index 5d79112..57c9951 100644 ---

[KVM-AUTOTEST PATCH 03/28] KVM test: corrections to migration_with_reboot

2010-12-27 Thread Michael Goldish
- Use wait_for() to try remote_login() multiple times before giving up. - Take VM parameters from vm.params, not params. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/migration_with_reboot.py | 26 +++--- 1 files changed, 13 insertions(+), 13

[KVM-AUTOTEST PATCH 05/28] KVM test: vmstop: use kvm_utils.Thread

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/vmstop.py | 61 ++--- 1 files changed, 30 insertions(+), 31 deletions(-) diff --git a/client/tests/kvm/tests/vmstop.py b/client/tests/kvm/tests/vmstop.py index 703c881..876c3ef 100644

[KVM-AUTOTEST PATCH 04/28] KVM test: migration_with_reboot: use kvm_utils.Thread

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/migration_with_reboot.py | 19 +++ 1 files changed, 7 insertions(+), 12 deletions(-) diff --git a/client/tests/kvm/tests/migration_with_reboot.py b/client/tests/kvm/tests/migration_with_reboot.py

[KVM-AUTOTEST PATCH 06/28] KVM test: migration_with_file_transfer: use kvm_utils.Thread

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- .../kvm/tests/migration_with_file_transfer.py | 42 +++- 1 files changed, 15 insertions(+), 27 deletions(-) diff --git a/client/tests/kvm/tests/migration_with_file_transfer.py

[KVM-AUTOTEST PATCH 09/28] KVM test: remove kvm_test_utils.BackgroundTest

2010-12-27 Thread Michael Goldish
kvm_utils.Thread is used instead. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 47 1 files changed, 0 insertions(+), 47 deletions(-) diff --git a/client/tests/kvm/kvm_test_utils.py

[KVM-AUTOTEST PATCH 15/28] KVM test: kvm_subprocess.py: increase default timeout from 30 to 60 secs

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/client/tests/kvm/kvm_subprocess.py b/client/tests/kvm/kvm_subprocess.py index a60eaf6..c3e2dd7 100755 ---

[KVM-AUTOTEST PATCH 17/28] KVM test: whql_submission: make the HDD tests run on a non-system drive

2010-12-27 Thread Michael Goldish
One of the tests refuses to run on a system drive, so: - Add a 2nd disk to the qemu command line and create a 4G image for it - Partition the 2nd disk and assign D: to it before running the tests - Tell the tests to run on a non-system drive Signed-off-by: Michael Goldish mgold...@redhat.com ---

[KVM-AUTOTEST PATCH 16/28] KVM test: whql_submission: run a user specified shell command before the test

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_submission.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/tests/whql_submission.py b/client/tests/kvm/tests/whql_submission.py index b1b7f25..8dd48b8 100644 ---

[KVM-AUTOTEST PATCH 18/28] KVM test: whql: rename the whql_submission variant to whql.submission

2010-12-27 Thread Michael Goldish
Rename whql_submission to whql.submission and whql_client_install to whql.client_install. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests_base.cfg.sample | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git

[KVM-AUTOTEST PATCH 07/28] KVM test: migration_with_file_transfer: use unique host filename

2010-12-27 Thread Michael Goldish
If the same constant filename is used every time, multiple instances of the test cannot run concurrently. Signed-off-by: Michael Goldish mgold...@redhat.com --- .../kvm/tests/migration_with_file_transfer.py | 12 +++- client/tests/kvm/tests_base.cfg.sample |2 +- 2

[KVM-AUTOTEST PATCH 08/28] KVM test: migration_with_file_transfer: verify transfer correctness

2010-12-27 Thread Michael Goldish
After the transfer, copy the file back from the guest to the host and make sure the returned file is identical to the one sent to the guest. Signed-off-by: Michael Goldish mgold...@redhat.com --- .../kvm/tests/migration_with_file_transfer.py | 34 +--- 1 files changed, 29

[KVM-AUTOTEST PATCH 13/28] KVM test: don't print the contents of env before and after tests

2010-12-27 Thread Michael Goldish
It produces a lot of output and normally isn't useful. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index 4dec182..dc00edd 100644 ---

[KVM-AUTOTEST PATCH 20/28] KVM test: whql.submission: add unclassified USB tablet tests

2010-12-27 Thread Michael Goldish
Group all device tests under a 'device' variant and create a new 'unclassified' variant that currently contains only the tablet tests. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests_base.cfg.sample | 134 ++-- 1 files changed, 77

[KVM-AUTOTEST PATCH 21/28] KVM test: refactor whql_submission_15.cs and whql_submission.py

2010-12-27 Thread Michael Goldish
- deps/whql_submission_15.cs: * Handle multiple machines instead of one. * Split the code into smaller functions. * Get job parameters from the user: each parameter is a regex that should match a device name in a machine, and is set using GetParameterByName(). Note that job

[KVM-AUTOTEST PATCH 22/28] KVM test: whql: add a network submission

2010-12-27 Thread Michael Goldish
- Add whql.support_vm_install which installs a 2nd VM that is required for NDISTest (like unattended_install.cdrom, but runs on an image with a '-supportvm' suffix). - Split whql.client_install into .original and .support_vm. - Append '-supportvm' to image_name of

[KVM-AUTOTEST PATCH 25/28] KVM test: whql.submission: don't use any cdroms

2010-12-27 Thread Michael Goldish
whql.submission doesn't require any cdroms so get rid of them. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests_base.cfg.sample |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/tests_base.cfg.sample

[KVM-AUTOTEST PATCH 28/28] KVM test: whql_submission.py: log in using all NICs before running tests

2010-12-27 Thread Michael Goldish
This will make sure all NICs are up before beginning testing. Useful for network tests. For other tests it should be harmless as they only use a single NIC. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_submission.py | 14 ++ 1 files changed,

[KVM-AUTOTEST PATCH 27/28] KVM test: whql.submission: reorder DeviceData

2010-12-27 Thread Michael Goldish
The DeviceData order should now match the order in the XMLs produced by the DTM studio, which should make it easier to look at diffs (for debugging) between the XMLs produced by the automation program and the those produced by the DTM studio Signed-off-by: Michael Goldish mgold...@redhat.com ---

[KVM-AUTOTEST PATCH 23/28] KVM test: whql.submission: use a different submission name for each submission category

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_submission.py | 10 +- client/tests/kvm/tests_base.cfg.sample|4 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/tests/whql_submission.py

[KVM-AUTOTEST PATCH 11/28] KVM test: make_qemu_command(): catch IndexError when accessing self.netdev_id

2010-12-27 Thread Michael Goldish
make_qemu_command() is sometimes called to see if a VM needs to be restarted using a different qemu command line. When it's called with more NICs than the VM currently has, accessing self.netdev_id can raise an IndexError. Signed-off-by: Michael Goldish mgold...@redhat.com ---

[KVM-AUTOTEST PATCH 10/28] KVM test: avoid printing address cache messages too often

2010-12-27 Thread Michael Goldish
Currently, messages such as (address cache) Adding cache entry: 11:22:33:44:55:66 --- 10.20.30.40 are displayed for every IP address assignment caught by tcpdump. These often occur in clusters. Therefore, to avoid bloating the log files, print a message only if the last message for the same

Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Avi Kivity
On 12/27/2010 01:07 PM, Yoshiaki Tamura wrote: Not sure whether we need to mention the codename here: is it likely to help the users? Ah:-) Just didn't know what the official name should be, and placed Kemari for convenience. Any ideas or preference here? Yoshi Do we need a

[PATCH] lfp: fix AF_INET checksum with csum offloading

2010-12-27 Thread Michael S. Tsirkin
When an AF_INET socket is used, linux would sometimes return a packet without the checksum. This happens when a packet originates on the same machine, which is most common with virtual machines but might be possible even without with a software-based dhcp server such as dnsmasq. This appears to

vhost-net guest memory usage

2010-12-27 Thread Arjan Koers
When running my guests with 'vhost=on', a lot less guest memory is available (about 18.5 MB less for each networking device). I searched the mailing list archive and found a comment by Michael S. Tsirkin: with vhost, virtio does currently consume a bit more memory than with userspace backend Is

Re: QEMU, MCE, unpoison memory address across reboot

2010-12-27 Thread Marcelo Tosatti
On Sun, Dec 26, 2010 at 02:27:26PM +0200, Avi Kivity wrote: +static void kvm_unpoison_all(void *param) +{ +HWPoisonPage *page, *next_page; +unsigned long address; +KVMState *s = param; + +QLIST_FOREACH_SAFE(page,hwpoison_page_list, list, next_page) { +

Re: QEMU, MCE, unpoison memory address across reboot

2010-12-27 Thread Marcelo Tosatti
On Fri, Dec 24, 2010 at 11:30:37AM +0800, Huang Ying wrote: On Thu, 2010-12-23 at 22:28 +0800, Marcelo Tosatti wrote: Can't you free and reallocate all guest memory instead, on reboot, if there's a hwpoisoned page? Then you don't need this interface. Consider about this method. It seems

[KVM-AUTOTEST PATCH v2] KVM test: migration_with_file_transfer: verify transfer correctness

2010-12-27 Thread Michael Goldish
After the transfer, copy the file back from the guest to the host and make sure the returned file is identical to the one sent to the guest. Changes from v1: - hash_file() is in autotest_lib.client.bin.utils, so import that as client_utils. - Pass host_path_returned (not host_path) to

[KVM-AUTOTEST PATCH 1/4] KVM test: introduce Params, a dict-like object containing test parameters

2010-12-27 Thread Michael Goldish
This object should replace get_sub_dict_names() and get_sub_dict(). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py

[KVM-AUTOTEST PATCH 2/4] KVM test: kvm.py: convert the params dict to a kvm_utils.Params object

2010-12-27 Thread Michael Goldish
Also bump the env version so old env files will not be used. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index dc00edd..ceee88f 100644

[KVM-AUTOTEST PATCH 4/4] KVM test: remove get_sub_dict_names() and get_sub_dict()

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 35 --- 1 files changed, 0 insertions(+), 35 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index 1e32e30..2e4ba92 100644 ---

[KVM-AUTOTEST PATCH 3/4] KVM test: use the new Params methods instead of get_sub_dict_.*()

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 14 ++--- client/tests/kvm/kvm_vm.py | 58 ++-- client/tests/kvm/tests/pci_hotplug.py |4 +-

Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Yoshiaki Tamura
2010/12/28 Avi Kivity a...@redhat.com: On 12/27/2010 01:07 PM, Yoshiaki Tamura wrote:    Not sure whether we need to mention the codename here: is it likely to    help the users?  Ah:-)  Just didn't know what the official name should be, and  placed Kemari for convenience.  Any

Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Michael S. Tsirkin
On Tue, Dec 28, 2010 at 08:34:12AM +0900, Yoshiaki Tamura wrote: 2010/12/28 Avi Kivity a...@redhat.com: On 12/27/2010 01:07 PM, Yoshiaki Tamura wrote:    Not sure whether we need to mention the codename here: is it likely to    help the users?  Ah:-)  Just didn't know what

Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Yoshiaki Tamura
2010/12/28 Michael S. Tsirkin m...@redhat.com: On Tue, Dec 28, 2010 at 08:34:12AM +0900, Yoshiaki Tamura wrote: 2010/12/28 Avi Kivity a...@redhat.com: On 12/27/2010 01:07 PM, Yoshiaki Tamura wrote:    Not sure whether we need to mention the codename here: is it likely to    help

Re: [PATCH 0/2 v6] MSI-X mask bit support for KVM

2010-12-27 Thread Sheng Yang
On Wednesday 22 December 2010 16:44:53 Sheng Yang wrote: This patchset didn't include two PCI related patches which would be checked in through PCI subsystem. Would add the API document soon. Avi? BTW, there is one compiling issue for the second patch, due to last minute clean up...

Re: [RFC -v2 PATCH 2/3] sched: add yield_to function

2010-12-27 Thread Mike Galbraith
On Mon, 2010-12-20 at 17:04 +0100, Mike Galbraith wrote: On Mon, 2010-12-20 at 10:40 -0500, Rik van Riel wrote: On 12/17/2010 02:15 AM, Mike Galbraith wrote: BTW, with this vruntime donation thingy, what prevents a task from forking off accomplices who do nothing but wait for a wakeup

Re: QEMU, MCE, unpoison memory address across reboot

2010-12-27 Thread Huang Ying
On Tue, 2010-12-28 at 05:27 +0800, Marcelo Tosatti wrote: On Sun, Dec 26, 2010 at 02:27:26PM +0200, Avi Kivity wrote: +static void kvm_unpoison_all(void *param) +{ +HWPoisonPage *page, *next_page; +unsigned long address; +KVMState *s = param; + +