* MinChan Kim minchan@gmail.com [2011-02-10 14:41:44]:
I don't know why the part of message is deleted only when I send you.
Maybe it's gmail bug.
I hope mail sending is successful in this turn. :)
On Thu, Feb 10, 2011 at 2:33 PM, Minchan Kim minchan@gmail.com wrote:
Sorry for
Drop base_address from the vmstate, upstream decided against managing it
at device level. Continuing to interpret the vmstate field would break
compatibility with upstream. Instead, fetch the base addres from the
sysbus device state when setting the in-kernel state.
Moreover, drop redundant
On 02/13/2011 08:57 PM, Anthony Liguori wrote:
It shouldn't be able to dead lock if the locking is designed right.
As an aside, one advantage of the qemuthread wrappers is that we can add
lockdep mechanisms. (It's true that these could be added to glib as
well, but getting stuff into glib
cpu-index which uses hyphen is better name.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 5d4cb9e..e43ac7c 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -721,7 +721,7 @@ ETEXI
#if defined(TARGET_I386)
{
.name
When the argument cpu-index is not given,
then nmi command will inject NMI on all CPUs.
This simulate the nmi button on physical machine.
Note: it will allow non-argument nmi command and
change the human monitor behavior.
Thanks to Markus Armbruster for correcting the logic
detecting
Make we can inject NMI via qemu-monitor-protocol.
We use inject-nmi for the qmp command name, the meaning is clearer.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
diff --git a/hmp-commands.hx b/hmp-commands.hx
index b2c6cd6..6d3e7d2 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@
When cpu-index is found invalid in runtime, it will report
QERR_INVALID_PARAMETER_VALUE.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
diff --git a/monitor.c b/monitor.c
index 1b1c0ba..82935f0 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2563,6 +2563,7 @@ static int do_inject_nmi(Monitor
On 02/09/2011 07:48 PM, Luiz Capitulino wrote:
You should use Anthony's tree:
git://git.qemu.org/qemu.git
Done, thank you for your concern and patience.
see my sent emails:
[PATCH V6 1/4 resend]
[PATCH V6 2/4 resend]
[PATCH V6 3/4 resend]
[PATCH V6 4/4 resend]
Thanks again.
Lai
--
To
On Sun, Feb 13, 2011 at 01:38:12PM -0600, Anthony Liguori wrote:
On 02/13/2011 12:08 PM, Gleb Natapov wrote:
On Sun, Feb 13, 2011 at 10:56:30AM -0600, Anthony Liguori wrote:
qemu -device i440fx,id=nb -device piix3,id=sb,chipset=nb -device
ioapic,id=ioapic,chipset=sb -device
On Fri, Dec 10, 2010 at 01:51:31AM -0800, Shirley Ma wrote:
This patchset add supports for TX zero-copy between guest and host
kernel through vhost. It significantly reduces CPU utilization on the
local host on which the guest is located (It reduced 30-50% CPU usage
for vhost thread for single
On 02/08/11 14:32, Peter Lieven wrote:
Hi,
is there any known issue when migrating a WinXP SP3 guest with qemu-kvm 0.13.0
or qemu-kvm-0.12.5?
If I migrate such a guest with a Realtek rtl8139 Network Device and an USB
Mouse Tablet
after migration the USB Tablet doesn't work any more and
If the guest executes the following code sequence
CLI
...
(interrupt becomes pending)
STI
HLT
then we will exit on HLT, enter the guest, and exit immediately again on
virtual interrupt pending. As this is wasteful, this patch set short
circuits the whole operation to inject the
The CPU_BASED_VM_EXEC_CONTROL VMCS field is write-only, so we can cache it
in the vcpu structure and avoid a costly vmcs_read32() every time we want
to change a bit.
Signed-off-by: Avi Kivity a...@redhat.com
---
arch/x86/kvm/vmx.c | 60 +--
1
Short-circuit an STI; HLT sequence while an interrupt is pending:
instead of halting, re-entering the guest, and exiting immediately
on an interrupt window exit, go directly to the last step.
Saves a vmexit on workloads where interrupts are received synchronously;
an example is a disk backed by
Short-circuit an STI; HLT sequence while an interrupt is pending:
instead of halting, re-entering the guest, and exiting immediately
on an interrupt window exit, go directly to the last step.
Saves a vmexit on workloads where interrupts are received synchronously;
an example is a disk backed by
https://bugzilla.kernel.org/show_bug.cgi?id=27052
--- Comment #35 from Avi Kivity a...@redhat.com 2011-02-14 14:52:24 ---
Even if it isn't a kvm bug, it needs to be fixed.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because:
We see severe memory corruption in kvm while used in conjunction with
bridge/netfilter. Enabling slab debugging points the finger at a
netfilter chain invoked from the bridge code.
Can someone take a look?
https://bugzilla.kernel.org/show_bug.cgi?id=27052
--
error compiling committee.c: too
Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit :
We see severe memory corruption in kvm while used in conjunction with
bridge/netfilter. Enabling slab debugging points the finger at a
netfilter chain invoked from the bridge code.
Can someone take a look?
On Monday 2011-02-14 16:11, Eric Dumazet wrote:
Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit :
We see severe memory corruption in kvm while used in conjunction with
bridge/netfilter. Enabling slab debugging points the finger at a
netfilter chain invoked from the bridge code.
From: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
cpus.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index 0abc009..8232d44 100644
--- a/cpus.c
+++
From: Jan Kiszka jan.kis...@siemens.com
Do not ignore errors of kvm_init_vcpu, they are fatal.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
cpus.c | 19 +++
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git
The following changes since commit 8668f61d20eac971d116ebbe8436b4ae963884a8:
vmmouse: fix queue_size field initialization (2011-02-12 17:44:11 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
Anthony PERARD (1):
Introduce
From: Jan Kiszka jan.kis...@siemens.com
No functional changes.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
cpus.c | 71 +++
1 files changed, 44 insertions(+), 27
From: Jan Kiszka jan.kis...@siemens.com
Avoid duplicate use of the function name cpu_has_work, it's confusing,
also their scope. Refactor cpu_has_work to cpu_thread_is_idle and do the
same with any_cpu_has_work.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com
Will be required for SIGBUS handling. For obvious reasons, this will
remain a nop on Windows hosts.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
From: Jan Kiszka jan.kis...@siemens.com
Instead of fiddling with debug_requested and vmstop_requested directly,
introduce qemu_system_debug_request and turn qemu_system_vmstop_request
into a public interface. This aligns those services with exiting ones in
vl.c.
Signed-off-by: Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com
First of all, vm_can_run is a misnomer, it actually means no request
pending. Moreover, there is no need to check all pending requests
twice, the first time via the inner loop check and then again when
actually processing the requests. We can simply remove
From: Jan Kiszka jan.kis...@siemens.com
Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between
checking for exit_request on vcpu entry and timer signals arriving
before KVM starts to catch them. Plug it by blocking both timer related
signals also on !CONFIG_IOTHREAD and process those
From: Jan Kiszka jan.kis...@siemens.com
Currently, we only configure and process MCE-related SIGBUS events if
CONFIG_IOTHREAD is enabled. The groundwork is laid, we just need to
factor out the required handler registration and system configuration.
Signed-off-by: Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com
A pending vmstop request is also a reason to leave the inner main loop.
So far we ignored it, and pending stop requests issued over VCPU threads
were simply ignored.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com
Introduce qemu_cpu_kick_self to send SIG_IPI to the calling VCPU
context. First user will be kvm.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
cpus.c| 21 +
From: Glauber Costa glom...@redhat.com
If the machine is stopped, we should not record two different tsc values
upon a save operation. The same problem happens with kvmclock.
But kvmclock is taking a different diretion, being now seen as a separate
device. Since this is unlikely to happen with
From: Jan Kiszka jan.kis...@siemens.com
Move {tcg,kvm}_init_ipi and block_io_signals to avoid prototypes, rename
the former two to clarify that they deal with more than SIG_IPI. No
functional changes - except for the tiny fixup of strerror usage.
The forward declaration of sigbus_handler is just
From: Anthony PERARD anthony.per...@citrix.com
In order to use log_start/log_stop with Xen as well in the vga code,
this two operations have been put in CPUPhysMemoryClient.
The two new functions cpu_physical_log_start,cpu_physical_log_stop are
used in hw/vga.c and replace the
From: Jan Kiszka jan.kis...@siemens.com
If kvmclock is used, which implies the kernel supports it, register a
kvmclock device with the sysbus. Its main purpose is to save and restore
the kernel state on migration, but this will also allow to visualize it
one day.
Signed-off-by: Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com
Except for timer events, we currently do not leave the loop over all
VCPUs if an IO event was filed. That may cause unexpected IO latencies
under !CONFIG_IOTHREAD in SMP scenarios. Fix it by setting the global
exit_request which breaks the loop.
From: Jan Kiszka jan.kis...@siemens.com
We do not check them, and the only arch with non-empty implementations
always returns 0 (this is also true for qemu-kvm).
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
CC: Alexander Graf ag...@suse.de
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
From: Jan Kiszka jan.kis...@siemens.com
Mixing up TCG bits with KVM already led to problems around eflags
emulation on x86. Moreover, quite some code that TCG requires on cpu
enty/exit is useless for KVM. So dispatch between tcg_cpu_exec and
kvm_cpu_exec as early as possible.
The core logic of
From: Jan Kiszka jan.kis...@siemens.com
Improve the readability of the exit dispatcher by moving the static
return value of kvm_handle_io to its caller.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
kvm-all.c | 17 -
1
From: Jan Kiszka jan.kis...@siemens.com
If there is any pending request that requires us to leave the inner loop
if main_loop, makes sure we do this as soon as possible by enforcing
non-blocking IO processing.
At this change, move variable definitions out of the inner loop to
improve
From: Jan Kiszka jan.kis...@siemens.com
The number of slots and the location of private ones changed several
times in KVM's early days. However, it's stable since 2.6.29 (our
required baseline), and slots 8..11 are no longer reserved since then.
So remove this unneeded restriction.
From: Jan Kiszka jan.kis...@siemens.com
The reset we issue on KVM_EXIT_SHUTDOWN implies that we should also
leave the VCPU loop. As we now check for exit_request which is set by
qemu_system_reset_request, this bug is no longer critical. Still it's an
unneeded extra turn.
Signed-off-by: Jan
From: Jan Kiszka jan.kis...@siemens.com
Provide arch-independent kvm_on_sigbus* stubs to remove the #ifdef'ery
from cpus.c. This patch also fixes --disable-kvm build by providing the
missing kvm_on_sigbus_vcpu kvm-stub.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Reviewed-by: Paolo Bonzini
From: Jan Kiszka jan.kis...@siemens.com
Pure interface cosmetics: Ensure that only kvm core services (as
declared in kvm.h) start with kvm_. Prepend qemu_ to those that
violate this rule in cpus.c. Also rename the corresponding tcg functions
for the sake of consistency.
Signed-off-by: Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
hw/cirrus_vga.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 5f45b5d..2724f7b 100644
From: Jan Kiszka jan.kis...@siemens.com
Effectively no functional change yet as kvm_irqchip_in_kernel still only
returns 0, but this patch will allow qemu-kvm to adopt the VCPU loop of
upsteam KVM.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com
If we call qemu_cpu_kick more than once before the target was able to
process the signal, pthread_kill will fail, and qemu will abort. Prevent
this by avoiding the redundant signal.
This logic can be found in qemu-kvm as well.
Signed-off-by: Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com
Move qemu_kvm_eat_signals around and call it also when the IO-thread is
not used. Do not yet process SIGBUS, will be armed in a separate step.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
cpus.c |
From: Jan Kiszka jan.kis...@siemens.com
If some I/O operation ends up calling qemu_system_reset_request in VCPU
context, we record this and inform the io-thread, but we do not
terminate the VCPU loop. This can lead to fairly unexpected behavior if
the triggering reset operation is supposed to
From: Jan Kiszka jan.kis...@siemens.com
We do not use the timeout, so drop its logic. As we always poll our
signals, we do not need to drop the global lock. Removing those calls
allows some further simplifications. Also fix the error processing of
sigpending at this chance.
Signed-off-by: Jan
From: Jan Kiszka jan.kis...@siemens.com
Block SIG_IPI, unblock it during KVM_RUN, just like in io-thread mode.
It's unused so far, but this infrastructure will be required for
self-IPIs and to process SIGBUS plus, in KVM mode, SIGIO and SIGALRM. As
Windows doesn't support signal services, we need
From: Jan Kiszka jan.kis...@siemens.com
We do not need to abort, but the user should be notified that weird
things go on.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
target-i386/kvm.c | 16 +---
1 files changed, 13
From: Jan Kiszka jan.kis...@siemens.com
To prepare splitting up KVM and TCG CPU entry/exit, move the debug
exception into cpus.c and invoke cpu_handle_debug_exception on return
from qemu_cpu_exec.
This also allows to clean up the debug request signaling: We can assign
the job of informing
From: Jan Kiszka jan.kis...@siemens.com
KVM-assisted devices need access to it but we have no clean channel to
distribute a reference. As a workaround until there is a better
solution, export kvm_state for global use, though use should remain
restricted to the mentioned scenario.
Signed-off-by:
From: Jan Kiszka jan.kis...@siemens.com
KVM requires to reenter the kernel after IO exits in order to complete
instruction emulation. Failing to do so will leave the kernel state
inconsistently behind. To ensure that we will get back ASAP, we issue a
self-signal that will cause KVM_RUN to return
From: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
---
kvm-all.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 2ec9e09..55f6ac3 100644
--- a/kvm-all.c
From: Jan Kiszka jan.kis...@siemens.com
Define and use dedicated constants for vm_stop reasons, they actually
have nothing to do with the EXCP_* defines used so far. At this chance,
specify more detailed reasons so that VM state change handlers can
evaluate them.
Signed-off-by: Jan Kiszka
On Mon, Feb 07, 2011 at 12:59:34PM +0100, Jan Kiszka wrote:
Drop base_address from the vmstate, upstream decided against managing it
at device level. Instead, fetch it from the sysbus device state when
setting the in-kernel state. Moreover, merge ioapic_pre_load into
ioapic_post_load as
https://bugzilla.kernel.org/show_bug.cgi?id=27052
--- Comment #36 from prochazka prochazka.nico...@gmail.com 2011-02-14
15:50:02 ---
I agree with you but i must resend this problem to kernel module bridge or
netfilter, I must isolate the issue .
Regards,
Nicolas Prochazka.
--
Configure
Le lundi 14 février 2011 à 16:18 +0100, Jan Engelhardt a écrit :
On Monday 2011-02-14 16:11, Eric Dumazet wrote:
Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit :
We see severe memory corruption in kvm while used in conjunction with
bridge/netfilter. Enabling slab debugging
https://bugzilla.kernel.org/show_bug.cgi?id=27052
--- Comment #37 from prochazka prochazka.nico...@gmail.com 2011-02-14
15:51:14 ---
Sorry I do not read your post to netfilter devel list.
Nicolas
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are
On 2011-02-14 16:43, Marcelo Tosatti wrote:
On Mon, Feb 07, 2011 at 12:59:34PM +0100, Jan Kiszka wrote:
Drop base_address from the vmstate, upstream decided against managing it
at device level. Instead, fetch it from the sysbus device state when
setting the in-kernel state. Moreover, merge
https://bugzilla.kernel.org/show_bug.cgi?id=27052
--- Comment #38 from Avi Kivity a...@redhat.com 2011-02-14 16:02:06 ---
Please revert ca44ac386181ba7 and try again (with netfilter enabled).
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are
Am 14.02.2011 16:50, schrieb Eric Dumazet:
Le lundi 14 février 2011 à 16:18 +0100, Jan Engelhardt a écrit :
On Monday 2011-02-14 16:11, Eric Dumazet wrote:
Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit :
We see severe memory corruption in kvm while used in conjunction with
Le lundi 14 février 2011 à 17:24 +0100, Patrick McHardy a écrit :
Am 14.02.2011 16:50, schrieb Eric Dumazet:
Le lundi 14 février 2011 à 16:18 +0100, Jan Engelhardt a écrit :
On Monday 2011-02-14 16:11, Eric Dumazet wrote:
Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit :
We
Am 14.02.2011 17:29, schrieb Eric Dumazet:
Le lundi 14 février 2011 à 17:24 +0100, Patrick McHardy a écrit :
Also, I wonder if RCU rules are respected in nf_iterate().
For example this line is really suspicious :
*i = (*i)-prev;
Yeah, that definitely looks wrong. How about this instead?
Le lundi 14 février 2011 à 17:37 +0100, Patrick McHardy a écrit :
Am 14.02.2011 17:29, schrieb Eric Dumazet:
Le lundi 14 février 2011 à 17:24 +0100, Patrick McHardy a écrit :
Also, I wonder if RCU rules are respected in nf_iterate().
For example this line is really suspicious :
*i =
Am 14.02.2011 17:48, schrieb Eric Dumazet:
Le lundi 14 février 2011 à 17:37 +0100, Patrick McHardy a écrit :
Am 14.02.2011 17:29, schrieb Eric Dumazet:
Le lundi 14 février 2011 à 17:24 +0100, Patrick McHardy a écrit :
Also, I wonder if RCU rules are respected in nf_iterate().
For example this
On Sun, 13 Feb 2011 23:43:40 +0100
Alexander Graf ag...@suse.de wrote:
struct kvmppc_book3e_tlb_entry {
union {
__u64 mas8_1;
struct {
__u32 mas8;
__u32 mas1;
};
};
__u64 mas2;
union {
On Mon, Feb 14, 2011 at 12:42 AM, Anthony Liguori anth...@codemonkey.ws wrote:
On 02/13/2011 03:00 PM, Blue Swirl wrote:
On Sun, Feb 13, 2011 at 9:57 PM, Anthony Liguorianth...@codemonkey.ws
wrote:
On 02/13/2011 01:37 PM, Blue Swirl wrote:
On Sun, Feb 13, 2011 at 5:31 PM, Anthony
On Sat, 2011-02-12 at 16:04 +, James Neave wrote:
On Tue, Feb 8, 2011 at 10:17 AM, James Neave robo...@gmail.com wrote:
On Tue, Feb 8, 2011 at 9:59 AM, Kenni Lund ke...@kelu.dk wrote:
2011/2/7 Daniel P. Berrange berra...@redhat.com:
On Sat, Feb 05, 2011 at 04:34:01PM +, James Neave
Please send in any agenda items you are interested in covering.
thanks,
-chris
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
I've been doing some work with /block/nbd.c with the aim of improving
its behaviour when the NBD server is inaccessible or goes away.
Current behaviour is to exit on startup if connecting to the NBD server
fails for any reason. If the connection dies once KVM is started, the
VM stays up but
These diffs to upstream should all date back to the days qemu-kvm
supported vga dirty logging with restricted/broken kvm kernel modules.
We no longer do, so there is no need for those workarounds. Even worse
they can trigger internal bug checks these days:
BUG: kvm_dirty_pages_log_change: invalid
Hi,
I've set up a KVM hypervisor for testing purposes. It's running on an
AMD Quad-Core Phenom with a local RAID5 which is made of three disks
connected to a hardware RAID controller. On top of this, there an LVM
volume.
dd'ing /dev/zero to a testfile gives me a throughput of about 400MB/s
On 02/14/2011 09:22 AM, Marcelo Tosatti wrote:
The following changes since commit 8668f61d20eac971d116ebbe8436b4ae963884a8:
vmmouse: fix queue_size field initialization (2011-02-12 17:44:11 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git
On 14.02.2011, at 18:11, Scott Wood scottw...@freescale.com wrote:
On Sun, 13 Feb 2011 23:43:40 +0100
Alexander Graf ag...@suse.de wrote:
struct kvmppc_book3e_tlb_entry {
union {
__u64 mas8_1;
struct {
__u32 mas8;
__u32 mas1;
};
};
On 02/14/2011 11:31 AM, Blue Swirl wrote:
I don't understand. The caller just does
if (isa_serial_init()) {
error();
}
or
if (serial_init()) {
error();
}
If you mean inside isa_serial_init() vs. serial_init(), that may be
true since isa_serial_init has to check for qdev failures, but the
On Mon, 14 Feb 2011 21:19:19 +0100
Alexander Graf ag...@suse.de wrote:
There's no nack here :). The only thing that needs to change is the anonymous
part, as that's a gnu extension. Just name the structs and unions and all is
well.
Ah, I thought it was an aesthetic objection -- didn't
On Mon, Feb 14, 2011 at 10:53 PM, Anthony Liguori anth...@codemonkey.ws wrote:
On 02/14/2011 11:31 AM, Blue Swirl wrote:
I don't understand. The caller just does
if (isa_serial_init()) {
error();
}
or
if (serial_init()) {
error();
}
If you mean inside isa_serial_init() vs.
On 02/14/2011 03:25 PM, Blue Swirl wrote:
I'd still like to have the inline wrapper over the factory interface,
probably with similar signature to isa_serial_new. Then there would be
two functions, one going through qdev and the other bypassing it. I
don't see how that would be useful.
The
On 02/14/2011 11:56 AM, Chris Wright wrote:
Please send in any agenda items you are interested in covering.
-rc2 is tagged and waiting for announcement. Please take a look at -rc2
and make sure there is nothing critical missing. Will tag 0.14.0 very
late tomorrow but unless there's
On Mon, 2011-02-14 at 15:09 +0200, Michael S. Tsirkin wrote:
What's the status here? Since there are core net changes, we'll need
to
see the final version soon if it's to appear in 2.6.39.
I am updating the patch and retesting it for the new kernel. I am trying
to understand why zero copy
On 14.02.2011, at 22:16, Scott Wood wrote:
On Mon, 14 Feb 2011 21:19:19 +0100
Alexander Graf ag...@suse.de wrote:
There's no nack here :). The only thing that needs to change is the
anonymous part, as that's a gnu extension. Just name the structs and unions
and all is well.
Ah, I
On Tue, 15 Feb 2011 00:39:51 +0100
Alexander Graf ag...@suse.de wrote:
On 14.02.2011, at 22:16, Scott Wood wrote:
On Mon, 14 Feb 2011 21:19:19 +0100
Alexander Graf ag...@suse.de wrote:
The struct name should also have
a version indicator - it's the data descriptor only a single
On 15.02.2011, at 00:49, Scott Wood wrote:
On Tue, 15 Feb 2011 00:39:51 +0100
Alexander Graf ag...@suse.de wrote:
On 14.02.2011, at 22:16, Scott Wood wrote:
On Mon, 14 Feb 2011 21:19:19 +0100
Alexander Graf ag...@suse.de wrote:
The struct name should also have
a version indicator -
On Sun, 13 Feb 2011 23:43:40 +0100
Alexander Graf ag...@suse.de wrote:
struct kvmppc_book3e_tlb_entry {
union {
__u64 mas8_1;
struct {
__u32 mas8;
__u32 mas1;
};
};
__u64 mas2;
union {
On 14.02.2011, at 18:11, Scott Wood scottw...@freescale.com wrote:
On Sun, 13 Feb 2011 23:43:40 +0100
Alexander Graf ag...@suse.de wrote:
struct kvmppc_book3e_tlb_entry {
union {
__u64 mas8_1;
struct {
__u32 mas8;
__u32 mas1;
};
};
On 14.02.2011, at 22:16, Scott Wood wrote:
On Mon, 14 Feb 2011 21:19:19 +0100
Alexander Graf ag...@suse.de wrote:
There's no nack here :). The only thing that needs to change is the
anonymous part, as that's a gnu extension. Just name the structs and unions
and all is well.
Ah, I
On 15.02.2011, at 00:49, Scott Wood wrote:
On Tue, 15 Feb 2011 00:39:51 +0100
Alexander Graf ag...@suse.de wrote:
On 14.02.2011, at 22:16, Scott Wood wrote:
On Mon, 14 Feb 2011 21:19:19 +0100
Alexander Graf ag...@suse.de wrote:
The struct name should also have
a version indicator -
90 matches
Mail list logo
