On Fri, 29 Apr 2011 14:38:08 +0900
Takuya Yoshikawa takuya.yoshik...@gmail.com wrote:
On Thu, 28 Apr 2011 19:46:00 -0700
Andi Kleen a...@firstfloor.org wrote:
Avi Kivity a...@redhat.com writes:
Good optimization. copy_from_user() really isn't optimized for short
buffers, I expect
This patch fixes virtio-net randmom stall
host $ scp guest:/root/big.guest .
big.guest 42% 440MB 67.7KB/s - stalled -
Signed-off-by: Asias He asias.he...@gmail.com
---
tools/kvm/virtio-net.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Asias He asias.he...@gmail.com
---
tools/kvm/virtio-console.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/kvm/virtio-console.c b/tools/kvm/virtio-console.c
index e66d198..492c859 100644
--- a/tools/kvm/virtio-console.c
+++
Signed-off-by: Asias He asias.he...@gmail.com
---
tools/kvm/virtio-blk.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/kvm/virtio-blk.c b/tools/kvm/virtio-blk.c
index 3feabd0..ade6335 100644
--- a/tools/kvm/virtio-blk.c
+++ b/tools/kvm/virtio-blk.c
@@ -159,7
* Asias He asias.he...@gmail.com wrote:
Signed-off-by: Asias He asias.he...@gmail.com
---
tools/kvm/virtio-blk.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/kvm/virtio-blk.c b/tools/kvm/virtio-blk.c
index 3feabd0..ade6335 100644
---
* Asias He asias.he...@gmail.com wrote:
Signed-off-by: Asias He asias.he...@gmail.com
---
tools/kvm/virtio-console.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/kvm/virtio-console.c b/tools/kvm/virtio-console.c
index e66d198..492c859 100644
---
* Asias He asias.he...@gmail.com wrote:
This patch fixes virtio-net randmom stall
host $ scp guest:/root/big.guest .
big.guest 42% 440MB 67.7KB/s - stalled -
Signed-off-by: Asias He asias.he...@gmail.com
---
tools/kvm/virtio-net.c |9 +++--
1 files changed, 7 insertions(+),
On Fri, Apr 29, 2011 at 9:36 AM, Asias He asias.he...@gmail.com wrote:
This patch fixes virtio-net randmom stall
host $ scp guest:/root/big.guest .
big.guest 42% 440MB 67.7KB/s - stalled -
Signed-off-by: Asias He asias.he...@gmail.com
---
tools/kvm/virtio-net.c | 9 +++--
1
On Fri, Apr 29, 2011 at 9:44 AM, Ingo Molnar mi...@elte.hu wrote:
Hm, this looks a bit strange (the mutex here protects only a kernel call -
that
cannot be right) and there's no explanation why it's needed. Why do
VIRTIO_BLK_IRQ (== KVM_IRQ_LINE ioctl()) calls have to be covered by the
Only I can guess for that reason is the reduction of some function calls
by inlining some functions.
Yes once at a time cfu was inline too and just checked for the right
sizes and the used g*u, but it got lost in the icache over everything else
mania which is unfortunately en vogue for quite
On 04/29/2011 02:52 PM, Pekka Enberg wrote:
Please make that IRQ latency fix a separate patch. Don't we need to do
it for TX path as well, btw?
No. We only need it in RX path. Sasha's threadpool patch breaks this.
I'm just moving it back.
--
Best Regards,
Asias He
--
To unsubscribe from
On 04/28/2011 09:40 PM, Sasha Levin wrote:
This patch adds a generic pool to create a common interface for working with
threads within the kvm tool.
Main idea here is using this threadpool for all I/O threads instead of having
every I/O module write it's own thread code.
The process of
On Fri, Apr 29, 2011 at 10:13 AM, Asias He asias.he...@gmail.com wrote:
No. We only need it in RX path. Sasha's threadpool patch breaks this.
I'm just moving it back.
OK, cool! Can you send the fix as a separate patch?
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body
On 04/29/2011 02:55 PM, Pekka Enberg wrote:
On Fri, Apr 29, 2011 at 9:44 AM, Ingo Molnar mi...@elte.hu wrote:
Hm, this looks a bit strange (the mutex here protects only a kernel call -
that
cannot be right) and there's no explanation why it's needed. Why do
VIRTIO_BLK_IRQ (== KVM_IRQ_LINE
* Asias He asias.he...@gmail.com wrote:
This patch fixes virtio-net randmom stall
host $ scp guest:/root/big.guest .
big.guest 42% 440MB 67.7KB/s - stalled -
@@ -77,9 +77,12 @@ static void virtio_net_rx_callback(struct kvm *self, void
*param)
head =
On 04/29/2011 03:15 PM, Pekka Enberg wrote:
On Fri, Apr 29, 2011 at 10:13 AM, Asias He asias.he...@gmail.com wrote:
No. We only need it in RX path. Sasha's threadpool patch breaks this.
I'm just moving it back.
OK, cool! Can you send the fix as a separate patch?
Here you go.
--
Best
* Asias He asias.he...@gmail.com wrote:
On 04/29/2011 03:15 PM, Pekka Enberg wrote:
On Fri, Apr 29, 2011 at 10:13 AM, Asias He asias.he...@gmail.com wrote:
No. We only need it in RX path. Sasha's threadpool patch breaks this.
I'm just moving it back.
OK, cool! Can you send the fix as
On 04/29/2011 03:30 PM, Ingo Molnar wrote:
* Asias He asias.he...@gmail.com wrote:
This patch fixes virtio-net randmom stall
host $ scp guest:/root/big.guest .
big.guest 42% 440MB 67.7KB/s - stalled -
@@ -77,9 +77,12 @@ static void virtio_net_rx_callback(struct kvm *self, void
On Fri, 2011-04-29 at 15:13 +0800, Asias He wrote:
On 04/29/2011 02:52 PM, Pekka Enberg wrote:
Please make that IRQ latency fix a separate patch. Don't we need to do
it for TX path as well, btw?
No. We only need it in RX path. Sasha's threadpool patch breaks this.
I'm just moving it
On Fri, Apr 29, 2011 at 10:26 AM, Asias He asias.he...@gmail.com wrote:
Yes, looks strange. Asias, did you see some bad behavior that this
fixes?
Yes. I see random virtio net hangs with scp test. This commit
847838c573f4c04be7547f508a99be2dfdefb4fd triggers this problem as we are
using
On Fri, 2011-04-29 at 10:55 +0300, Pekka Enberg wrote:
On Fri, Apr 29, 2011 at 10:26 AM, Asias He asias.he...@gmail.com wrote:
Yes, looks strange. Asias, did you see some bad behavior that this
fixes?
Yes. I see random virtio net hangs with scp test. This commit
On Thu, Apr 28, 2011 at 08:00:57PM -0700, Zachary Amsden wrote:
On 04/28/2011 01:20 PM, Joerg Roedel wrote:
This code checks how many guest tsc cycles have passed since this vCPU
was de-scheduled last time (and before it is running again). So since
the vCPU hasn't run in the meantime it had
klondike franxisco1988 at gmail.com writes:
/usr/src/redhat/BUILD/qemu-kvm-0.14.0/qemu-kvm.h:673:38: error: attempt to
use poisoned env
/usr/src/redhat/BUILD/qemu-kvm-0.14.0/qemu-kvm.h:690:37: error: attempt to
use poisoned TARGET_PAGE_BITS
If we emulate the command register, we must only read its content from
the shadow config space. For dword read of both PCI_COMMAND and
PCI_STATUS, at least the latter must be read from the device.
For simplicity reasons and as the code path is not considered
performance critical for the affected
We will need it earlier in the file, so move it unmodified to the top.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
hw/device-assignment.c | 44 ++--
1 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/hw/device-assignment.c
Define a mask of PCI command register bits that need to be emulated,
i.e. read back from their shadow state. We will need this for
selectively emulating the INTx mask bit.
Note: No initialization of emulate_cmd_mask to zero needed, the device
state is already zero-initialized.
Signed-off-by: Jan
Use ranges_overlap and proper constants to match the access range
against regions that need special handling. This also fixes yet uncaught
high-byte write access to the command register. Moreover, use more
constants instead of magic numbers.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
No one can remember where this came from, and it looks very hacky
anyway (we return 0 for config space address 0xfc of _every_ assigned
device, not only vga as the comment claims). So better remove it and
wait for the underlying issue to reappear.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
This round addresses the review comments and also add another fix to
ensure that non-virtualized config areas always hit the real device.
Jan Kiszka (6):
pci-assign: Clean up assigned_dev_pci_read/write_config
pci-assign: Move merge_bits
pci-assign: Fix dword read at PCI_COMMAND
Ensure that accesses exceeding PCI_CAPABILITY_LIST and
PCI_INTERRUPT_LINE+PIN hit the real device in areas we do not
virtualize. Again, we do not optimize these checks and accesses a lot,
they are considered to be slow paths.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
On 2011-04-28 20:51, Blue Swirl wrote:
On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell wrote:
'target_get_irq_delivered' and 'target_reset_irq_delivered' contain
entry addresses of functions that are utilized by update_irq() to
detect coalesced interrupts. apic code loads these pointers
On Fri, Apr 29, 2011 at 11:53 AM, Sasha Levin levinsasha...@gmail.com wrote:
On Fri, 2011-04-29 at 15:13 +0800, Asias He wrote:
On 04/29/2011 02:52 PM, Pekka Enberg wrote:
Please make that IRQ latency fix a separate patch. Don't we need to do
it for TX path as well, btw?
No. We only need
On 2011-04-29 11:45, Ulrich Obergfell wrote:
On 2011-04-28 20:51, Blue Swirl wrote:
On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell wrote:
'target_get_irq_delivered' and 'target_reset_irq_delivered' contain
entry addresses of functions that are utilized by update_irq() to
detect coalesced
* Sasha Levin levinsasha...@gmail.com wrote:
On Fri, 2011-04-29 at 15:13 +0800, Asias He wrote:
On 04/29/2011 02:52 PM, Pekka Enberg wrote:
Please make that IRQ latency fix a separate patch. Don't we need to do
it for TX path as well, btw?
No. We only need it in RX path.
* Asias He asias.he...@gmail.com wrote:
On 04/29/2011 03:30 PM, Ingo Molnar wrote:
* Asias He asias.he...@gmail.com wrote:
This patch fixes virtio-net randmom stall
host $ scp guest:/root/big.guest .
big.guest 42% 440MB 67.7KB/s - stalled -
@@ -77,9 +77,12 @@ static void
On Fri, Apr 29, 2011 at 1:02 PM, Cyrill Gorcunov gorcu...@gmail.com wrote:
So, if I understand all the things correct -- making virtio devices to
belong separated irqs
issued some race conditions on read\write operations between host and
guest and adding
thread pool revealed it, right?
On Fri, Apr 29, 2011 at 1:32 PM, Ingo Molnar mi...@elte.hu wrote:
Without the mutex around the kvm__irq_line, I am still seeing the
hangs(with the irq assertion movement patch).
since the mutex has no effect on the other party that modifies the virtual
queue (the guest OS), this at best only
i suspect so, threadpool makes all things to be more async as they
were before and proper lockings does matter, i could test any patches
at evening, and i must admit i never get well uderstanding on virtio
device operations yet (in terms of virtio ring :)
On Friday, April 29, 2011, Pekka Enberg
On Fri, 2011-04-29 at 15:08 +0800, Asias He wrote:
On 04/28/2011 09:40 PM, Sasha Levin wrote:
+ nr_online_cpus = sysconf(_SC_NPROCESSORS_ONLN);
+ thread_pool__init(nr_online_cpus);
We may benefit from more threads than the number of hardware thread we
have. Currently, virtio_console
As suggested by Michael Tsirkin: Move the check for GSI routing from
kvm_msi_message_add to the MSI/MSI-X initalization. If it fails (and KVM
is in in-kernel irqchip mode), do not advertise MSI at all.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
hw/msi.c |4
hw/msix.c |4
We only need to walk as many vectors on updates as the device supports.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
hw/msi.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index ddcfedd..92773e5 100644
--- a/hw/msi.c
+++ b/hw/msi.c
@@
On Fri, Apr 29, 2011 at 01:36:18AM -0700, Paul E. McKenney wrote:
On Thu, Apr 28, 2011 at 12:52:02PM +0300, Gleb Natapov wrote:
Hmmm This is interesting. KVM being a module, we either expand
TINY_RCU's size a bit by making rcu_note_context_switch() be a real
function in rcutiny.c and
On Thu, Apr 28, 2011 at 12:52:02PM +0300, Gleb Natapov wrote:
Hmmm This is interesting. KVM being a module, we either expand
TINY_RCU's size a bit by making rcu_note_context_switch() be a real
function in rcutiny.c and adding an export, or we expand it by adding
two exports.
I would like
On Fri, 29 Apr 2011 08:30:25 +0800
Huang Ying ying.hu...@intel.com wrote:
On 04/28/2011 10:04 PM, Marcelo Tosatti wrote:
On Thu, Apr 28, 2011 at 08:00:19AM -0500, Anthony Liguori wrote:
On 04/27/2011 06:06 PM, Marcelo Tosatti wrote:
On Fri, Nov 19, 2010 at 04:17:35PM +0800, Huang Ying
Andi Kleen a...@firstfloor.org wrote:
Only I can guess for that reason is the reduction of some function calls
by inlining some functions.
Yes once at a time cfu was inline too and just checked for the right
sizes and the used g*u, but it got lost in the icache over everything else
Repaired version of previous patch which has aplication problem with new
patches of autotest.
First patch in series repair minor bug in creation of kvm guest machine.
This patch is necessary for aplication of main patch.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body
Access to undefined variable.
Signed-off-by: Jiří Župka jzu...@redhat.com
---
client/virt/kvm_vm.py |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
index 5df8719..619a5f9 100644
--- a/client/virt/kvm_vm.py
+++
Example run autotest/client/netperf2 like a server.
test.runsubtest(netperf2, tag=server, server_ip=host_ip,
client_ip=guest_ip, role='server')
Client part is called in paralel thread on virtual machine.
guest = kvm_utils.Thread(kvm_test_utils.run_autotest,
Modify API function names and type names.
Signed-off-by: Sasha Levin levinsasha...@gmail.com
---
tools/kvm/include/kvm/threadpool.h |4 +-
tools/kvm/threadpool.c | 42 ++--
tools/kvm/virtio-blk.c |4 +-
tools/kvm/virtio-console.c
On Fri, 2011-04-29 at 15:59 +0200, Jiří Župka wrote:
Access to undefined variable.
Applied, thanks!
Signed-off-by: Jiří Župka jzu...@redhat.com
---
client/virt/kvm_vm.py |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
Do you think the following case would not differ so much
from (1' 2') ?
walk_addr_generic() ---1''
copy_from_user() ---2''
Yes it should be the same and is cleaner.
If you do a make .../foo.i and look at the code coming out of the
preprocessor you'll see it
On Fri, 2011-04-29 at 12:22 +0200, Ingo Molnar wrote:
If that is so then indeed the right approach might be to signal the guest
every
time we manage to readv() something - there might not come any other packet
for
a long time. But the reason is not some 'erroneous state' - all state is
On Fri, Apr 29, 2011 at 1:32 PM, Ingo Molnar mi...@elte.hu wrote:
Without the mutex around the kvm__irq_line, I am still seeing the
hangs(with the irq assertion movement patch).
since the mutex has no effect on the other party that modifies the virtual
queue (the guest OS), this at best only
On Fri, Apr 29, 2011 at 01:39:04AM -0700, Paul E. McKenney wrote:
On Fri, Apr 29, 2011 at 01:36:18AM -0700, Paul E. McKenney wrote:
On Thu, Apr 28, 2011 at 12:52:02PM +0300, Gleb Natapov wrote:
Hmmm This is interesting. KVM being a module, we either expand
TINY_RCU's size a bit by
On 04/29/2011 01:40 AM, Joerg Roedel wrote:
On Thu, Apr 28, 2011 at 08:00:57PM -0700, Zachary Amsden wrote:
On 04/28/2011 01:20 PM, Joerg Roedel wrote:
This code checks how many guest tsc cycles have passed since this vCPU
was de-scheduled last time (and before it is running
On Fri, Apr 29, 2011 at 09:02:39PM +0300, Gleb Natapov wrote:
On Fri, Apr 29, 2011 at 01:39:04AM -0700, Paul E. McKenney wrote:
On Fri, Apr 29, 2011 at 01:36:18AM -0700, Paul E. McKenney wrote:
On Thu, Apr 28, 2011 at 12:52:02PM +0300, Gleb Natapov wrote:
Hmmm This is
On 4/29/11, Emmanuel Noobadmin centos.ad...@gmail.com wrote:
Only problem is... networking still isn't working although brctl show
on the host shows that a vnet0 had been created and attached to the
bridge. Any pointers would be appreciated!
Just to close off on this issue for the benefit of
* Pekka Enberg penb...@kernel.org wrote:
On Fri, Apr 29, 2011 at 1:32 PM, Ingo Molnar mi...@elte.hu wrote:
Without the mutex around the kvm__irq_line, I am still seeing the
hangs(with the irq assertion movement patch).
since the mutex has no effect on the other party that modifies the
On 04/20/2011 03:33 AM, Jason Wang wrote:
This patch adds the multiqueues support for emulated nics. Each VLANClientState
pairs are now abstract as a queue instead of a nic, and multiple VLANClientState
pointers were stored in the NICState and treated as the multiple queues of a
single nic. The
On 04/20/2011 10:33 PM, Jason Wang wrote:
Krishna Kumar2 writes:
Thanks Jason!
So I can use my virtio-net guest driver and test with this patch?
Please provide the script you use to start MQ guest.
Yes and thanks. Following is a simple script may help you start macvtap mq
* Sasha Levin levinsasha...@gmail.com wrote:
On Fri, 2011-04-29 at 12:22 +0200, Ingo Molnar wrote:
If that is so then indeed the right approach might be to signal the guest
every
time we manage to readv() something - there might not come any other packet
for
a long time. But the
On Fri, 2011-04-29 at 11:05 +0200, Jan Kiszka wrote:
Ensure that accesses exceeding PCI_CAPABILITY_LIST and
PCI_INTERRUPT_LINE+PIN hit the real device in areas we do not
virtualize. Again, we do not optimize these checks and accesses a lot,
they are considered to be slow paths.
On Fri, Apr 29, 2011 at 12:45 PM, Ulrich Obergfell uober...@redhat.com wrote:
On 2011-04-28 20:51, Blue Swirl wrote:
On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell wrote:
'target_get_irq_delivered' and 'target_reset_irq_delivered' contain
entry addresses of functions that are utilized by
On Thu, 28 Apr 2011 11:35:20 +0800
Lai Jiangshan la...@cn.fujitsu.com wrote:
Adds new QERR_UNSUPPORTED, converts nmi to inject-nmi and
make it supports qmp.
Lai, unfortunately this series still have some issues (like changing
the HMP command name). I think V7 was the best submission so
--- a/arch/powerpc/kvm/book3s_emulate.c
+++ b/arch/powerpc/kvm/book3s_emulate.c
@@ -88,6 +88,23 @@ int kvmppc_core_emulate_op(struct kvm_run *run,
struct kvm_vcpu *vcpu,
case OP_31_XOP_MFMSR:
kvmppc_set_gpr(vcpu, get_rt(inst),
65 matches
Mail list logo
