Re: [PATCH v2 5/7] KVM-GST: KVM Steal time accounting

2011-06-19 Thread Avi Kivity
On 06/20/2011 05:38 AM, Glauber Costa wrote: On 06/19/2011 07:04 AM, Avi Kivity wrote: On 06/17/2011 01:20 AM, Glauber Costa wrote: This patch accounts steal time time in kernel/sched. I kept it from last proposal, because I still see advantages in it: Doing it here will give us easier access f

Re: [PATCH v2 3/7] KVM-HV: KVM Steal time implementation

2011-06-19 Thread Avi Kivity
On 06/20/2011 05:53 AM, Glauber Costa wrote: +static void record_steal_time(struct kvm_vcpu *vcpu) +{ + u64 delta; + + if (vcpu->arch.st.stime&& vcpu->arch.st.this_time_out) { 0 is a valid value for stime. how exactly? stime is a guest physical address... 0 is a valid physical address.

buildbot failure in kvm on next-s390

2011-06-19 Thread kvm
The Buildbot has detected a new failure on builder next-s390 while building kvm. Full details are available at: http://buildbot.b1-systems.de/kvm/builders/next-s390/builds/205 Buildbot URL: http://buildbot.b1-systems.de/kvm/ Buildslave for this Build: b1_kvm_1 Build Reason: The Nightly schedule

buildbot failure in kvm on s390

2011-06-19 Thread kvm
The Buildbot has detected a new failure on builder s390 while building kvm. Full details are available at: http://buildbot.b1-systems.de/kvm/builders/s390/builds/214 Buildbot URL: http://buildbot.b1-systems.de/kvm/ Buildslave for this Build: b1_kvm_1 Build Reason: The Nightly scheduler named 'n

Re: [PATCH v2 2/7] KVM-HDR: KVM Steal time implementation

2011-06-19 Thread Glauber Costa
On 06/19/2011 06:49 AM, Avi Kivity wrote: On 06/17/2011 01:20 AM, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM. This is per-vcpu, and using the kvmclock structure for that i

Re: [PATCH v2 3/7] KVM-HV: KVM Steal time implementation

2011-06-19 Thread Glauber Costa
On 06/19/2011 06:57 AM, Avi Kivity wrote: On 06/17/2011 01:20 AM, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM. This is per-vcpu, and using the kvmclock structure for that i

Re: [PATCH v2 5/7] KVM-GST: KVM Steal time accounting

2011-06-19 Thread Glauber Costa
On 06/19/2011 07:04 AM, Avi Kivity wrote: On 06/17/2011 01:20 AM, Glauber Costa wrote: This patch accounts steal time time in kernel/sched. I kept it from last proposal, because I still see advantages in it: Doing it here will give us easier access from scheduler variables such as the cpu rq. Th

[GIT PULL] KVM updates for Linux 3.0-rc3

2011-06-19 Thread Avi Kivity
Linus, please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-updates/3.0 to receive several (fairly serious) KVM fixes: kvmclock was broken due to bad asm constraints, live migration & vga tracking instantiated large ptes instead of small ones, and the guest cr3 was corrupted in

[PATCH kvm-unit-tests] emulator: test rip-relative insn with immediate operand

2011-06-19 Thread Avi Kivity
kvm has a bug with instructions of the form opcode $imm, displ(%%rip) Where the effective address was not calculated correctly. Test it now. Signed-off-by: Avi Kivity --- x86/emulator.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/x86/emulator.c

[PATCH] KVM: x86 emulator: fix %rip-relative addressing with immediate source operand

2011-06-19 Thread Avi Kivity
%rip-relative addressing is relative to the first byte of the next instruction, so we need to add %rip only after we've fetched any immediate bytes. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/x86/k

[Bug 37732] intel-kvm/ksmd gp fault after some page scan changes in /sys/kernel/mm/ksm/

2011-06-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=37732 --- Comment #4 from Avi Kivity 2011-06-19 14:37:24 --- Please reconfigure using SLUB and run the tests. We don't suspect SLUB; rather we want to use its debug capabilities. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?t

[Bug 37732] intel-kvm/ksmd gp fault after some page scan changes in /sys/kernel/mm/ksm/

2011-06-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=37732 --- Comment #3 from Konstantin 2011-06-19 14:11:46 --- (In reply to comment #2) This machine is using SLAB not SLUB. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: ---

Re: [RFC] virtio: Support releasing lock during kick

2011-06-19 Thread Christoph Hellwig
On Sun, Jun 19, 2011 at 10:48:41AM +0300, Michael S. Tsirkin wrote: > diff --git a/block/blk-core.c b/block/blk-core.c > index 4ce953f..a8672ec 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -433,6 +433,8 @@ void blk_run_queue(struct request_queue *q) > spin_lock_irqsave(q->que

Re: [PULL] PPC KVM patch queue 2011-06-19

2011-06-19 Thread Avi Kivity
On 06/19/2011 04:42 PM, Alexander Graf wrote: Hi Avi, here's the updated pull request. Alex The following changes since commit a94925fed08e72213eabf611744b12af3e832218: Yang, Wei (1): KVM: Enable ERMS feature support for KVM are available in the git repository at: git://githu

sharing a folder from a guest running windows XP

2011-06-19 Thread Mansour Al Akeel
Hello all, I am not sure if this is the right place to ask this question. I have been trying to get this working for the last few days. I need to mount a directory from the guest under the host. The guest is win XP and the host is linux gentoo. I tried to follow this steps: http://en.wikibooks.org

[Bug 37732] intel-kvm/ksmd gp fault after some page scan changes in /sys/kernel/mm/ksm/

2011-06-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=37732 --- Comment #2 from Konstantin 2011-06-19 13:44:05 --- RAX should contain 8804530057f8 right? If so then i understand the gp fault here :-) ... a bit Yes i use netfilter to forward traffic to and from vm's. Is it possible that the RCU

[PULL] PPC KVM patch queue 2011-06-19

2011-06-19 Thread Alexander Graf
Hi Avi, here's the updated pull request. Alex The following changes since commit a94925fed08e72213eabf611744b12af3e832218: Yang, Wei (1): KVM: Enable ERMS feature support for KVM are available in the git repository at: git://github.com/agraf/linux-2.6.git kvm-ppc-next Alexander G

Re: [PATCH] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK

2011-06-19 Thread Avi Kivity
On 06/09/2011 06:57 PM, Paolo Bonzini wrote: -- 8< - From Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Thu, 9 Jun 2011 17:48:50 +0200 Subject: [PATCH] KVM: fix documentation for KVM_SET_SIGNAL_MAS

Re: [PATCH] KVM: Fix XSAVE feature bit enumeration

2011-06-19 Thread Avi Kivity
On 06/10/2011 04:56 PM, Andre Przywara wrote: When iterating through the XSAVE feature enumeration CPUID leaf (0xD) we should not stop at the first zero EAX, but instead keep scanning since there are gaps in the enumeration (ECX=1 for instance). This fixes the proper usage of AVX in KVM guests.

Re: [PATCH 3/7] KVM-HV: KVM Steal time implementation

2011-06-19 Thread Avi Kivity
On 06/19/2011 03:59 PM, Gleb Natapov wrote: On Sun, Jun 19, 2011 at 03:35:58PM +0300, Avi Kivity wrote: > On 06/15/2011 12:09 PM, Gleb Natapov wrote: > >> > >> Actually, I'd expect most read/writes to benefit from caching, no? > >> So why don't we just rename kvm_write_guest_cached() to >

Re: [PATCH 03/15] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK

2011-06-19 Thread Avi Kivity
On 06/19/2011 03:53 PM, Alexander Graf wrote: On 19.06.2011, at 11:04, Avi Kivity wrote: > On 06/17/2011 05:49 PM, Alexander Graf wrote: >> KVM has an ioctl to define which signal mask should be used while running >> inside VCPU_RUN. At least for big endian systems, this mask is different >>

Re: [PATCH 3/7] KVM-HV: KVM Steal time implementation

2011-06-19 Thread Gleb Natapov
On Sun, Jun 19, 2011 at 03:35:58PM +0300, Avi Kivity wrote: > On 06/15/2011 12:09 PM, Gleb Natapov wrote: > >> > >> Actually, I'd expect most read/writes to benefit from caching, no? > >> So why don't we just rename kvm_write_guest_cached() to > >> kvm_write_guest(), and the few places - if any

Re: [PATCH v2][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-19 Thread Avi Kivity
On 06/15/2011 04:17 PM, Jan Kiszka wrote: These FPU states are properly maintained by KVM but not yet by TCG. So far we unconditionally set them to 0 in the guest which may cause state corruptions, though not with modern guests. To avoid breaking backward migration, use a conditional subsection

Re: [PATCH 03/15] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK

2011-06-19 Thread Alexander Graf
On 19.06.2011, at 11:04, Avi Kivity wrote: > On 06/17/2011 05:49 PM, Alexander Graf wrote: >> KVM has an ioctl to define which signal mask should be used while running >> inside VCPU_RUN. At least for big endian systems, this mask is different >> on 32-bit and 64-bit systems (though the size is i

Re: [PATCH] support piix PAM registers in KVM

2011-06-19 Thread Avi Kivity
On 06/15/2011 06:27 PM, Jason Krieg wrote: On 06/15/2011 05:19 PM, Avi Kivity wrote: On 06/15/2011 06:16 PM, Jason Krieg wrote: On 06/15/2011 03:59 PM, Avi Kivity wrote: On 06/15/2011 04:57 PM, Avi Kivity wrote: Any ideas for what I could look for ? Try -no-tpr-opt (on both sides). T

Re: [PATCH x86 kvm] Fix register corruption in pvclock_scale_delta

2011-06-19 Thread Avi Kivity
On 06/16/2011 06:50 AM, Zachary Amsden wrote: The 128-bit multiply in pvclock.h was missing an output constraint for EDX which caused a register corruption to appear. Thanks to Ulrich for diagnosing the EDX corruption and Avi for providing this fix (which now I am sending back to you Avi..)

Re: [PATCH 3/7] KVM-HV: KVM Steal time implementation

2011-06-19 Thread Avi Kivity
On 06/15/2011 12:09 PM, Gleb Natapov wrote: > > Actually, I'd expect most read/writes to benefit from caching, no? > So why don't we just rename kvm_write_guest_cached() to > kvm_write_guest(), and the few places - if any - that need to force > transversing of the gfn mappings, get renamed to

Re: Why doesn't Intel e1000 NIC work correctly in Windows XP?

2011-06-19 Thread Flypen CloudMe
Hi, Here are the command line: /usr/bin/qemu-kvm -S -M rhel6.0.0 -enable-kvm -m 2048 -smp 2,sockets=1,cores=2,threads=1 \ -name winxp -uuid 23cd2751-8a30-dd34-db47-bfc8c76ccadb -nodefconfig -nodefaults \ -chardev socket,id=monitor,path=/var/lib/libvirt/qemu/winxp.monitor,server,nowait -mon chard

[Bug 37732] intel-kvm/ksmd gp fault after some page scan changes in /sys/kernel/mm/ksm/

2011-06-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=37732 Avi Kivity changed: What|Removed |Added CC||a...@redhat.com --- Comment #1 from Avi

Email Valid?

2011-06-19 Thread Michelle Miller
Please let me know if this email is valid as I would like to discuss a very important issue with you. Contact my email asap: mchick...@hotmail.co.uk Respectfully, Micheal Majeed -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.k

Re: wrong placement of RIP-relative address computing

2011-06-19 Thread Avi Kivity
On 06/16/2011 02:00 PM, Li, Xin wrote: > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 6df88c7..e269d20 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -3547,9 +3547,6 @@ done_prefixes: > if (memop.type == OP_MEM&& c->ad_bytes != 8)

Re: [PATCH 1/2] qemu-x86: Add tsc_khz option to -cpu

2011-06-19 Thread Avi Kivity
On 06/17/2011 05:00 PM, Joerg Roedel wrote: To let the user configure the desired tsc frequency for the guest if running in KVM. @@ -704,6 +705,14 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_def, const char *cpu_model) } else if (!strcmp(featurestr, "model_id")) {

RFT: virtio_net: limit xmit polling

2011-06-19 Thread Michael S. Tsirkin
OK, different people seem to test different trees. In the hope to get everyone on the same page, I created several variants of this patch so they can be compared. Whoever's interested, please check out the following, and tell me how these compare: kernel: git://git.kernel.org/pub/scm/linux/kerne

[PATCH 1/2] tools/kvm/9p: Make the 9p handler void return

2011-06-19 Thread Aneesh Kumar K.V
Error is reported via RERROR message. Signed-off-by: Aneesh Kumar K.V --- tools/kvm/virtio/9p.c | 54 1 files changed, 27 insertions(+), 27 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c index 0e885b5..8067e8a 100644 --

[PATCH 2/2] tools/kvm/9p: Add error handling

2011-06-19 Thread Aneesh Kumar K.V
return error via RERROR message Signed-off-by: Aneesh Kumar K.V --- tools/kvm/virtio/9p.c | 23 --- 1 files changed, 16 insertions(+), 7 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c index 8067e8a..453b34b 100644 --- a/tools/kvm/virtio/9p.c +++ b/

Re: [PATCH v2 6/7] KVM-GST: adjust scheduler cpu power

2011-06-19 Thread Avi Kivity
On 06/17/2011 01:20 AM, Glauber Costa wrote: This is a first proposal for using steal time information to influence the scheduler. There are a lot of optimizations and fine grained adjustments to be done, but it is working reasonably so far for me (mostly) With this patch (and some host pinnings

Re: [PATCH v2 5/7] KVM-GST: KVM Steal time accounting

2011-06-19 Thread Avi Kivity
On 06/17/2011 01:20 AM, Glauber Costa wrote: This patch accounts steal time time in kernel/sched. I kept it from last proposal, because I still see advantages in it: Doing it here will give us easier access from scheduler variables such as the cpu rq. The next patch shows an example of usage for

Re: [PATCH v2 3/7] KVM-HV: KVM Steal time implementation

2011-06-19 Thread Avi Kivity
On 06/17/2011 01:20 AM, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM. This is per-vcpu, and using the kvmclock structure for that is an abuse we decided not to make. In this

Re: [PATCH v2 2/7] KVM-HDR: KVM Steal time implementation

2011-06-19 Thread Avi Kivity
On 06/17/2011 01:20 AM, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM. This is per-vcpu, and using the kvmclock structure for that is an abuse we decided not to make. In this

[PATCH] tools/kvm/9p: check the iov count with the read/write count

2011-06-19 Thread Aneesh Kumar K.V
Make sure we don't read/write more than what is requested from client. Signed-off-by: Aneesh Kumar K.V --- I am not sure whether we really need this. But seems to be a good check to make sure we don't read/write more tools/kvm/virtio/9p.c | 21 + 1 files changed, 21 insert

[PATCH -V2] tools/kvm/9p: Use the same #define as the kernel

2011-06-19 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- v2: Add proper indentation in #define tools/kvm/virtio/9p.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c index 1545995..5baa774 100644 --- a/tools/kvm/virtio/9p.c +++ b/tools/kvm/

Re: [PATCH 3/5] tools/kvm/9p: Don't follow symlink on server

2011-06-19 Thread Aneesh Kumar K.V
On Sun, 19 Jun 2011 10:47:33 +0530, "Aneesh Kumar K.V" wrote: > On Sat, 18 Jun 2011 14:51:13 -0400, Sasha Levin > wrote: > > On Sat, 2011-06-18 at 23:19 +0530, Aneesh Kumar K.V wrote: > > > Use lstat instead of stat > > > > This patch should probably come after 9p2000.u support is added, since

Re: [PULL 00/15] PPC KVM patch queue 2011-06-15

2011-06-19 Thread Avi Kivity
On 06/17/2011 05:49 PM, Alexander Graf wrote: Hi Avi/Marcelo, This is my current patch queue for PPC KVM. Please apply. It's all good except for patch 3 which is duplicate. Can you drop it and re-post the pull URL? I could apply all ^ 3 but prefer to pull. -- error compiling committee.c:

[PATCH] tools/kvm/9p: Add error protocol reply

2011-06-19 Thread Aneesh Kumar K.V
Add RERROR and use that in open on failure NOTE: All the protocol operation should handle like this. Signed-off-by: Aneesh Kumar K.V --- tools/kvm/virtio/9p.c | 37 ++--- 1 files changed, 30 insertions(+), 7 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/to

Re: Unable to unload kvm-intel module

2011-06-19 Thread Jan Kiszka
On 2011-06-17 20:04, AP wrote: > I tired that and it did not give me any warning. Here is the compilation > output: > > make -C /lib/modules/2.6.38-8-generic/build M=`pwd` \ > LINUXINCLUDE="-I`pwd`/include -Iinclude \ >-Iarch/x86/include \ >

Re: [PATCH 03/15] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK

2011-06-19 Thread Avi Kivity
On 06/17/2011 05:49 PM, Alexander Graf wrote: KVM has an ioctl to define which signal mask should be used while running inside VCPU_RUN. At least for big endian systems, this mask is different on 32-bit and 64-bit systems (though the size is identical). Add a compat wrapper that converts the mas

Re: [PATCH 0/5] perf support for amd guest/host-only bits v2

2011-06-19 Thread Avi Kivity
On 06/17/2011 04:37 PM, Joerg Roedel wrote: Hi, this is the second version of the patch-set to support the AMD guest-/host only bits in the performance counter MSRs. Due to lack of time I havn't looked into emulating support for this feature on Intel or other architectures, but the other comment

Re: current qemu-kvm doesn't work with vhost

2011-06-19 Thread Jan Kiszka
On 2011-06-17 22:31, Georg Hopp wrote: > Am 17.06.2011 09:29:41 schrieb(en) Jan Kiszka: >> On 2011-06-17 09:10, Georg Hopp wrote: >> > Jan Kiszka web.de> writes: >> >> >> >> On 2011-06-10 05:08, Amos Kong wrote: >> >>> host kernel: 2.6.39-rc2+ >> >>> qemu-kvm : 05f1737582ab6c075476bde931c5eafbc62a

Re: Biweekly KVM Test report, kernel 681fb677... qemu 05f17375...

2011-06-19 Thread Avi Kivity
On 06/18/2011 07:43 AM, Ren, Yongjie wrote: Hi All, This is KVM test result against kvm.git 681fb677ace0754589792c92b8dbee9884d07158 based on kernel 3.0.0-rc2+, and qemu-kvm.git 05f1737582ab6c075476bde931c5eafbc62a9349. We found a new vt-d bug about “NIC assignment order in command line makes

Re: current qemu-kvm doesn't work with vhost

2011-06-19 Thread Avi Kivity
On 06/10/2011 09:12 AM, Jan Kiszka wrote: From: Jan Kiszka qemu-kvm: Fix error path of virtio_pci_set_guest_notifiers The mask notifier is never installed on error, so this deinstallation will just trigger an assert in msix_unset_mask_notifier. Applied, thanks. -- error compiling committee.c:

Re: [PATCHv2 RFC 0/4] virtio and vhost-net capacity handling

2011-06-19 Thread Michael S. Tsirkin
On Mon, Jun 13, 2011 at 07:02:27PM +0530, Krishna Kumar2 wrote: > "Michael S. Tsirkin" wrote on 06/07/2011 09:38:30 PM: > > > > This is on top of the patches applied by Rusty. > > > > > > Warning: untested. Posting now to give people chance to > > > comment on the API. > > > > OK, this seems to h

[Bug 37262] VNC access to KVM VM is unusable

2011-06-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=37262 --- Comment #46 from Avi Kivity 2011-06-19 08:50:13 --- On 06/17/2011 05:25 AM, Xiao Guangrong wrote: > From: Steve > Subject: [PATCH] KVM: MMU: fix opposite condition in > mapping_level_dirty_bitmap > > The condition is opposite, it always

Re: [Bug 37262] VNC access to KVM VM is unusable

2011-06-19 Thread Avi Kivity
On 06/17/2011 05:25 AM, Xiao Guangrong wrote: From: Steve Subject: [PATCH] KVM: MMU: fix opposite condition in mapping_level_dirty_bitmap The condition is opposite, it always maps huge page for the dirty tracked page Thanks, applied and queued. -- error compiling committee.c: too many argume

Re: [ANNOUNCE] Native Linux KVM tool v2

2011-06-19 Thread Michael S. Tsirkin
On Thu, Jun 16, 2011 at 11:01:22PM +0800, Asias He wrote: > On 06/16/2011 10:28 PM, Michael S. Tsirkin wrote: > > On Wed, Jun 15, 2011 at 06:53:34PM +0300, Pekka Enberg wrote: > >> Hi all, > >> > >> We’re proud to announce the second version of the Native Linux KVM tool! > >> We’re > >> now offici

Re: [RFC] virtio: Support releasing lock during kick

2011-06-19 Thread Michael S. Tsirkin
On Wed, Jun 23, 2010 at 10:24:02PM +0100, Stefan Hajnoczi wrote: > The virtio block device holds a lock during I/O request processing. > Kicking the virtqueue while the lock is held results in long lock hold > times and increases contention for the lock. As you point out the problem with dropping

Re: [RFC] virtio: Support releasing lock during kick

2011-06-19 Thread Michael S. Tsirkin
On Wed, Jun 23, 2010 at 10:24:02PM +0100, Stefan Hajnoczi wrote: > The virtio block device holds a lock during I/O request processing. > Kicking the virtqueue while the lock is held results in long lock hold > times and increases contention for the lock. > > This patch modifies virtqueue_kick() to