Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-05 Thread Markus Armbruster
Typo in subject: unsed. The warning is spelled unused-but-set-variable, the option -Wunused-but-set-variable. Raghavendra D Prabhu raghu.prabh...@gmail.com writes: In a few cases, variable attributed 'unused' has been added, in other cases unused variable has been either removed or commented

RE: [PATCH 2/2] vmx,svm: Print errors if SVM or VMX were already set

2011-07-05 Thread Tian, Kevin
From: Sasha Levin Sent: Tuesday, July 05, 2011 7:09 AM Instead of exiting quietly, print an error if the VMX or the SVM bits were already set when loading the module. Having VMX/SVM bits set means that either there is someone else doing hardware virtualization, or that the BIOS is buggy

RE: [PATCH 2/2] vmx,svm: Print errors if SVM or VMX were already set

2011-07-05 Thread Tian, Kevin
From: Alexander Graf Sent: Tuesday, July 05, 2011 8:42 AM On 05.07.2011, at 01:09, Sasha Levin wrote: Instead of exiting quietly, print an error if the VMX or the SVM bits were already set when loading the module. Having VMX/SVM bits set means that either there is someone else

building kvm-kmod 2.6.39 on debian squeeze fails

2011-07-05 Thread Thomas Mueller
hi kvm-kmod-2.6.39 fails to build on debian squeeze (debian kernel 2.6.32). error messages: In file included from /usr/src/kvm-kmod-2.6.39/x86/x86.c:93: /lib/modules/2.6.32-5-amd64/source/arch/x86/include/asm/pvclock.h:19: error: redefinition of ‘pvclock_scale_delta’

Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-05 Thread Peter Maydell
On 5 July 2011 07:15, Markus Armbruster arm...@redhat.com wrote: +    int fd, __attribute__((unused)) ret;      snprintf(reset_file, sizeof(reset_file),               /sys/bus/pci/devices/%04x:%02x:%02x.%01x/reset, What about (void)write() and do away with ret? If 'ret' has been used to

Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-05 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 5 July 2011 07:15, Markus Armbruster arm...@redhat.com wrote: +    int fd, __attribute__((unused)) ret;      snprintf(reset_file, sizeof(reset_file),               /sys/bus/pci/devices/%04x:%02x:%02x.%01x/reset, What about (void)write() and

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Dor Laor
I tried to re-arrange all of the requirements and use cases using this wiki page: http://wiki.qemu.org/Features/LiveBlockMigration It would be the best to agree upon the most interesting use cases (while we make sure we cover future ones) and agree to them. The next step is to set the

Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 09:49 AM, Markus Armbruster wrote: If 'ret' has been used to silence compiler warnings about functions which have been declared with attribute __warn_unused_result__ (eg write() and various other libc functions) then (void)write() is insufficient -- gcc requires the

Re: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check

2011-07-05 Thread Avi Kivity
On 07/05/2011 02:09 AM, Sasha Levin wrote: Add a module parameter 'check_inuse' to allow disabling the check of whether virtualization has already been enabled on the given cpu. This is needed to deal with broken BIOS which set the SVM/VMX bit by default. Please split the vmx and svm parts.

Re: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check

2011-07-05 Thread Sasha Levin
On Tue, 2011-07-05 at 11:09 +0300, Avi Kivity wrote: On 07/05/2011 02:09 AM, Sasha Levin wrote: Add a module parameter 'check_inuse' to allow disabling the check of whether virtualization has already been enabled on the given cpu. This is needed to deal with broken BIOS which set the

[PATCH kvm-unit-tests v3] Check SMEP when cr0.wp=0

2011-07-05 Thread Yang, Wei
This patch adds SMEP to all test cases and checks SMEP when cr0.wp=0. changes since v2: Recover U/S bit after turning off SMEP and correct the title changes since v1: Add SMEP to all test cases and verify it before setting cr4 Signed-off-by: Yang, Wei wei.y.y...@intel.com

Re: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check

2011-07-05 Thread Joerg Roedel
On Tue, Jul 05, 2011 at 11:14:43AM +0300, Sasha Levin wrote: I have no information about the machine. It was the result of trying to debug an issue reported on IRC where we found that the SVM flag is being set after boot even before the kvm module is loaded. Have you ruled out that any other

Re: [PATCH v5 7/9] KVM-GST: KVM Steal time accounting

2011-07-05 Thread Peter Zijlstra
On Mon, 2011-07-04 at 11:32 -0400, Glauber Costa wrote: This patch accounts steal time time in account_process_tick. If one or more tick is considered stolen in the current accounting cycle, user/system accounting is skipped. Idle is fine, since the hypervisor does not report steal time if the

Re: [PATCH v5 8/9] KVM-GST: adjust scheduler cpu power

2011-07-05 Thread Peter Zijlstra
On Mon, 2011-07-04 at 11:32 -0400, Glauber Costa wrote: This patch makes update_rq_clock() aware of steal time. The mechanism of operation is not different from irq_time, and follows the same principles. This lives in a CONFIG option itself, and can be compiled out independently of the rest

Re: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check

2011-07-05 Thread Sasha Levin
On Tue, 2011-07-05 at 11:11 +0200, Joerg Roedel wrote: On Tue, Jul 05, 2011 at 11:14:43AM +0300, Sasha Levin wrote: I have no information about the machine. It was the result of trying to debug an issue reported on IRC where we found that the SVM flag is being set after boot even before

Re: [Qemu-devel] [PATCH 2/3] Add fno-strict-overflow

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 6:41 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jul 4, 2011 at 11:38 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 4 July 2011 23:00, Raghavendra D Prabhu raghu.prabh...@gmail.com wrote: This is to avoid gcc optimizating out the comparison in assert,

[PATCH 1/2] kvm tools: Export kvm__remove_pidfile

2011-07-05 Thread Sasha Levin
This will allow cleaning up ghost pid files outside of the module. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/include/kvm/kvm.h |1 + tools/kvm/kvm.c |9 +++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tools/kvm/include/kvm/kvm.h

[PATCH 2/2] kvm tools: Clean ghost pid files in 'kvm list'

2011-07-05 Thread Sasha Levin
When running 'kvm list', first make sure that the guest process is up and running before printing the entry. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/kvm-list.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check

2011-07-05 Thread Avi Kivity
On 07/05/2011 12:32 PM, Sasha Levin wrote: On Tue, 2011-07-05 at 11:11 +0200, Joerg Roedel wrote: On Tue, Jul 05, 2011 at 11:14:43AM +0300, Sasha Levin wrote: I have no information about the machine. It was the result of trying to debug an issue reported on IRC where we found that the

PowerPoint performance degrade greatly when logon on through rdesktop to winxp, and when lotus notes is running.

2011-07-05 Thread ya su
I am using qemu-kvm, cli as the following: qemu-system-x86_64 -drive file=test-notes.img,if=virtio,cache=none,boot=on -net nic,macaddr=00:00:00:11:22:88,model=virtio -net tap -m 1024 -vnc :3 I open powerpoint 2007, and drag a rectangel, it moves very slowly. it must meet the following

Re: PowerPoint performance degrade greatly when logon on through rdesktop to winxp, and when lotus notes is running.

2011-07-05 Thread Avi Kivity
On 07/05/2011 12:40 PM, ya su wrote: I am using qemu-kvm, cli as the following: qemu-system-x86_64 -drive file=test-notes.img,if=virtio,cache=none,boot=on -net nic,macaddr=00:00:00:11:22:88,model=virtio -net tap -m 1024 -vnc :3 I open powerpoint 2007, and drag a rectangel, it moves

Re: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check

2011-07-05 Thread Sasha Levin
On Tue, 2011-07-05 at 12:37 +0300, Avi Kivity wrote: On 07/05/2011 12:32 PM, Sasha Levin wrote: On Tue, 2011-07-05 at 11:11 +0200, Joerg Roedel wrote: On Tue, Jul 05, 2011 at 11:14:43AM +0300, Sasha Levin wrote: I have no information about the machine. It was the result of trying

Re: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check

2011-07-05 Thread Avi Kivity
On 07/05/2011 12:56 PM, Sasha Levin wrote: Please note that I don't have access to the hardware in question, this was done over IRC. I understand that. Can you get in contact with the reporter again? Here are the steps taken in debugging this issue: 1. Looking at the dmesg (

[PATCH 0/5][v6] Megasas HBA emulation

2011-07-05 Thread Hannes Reinecke
Hi all, as Alex Graf reminded me the driver needed some more bugfixing to be done. I've found some issues and also moved the megasas emulation over to the new trace infrastructure. Driver works for me now and a full installation of openSUSE-12.1 works perfectly. I've also included the fixes

[PATCH 1/5] iov: Update parameter usage in iov_(to|from)_buf()

2011-07-05 Thread Hannes Reinecke
iov_to_buf() has an 'offset' parameter, iov_from_buf() hasn't. This patch adds the missing parameter to iov_from_buf(). It also renames the 'offset' parameter to 'iov_off' to emphasize it's the offset into the iovec and not the buffer. Signed-off-by: Hannes Reinecke h...@suse.de Acked-by:

[PATCH 2/5] scsi: Add 'hba_private' to SCSIRequest

2011-07-05 Thread Hannes Reinecke
'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a driver-defined pointer 'hba_private'. This saves the lookup for driver handling several commands in parallel. 'tag' is still being kept for tracing purposes.

[PATCH 3/5] scsi-disk: Fixup debugging statement

2011-07-05 Thread Hannes Reinecke
A debugging statement wasn't converted to the new interface. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index c2a99fe..5804662 100644 --- a/hw/scsi-disk.c +++

[PATCH 4/5] scsi-disk: Mask out serial number EVPD

2011-07-05 Thread Hannes Reinecke
If the serial number is not set we should mask it out in the list of supported VPD pages and mark it as not supported. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/scsi-disk.c

Re: [PATCH 3/5] scsi-disk: Fixup debugging statement

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: A debugging statement wasn't converted to the new interface. Signed-off-by: Hannes Reineckeh...@suse.de --- hw/scsi-disk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index

Re: [PATCH 4/5] scsi-disk: Mask out serial number EVPD

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: If the serial number is not set we should mask it out in the list of supported VPD pages and mark it as not supported. Signed-off-by: Hannes Reineckeh...@suse.de --- hw/scsi-disk.c | 15 --- 1 files changed, 12 insertions(+), 3

Re: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check

2011-07-05 Thread Sasha Levin
On Tue, 2011-07-05 at 13:37 +0300, Avi Kivity wrote: On 07/05/2011 12:56 PM, Sasha Levin wrote: Please note that I don't have access to the hardware in question, this was done over IRC. I understand that. Can you get in contact with the reporter again? Hopefully, If he comes back on

Re: [PATCH 1/2] vmx,svm: Add module parameter to ignore the 'in use' check

2011-07-05 Thread Avi Kivity
On 07/05/2011 02:07 PM, Sasha Levin wrote: - was a BIOS update attempted? at least VMware uses the same check as kvm, and probably virtualbox as well, so this problem should have been seen before. We didn't update the BIOS. virtualbox was installed previously and didn't work properly

CPU assignment possiblities?

2011-07-05 Thread erik . rull
Hi all, I want to assign multiple host cores to a VM that are then exposed there as only one virtual processor core. I want to maximize there the available computation power and the guest OS cannot handle SMP. And: How can I enable qemu-kvm to run on multiple host cores? I have a i7 HT enabled

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 9:01 AM, Dor Laor dl...@redhat.com wrote: I tried to re-arrange all of the requirements and use cases using this wiki page: http://wiki.qemu.org/Features/LiveBlockMigration It would be the best to agree upon the most interesting use cases (while we make sure we cover

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Marcelo Tosatti
On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laor dl...@redhat.com wrote: I tried to re-arrange all of the requirements and use cases using this wiki page: http://wiki.qemu.org/Features/LiveBlockMigration It would be the best to

Re: [PATCH 0/5][v6] Megasas HBA emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: Hi all, as Alex Graf reminded me the driver needed some more bugfixing to be done. I've found some issues and also moved the megasas emulation over to the new trace infrastructure. Driver works for me now and a full installation of openSUSE-12.1

Re: [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. Nice, so it does work for me this time :). Tested-by: Alexander Graf ag...@suse.de Alex -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message

Re: [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. Signed-off-by: Hannes Reineckeh...@suse.de --- Makefile.objs |1 + default-configs/pci.mak |1 + hw/megasas.c| 1950

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Dor Laor
On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laordl...@redhat.com wrote: I tried to re-arrange all of the requirements and use cases using this wiki page:

Re: [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 03:38 PM, Alexander Graf wrote: +if (is_sgl64) { +iov_pa = ldq_phys(pa); +} else { +iov_pa = ldl_phys(pa); These load data from memory in target endianness. Are you sure that's what you want? I'd expect this to be defined as little

Re: PowerPoint performance degrade greatly when logon on through rdesktop to winxp, and when lotus notes is running.

2011-07-05 Thread ya su
the previous kvm-stat is produced base on current kvm-kmod git version, and pateched with xiaoguangrong's mmio page-fault, but it can not produce trace-cmd report for truncated trace.dat file. so I change back to kvm-kmod 2.6.32.27 release. then kvm-stat produce: kvm_exit

Re: [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 03:59 PM, Paolo Bonzini wrote: On 07/05/2011 03:38 PM, Alexander Graf wrote: +if (is_sgl64) { +iov_pa = ldq_phys(pa); +} else { +iov_pa = ldl_phys(pa); These load data from memory in target endianness. Are you sure that's what you want? I'd

Re: [PATCH 1/3] perf: add context field to perf_event

2011-07-05 Thread Will Deacon
Hi Frederic, On Mon, Jul 04, 2011 at 02:58:24PM +0100, Frederic Weisbecker wrote: On Wed, Jun 29, 2011 at 05:27:25PM +0100, Will Deacon wrote: Hi Frederic, Thanks for including me on CC. On Wed, Jun 29, 2011 at 05:08:45PM +0100, Frederic Weisbecker wrote: On Wed, Jun 29, 2011 at

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Marcelo Tosatti
On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laordl...@redhat.com wrote: I tried to re-arrange all of the requirements and use cases

Re: [PATCH 1/3] perf: add context field to perf_event

2011-07-05 Thread Frederic Weisbecker
On Tue, Jul 05, 2011 at 03:30:26PM +0100, Will Deacon wrote: Hi Frederic, On Mon, Jul 04, 2011 at 02:58:24PM +0100, Frederic Weisbecker wrote: On Wed, Jun 29, 2011 at 05:27:25PM +0100, Will Deacon wrote: Hi Frederic, Thanks for including me on CC. On Wed, Jun 29, 2011 at

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Kevin Wolf
Am 05.07.2011 16:32, schrieb Marcelo Tosatti: On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laordl...@redhat.com wrote: I tried to

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Dor Laor
On 07/05/2011 05:32 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laordl...@redhat.com wrote: I tried

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 12:03 PM, Hannes Reinecke h...@suse.de wrote: +static void megasas_unmap_sgl(struct megasas_cmd_t *cmd) +{ +    uint16_t flags = le16_to_cpu(cmd-frame-header.flags); +    int i, is_write = (flags MFI_FRAME_DIR_WRITE) ? 1 : 0; + +    for (i = 0; i

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Marcelo Tosatti
On Tue, Jul 05, 2011 at 06:04:34PM +0300, Dor Laor wrote: On 07/05/2011 05:32 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5,

Re: [Qemu-devel] [PATCH 2/3] Add fno-strict-overflow

2011-07-05 Thread Raghavendra D Prabhu
* On Mon, Jul 04, 2011 at 11:38:30PM +0100, Peter Maydell peter.mayd...@linaro.org wrote: On 4 July 2011 23:00, Raghavendra D Prabhu raghu.prabh...@gmail.com wrote: This is to avoid gcc optimizating out the comparison in assert, due to assumption of signed overflow being undefined by default

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 3:32 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor

Re: [Autotest] [PATCH 1/3] KVM-Test: kickstart script: Add pre-installation script for dumping anaconda log

2011-07-05 Thread Lucas Meneghel Rodrigues
On Tue, 2011-06-28 at 17:44 +0800, Qingtang Zhou wrote: Anaconda log will help us to analyse failure of installation. Hi Qingtang, I have verified the code, have a couple of comments on one of the patches. We have a problem though: I did test it in my laptop, with both the default atbr0 bridge

Re: [Autotest] [PATCH 2/3] KVM-Test: unattended_install.py: Get anaconda log and save it to log file

2011-07-05 Thread Lucas Meneghel Rodrigues
On Tue, 2011-06-28 at 17:45 +0800, Qingtang Zhou wrote: This patch will save guest's anaconda log to 'anaconda.log' in debug directory. Signed-off-by: Qingtang Zhou qz...@redhat.com --- client/tests/kvm/tests/unattended_install.py | 31 ++ 1 files changed, 31

[PATCH] KVM test: Add subtest smbios_table

2011-07-05 Thread Lucas Meneghel Rodrigues
From: pradeep psuri...@linux.vnet.ibm.com Check smbios table : 1) Boot a guest with smbios options 2) verify if host bios options have been emulated, that is, the vendor, date and version options returned by dmidecode are the same on host and on guest.

Re: [Autotest] [PATCH] KVM test: Add subtest smbios_table

2011-07-05 Thread Lucas Meneghel Rodrigues
On Tue, 2011-07-05 at 15:07 -0300, Lucas Meneghel Rodrigues wrote: From: pradeep psuri...@linux.vnet.ibm.com Check smbios table : 1) Boot a guest with smbios options 2) verify if host bios options have been emulated, that is, the vendor, date and version options

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Marcelo Tosatti
On Tue, Jul 05, 2011 at 04:37:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 3:32 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100,

Re: [PATCH v5 3/9] KVM-HDR: KVM Steal time implementation

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM. This is per-vcpu, and using the kvmclock structure for that is an abuse we decided not to make. In

Re: [PATCH v5 2/9] KVM-HDR Add constant to represent KVM MSRs enabled bit

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: This patch is simple, put in a different commit so it can be more easily shared between guest and hypervisor. It just defines a named constant to indicate the enable bit for KVM-specific MSRs. Signed-off-by: Glauber Costa glom...@redhat.com CC: Rik

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM, while the vcpu had meaningful work to do - halt time does not count. This information is acquired

Re: [PATCH v5 5/9] KVM-GST: Add a pv_ops stub for steal time

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: This patch adds a function pointer in one of the many paravirt_ops structs, to allow guests to register a steal time function. Besides a steal time function, we also declare two jump_labels. They will be used to allow the steal time code to be easily

Re: [PATCH v5 6/9] add jump labels for ia64 paravirt

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: Since in a later patch I intend to call jump labels inside CONFIG_PARAVIRT, IA64 would fail to compile if they are not provided. This patch provides those jump labels for the IA64 architecture. Signed-off-by: Glauber Costa glom...@redhat.com CC:

Re: [PATCH v5 7/9] KVM-GST: KVM Steal time accounting

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: This patch accounts steal time time in account_process_tick. If one or more tick is considered stolen in the current accounting cycle, user/system accounting is skipped. Idle is fine, since the hypervisor does not report steal time if the guest is

Re: [PATCH v5 8/9] KVM-GST: adjust scheduler cpu power

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: This patch makes update_rq_clock() aware of steal time. The mechanism of operation is not different from irq_time, and follows the same principles. This lives in a CONFIG option itself, and can be compiled out independently of the rest of steal time

Re: [PATCH v5 9/9] KVM-GST: KVM Steal time registration

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: This patch implements the kvm bits of the steal time infrastructure. The most important part of it, is the steal time clock. It is an continuous clock that shows the accumulated amount of steal time since vcpu creation. It is supposed to survive cpu

Re: [PATCH v5 1/9] introduce kvm_read_guest_cached

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: From: Gleb Natapov g...@redhat.com Introduce kvm_read_guest_cached() function in addition to write one we already have. [ by glauber: export function signature in kvm header ] Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Glauber

[PATCH] KVM test: A couple of fixes for unattended install

2011-07-05 Thread Lucas Meneghel Rodrigues
Fix a typo and verify if virtio_network_installer is actually set to something before trying to use it as a class attribute. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/tests/unattended_install.py |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 2/3] Add fno-strict-overflow

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 4:36 PM, Raghavendra D Prabhu raghu.prabh...@gmail.com wrote: * On Mon, Jul 04, 2011 at 11:38:30PM +0100, Peter Maydell peter.mayd...@linaro.org wrote: On 4 July 2011 23:00, Raghavendra D Prabhu raghu.prabh...@gmail.com wrote: This is to avoid gcc optimizating out the

[PATCH] KVM test: Don't restrict Windows guests on virtio_blk variant anymore

2011-07-05 Thread Lucas Meneghel Rodrigues
The original config was making harder to maintain custom config files with virtio drivers install enabled. So, rather than doing a whitelist of OSs, just make a not very strict blacklist, just to help users, and not block them. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com ---

Re: [PATCH v3 04/19] KVM: MMU: cache mmio info on page fault path

2011-07-05 Thread Marcelo Tosatti
On Thu, Jun 30, 2011 at 04:20:58PM +0800, Xiao Guangrong wrote: If the page fault is caused by mmio, we can cache the mmio info, later, we do not need to walk guest page table and quickly know it is a mmio fault while we emulate the mmio instruction Signed-off-by: Xiao Guangrong

Re: [PATCH v3 05/19] KVM: MMU: optimize to handle dirty bit

2011-07-05 Thread Marcelo Tosatti
On Thu, Jun 30, 2011 at 04:21:30PM +0800, Xiao Guangrong wrote: If dirty bit is not set, we can make the pte access read-only to avoid handing dirty bit everywhere Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com -static unsigned FNAME(gpte_access)(struct kvm_vcpu *vcpu,

[Bug 38672] KVM guest boot crashed

2011-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=38672 --- Comment #5 from Steve stefan.bo...@gmail.com 2011-07-05 23:00:47 --- I tested reported bug on more servers also with kernel 3.0.0-rc6+ - same result. git bisect result: 6506e4f995967b1a48cc34418c77b318df92ce35 is the first bad commit

[Bug 38672] KVM guest boot crashed

2011-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=38672 --- Comment #6 from Steve stefan.bo...@gmail.com 2011-07-05 23:44:45 --- Here is bug (xen-mapcache.c): void qemu_map_cache_init(void) { -mapcache-entry = qemu_mallocz(size); should be: mapcache-entry =

[Bug 38672] KVM guest boot crashed

2011-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=38672 --- Comment #7 from Steve stefan.bo...@gmail.com 2011-07-05 23:54:31 --- After applying above simple fix all tested guests started running correctly. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are

Re: [PATCH v3 04/19] KVM: MMU: cache mmio info on page fault path

2011-07-05 Thread Xiao Guangrong
On 07/06/2011 03:04 AM, Marcelo Tosatti wrote: return 0; /* mmio */ -if (is_error_pfn(pfn)) -return kvm_handle_bad_page(vcpu-kvm, walker.gfn, pfn); +if (is_error_pfn(pfn)) { +unsigned access = walker.pte_access; +bool dirty

Re: [PATCH v3 05/19] KVM: MMU: optimize to handle dirty bit

2011-07-05 Thread Xiao Guangrong
On 07/06/2011 03:27 AM, Marcelo Tosatti wrote: On Thu, Jun 30, 2011 at 04:21:30PM +0800, Xiao Guangrong wrote: If dirty bit is not set, we can make the pte access read-only to avoid handing dirty bit everywhere Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com -static unsigned

[PATCH] KVM test: Add new virtio-win.cfg.sample file

2011-07-05 Thread Lucas Meneghel Rodrigues
One of the problems with virtio drivers install is that the configuration needed to get it done was scattered around the pretty large tests_base.cfg.sample file. So, separate the relevant configuration from that file and create a file dedicated to be the central point of configuration for virtio

Re: [PATCH kvm-unit-tests v3] Check SMEP when cr0.wp=0

2011-07-05 Thread Xiao Guangrong
On 07/05/2011 05:00 PM, Yang, Wei wrote: This patch adds SMEP to all test cases and checks SMEP when cr0.wp=0. changes since v2: Recover U/S bit after turning off SMEP and correct the title changes since v1: Add SMEP to all test cases and verify it before setting cr4 Reviewed-by: Xiao

[PATCH kvm-unit-tests v4] Check SMEP when cr0.wp=0

2011-07-05 Thread Yang, Wei
This patch adds SMEP to all test cases and checks SMEP when cr0.wp=0. changes since v3: Add Reviewed-by changes since v2: Recover U/S bit after turning off SMEP and correct the title changes since v1: Add SMEP to all test cases and verify it before setting cr4

Re: [PATCH v2] staging: zcache: support multiple clients, prep for KVM and RAMster

2011-07-05 Thread Greg KH
On Fri, Jul 01, 2011 at 07:58:45PM +0300, Dan Carpenter wrote: On Fri, Jul 01, 2011 at 07:31:54AM -0700, Dan Magenheimer wrote: Off by one errors are kind of insidious. People cut and paste them and they spread. If someone adds a new list of chunks then there are now two examples that

Re: [PATCH v5 1/9] introduce kvm_read_guest_cached

2011-07-05 Thread Rik van Riel
On 07/04/2011 11:32 AM, Glauber Costa wrote: From: Gleb Natapovg...@redhat.com Introduce kvm_read_guest_cached() function in addition to write one we already have. [ by glauber: export function signature in kvm header ] Signed-off-by: Gleb Natapovg...@redhat.com Signed-off-by: Glauber

Re: [PATCH v5 2/9] KVM-HDR Add constant to represent KVM MSRs enabled bit

2011-07-05 Thread Rik van Riel
On 07/04/2011 11:32 AM, Glauber Costa wrote: This patch is simple, put in a different commit so it can be more easily shared between guest and hypervisor. It just defines a named constant to indicate the enable bit for KVM-specific MSRs. Signed-off-by: Glauber Costaglom...@redhat.com CC: Rik

Re: [PATCH v5 3/9] KVM-HDR: KVM Steal time implementation

2011-07-05 Thread Rik van Riel
On 07/04/2011 11:32 AM, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM. This is per-vcpu, and using the kvmclock structure for that is an abuse we decided not to make. In

KVM autotest tip of the week

2011-07-05 Thread Lucas Meneghel Rodrigues
Hi guys, On an effort to make KVM autotest better and more useful for our target users (KVM developers), we are expanding documentation and writing articles on how to get some commonly asked test jobs running (I plan on get this going at least for some weeks). So here is our first KVM autotest

Re: [PATCH] ioeventfd: Introduce KVM_IOEVENTFD_FLAG_PIPE

2011-07-05 Thread Sasha Levin
On Mon, 2011-07-04 at 17:59 +0300, Avi Kivity wrote: On 07/04/2011 05:52 PM, Sasha Levin wrote: I can't really see that as useful. eventfds destroy information; without datamatch, you have no idea what value was written. Even with datamatch, you have no idea how many times it was

[PATCH 1/5] ioeventfd: Remove natural sized length limitation

2011-07-05 Thread Sasha Levin
This patch removes the 8 byte length limit on ioeventfds. The consequences are that any write in the provided region which is contained entierly by the region and matches datamatch (if specified) will trigger an event. Cc: Avi Kivity a...@redhat.com Cc: Ingo Molnar mi...@elte.hu Cc: Marcelo

[PATCH 2/5] ioeventfd: Add helper functions for reading and writing

2011-07-05 Thread Sasha Levin
Add get_val() and set_val() to help getting and setting a natural sized variable pointed by a void ptr. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- virt/kvm/eventfd.c | 57 ++- 1 files changed, 42 insertions(+), 15 deletions(-) diff

[PATCH 3/5] ioeventfd: Introduce KVM_IOEVENTFD_FLAG_READ

2011-07-05 Thread Sasha Levin
The new flag specifies whether reads from the address specified in the ioeventfd will raise the event like writes do. The read value will be the one passed in datamatch. Cc: Avi Kivity a...@redhat.com Cc: Ingo Molnar mi...@elte.hu Cc: Marcelo Tosatti mtosa...@redhat.com Cc: Michael S. Tsirkin

[PATCH 4/5] ioeventfd: Introduce KVM_IOEVENTFD_FLAG_NOWRITE

2011-07-05 Thread Sasha Levin
The new flag specifies whether writes to the address specified in the ioeventfd shouldn't raise the event. Cc: Avi Kivity a...@redhat.com Cc: Ingo Molnar mi...@elte.hu Cc: Marcelo Tosatti mtosa...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Pekka Enberg penb...@kernel.org Signed-off-by:

[PATCH 5/5] ioeventfd: Introduce KVM_IOEVENTFD_FLAG_SOCKET

2011-07-05 Thread Sasha Levin
The new flag allows passing a connected socket instead of an eventfd to be notified of writes or reads to the specified memory region. Instead of signaling an event, On write - the value written to the memory region is written to the pipe. On read - a notification of the read is sent to the host,