Re: [PATCH 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Pekka Enberg
On Mon, 7 Nov 2011, Darren Hart wrote: Could you try cloning a small repository and see if it works for you? sh-4.2# git clone git://github.com/dvhart/braindump.git Cloning into braindump... remote: Counting objects: 1014, done. remote: Compressing objects: 100% (441/441), done. Receiving objec

Re: virtio-pci new configuration proposal

2011-11-07 Thread Michael S. Tsirkin
On Tue, Nov 08, 2011 at 10:23:33AM +1030, Rusty Russell wrote: > Even so, should we just use the PCI cap list, and have each > cap entry just contain a BIR & offset? > > Thanks, > Rusty. And size :) I say, Rusty, did you see my patch? That's what it's doing, I also addressed the issue that with K

Re: virtio-pci new configuration proposal

2011-11-07 Thread Rusty Russell
On Mon, 7 Nov 2011 23:14:14 +0200, "Michael S. Tsirkin" wrote: > On Mon, Nov 07, 2011 at 03:46:23PM +1030, Rusty Russell wrote: > > So far, the only three things make sense to have in a capability list: > > MSI-X, the upper 32 feature bits, and the per-device config. > > You mean the queue # to M

Re: Secure KVM

2011-11-07 Thread Rusty Russell
On Mon, 07 Nov 2011 11:26:53 +0200, Avi Kivity wrote: > One thing to beware of is memory hotplug. If the memory map is static, > then a fork() once everything is set up (with MAP_SHARED) alllows all > processes to access guest memory. However, if memory hotplug is > supported (or planned to be s

Re: Secure KVM

2011-11-07 Thread Rusty Russell
On Mon, 07 Nov 2011 08:29:03 +0200, Sasha Levin wrote: > On Mon, 2011-11-07 at 10:37 +1030, Rusty Russell wrote: > > On Sun, 06 Nov 2011 22:40:20 +0200, Sasha Levin > > wrote: > > > The solution is also simple to explain: Split the devices into different > > > processes and use seccomp to sandbo

Re: [Qemu-devel] Secure KVM

2011-11-07 Thread Rusty Russell
On Mon, 07 Nov 2011 12:03:38 -0600, Anthony Liguori wrote: > So the sandbox loop would look like: > > void main() { >setup_devices(); > >read_from_event_channel(main_channel); >for i in vrings: > check_vring_notification(i); > } lguest uses a model where you attach an eventfd

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Vince Weaver
On Mon, 7 Nov 2011, Ingo Molnar wrote: > I think we needed to do only one revert along the way in the past two > years, to fix an unintended ABI breakage in PowerTop. Considering the > total complexity of the perf ABI our compatibility track record is > *very* good. There have been more breakag

[PATCH 4/5] virt.kvm_vm: Introduce vm.verify_userspace_crash()

2011-11-07 Thread Lucas Meneghel Rodrigues
In order to capture any qemu crashes, introduce a method that scans qemu output and throws an error if a core dump condition is found. Signed-off-by: Lucas Meneghel Rodrigues --- client/virt/kvm_vm.py | 18 ++ client/virt/libvirt_vm.py |7 +++

[PATCH 5/5] KVM test: Verify qemu process before throwing monitor exceptions

2011-11-07 Thread Lucas Meneghel Rodrigues
When qemu suffers a segmentation fault, monitor code might still want to issue commands to a VM, masking the segmentation fault. So, pass the vm object to the monitor code, and before throwing monitor exceptions, verify the state of the qemu process (whether it crashed or not), and throw the QemuS

[PATCH 3/5] virt tests: Introduce inactivity watcher for unattended_install

2011-11-07 Thread Lucas Meneghel Rodrigues
With this patch, if the screen got inactive during unattended install for more than 30 minutes, an error will be thrown. For any other tests, we'll just log a debug message, since in other tests we do not expect to see much action going on the screen. Signed-off-by: Lucas Meneghel Rodrigues ---

[PATCH 2/5] virt.virt_env_process: fail tests due to guest screen inactivity

2011-11-07 Thread Lucas Meneghel Rodrigues
In a very specific test (unattended_install), all OEM installer mechanism will present intense guest screen activity, so screen inactivity for a relatively long time almost always mean something went very wrong and the installer is stuck. So create a mechanism to detect screen inactivity for any v

[PATCH 1/5] virt.kvm_vm: Introduce background error queue

2011-11-07 Thread Lucas Meneghel Rodrigues
Introduce a background error queue to store exceptions happened during virt background tasks (such as aexpect instances and screendump thread). With this queue, it is possible to store exception information useful to fail tests at certain points. Examples: * We can detect qemu suffered a crash fro

[PATCH 0/5] Improve KVM autotest error reporting

2011-11-07 Thread Lucas Meneghel Rodrigues
This patchset adds some very welcome features: * Make it possible to fail some tests due to guest screen inactivity (unattended_install, mainly) * Make monitor errors to not mask qemu segmentation fault errors * Introduce a mechanism to communicate errors that happen on a background thr

Re: cannot create VM with image on zfs filesystem (zfsonlinux)

2011-11-07 Thread Peter Lees
On 08/11/2011, at 8:51 AM, Peter Lees wrote: > > > On 08/11/2011, at 2:22 AM, Avi Kivity wrote: > >> On 11/07/2011 03:57 PM, Peter Lees wrote: >>> hello all >>> >>> when trying to create a VM using a RAW image on a zfs filesystem, i get an >>> "invalid argument" error. >>> >>> has anyone m

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Theodore Tso
On Nov 7, 2011, at 5:19 PM, Anthony Liguori wrote: > > The kernel ecosystem does not have to be limited to linux.git. There could > be a process to be a "kernel.org project" for projects that fit a certain set > of criteria. These projects could all share the Linux kernel release cadence >

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Anthony Liguori
On 11/07/2011 03:36 PM, Pekka Enberg wrote: Hi Ted, On Mon, Nov 7, 2011 at 10:32 PM, Ted Ts'o wrote: Personally, I consider code that runs in userspace as a pretty bright line, as being "not kernel code", and while perhaps things like initramfs and the crazy ideas people have had in the past o

Re: [PATCH 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Darren Hart
On 11/07/2011 01:40 PM, Sasha Levin wrote: > Hi Darren, > > On Mon, 2011-11-07 at 12:52 -0800, Darren Hart wrote: >> Hi Pekka, >> >> On 11/07/2011 07:38 AM, Pekka Enberg wrote: >>> On Mon, 2011-11-07 at 17:19 +0200, Sasha Levin wrote: Signed-off-by: Sasha Levin >>> >>> -ENOCHANGELOG :-) >>

Re: cannot create VM with image on zfs filesystem (zfsonlinux)

2011-11-07 Thread Peter Lees
On 08/11/2011, at 2:22 AM, Avi Kivity wrote: > On 11/07/2011 03:57 PM, Peter Lees wrote: >> hello all >> >> when trying to create a VM using a RAW image on a zfs filesystem, i get an >> "invalid argument" error. >> >> has anyone made this work? is it a known issue and/or is there a workaroun

Re: [PATCH 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Sasha Levin
Hi Darren, On Mon, 2011-11-07 at 12:52 -0800, Darren Hart wrote: > Hi Pekka, > > On 11/07/2011 07:38 AM, Pekka Enberg wrote: > > On Mon, 2011-11-07 at 17:19 +0200, Sasha Levin wrote: > >> Signed-off-by: Sasha Levin > > > > -ENOCHANGELOG :-) > > > > I assume this is related to the git problems

[PATCH 2/2] kvm tools: Create /etc/passwd in shared rootfs

2011-11-07 Thread Sasha Levin
This patch creates a dummy /etc/passwd on guest creation. This is done because some applications (read: git) get angry when they can't find current user in /etc/passwd. Reported-by: Darren Hart Signed-off-by: Sasha Levin --- tools/kvm/builtin-setup.c | 15 ++- tools/kvm/guest/pas

[PATCH 1/2] kvm tools: Clean up remove/rename in 9p

2011-11-07 Thread Sasha Levin
Trivial cleanups. Reported-by: Darren Hart Signed-off-by: Sasha Levin --- tools/kvm/virtio/9p.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c index 2392bd1..8104ac4 100644 --- a/tools/kvm/virtio/9p.c +++ b/tools/k

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
Hi Ted, On Mon, Nov 7, 2011 at 10:32 PM, Ted Ts'o wrote: > Personally, I consider code that runs in userspace as a pretty bright > line, as being "not kernel code", and while perhaps things like > initramfs and the crazy ideas people have had in the past of moving > stuff out of kernel/init.c int

Re: virtio-pci new configuration proposal

2011-11-07 Thread Michael S. Tsirkin
On Mon, Nov 07, 2011 at 03:46:23PM +1030, Rusty Russell wrote: > On Sun, 6 Nov 2011 23:38:49 +0200, "Michael S. Tsirkin" > wrote: > > On Sun, Nov 06, 2011 at 10:24:57PM +0200, Sasha Levin wrote: > > > On Sun, 2011-11-06 at 09:30 +0200, Michael S. Tsirkin wrote: > > > > On Fri, Nov 04, 2011 at 04:

Re: [PATCH 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Darren Hart
Hi Pekka, On 11/07/2011 07:38 AM, Pekka Enberg wrote: > On Mon, 2011-11-07 at 17:19 +0200, Sasha Levin wrote: >> Signed-off-by: Sasha Levin > > -ENOCHANGELOG :-) > > I assume this is related to the git problems Darren Hart reported on > Google Plus? These patches certainly help things along. T

Re: Current kernel fails to compile with KVM on PowerPC

2011-11-07 Thread Alexander Graf
On 07.11.2011, at 21:16, Avi Kivity wrote: > On 11/07/2011 09:48 PM, Jörg Sommer wrote: >> Hello everybody, >> >> I'm trying to build the kernel with the git commit-id >> 31555213f03bca37d2c02e10946296052f4ecfcd, but it fails >> > > Alex, can we set up some buildbots for the ppc family, feedi

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ted Ts'o
On Mon, Nov 07, 2011 at 10:09:34PM +0200, Pekka Enberg wrote: > > I guess for perf ABI, "perf test" is the closest thing to a > specification so if your application is using something that's not > covered by it, you might be in trouble. I don't believe there's ever been any guarantee that "perf t

Re: Autotest | Job ID: 2072 "[unittest emulator + kernel git] Upstream qemu-kvm.git sanity 11-07-2011 13:16:33" | Status: 1 Completed | Success Rate: 94.74 %

2011-11-07 Thread Cleber Rosa
4:35:06 INFO | unittest:0052| Running emulator 11/07 14:35:06 DEBUG|virt_env_p:0062| Preprocessing VM 'None' 11/07 14:35:06 INFO |kvm_vm:0790| Running qemu command: /usr/local/autotest/tests/kvm/qemu -name 'None' -nodefaults -vga std -monitor unix:'/tmp/monitor-humanmon

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ted Ts'o
On Mon, Nov 07, 2011 at 09:53:28PM +0200, Pekka Enberg wrote: > > I'm sure perf developers break the ABI sometimes - that happens > elsewhere in the kernel as well. However, Ted claimed that perf > developers use tools/perf as an excuse to break the ABI _on purpose_ > which is something I have har

Re: Current kernel fails to compile with KVM on PowerPC

2011-11-07 Thread Avi Kivity
On 11/07/2011 09:48 PM, Jörg Sommer wrote: > Hello everybody, > > I'm trying to build the kernel with the git commit-id > 31555213f03bca37d2c02e10946296052f4ecfcd, but it fails > Alex, can we set up some buildbots for the ppc family, feeding on kvm.git master/next? -- I have a truly marvellous p

Current kernel fails to compile with KVM on PowerPC

2011-11-07 Thread Jörg Sommer
Hello everybody, I'm trying to build the kernel with the git commit-id 31555213f03bca37d2c02e10946296052f4ecfcd, but it fails CHK include/linux/version.h HOSTCC scripts/mod/modpost.o CHK include/generated/utsrelease.h UPD include/generated/utsrelease.h HOSTLD scripts/mod/m

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, 7 Nov 2011, Frank Ch. Eigler wrote: The ABI design allows for that kind of flexible extensibility, and it's one of its major advantages. What we *cannot* protect against is you relying on obscure details of the ABI [...] Is there some documentation that clearly spells out which parts o

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Frank Ch. Eigler
Ingo Molnar writes: > [...] >> It's problem enough that there's no way to know what version of the >> perf_event abi you are running against and we have to guess based >> on kernel version. This gets "fun" because all of the vendors have >> backported seemingly random chunks of perf_event cod

Re: Secure KVM

2011-11-07 Thread Avi Kivity
On 11/07/2011 09:07 PM, Anthony Liguori wrote: >> We lost the context of all threads, but that also happens on live >> migration. I'm sure this is workable. >> >> Plus we get save/restore testing for free. Did someone say win/win? > > > Indeed. > > But it mandates that everything in the sandbox b

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, 7 Nov 2011, Pekka Enberg wrote: >> I've never heard ABI incompatibility used as an argument for perf. Ingo? On Mon, Nov 7, 2011 at 7:03 PM, Vince Weaver wrote: > Never overtly.  They're too clever for that. If you want me to take you seriously, spare me from the conspiracy theories, OK?

Re: Secure KVM

2011-11-07 Thread Anthony Liguori
On 11/07/2011 12:43 PM, Avi Kivity wrote: On 11/07/2011 07:39 PM, Anthony Liguori wrote: One thing to beware of is memory hotplug. If the memory map is static, then a fork() once everything is set up (with MAP_SHARED) alllows all processes to access guest memory. However, if memory hotplug is

Re: Secure KVM

2011-11-07 Thread Avi Kivity
On 11/07/2011 07:39 PM, Anthony Liguori wrote: >> One thing to beware of is memory hotplug. If the memory map is static, >> then a fork() once everything is set up (with MAP_SHARED) alllows all >> processes to access guest memory. However, if memory hotplug is >> supported (or planned to be suppo

Re: Secure KVM

2011-11-07 Thread Avi Kivity
On 11/07/2011 07:43 PM, Anthony Liguori wrote: >> In that respect I think Avi's ideas about using safe programming >> languages (even if just a NaCl toolchain) are nice because they are >> more general and apply to all of the codebase. > > > It's a nice idea but the NaCL toolchain doesn't have a ni

Re: [Qemu-devel] Secure KVM

2011-11-07 Thread Anthony Liguori
On 11/07/2011 11:52 AM, Sasha Levin wrote: Hi Anthony, Thank you for your comments! On Mon, 2011-11-07 at 11:37 -0600, Anthony Liguori wrote: On 11/06/2011 02:40 PM, Sasha Levin wrote: Hi all, I'm planning on doing a small fork of the KVM tool to turn it into a 'Secure KVM' enabled hyperviso

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ingo Molnar
* Vince Weaver wrote: > On Mon, 7 Nov 2011, Pekka Enberg wrote: > > > I've never heard ABI incompatibility used as an argument for > > perf. Ingo? Correct, the ABI has been designed in a way to make it really hard to break the ABI via either directed backports or other mess-ups. The ABI is

Re: Secure KVM

2011-11-07 Thread Sasha Levin
Hi Anthony, Thank you for your comments! On Mon, 2011-11-07 at 11:37 -0600, Anthony Liguori wrote: > On 11/06/2011 02:40 PM, Sasha Levin wrote: > > Hi all, > > > > I'm planning on doing a small fork of the KVM tool to turn it into a > > 'Secure KVM' enabled hypervisor. Now you probably ask yourse

Re: Secure KVM

2011-11-07 Thread Anthony Liguori
On 11/07/2011 05:27 AM, Stefan Hajnoczi wrote: On Mon, Nov 7, 2011 at 10:17 AM, Sasha Levin wrote: This is a really interesting topic - something that we've discussed in QEMU as well. Doing it with seccomp is really hard since that only allows read(2), write(2), exit(2), and sigreturn(2). I t

Re: Secure KVM

2011-11-07 Thread Anthony Liguori
On 11/07/2011 03:26 AM, Avi Kivity wrote: On 11/06/2011 10:40 PM, Sasha Levin wrote: Hi all, I'm planning on doing a small fork of the KVM tool to turn it into a 'Secure KVM' enabled hypervisor. Now you probably ask yourself, Huh? Actually, no. The idea was discussed briefly couple of month

Re: Secure KVM

2011-11-07 Thread Anthony Liguori
On 11/06/2011 02:40 PM, Sasha Levin wrote: Hi all, I'm planning on doing a small fork of the KVM tool to turn it into a 'Secure KVM' enabled hypervisor. Now you probably ask yourself, Huh? The idea was discussed briefly couple of months ago, but never got off the ground - which is a shame IMO.

Re: [qemu-kvm unittest regression] Re: Autotest | Job ID: 2011 "Upstream qemu-kvm.git sanity 11-01-2011 00:04:02" | Status: 1 Completed | Success Rate: 94.74 %

2011-11-07 Thread Cleber Rosa
On 11/07/2011 02:22 PM, Marcelo Tosatti wrote: On Mon, Nov 07, 2011 at 09:00:26AM -0300, Cleber Rosa wrote: On 11/07/2011 07:21 AM, Marcelo Tosatti wrote: On Tue, Nov 01, 2011 at 02:08:54PM -0200, Lucas Meneghel Rodrigues wrote: On 11/01/2011 12:17 PM, kvm-autotest wrote: Job ID: 2011 Job nam

Re: [qemu-kvm unittest regression] Re: Autotest | Job ID: 2011 "Upstream qemu-kvm.git sanity 11-01-2011 00:04:02" | Status: 1 Completed | Success Rate: 94.74 %

2011-11-07 Thread Marcelo Tosatti
On Mon, Nov 07, 2011 at 09:00:26AM -0300, Cleber Rosa wrote: > On 11/07/2011 07:21 AM, Marcelo Tosatti wrote: > >On Tue, Nov 01, 2011 at 02:08:54PM -0200, Lucas Meneghel Rodrigues wrote: > >>On 11/01/2011 12:17 PM, kvm-autotest wrote: > >>>Job ID: 2011 > >>>Job name: Upstream qemu-kvm.git sanity 11

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 05:45:14PM +0100, Peter Zijlstra wrote: > On Mon, 2011-11-07 at 17:25 +0200, Gleb Natapov wrote: > > > Since the below programming doesn't use perf_event_attr::pinned, yes. > > > > > Yes, that is on todo :). Actually I do want to place all guest perf > > counters into the s

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Vince Weaver
On Mon, 7 Nov 2011, Pekka Enberg wrote: > I've never heard ABI incompatibility used as an argument for perf. Ingo? Never overtly. They're too clever for that. In any case, as a primary developer of a library (PAPI) that uses the perf_events ABI I have to say that having perf in the kernel has

Universities and the Open Virtualization Alliance

2011-11-07 Thread Michael Waite
Hello, We are looking for some universities who are doing work with KVM to participate in the Open Virtualization Alliance. We are very interested to have some universities join the project to help promote KVM as an enterprise class hypervisor. Please let me know. Thanks. -Mike -- To

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Peter Zijlstra
On Mon, 2011-11-07 at 17:25 +0200, Gleb Natapov wrote: > > Since the below programming doesn't use perf_event_attr::pinned, yes. > > > Yes, that is on todo :). Actually I do want to place all guest perf > counters into the same event group and make it pinned. But currently perf > event groups are

Re: [PATCHv2 6/9] perf: expose perf capability to other modules.

2011-11-07 Thread Peter Zijlstra
On Mon, 2011-11-07 at 18:22 +0200, Gleb Natapov wrote: > > Right, so what model number do you expose? > Depends on what management wants. You can specify -cpu Nehalem or -cpu > Conroe or even override model manually by doing -cpu host,model=15. Oh cute ;-) -- To unsubscribe from this list: send

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 05:22:21PM +0100, Peter Zijlstra wrote: > On Mon, 2011-11-07 at 17:25 +0200, Avi Kivity wrote: > > On 11/07/2011 05:19 PM, Gleb Natapov wrote: > > > > > > > > note, this needs a fairly huge PMI skew to happen. > > > > > > > No, it need not. It is enough to get exit reason

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Peter Zijlstra
On Mon, 2011-11-07 at 17:25 +0200, Avi Kivity wrote: > On 11/07/2011 05:19 PM, Gleb Natapov wrote: > > > > > > note, this needs a fairly huge PMI skew to happen. > > > > > No, it need not. It is enough to get exit reason as hlt instead of nmi > > for a vcpu to go to blocking state instead of reen

Re: [PATCHv2 6/9] perf: expose perf capability to other modules.

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 05:01:11PM +0100, Peter Zijlstra wrote: > On Mon, 2011-11-07 at 17:53 +0200, Gleb Natapov wrote: > > I removed branch-miss-retired here because for perf user it exists. Perf > > approximates it by other event but perf user shouldn't know that. A > > guest is not always runs

Re: [PATCHv2 6/9] perf: expose perf capability to other modules.

2011-11-07 Thread Peter Zijlstra
On Mon, 2011-11-07 at 17:53 +0200, Gleb Natapov wrote: > I removed branch-miss-retired here because for perf user it exists. Perf > approximates it by other event but perf user shouldn't know that. A > guest is not always runs with exactly same cpu model number as a host, > so if we will not drop t

[RFC/PATCH] kvm tools: Use initrd from "/boot" for distro kernels

2011-11-07 Thread Pekka Enberg
This patch implements automatic initrd detection for distro kernels. Unfortunately, it doesn't quite produce a working environment on Fedora: [0.588066] Freeing unused kernel memory: 912k freed [0.588981] Write protecting the kernel read-only data: 10240k [0.593634] Freeing unuse

Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-07 Thread Anthony Liguori
On 11/07/2011 09:33 AM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card gets the default qemu subsystem id (1af4:

[PATCH v2 2/2] kvm tools: Add missing 9p rename handler

2011-11-07 Thread Sasha Levin
This adds a rename handler which actually allows us to rename files in the guest. Reported-by: Darren Hart Signed-off-by: Sasha Levin --- tools/kvm/virtio/9p.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/v

[PATCH v2 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Sasha Levin
This adds a remove handler which actually allows us to unlink files in the guest. Reported-by: Darren Hart Signed-off-by: Sasha Levin --- tools/kvm/virtio/9p.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/vir

Re: [PATCHv2 7/9] KVM: Expose the architectural performance monitoring CPUID leaf

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 04:45:57PM +0100, Peter Zijlstra wrote: > On Mon, 2011-11-07 at 17:41 +0200, Gleb Natapov wrote: > > > > + entry->eax = min(cap.version, 2) > > > > + | (cap.num_counters_gp << 8) > > > > + | (cap.bit_width_gp << 16) >

Re: [PATCHv2 6/9] perf: expose perf capability to other modules.

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 03:07:50PM +0100, Peter Zijlstra wrote: > On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > > @@ -1580,6 +1580,8 @@ __init int intel_pmu_init(void) > > x86_pmu.num_counters= eax.split.num_counters; > > x86_pmu.cntval_bits = eax.

Re: [PATCH 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Pekka Enberg
On Mon, 2011-11-07 at 17:38 +0200, Sasha Levin wrote: > On Mon, 2011-11-07 at 17:38 +0200, Pekka Enberg wrote: > > On Mon, 2011-11-07 at 17:19 +0200, Sasha Levin wrote: > > > Signed-off-by: Sasha Levin > > > > -ENOCHANGELOG :-) > > > > I assume this is related to the git problems Darren Hart rep

Re: [PATCH 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Sasha Levin
On Mon, 2011-11-07 at 17:43 +0200, Pekka Enberg wrote: > On Mon, 2011-11-07 at 17:38 +0200, Sasha Levin wrote: > > On Mon, 2011-11-07 at 17:38 +0200, Pekka Enberg wrote: > > > On Mon, 2011-11-07 at 17:19 +0200, Sasha Levin wrote: > > > > Signed-off-by: Sasha Levin > > > > > > -ENOCHANGELOG :-) >

Re: [PATCHv2 7/9] KVM: Expose the architectural performance monitoring CPUID leaf

2011-11-07 Thread Peter Zijlstra
On Mon, 2011-11-07 at 17:41 +0200, Gleb Natapov wrote: > > > + entry->eax = min(cap.version, 2) > > > + | (cap.num_counters_gp << 8) > > > + | (cap.bit_width_gp << 16) > > > + | (cap.events_mask_len << 24); > Do you

Re: [PATCH 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Pekka Enberg
On Mon, 2011-11-07 at 17:19 +0200, Sasha Levin wrote: > Signed-off-by: Sasha Levin -ENOCHANGELOG :-) I assume this is related to the git problems Darren Hart reported on Google Plus? > --- > tools/kvm/virtio/9p.c | 25 + > 1 files changed, 25 insertions(+), 0 deletion

Re: [PATCHv2 7/9] KVM: Expose the architectural performance monitoring CPUID leaf

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 03:09:46PM +0100, Peter Zijlstra wrote: > On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > > + case 0xa: { /* Architectural Performance Monitoring */ > > + struct x86_pmu_capability cap; > > + > > + perf_get_x86_pmu_capability(&cap);

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Avi Kivity
On 11/07/2011 05:34 PM, Gleb Natapov wrote: > On Mon, Nov 07, 2011 at 03:22:05PM +0100, Peter Zijlstra wrote: > > On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > > > @@ -35,6 +35,7 @@ config KVM > > > select KVM_MMIO > > > select TASKSTATS > > > select TASK_DELAY_AC

Re: [PATCH 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Sasha Levin
On Mon, 2011-11-07 at 17:38 +0200, Pekka Enberg wrote: > On Mon, 2011-11-07 at 17:19 +0200, Sasha Levin wrote: > > Signed-off-by: Sasha Levin > > -ENOCHANGELOG :-) > > I assume this is related to the git problems Darren Hart reported on > Google Plus? Yup. We forgot to do something that handle

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 03:22:05PM +0100, Peter Zijlstra wrote: > On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > > @@ -35,6 +35,7 @@ config KVM > > select KVM_MMIO > > select TASKSTATS > > select TASK_DELAY_ACCT > > + select PERF_EVENTS > > Do you really wa

[PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-07 Thread Gerd Hoffmann
This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card gets the default qemu subsystem id (1af4:1100) instead. [ v2: old & broken id is mainta

[PATCH 1/2] pc: add 1.0 machine type

2011-11-07 Thread Gerd Hoffmann
This patch adds a pc-1.0 machine type. Signed-off-by: Gerd Hoffmann --- hw/pc_piix.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 8c7f2b7..93e40d0 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -297,8 +297,8 @@ static v

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 03:36:49PM +0100, Peter Zijlstra wrote: > On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > > +static u64 read_pmc(struct kvm_pmc *pmc) > > +{ > > + u64 counter, enabled, running; > > + > > + counter = pmc->counter; > > + > > + if (pmc->perf_event) >

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Avi Kivity
On 11/07/2011 05:19 PM, Gleb Natapov wrote: > > > > note, this needs a fairly huge PMI skew to happen. > > > No, it need not. It is enough to get exit reason as hlt instead of nmi > for a vcpu to go to blocking state instead of reentering guest mode. > Note that we do not check request flags in k

Re: cannot create VM with image on zfs filesystem (zfsonlinux)

2011-11-07 Thread Avi Kivity
On 11/07/2011 03:57 PM, Peter Lees wrote: > hello all > > when trying to create a VM using a RAW image on a zfs filesystem, i get an > "invalid argument" error. > > has anyone made this work? is it a known issue and/or is there a workaround? > > > > > more detail: > > - i can create the VM on a ex

[PATCH 2/2] kvm tools: Add missing 9p rename handler

2011-11-07 Thread Sasha Levin
Signed-off-by: Sasha Levin --- tools/kvm/virtio/9p.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c index 08b1be7..2392bd1 100644 --- a/tools/kvm/virtio/9p.c +++ b/tools/kvm/virtio/9p.c @@ -700,6 +7

[PATCH 1/2] kvm tools: Add missing 9p remove handler

2011-11-07 Thread Sasha Levin
Signed-off-by: Sasha Levin --- tools/kvm/virtio/9p.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c index 1569bb2..08b1be7 100644 --- a/tools/kvm/virtio/9p.c +++ b/tools/kvm/virtio/9p.c @@ -677,6 +677

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 05:13:17PM +0200, Avi Kivity wrote: > On 11/07/2011 04:59 PM, Peter Zijlstra wrote: > > > > > +*/ > > > > > + if (!kvm_is_in_guest()) > > > > > + irq_work_queue(&pmc->vcpu->arch.pmu.irq_work); > > > > > + else

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 05:10 PM, Gerd Hoffmann wrote: > Hi, > > > This is more of an edge case however, since we know that hardware tools > > rely on PCI IDs. > > The ID is invalid, you can't do anything useful with it ... > > > For example our hypothetical ABI signature tool will > > certainly include ls

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Avi Kivity
On 11/07/2011 04:59 PM, Peter Zijlstra wrote: > > > > +*/ > > > > + if (!kvm_is_in_guest()) > > > > + irq_work_queue(&pmc->vcpu->arch.pmu.irq_work); > > > > + else > > > > + kvm_make_request(KVM_REQ_PMI, pmc->vc

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Gleb Natapov
On Mon, Nov 07, 2011 at 03:59:08PM +0100, Peter Zijlstra wrote: > On Mon, 2011-11-07 at 16:46 +0200, Avi Kivity wrote: > > On 11/07/2011 04:34 PM, Peter Zijlstra wrote: > > > On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > > > > +static void kvm_perf_overflow_intr(struct perf_event *perf_e

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Gerd Hoffmann
Hi, > This is more of an edge case however, since we know that hardware tools > rely on PCI IDs. The ID is invalid, you can't do anything useful with it ... > For example our hypothetical ABI signature tool will > certainly include lspci like functionality and detect this as a change. ... exc

Re: cannot create VM with image on zfs filesystem (zfsonlinux)

2011-11-07 Thread Michael Tokarev
On 07.11.2011 17:57, Peter Lees wrote: > when trying to create a VM using a RAW image on a zfs filesystem, i get an > "invalid argument" error. [] > qemu: could not open disk image /space/vm_store/elveros_001.raw: Invalid > argument Please run qemu under strace to show what exactly it is doing.

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 04:53 PM, Anthony Liguori wrote: >> I think so, but that's unrelated. The worry is that some DRM code >> checksums your hardware and complains if it changed too much. Nothing >> to do with the test suite. >> >> The sense of Gerd's comment is reversed. We should preserve the ABI >>

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Peter Zijlstra
On Mon, 2011-11-07 at 16:46 +0200, Avi Kivity wrote: > On 11/07/2011 04:34 PM, Peter Zijlstra wrote: > > On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > > > +static void kvm_perf_overflow_intr(struct perf_event *perf_event, > > > + struct perf_sample_data *data, struct pt_reg

Re: Secure KVM

2011-11-07 Thread Stefan Hajnoczi
On Mon, Nov 7, 2011 at 12:51 PM, Avi Kivity wrote: > On 11/07/2011 02:40 PM, Sasha Levin wrote: >> > >> > Where does the VNC server, the image formats, etc go?  It would be >> > nice to confine them too. >> >> Regarding image formats, just wondering - was there ever any plan to >> merge (at least

KVM call agenda for November 8th

2011-11-07 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Anthony Liguori
On 11/07/2011 08:50 AM, Avi Kivity wrote: On 11/07/2011 04:44 PM, Anthony Liguori wrote: This a guest ABI change. Do we want -M support for it? Given that the old subsystem id isn't valid I'd say no unless someone comes up with a good reason. Do we know that Windows won't complain about it?

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 04:44 PM, Anthony Liguori wrote: This a guest ABI change. Do we want -M support for it? >>> >>> Given that the old subsystem id isn't valid I'd say no unless someone >>> comes up with a good reason. >> >> Do we know that Windows won't complain about it? > > > I thought the origi

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Avi Kivity
On 11/07/2011 04:34 PM, Peter Zijlstra wrote: > On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > > +static void kvm_perf_overflow_intr(struct perf_event *perf_event, > > + struct perf_sample_data *data, struct pt_regs *regs) > > +{ > > + struct kvm_pmc *pmc = perf_event-

Re: [PATCH 6/9] perf: expose perf capability to other modules.

2011-11-07 Thread Will Deacon
Hi Frederic, On Wed, Nov 02, 2011 at 07:42:04AM +, Frederic Weisbecker wrote: > On Tue, Nov 01, 2011 at 10:20:04AM -0600, David Ahern wrote: > > Right. Originally it could be enabled/disabled. Right now it cannot be, > > but I believe Frederic is working on making it configurable again. > > >

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Anthony Liguori
On 11/07/2011 08:42 AM, Avi Kivity wrote: On 11/07/2011 04:33 PM, Gerd Hoffmann wrote: On 11/07/11 15:17, Avi Kivity wrote: On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id b

Re: [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 04:33 PM, Gerd Hoffmann wrote: > On 11/07/11 15:17, Avi Kivity wrote: > > On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: > >> This patch removes the code lines which set the subsystem id for the > >> emulated ac97 card to 8086:. Due to the device id being zero the > >> subsystem id

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Anthony Liguori
On 11/07/2011 08:33 AM, Gerd Hoffmann wrote: On 11/07/11 15:17, Avi Kivity wrote: On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyw

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Peter Zijlstra
On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > +static u64 read_pmc(struct kvm_pmc *pmc) > +{ > + u64 counter, enabled, running; > + > + counter = pmc->counter; > + > + if (pmc->perf_event) > + counter += perf_event_read_value(pmc->perf_event, > +

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Peter Zijlstra
On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > +static void kvm_perf_overflow_intr(struct perf_event *perf_event, > + struct perf_sample_data *data, struct pt_regs *regs) > +{ > + struct kvm_pmc *pmc = perf_event->overflow_handler_context; > + struct kvm_pmu *pmu

Re: [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Gerd Hoffmann
On 11/07/11 15:17, Avi Kivity wrote: > On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: >> This patch removes the code lines which set the subsystem id for the >> emulated ac97 card to 8086:. Due to the device id being zero the >> subsystem id isn't vaild anyway. With the patch applied the sound

cannot create VM with image on zfs filesystem (zfsonlinux)

2011-11-07 Thread Peter Lees
hello all when trying to create a VM using a RAW image on a zfs filesystem, i get an "invalid argument" error. has anyone made this work? is it a known issue and/or is there a workaround? more detail: - i can create the VM on a ext4 filesystem - i can create the VM on a ZFS zvol ("raw" devi

Re: [PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-07 Thread Peter Zijlstra
On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > @@ -35,6 +35,7 @@ config KVM > select KVM_MMIO > select TASKSTATS > select TASK_DELAY_ACCT > + select PERF_EVENTS Do you really want to make that an unconditional part of KVM? I know we can't currently build x8

Re: [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: > This patch removes the code lines which set the subsystem id for the > emulated ac97 card to 8086:. Due to the device id being zero the > subsystem id isn't vaild anyway. With the patch applied the sound card > gets the default qemu subsystem id

Re: [PATCHv2 7/9] KVM: Expose the architectural performance monitoring CPUID leaf

2011-11-07 Thread Peter Zijlstra
On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > + case 0xa: { /* Architectural Performance Monitoring */ > + struct x86_pmu_capability cap; > + > + perf_get_x86_pmu_capability(&cap); > + > + /* > +* Only support guest architec

Re: [PATCHv2 6/9] perf: expose perf capability to other modules.

2011-11-07 Thread Peter Zijlstra
On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote: > @@ -1580,6 +1580,8 @@ __init int intel_pmu_init(void) > x86_pmu.num_counters= eax.split.num_counters; > x86_pmu.cntval_bits = eax.split.bit_width; > x86_pmu.cntval_mask = (1ULL << ea

  1   2   >