Re: [PATCH] virtio: make udp more efficient by avoiding indirect desc

2014-02-12 Thread Rusty Russell
Qin Chuanyu writes: > udp packet use 2 buffers at least, one for vnet_hdr and > one for skb->data. > we could change the threshold from 2 to 3, so the udp packet > which data buff only using single desc will gain from this. > the guest would avoid from allocating memory dynamically. > the host wou

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Luis R. Rodriguez
On Wed, Feb 12, 2014 at 8:27 PM, Luis R. Rodriguez wrote: > I have a test patch that now works that restricts xen-netback from > getting any IPv4 and IPv6 addresses, and disables multicast. With this > set in place the xen-frontend still gets IPv4 and IPv6 addresses and > Multicast still works. Th

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Luis R. Rodriguez
On Wed, Feb 12, 2014 at 2:05 PM, Luis R. Rodriguez wrote: > We have to be careful for sure, I'll try to test all cases including > kvm, but architecturally as I see it so far these things are simply > exchanging over data through their respective backend channels, I know > ipv6 interfaces are unus

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Luis R. Rodriguez
On Wed, Feb 12, 2014 at 3:15 AM, Ian Campbell wrote: > On Tue, 2014-02-11 at 13:53 -0800, Luis R. Rodriguez wrote: >> Cc'ing kvm folks as they may have a shared interest on the shared >> physical case with the bridge (non NAT). >> >> On Tue, Feb 11, 2014 at 12:43 AM, Ian Campbell >> wrote: >> >

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Luis R. Rodriguez
On Wed, Feb 12, 2014 at 9:17 AM, Bill Fink wrote: > On Wed, 12 Feb 2014, Ian Campbell wrote: >> IOW -- enabling/disabling multicast seems to me to be an odd proxy for >> disabling SLAAC or DAD and AIUI your patch fixes the opposite case, >> which is to avoid SLAAC and DAD on interfaces which don't

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Bill Fink
On Wed, 12 Feb 2014, Ian Campbell wrote: > On Tue, 2014-02-11 at 13:53 -0800, Luis R. Rodriguez wrote: > > Cc'ing kvm folks as they may have a shared interest on the shared > > physical case with the bridge (non NAT). > > > > On Tue, Feb 11, 2014 at 12:43 AM, Ian Campbell > > wrote: > > > On Mo

[PATCH net 2/3] vhost: fix ref cnt checking deadlock

2014-02-12 Thread Michael S. Tsirkin
vhost checked the counter within the refcnt before decrementing. It really wanted to know that there aren't too many references, as a way to batch freeing resources a bit more efficiently. This works well but it we now access the ref counter twice so there's a race: all users might see a high cou

[PATCH net 3/3] vhost: fix a theoretical race in device cleanup

2014-02-12 Thread Michael S. Tsirkin
vhost_zerocopy_callback accesses VQ right after it drops the last ubuf reference. In theory, this could race with device removal which waits on the ubuf kref, and crash on use after free. Do all accesses within rcu read side critical section, and all synchronize on release. Since callbacks are al

Re: [PATCH V2 5/6] vhost_net: poll vhost queue after marking DMA is done

2014-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2014 at 03:38:18PM +0800, Qin Chuanyu wrote: > another question is that vhost_zerocopy_callback is called by kfree_skb, > it may called in different thread context. > vhost_poll_queue is called decided by ubufs->kref.refcount, this may > cause there isn't any thread call vhost_poll

Re: [Qemu-devel] [PATCH v2 09/10] hw/mips: malta: Add KVM support

2014-02-12 Thread James Hogan
On 21/12/13 20:42, Peter Maydell wrote: > On 16 December 2013 14:12, James Hogan wrote: >> +#include "linux/kvm.h" > > You can't include linux/kvm.h like this -- on Linux this will pull in > whatever the host's system kvm.h happens to be, and on non-Linux > it won't compile: > > /Users/pm215/src

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Wei Liu
On Tue, Feb 11, 2014 at 01:53:26PM -0800, Luis R. Rodriguez wrote: > Cc'ing kvm folks as they may have a shared interest on the shared > physical case with the bridge (non NAT). > > On Tue, Feb 11, 2014 at 12:43 AM, Ian Campbell > wrote: > > On Mon, 2014-02-10 at 14:29 -0800, Luis R. Rodriguez w

Re: Another preempt folding issue?

2014-02-12 Thread Peter Zijlstra
On Wed, Feb 12, 2014 at 12:09:29PM +0100, Stefan Bader wrote: > Something else here I run a kernel with CONFIG_PREEMPT not set and NR_CPUS > limited to 8 (for the 32bit kernel). So the default apic driver is used. Since > default_send_IPI_mask_logical is only used from there, I assume the trace you

Re: [PATCH net] vhost_net: do not report a used len larger than receive buffer size

2014-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2014 at 01:57:46PM +0800, Jason Wang wrote: > Currently, even if the packet were truncated by lower socket, we still > report the packet size as the used len which may confuse guest > driver. Fixes this by returning the size of guest receive buffer instead. > > Fixes 3a4d5c94e95935

Re: Another preempt folding issue?

2014-02-12 Thread Joerg Roedel
On Wed, Feb 12, 2014 at 11:40:17AM +0100, Borislav Petkov wrote: > Also what I'm wondering about and what's not clear from Stefan's reply > is whether this is purely a 32-bit issue, i.e. a 32-bit host running a > 64-bit qemu running a 32-bit iso or what is it? > > Or do we have reports for both 32

Re: [RFC 2/2] xen-netback: disable multicast and use a random hw MAC address

2014-02-12 Thread Ian Campbell
On Tue, 2014-02-11 at 13:53 -0800, Luis R. Rodriguez wrote: > Cc'ing kvm folks as they may have a shared interest on the shared > physical case with the bridge (non NAT). > > On Tue, Feb 11, 2014 at 12:43 AM, Ian Campbell > wrote: > > On Mon, 2014-02-10 at 14:29 -0800, Luis R. Rodriguez wrote: >

Re: Another preempt folding issue?

2014-02-12 Thread Stefan Bader
On 12.02.2014 11:40, Borislav Petkov wrote: > On Wed, Feb 12, 2014 at 11:37:13AM +0100, Peter Zijlstra wrote: >>> Another reporter also saw this on an AMD and said it could not be >>> reproduced on >>> the same hardware and the same software versions when using 64bit instead >>> of 32. >>> >>> In

Re: Another preempt folding issue?

2014-02-12 Thread Borislav Petkov
On Wed, Feb 12, 2014 at 11:37:13AM +0100, Peter Zijlstra wrote: > > Another reporter also saw this on an AMD and said it could not be > > reproduced on > > the same hardware and the same software versions when using 64bit instead > > of 32. > > > > In my case on a 32bit installation I will see t

Re: Another preempt folding issue?

2014-02-12 Thread Peter Zijlstra
On Wed, Feb 12, 2014 at 09:20:24AM +0100, Stefan Bader wrote: > On 11.02.2014 20:45, Peter Zijlstra wrote: > > On Tue, Feb 11, 2014 at 07:34:51PM +0100, Stefan Bader wrote: > >> Hi Peter, > >> > >> I am currently looking at a weird issue that manifest itself when trying > >> to run > >> kvm enable

Re: [PATCH V2 5/6] vhost_net: poll vhost queue after marking DMA is done

2014-02-12 Thread Jason Wang
On 02/12/2014 03:38 PM, Qin Chuanyu wrote: > On 2013/8/30 12:29, Jason Wang wrote: >> We used to poll vhost queue before making DMA is done, this is racy >> if vhost >> thread were waked up before marking DMA is done which can result the >> signal to >> be missed. Fix this by always poll the vhost

Re: [PATCH] virtio: make udp more efficient by avoiding indirect desc

2014-02-12 Thread Paolo Bonzini
Il 11/02/2014 16:43, Michael S. Tsirkin ha scritto: > Signed-off-by: Chuanyu Qin Optimization patch without any performance data? Such a change would need much more testing than that: would have to try various workloads with -net and -blk at least. -blk and -scsi never use 2 descriptors exce

Re: Another preempt folding issue?

2014-02-12 Thread Stefan Bader
On 11.02.2014 20:45, Peter Zijlstra wrote: > On Tue, Feb 11, 2014 at 07:34:51PM +0100, Stefan Bader wrote: >> Hi Peter, >> >> I am currently looking at a weird issue that manifest itself when trying to >> run >> kvm enabled qemu on a i386 host (v3.13 kernel, oh and potentially important >> the >>