[PATCH] arch/x86: Use RCU_INIT_POINTER(x, NULL) in kvm/vmx.c

2014-03-22 Thread Monam Agarwal
Here rcu_assign_pointer() is ensuring that the initialization of a structure is carried out before storing a pointer to that structure. So, rcu_assign_pointer(p, NULL) can always safely be converted to RCU_INIT_POINTER(p, NULL). Signed-off-by: Monam Agarwal monamagarwal...@gmail.com ---

Re: [PATCH v2 2/4] KVM: ioapic: clear IRR for edge-triggered interrupts at delivery

2014-03-22 Thread Paolo Bonzini
Il 21/03/2014 19:34, Eduardo Habkost ha scritto: + if (irqe.trig_mode == IOAPIC_EDGE_TRIG) + ioapic-irr = ~(1 irq); + Now, every call to ioapic_service() for an edge interrupt clears the IRR bit immediately (assuming the mask is unset). If the IRR bit is immediately zero on

Re: GPF in intel_pmu_lbr_reset() with qemu -cpu host

2014-03-22 Thread Paolo Bonzini
Il 21/03/2014 20:09, H. Peter Anvin ha scritto: Calling this a bug in the PMU code is ridiculous. If KVM tells the system it os a specific vendor-family-model-stepping but diverges in behavior then it, by definition, is broken. Yeah, this is true. On AMD there is processor support for

Re: [RFC] ARM VM System Sepcification

2014-03-22 Thread Paolo Bonzini
Il 22/03/2014 03:29, Christoffer Dall ha scritto: 1. Simply mandate that VM implementations support persistent variables for their UEFI implementation - with whatever constraints that may put on higher level tools. 2. Require that OSes shipped as part of compliant VM images make no

Where to file this bug, please?

2014-03-22 Thread Prof. Dr. Michael Schefczyk
Dear Recipients, As per http://www.linux-kvm.org/page/Bugs, I am seeking advice regarding where to file the following bug: I think that the current RHEL/Centos-Version of KVM (qemu-kvm-0.12.1.2-2.415.el6_5.6.x86_64) on Centos 6.5 does make it substantially more difficult to install a Windows

Re: GPF in intel_pmu_lbr_reset() with qemu -cpu host

2014-03-22 Thread Gleb Natapov
On Fri, Mar 21, 2014 at 12:04:32PM -0700, Venkatesh Srinivas wrote: On Fri, Mar 21, 2014 at 10:46 AM, Peter Wu pe...@lekensteyn.nl wrote: [skip] When -cpu host is used, qemu/kvm passed the host CPUID F/M/S to the guest. intel_pmu_cpu_*() - intel_pmu_lbr_reset() uses rdmsr() / wrmsr(), rather

Re: GPF in intel_pmu_lbr_reset() with qemu -cpu host

2014-03-22 Thread Peter Wu
On Saturday 22 March 2014 10:50:45 Gleb Natapov wrote: On Fri, Mar 21, 2014 at 12:04:32PM -0700, Venkatesh Srinivas wrote: On Fri, Mar 21, 2014 at 10:46 AM, Peter Wu pe...@lekensteyn.nl wrote: [skip] When -cpu host is used, qemu/kvm passed the host CPUID F/M/S to the guest.

Re: [PATCH 3/3] KVM: nVMX: check for null vmcs12 when L1 does invept

2014-03-22 Thread Jan Kiszka
On 2014-03-20 21:58, Bandan Das wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2014-03-20 04:28, Bandan Das wrote: Some L1 hypervisors such as Xen seem to be calling invept after vmclear or before vmptrld on L2. In this case, proceed with falling through and syncing roots as a case

Re: Is there any consumer of virtio-balloon now?

2014-03-22 Thread Kai Huang
Thanks Paolo. What's the user space tool / command to trigger the virtio_balloon functionality? Basically I am looking for the whole code patch that triggers the virtio_balloon. Thanks, -Kai On 2014年03月21日 16:51, Paolo Bonzini wrote: Il 21/03/2014 05:22, Kai Huang ha scritto: Hi, I see the

Re: Is there any consumer of virtio-balloon now?

2014-03-22 Thread Kai Huang
Just see the reply. Thanks a lot! Thanks, -Kai On 2014年03月21日 17:03, Kashyap Chamarthy wrote: On Fri, Mar 21, 2014 at 12:22:54PM +0800, Kai Huang wrote: Hi, I see the virtio-balloon is designed for memory auto balloon between KVM host and guest, but from latest linux kernel mainline code,

Re: [RFC] ARM VM System Sepcification

2014-03-22 Thread Grant Likely
On Fri, 21 Mar 2014 19:29:50 -0700, Christoffer Dall christoffer.d...@linaro.org wrote: On Fri, Mar 07, 2014 at 08:24:18PM +0800, Grant Likely wrote: On Thu, 6 Mar 2014 12:04:50 +, Robie Basak robie.ba...@canonical.com wrote: On Thu, Mar 06, 2014 at 12:44:57PM +0100, Laszlo Ersek

Re: [PATCH 3/3] KVM: nVMX: check for null vmcs12 when L1 does invept

2014-03-22 Thread Bandan Das
Jan Kiszka jan.kis...@web.de writes: On 2014-03-20 21:58, Bandan Das wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2014-03-20 04:28, Bandan Das wrote: Some L1 hypervisors such as Xen seem to be calling invept after vmclear or before vmptrld on L2. In this case, proceed with falling

Re: Where to file this bug, please?

2014-03-22 Thread Kashyap Chamarthy
On Sat, Mar 22, 2014 at 08:07:42AM +, Prof. Dr. Michael Schefczyk wrote: Dear Recipients, As per http://www.linux-kvm.org/page/Bugs, I am seeking advice regarding where to file the following bug: If you're experiencing it on CentOS http://bugs.centos.org/ If you're experiencing it

Re: GPF in intel_pmu_lbr_reset() with qemu -cpu host

2014-03-22 Thread Gleb Natapov
On Sat, Mar 22, 2014 at 11:05:03AM +0100, Peter Wu wrote: On Saturday 22 March 2014 10:50:45 Gleb Natapov wrote: On Fri, Mar 21, 2014 at 12:04:32PM -0700, Venkatesh Srinivas wrote: On Fri, Mar 21, 2014 at 10:46 AM, Peter Wu pe...@lekensteyn.nl wrote: [skip] When -cpu host is used,

Re: [RFC] ARM VM System Sepcification

2014-03-22 Thread Paolo Bonzini
Il 22/03/2014 13:23, Grant Likely ha scritto: VM implementations SHOULD to implement persistent variables for their UEFI implementation - with whatever constraints that may be put on higher level tools. Variable storage SHALL be a property of a VM instance, but SHALL NOT be stored as part of a

Re: GPF in intel_pmu_lbr_reset() with qemu -cpu host

2014-03-22 Thread H. Peter Anvin
Using _safe has it's own issues if noone checks the errors. On March 22, 2014 5:27:59 AM PDT, Gleb Natapov g...@kernel.org wrote: On Sat, Mar 22, 2014 at 11:05:03AM +0100, Peter Wu wrote: On Saturday 22 March 2014 10:50:45 Gleb Natapov wrote: On Fri, Mar 21, 2014 at 12:04:32PM -0700, Venkatesh

Re: GPF in intel_pmu_lbr_reset() with qemu -cpu host

2014-03-22 Thread Peter Wu
On Saturday 22 March 2014 14:27:59 Gleb Natapov wrote: but now I have a NULL dereference (in rapl_pmu_init). Previously, when `-cpu SandyBridge` was passed to qemu, it would show this: [0.016995] Performance Events: unsupported p6 CPU model 42 no PMU driver, software events

Re: [RFC] ARM VM System Sepcification

2014-03-22 Thread Grant Likely
On Sat, 22 Mar 2014 20:57:58 +0100, Paolo Bonzini pbonz...@redhat.com wrote: Il 22/03/2014 13:23, Grant Likely ha scritto: VM implementations SHOULD to implement persistent variables for their UEFI implementation - with whatever constraints that may be put on higher level tools. Variable

Re: [RFC] ARM VM System Sepcification

2014-03-22 Thread Michael Casadevall
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/22/2014 03:57 PM, Paolo Bonzini wrote: Il 22/03/2014 13:23, Grant Likely ha scritto: VM implementations SHOULD to implement persistent variables for their UEFI implementation - with whatever constraints that may be put on higher level

Re: [RFC] ARM VM System Sepcification

2014-03-22 Thread Laszlo Ersek
On 03/23/14 00:38, Michael Casadevall wrote: On 03/22/2014 03:57 PM, Paolo Bonzini wrote: Il 22/03/2014 13:23, Grant Likely ha scritto: VM implementations SHOULD to implement persistent variables for their UEFI implementation - with whatever constraints that may be put on higher level tools.

Re: [RFC] ARM VM System Sepcification

2014-03-22 Thread Christoffer Dall
On Sat, Mar 22, 2014 at 09:08:37AM +0100, Paolo Bonzini wrote: Il 22/03/2014 03:29, Christoffer Dall ha scritto: 1. Simply mandate that VM implementations support persistent variables for their UEFI implementation - with whatever constraints that may put on higher level tools. 2.

Re: [RFC] ARM VM System Sepcification

2014-03-22 Thread Christoffer Dall
On Sat, Mar 22, 2014 at 12:23:54PM +, Grant Likely wrote: On Fri, 21 Mar 2014 19:29:50 -0700, Christoffer Dall christoffer.d...@linaro.org wrote: On Fri, Mar 07, 2014 at 08:24:18PM +0800, Grant Likely wrote: On Thu, 6 Mar 2014 12:04:50 +, Robie Basak robie.ba...@canonical.com

Re: [RFC] ARM VM System Sepcification

2014-03-22 Thread Christoffer Dall
On Sat, Mar 22, 2014 at 08:19:52PM -0700, Christoffer Dall wrote: On Sat, Mar 22, 2014 at 09:08:37AM +0100, Paolo Bonzini wrote: Il 22/03/2014 03:29, Christoffer Dall ha scritto: 1. Simply mandate that VM implementations support persistent variables for their UEFI implementation - with